HBase
  1. HBase
  2. HBASE-5735

Clearer warning message when connecting a non-secure HBase client to a secure HBase server

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.92.1, 0.94.0
    • Fix Version/s: 0.92.2, 0.94.0
    • Component/s: security
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      When a connection from a non secure-rpc-engine
      client is attempted the warning message you get is related to version
      mismatch:

      Mar 28, 3:27:13 PM WARN org.apache.hadoop.ipc.SecureServer Incorrect
      header or version mismatch from 172.29.82.121:43849 got version 3
      expected version 4

      While this is true, it isn't as useful as it could be. A more specific error message warning end users that they're connecting with a non-secure client may be more useful.

      1. HBASE-5375.patch
        2 kB
        Shaneal Manek
      2. HBASE-5375-v2.patch
        2 kB
        Shaneal Manek
      3. HBASE-5735-v3.patch
        2 kB
        Shaneal Manek

        Activity

        Hide
        Hudson added a comment -

        Integrated in HBase-0.92-security #105 (See https://builds.apache.org/job/HBase-0.92-security/105/)
        HBASE-5735 Clearer warning message when connecting a non-secure HBase client to a secure HBase server (Revision 1310916)

        Result = FAILURE
        stack :
        Files :

        • /hbase/branches/0.92/CHANGES.txt
        • /hbase/branches/0.92/security/src/main/java/org/apache/hadoop/hbase/ipc/SecureServer.java
        Show
        Hudson added a comment - Integrated in HBase-0.92-security #105 (See https://builds.apache.org/job/HBase-0.92-security/105/ ) HBASE-5735 Clearer warning message when connecting a non-secure HBase client to a secure HBase server (Revision 1310916) Result = FAILURE stack : Files : /hbase/branches/0.92/CHANGES.txt /hbase/branches/0.92/security/src/main/java/org/apache/hadoop/hbase/ipc/SecureServer.java
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94-security #9 (See https://builds.apache.org/job/HBase-0.94-security/9/)
        HBASE-5735 Clearer warning message when connecting a non-secure HBase client to a secure HBase server (Revision 1310915)

        Result = SUCCESS
        stack :
        Files :

        • /hbase/branches/0.94/security/src/main/java/org/apache/hadoop/hbase/ipc/SecureServer.java
        Show
        Hudson added a comment - Integrated in HBase-0.94-security #9 (See https://builds.apache.org/job/HBase-0.94-security/9/ ) HBASE-5735 Clearer warning message when connecting a non-secure HBase client to a secure HBase server (Revision 1310915) Result = SUCCESS stack : Files : /hbase/branches/0.94/security/src/main/java/org/apache/hadoop/hbase/ipc/SecureServer.java
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-security #162 (See https://builds.apache.org/job/HBase-TRUNK-security/162/)
        HBASE-5735 Clearer warning message when connecting a non-secure HBase client to a secure HBase server (Revision 1310914)

        Result = FAILURE
        stack :
        Files :

        • /hbase/trunk/security/src/main/java/org/apache/hadoop/hbase/ipc/SecureServer.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-security #162 (See https://builds.apache.org/job/HBase-TRUNK-security/162/ ) HBASE-5735 Clearer warning message when connecting a non-secure HBase client to a secure HBase server (Revision 1310914) Result = FAILURE stack : Files : /hbase/trunk/security/src/main/java/org/apache/hadoop/hbase/ipc/SecureServer.java
        Hide
        Hudson added a comment -

        Integrated in HBase-0.92 #362 (See https://builds.apache.org/job/HBase-0.92/362/)
        HBASE-5735 Clearer warning message when connecting a non-secure HBase client to a secure HBase server (Revision 1310916)

        Result = FAILURE
        stack :
        Files :

        • /hbase/branches/0.92/CHANGES.txt
        • /hbase/branches/0.92/security/src/main/java/org/apache/hadoop/hbase/ipc/SecureServer.java
        Show
        Hudson added a comment - Integrated in HBase-0.92 #362 (See https://builds.apache.org/job/HBase-0.92/362/ ) HBASE-5735 Clearer warning message when connecting a non-secure HBase client to a secure HBase server (Revision 1310916) Result = FAILURE stack : Files : /hbase/branches/0.92/CHANGES.txt /hbase/branches/0.92/security/src/main/java/org/apache/hadoop/hbase/ipc/SecureServer.java
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94 #98 (See https://builds.apache.org/job/HBase-0.94/98/)
        HBASE-5735 Clearer warning message when connecting a non-secure HBase client to a secure HBase server (Revision 1310915)

        Result = SUCCESS
        stack :
        Files :

        • /hbase/branches/0.94/security/src/main/java/org/apache/hadoop/hbase/ipc/SecureServer.java
        Show
        Hudson added a comment - Integrated in HBase-0.94 #98 (See https://builds.apache.org/job/HBase-0.94/98/ ) HBASE-5735 Clearer warning message when connecting a non-secure HBase client to a secure HBase server (Revision 1310915) Result = SUCCESS stack : Files : /hbase/branches/0.94/security/src/main/java/org/apache/hadoop/hbase/ipc/SecureServer.java
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #2727 (See https://builds.apache.org/job/HBase-TRUNK/2727/)
        HBASE-5735 Clearer warning message when connecting a non-secure HBase client to a secure HBase server (Revision 1310914)

        Result = SUCCESS
        stack :
        Files :

        • /hbase/trunk/security/src/main/java/org/apache/hadoop/hbase/ipc/SecureServer.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #2727 (See https://builds.apache.org/job/HBase-TRUNK/2727/ ) HBASE-5735 Clearer warning message when connecting a non-secure HBase client to a secure HBase server (Revision 1310914) Result = SUCCESS stack : Files : /hbase/trunk/security/src/main/java/org/apache/hadoop/hbase/ipc/SecureServer.java
        Hide
        stack added a comment -

        Committed to trunk, 0.92 and 0.94. Thanks for the patch Shaneal.

        Show
        stack added a comment - Committed to trunk, 0.92 and 0.94. Thanks for the patch Shaneal.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12521722/HBASE-5735-v3.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1438//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1438//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1438//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12521722/HBASE-5735-v3.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1438//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1438//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1438//console This message is automatically generated.
        Hide
        Shaneal Manek added a comment -

        Jon: Sounds reasonable. Uploaded a new patch that does so.

        Show
        Shaneal Manek added a comment - Jon: Sounds reasonable. Uploaded a new patch that does so.
        Hide
        Shaneal Manek added a comment -

        Adds the server's version to the warning message when an insecure client is attempting to connect (per Jon's suggestion).

        Show
        Shaneal Manek added a comment - Adds the server's version to the warning message when an insecure client is attempting to connect (per Jon's suggestion).
        Hide
        Jonathan Hsieh added a comment -

        nit: Should we still include the server version as well?

        Show
        Jonathan Hsieh added a comment - nit: Should we still include the server version as well?
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12521638/HBASE-5375-v2.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1424//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1424//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1424//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12521638/HBASE-5375-v2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1424//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1424//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1424//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12521637/HBASE-5375.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.TestDrainingServer

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1421//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1421//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1421//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12521637/HBASE-5375.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.TestDrainingServer Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1421//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1421//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1421//console This message is automatically generated.
        Hide
        Shaneal Manek added a comment -

        Give a more specific error message if a current, but insecure, client is attempting to connect to a secure HBase server.

        Several users have reported being confused by the more generic error message (thinking they were using old client JARs, etc).

        Show
        Shaneal Manek added a comment - Give a more specific error message if a current, but insecure, client is attempting to connect to a secure HBase server. Several users have reported being confused by the more generic error message (thinking they were using old client JARs, etc).

          People

          • Assignee:
            Shaneal Manek
            Reporter:
            Shaneal Manek
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development