Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.94.0, 0.95.2
    • Fix Version/s: 0.94.0, 0.95.0
    • Component/s: hbck
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Currently hbck sideline root is the root which can run into permission issue. We can change it to /hbck

      1. hbase-5734-90.patch
        0.7 kB
        Jonathan Hsieh
      2. hbase-5734.patch
        0.7 kB
        Jimmy Xiang

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in HBase-0.92-security #105 (See https://builds.apache.org/job/HBase-0.92-security/105/)
          HBASE-5734 Change hbck sideline root (Jimmy Xiang) (Revision 1310627)

          Result = FAILURE
          jmhsieh :
          Files :

          • /hbase/branches/0.92/CHANGES.txt
          • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          Show
          Hudson added a comment - Integrated in HBase-0.92-security #105 (See https://builds.apache.org/job/HBase-0.92-security/105/ ) HBASE-5734 Change hbck sideline root (Jimmy Xiang) (Revision 1310627) Result = FAILURE jmhsieh : Files : /hbase/branches/0.92/CHANGES.txt /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          Hide
          Hudson added a comment -

          Integrated in HBase-0.94-security #8 (See https://builds.apache.org/job/HBase-0.94-security/8/)
          HBASE-5734 Change hbck sideline root (Jimmy Xiang) (Revision 1310628)

          Result = SUCCESS
          jmhsieh :
          Files :

          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          Show
          Hudson added a comment - Integrated in HBase-0.94-security #8 (See https://builds.apache.org/job/HBase-0.94-security/8/ ) HBASE-5734 Change hbck sideline root (Jimmy Xiang) (Revision 1310628) Result = SUCCESS jmhsieh : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK-security #161 (See https://builds.apache.org/job/HBase-TRUNK-security/161/)
          HBASE-5734 Change hbck sideline root (Jimmy Xiang) (Revision 1310625)

          Result = FAILURE
          jmhsieh :
          Files :

          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          Show
          Hudson added a comment - Integrated in HBase-TRUNK-security #161 (See https://builds.apache.org/job/HBase-TRUNK-security/161/ ) HBASE-5734 Change hbck sideline root (Jimmy Xiang) (Revision 1310625) Result = FAILURE jmhsieh : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          Hide
          Hudson added a comment -

          Integrated in HBase-0.92 #361 (See https://builds.apache.org/job/HBase-0.92/361/)
          HBASE-5734 Change hbck sideline root (Jimmy Xiang) (Revision 1310627)

          Result = FAILURE
          jmhsieh :
          Files :

          • /hbase/branches/0.92/CHANGES.txt
          • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          Show
          Hudson added a comment - Integrated in HBase-0.92 #361 (See https://builds.apache.org/job/HBase-0.92/361/ ) HBASE-5734 Change hbck sideline root (Jimmy Xiang) (Revision 1310627) Result = FAILURE jmhsieh : Files : /hbase/branches/0.92/CHANGES.txt /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          Hide
          Hudson added a comment -

          Integrated in HBase-0.94 #94 (See https://builds.apache.org/job/HBase-0.94/94/)
          HBASE-5734 Change hbck sideline root (Jimmy Xiang) (Revision 1310628)

          Result = FAILURE
          jmhsieh :
          Files :

          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          Show
          Hudson added a comment - Integrated in HBase-0.94 #94 (See https://builds.apache.org/job/HBase-0.94/94/ ) HBASE-5734 Change hbck sideline root (Jimmy Xiang) (Revision 1310628) Result = FAILURE jmhsieh : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK #2724 (See https://builds.apache.org/job/HBase-TRUNK/2724/)
          HBASE-5734 Change hbck sideline root (Jimmy Xiang) (Revision 1310625)

          Result = SUCCESS
          jmhsieh :
          Files :

          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          Show
          Hudson added a comment - Integrated in HBase-TRUNK #2724 (See https://builds.apache.org/job/HBase-TRUNK/2724/ ) HBASE-5734 Change hbck sideline root (Jimmy Xiang) (Revision 1310625) Result = SUCCESS jmhsieh : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          Hide
          Jonathan Hsieh added a comment -

          Docs look great Jimmy, thanks.

          Failed test passed fo rme.

          Committed to 0.90/0.92/0.94/trunk

          Show
          Jonathan Hsieh added a comment - Docs look great Jimmy, thanks. Failed test passed fo rme. Committed to 0.90/0.92/0.94/trunk
          Hide
          Jimmy Xiang added a comment -

          Thanks.

          Currently, hbck creates a folder /hbase-[timestamp] to hold those regions sidelined, if it runs in fix mode and needs to sideline some regions, for example, to fix some overlapped regions. In most cases, this is fine. However, if HDFS security is turned on and the user doesn't have permission to create this folder, hbck can't move ahead. With this patch, administrator can just set the right privilege for folder /hbck, then it will be
          good to go.

          The other issue is that there will be serveral /hbase-[timestamp] folders after serveral run. It is better to put them all under /hbck so that we know they are created by hbck, to avoid confusion.

          The next step is to fix HBASE-5714, do some permission checking before trying to fix those problems invovling sideline some regions.

          Show
          Jimmy Xiang added a comment - Thanks. Currently, hbck creates a folder /hbase- [timestamp] to hold those regions sidelined, if it runs in fix mode and needs to sideline some regions, for example, to fix some overlapped regions. In most cases, this is fine. However, if HDFS security is turned on and the user doesn't have permission to create this folder, hbck can't move ahead. With this patch, administrator can just set the right privilege for folder /hbck, then it will be good to go. The other issue is that there will be serveral /hbase- [timestamp] folders after serveral run. It is better to put them all under /hbck so that we know they are created by hbck, to avoid confusion. The next step is to fix HBASE-5714 , do some permission checking before trying to fix those problems invovling sideline some regions.
          Hide
          Jonathan Hsieh added a comment -

          Attched version that applies to 0.90.

          Show
          Jonathan Hsieh added a comment - Attched version that applies to 0.90.
          Hide
          Jonathan Hsieh added a comment -

          Can you followup by writing an example up about what problem this solves in a little more detail? This will help a lot when I write the documentation.

          I'm assuming the failed test is a flakey. Patch look good to me.

          Show
          Jonathan Hsieh added a comment - Can you followup by writing an example up about what problem this solves in a little more detail? This will help a lot when I write the documentation. I'm assuming the failed test is a flakey. Patch look good to me.
          Hide
          Jimmy Xiang added a comment -

          It is nice to expose it as an argument. However, it offers not too much value since we don't expect hbck to be ran all the time. They can rename it afterwards if they really want.

          We already have lots of arguments.

          Show
          Jimmy Xiang added a comment - It is nice to expose it as an argument. However, it offers not too much value since we don't expect hbck to be ran all the time. They can rename it afterwards if they really want. We already have lots of arguments.
          Hide
          Jonathan Hsieh added a comment -

          This seems is related to HBASE-5714. Maybe we should expose the target dir an argument instead?

          Show
          Jonathan Hsieh added a comment - This seems is related to HBASE-5714 . Maybe we should expose the target dir an argument instead?
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12521591/hbase-5734.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.master.TestSplitLogManager

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1417//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1417//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1417//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12521591/hbase-5734.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.master.TestSplitLogManager Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1417//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1417//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1417//console This message is automatically generated.

            People

            • Assignee:
              Jimmy Xiang
              Reporter:
              Jimmy Xiang
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development