HBase
  1. HBase
  2. HBASE-5731

Make max line length 100 in linter

    Details

    • Type: New Feature New Feature
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      We have switched to 100 characters per line in our Java files. Making the change in the linter.

        Activity

        Hide
        Phabricator added a comment -

        mbautin requested code review of "[jira] HBASE-5731 [89-fb] Make max line length 100 in linter".
        Reviewers: JIRA, nspiegelberg, Kannan, tedyu, stack

        We have switched to 100 characters per line in our Java files. Making the change in the linter.

        TEST PLAN
        arc lint

        REVISION DETAIL
        https://reviews.facebook.net/D2625

        AFFECTED FILES
        .arcconfig

        MANAGE HERALD DIFFERENTIAL RULES
        https://reviews.facebook.net/herald/view/differential/

        WHY DID I GET THIS EMAIL?
        https://reviews.facebook.net/herald/transcript/6039/

        Tip: use the X-Herald-Rules header to filter Herald messages in your client.

        Show
        Phabricator added a comment - mbautin requested code review of " [jira] HBASE-5731 [89-fb] Make max line length 100 in linter". Reviewers: JIRA, nspiegelberg, Kannan, tedyu, stack We have switched to 100 characters per line in our Java files. Making the change in the linter. TEST PLAN arc lint REVISION DETAIL https://reviews.facebook.net/D2625 AFFECTED FILES .arcconfig MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/6039/ Tip: use the X-Herald-Rules header to filter Herald messages in your client.
        Hide
        Phabricator added a comment -

        tedyu has accepted the revision "[jira] HBASE-5731 [89-fb] Make max line length 100 in linter".

        REVISION DETAIL
        https://reviews.facebook.net/D2625

        BRANCH
        master

        Show
        Phabricator added a comment - tedyu has accepted the revision " [jira] HBASE-5731 [89-fb] Make max line length 100 in linter". REVISION DETAIL https://reviews.facebook.net/D2625 BRANCH master
        Hide
        Phabricator added a comment -

        mbautin requested code review of "[jira] HBASE-5731 Make max line length 100 in linter".
        Reviewers: JIRA, nspiegelberg, Kannan, Liyin, tedyu, stack

        We have switched to 100 characters per line in our Java files. Making the change in the linter. The 89-fb version is D2625.

        TEST PLAN
        arc lint

        REVISION DETAIL
        https://reviews.facebook.net/D2631

        AFFECTED FILES
        .arcconfig

        MANAGE HERALD DIFFERENTIAL RULES
        https://reviews.facebook.net/herald/view/differential/

        WHY DID I GET THIS EMAIL?
        https://reviews.facebook.net/herald/transcript/6045/

        Tip: use the X-Herald-Rules header to filter Herald messages in your client.

        Show
        Phabricator added a comment - mbautin requested code review of " [jira] HBASE-5731 Make max line length 100 in linter". Reviewers: JIRA, nspiegelberg, Kannan, Liyin, tedyu, stack We have switched to 100 characters per line in our Java files. Making the change in the linter. The 89-fb version is D2625. TEST PLAN arc lint REVISION DETAIL https://reviews.facebook.net/D2631 AFFECTED FILES .arcconfig MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/6045/ Tip: use the X-Herald-Rules header to filter Herald messages in your client.
        Hide
        Phabricator added a comment -

        stack has commented on the revision "[jira] HBASE-5731 Make max line length 100 in linter".

        +1

        REVISION DETAIL
        https://reviews.facebook.net/D2631

        Show
        Phabricator added a comment - stack has commented on the revision " [jira] HBASE-5731 Make max line length 100 in linter". +1 REVISION DETAIL https://reviews.facebook.net/D2631
        Hide
        Phabricator added a comment -

        Kannan has accepted the revision "[jira] HBASE-5731 Make max line length 100 in linter".

        REVISION DETAIL
        https://reviews.facebook.net/D2631

        BRANCH
        linter_100chars

        Show
        Phabricator added a comment - Kannan has accepted the revision " [jira] HBASE-5731 Make max line length 100 in linter". REVISION DETAIL https://reviews.facebook.net/D2631 BRANCH linter_100chars
        Hide
        Phabricator added a comment -

        mbautin has committed the revision "[jira] HBASE-5731 [89-fb] Make max line length 100 in linter".

        REVISION DETAIL
        https://reviews.facebook.net/D2625

        COMMIT
        https://reviews.facebook.net/rHBASEEIGHTNINEFBBRANCH1310000

        Show
        Phabricator added a comment - mbautin has committed the revision " [jira] HBASE-5731 [89-fb] Make max line length 100 in linter". REVISION DETAIL https://reviews.facebook.net/D2625 COMMIT https://reviews.facebook.net/rHBASEEIGHTNINEFBBRANCH1310000
        Hide
        Mikhail Bautin added a comment -

        Committed in 89-fb and trunk.

        Show
        Mikhail Bautin added a comment - Committed in 89-fb and trunk.
        Hide
        Phabricator added a comment -

        mbautin has committed the revision "[jira] HBASE-5731 Make max line length 100 in linter".

        REVISION DETAIL
        https://reviews.facebook.net/D2631

        COMMIT
        https://reviews.facebook.net/rHBASE1310006

        Show
        Phabricator added a comment - mbautin has committed the revision " [jira] HBASE-5731 Make max line length 100 in linter". REVISION DETAIL https://reviews.facebook.net/D2631 COMMIT https://reviews.facebook.net/rHBASE1310006
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #2713 (See https://builds.apache.org/job/HBase-TRUNK/2713/)
        [jira] HBASE-5731 Make max line length 100 in linter

        Summary: We have switched to 100 characters per line in our Java files. Making
        the change in the linter. The 89-fb version is D2625.

        Test Plan: arc lint

        Reviewers: JIRA, nspiegelberg, Kannan, Liyin, tedyu, stack

        Reviewed By: Kannan

        Differential Revision: https://reviews.facebook.net/D2631 (Revision 1310006)

        Result = SUCCESS
        mbautin :
        Files :

        • /hbase/trunk/.arcconfig
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #2713 (See https://builds.apache.org/job/HBase-TRUNK/2713/ ) [jira] HBASE-5731 Make max line length 100 in linter Summary: We have switched to 100 characters per line in our Java files. Making the change in the linter. The 89-fb version is D2625. Test Plan: arc lint Reviewers: JIRA, nspiegelberg, Kannan, Liyin, tedyu, stack Reviewed By: Kannan Differential Revision: https://reviews.facebook.net/D2631 (Revision 1310006) Result = SUCCESS mbautin : Files : /hbase/trunk/.arcconfig
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-security #158 (See https://builds.apache.org/job/HBase-TRUNK-security/158/)
        [jira] HBASE-5731 Make max line length 100 in linter

        Summary: We have switched to 100 characters per line in our Java files. Making
        the change in the linter. The 89-fb version is D2625.

        Test Plan: arc lint

        Reviewers: JIRA, nspiegelberg, Kannan, Liyin, tedyu, stack

        Reviewed By: Kannan

        Differential Revision: https://reviews.facebook.net/D2631 (Revision 1310006)

        Result = FAILURE
        mbautin :
        Files :

        • /hbase/trunk/.arcconfig
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-security #158 (See https://builds.apache.org/job/HBase-TRUNK-security/158/ ) [jira] HBASE-5731 Make max line length 100 in linter Summary: We have switched to 100 characters per line in our Java files. Making the change in the linter. The 89-fb version is D2625. Test Plan: arc lint Reviewers: JIRA, nspiegelberg, Kannan, Liyin, tedyu, stack Reviewed By: Kannan Differential Revision: https://reviews.facebook.net/D2631 (Revision 1310006) Result = FAILURE mbautin : Files : /hbase/trunk/.arcconfig

          People

          • Assignee:
            Mikhail Bautin
            Reporter:
            Mikhail Bautin
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development