Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-5720

HFileDataBlockEncoderImpl uses wrong header size when reading HFiles with no checksums

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.94.0
    • Fix Version/s: 0.94.0
    • Component/s: io, regionserver
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      When reading a .92 HFile without checksums, encoding it, and storing in the block cache, the HFileDataBlockEncoderImpl always allocates a dummy header appropriate for checksums even though there are none. This corrupts the byte[].

      Attaching a patch that allocates a DUMMY_HEADER_NO_CHECKSUM in that case which I think is the desired behavior.

        Attachments

        1. 5720-trunk-v2.txt
          14 kB
          Ted Yu
        2. 5720-trunk.txt
          13 kB
          Ted Yu
        3. 5720v4.txt
          3 kB
          Lars Hofhansl
        4. 5720v4.txt
          3 kB
          stack
        5. 5720v4.txt
          3 kB
          stack
        6. HBASE-5720-v3.patch
          4 kB
          Matt Corgan
        7. HBASE-5720-v2.patch
          3 kB
          Matt Corgan
        8. HBASE-5720-v1.patch
          2 kB
          Matt Corgan

          Issue Links

          There are no Sub-Tasks for this issue.

            Activity

              People

              • Assignee:
                mcorgan Matt Corgan
                Reporter:
                mcorgan Matt Corgan
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: