Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-5720

HFileDataBlockEncoderImpl uses wrong header size when reading HFiles with no checksums

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Blocker
    • Resolution: Fixed
    • 0.94.0
    • 0.94.0
    • io, regionserver
    • None
    • Reviewed

    Description

      When reading a .92 HFile without checksums, encoding it, and storing in the block cache, the HFileDataBlockEncoderImpl always allocates a dummy header appropriate for checksums even though there are none. This corrupts the byte[].

      Attaching a patch that allocates a DUMMY_HEADER_NO_CHECKSUM in that case which I think is the desired behavior.

      Attachments

        1. HBASE-5720-v1.patch
          2 kB
          Matt Corgan
        2. HBASE-5720-v2.patch
          3 kB
          Matt Corgan
        3. HBASE-5720-v3.patch
          4 kB
          Matt Corgan
        4. 5720v4.txt
          3 kB
          Michael Stack
        5. 5720v4.txt
          3 kB
          Michael Stack
        6. 5720v4.txt
          3 kB
          Lars Hofhansl
        7. 5720-trunk.txt
          13 kB
          Ted Yu
        8. 5720-trunk-v2.txt
          14 kB
          Ted Yu

        Issue Links

          Activity

            People

              mcorgan Matt Corgan
              mcorgan Matt Corgan
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: