HBase
  1. HBase
  2. HBASE-5719

Enhance hbck to sideline overlapped mega regions

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.94.0, 0.95.2
    • Fix Version/s: 0.94.0, 0.95.0
    • Component/s: hbck
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      If there are too many regions in one overlapped group (by default, more than 10), hbck currently doesn't merge them since it takes time.
      In this case, we can sideline some regions in the group and break the overlapping to fix the inconsistency. Later on, sidelined regions can be bulk loaded manually.

      1. hbase-5719.patch
        15 kB
        Jimmy Xiang
      2. hbase-5719_v3-new.patch
        19 kB
        Jimmy Xiang
      3. hbase-5719_v3.patch
        19 kB
        Jimmy Xiang
      4. hbase-5719_0.94.patch
        19 kB
        Jimmy Xiang
      5. hbase-5719_0.92.patch
        19 kB
        Jimmy Xiang
      6. hbase-5719_0.90.patch
        19 kB
        Jimmy Xiang
      7. 5719.patch
        19 kB
        Jimmy Xiang
      8. 5719_0.94.patch
        19 kB
        Jimmy Xiang
      9. 5719_0.92.patch
        19 kB
        Jimmy Xiang
      10. 5719_0.90.patch
        19 kB
        Jimmy Xiang

        Issue Links

          Activity

          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/4649/
          -----------------------------------------------------------

          Review request for hbase.

          Summary
          -------

          Make it configurable to sideline some regions in big overlapped groups which hbck doesn't handle currently.

          The regions chose to sideline are those which overlap with most other regions.

          This addresses bug HBASE-5719.
          https://issues.apache.org/jira/browse/HBASE-5719

          Diffs


          src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 54f9b21
          src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java 17678dd

          Diff: https://reviews.apache.org/r/4649/diff

          Testing
          -------

          mvn -PlocalTests -Dtest=TestHBaseFsck* clean test

          Also tested in real system to fix inconsistencies.

          Thanks,

          Jimmy

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4649/ ----------------------------------------------------------- Review request for hbase. Summary ------- Make it configurable to sideline some regions in big overlapped groups which hbck doesn't handle currently. The regions chose to sideline are those which overlap with most other regions. This addresses bug HBASE-5719 . https://issues.apache.org/jira/browse/HBASE-5719 Diffs src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 54f9b21 src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java 17678dd Diff: https://reviews.apache.org/r/4649/diff Testing ------- mvn -PlocalTests -Dtest=TestHBaseFsck* clean test Also tested in real system to fix inconsistencies. Thanks, Jimmy
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/4649/
          -----------------------------------------------------------

          (Updated 2012-04-04 23:52:50.930344)

          Review request for hbase and jmhsieh.

          Summary
          -------

          Make it configurable to sideline some regions in big overlapped groups which hbck doesn't handle currently.

          The regions chose to sideline are those which overlap with most other regions.

          This addresses bug HBASE-5719.
          https://issues.apache.org/jira/browse/HBASE-5719

          Diffs


          src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 54f9b21
          src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java 17678dd

          Diff: https://reviews.apache.org/r/4649/diff

          Testing
          -------

          mvn -PlocalTests -Dtest=TestHBaseFsck* clean test

          Also tested in real system to fix inconsistencies.

          Thanks,

          Jimmy

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4649/ ----------------------------------------------------------- (Updated 2012-04-04 23:52:50.930344) Review request for hbase and jmhsieh. Summary ------- Make it configurable to sideline some regions in big overlapped groups which hbck doesn't handle currently. The regions chose to sideline are those which overlap with most other regions. This addresses bug HBASE-5719 . https://issues.apache.org/jira/browse/HBASE-5719 Diffs src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 54f9b21 src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java 17678dd Diff: https://reviews.apache.org/r/4649/diff Testing ------- mvn -PlocalTests -Dtest=TestHBaseFsck* clean test Also tested in real system to fix inconsistencies. Thanks, Jimmy
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12521425/hbase-5719.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 3 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1399//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1399//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1399//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12521425/hbase-5719.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 3 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1399//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1399//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1399//console This message is automatically generated.
          Hide
          Jonathan Hsieh added a comment -

          More context:

          We ran into a corrupted cluster that had encountered HBASE-4238 and had several generations of "grandparent" and regions lingering in HDFS. If you looked at a region map, we had overlapping regions that looked like this:

          [A-I], [A-E], [E-H], [A-C], [A-B], [B-C] ...

          The HBASE-5128 version of hbck would see that all these regions fit inside of A-I and then attempt to merge the all into one mega region. This is technically correct but could result merging all the regions in an overlap group into one region that was significantly larger than all others (worst case all regions of a table could get combined into one region). HBASE-5128 includes some safeguards to prevent these "mega merges". In order to fix these situations, we sidelined (close, offline, move to different dir) the grandparent regions with the largest overlapped with the most other regions. This leaves us with many small groups of overlapping regions instead of a single large set of overlapping regions. These smaller regions could be safely repaired automatically via merges, and any data from the sidelined grandparent regions could be restored via a bulk load later on.

          So in the example above, the [A-I], [A-E], [E-H] grandparent regions would get sidelined, and leaving us with [A-C], [A-B],[B-C]. These smaller regions could get safely merged automatically into a single [A-C]' region. We'd then bulk load [A-I], [A-E], and [E-H] regions back in afterwards to restore data.

          The goal of this patch is to automatically id and sideline overlapping grandparent regions.

          Show
          Jonathan Hsieh added a comment - More context: We ran into a corrupted cluster that had encountered HBASE-4238 and had several generations of "grandparent" and regions lingering in HDFS. If you looked at a region map, we had overlapping regions that looked like this: [A-I] , [A-E] , [E-H] , [A-C] , [A-B] , [B-C] ... The HBASE-5128 version of hbck would see that all these regions fit inside of A-I and then attempt to merge the all into one mega region. This is technically correct but could result merging all the regions in an overlap group into one region that was significantly larger than all others (worst case all regions of a table could get combined into one region). HBASE-5128 includes some safeguards to prevent these "mega merges". In order to fix these situations, we sidelined (close, offline, move to different dir) the grandparent regions with the largest overlapped with the most other regions. This leaves us with many small groups of overlapping regions instead of a single large set of overlapping regions. These smaller regions could be safely repaired automatically via merges, and any data from the sidelined grandparent regions could be restored via a bulk load later on. So in the example above, the [A-I] , [A-E] , [E-H] grandparent regions would get sidelined, and leaving us with [A-C] , [A-B] , [B-C] . These smaller regions could get safely merged automatically into a single [A-C] ' region. We'd then bulk load [A-I] , [A-E] , and [E-H] regions back in afterwards to restore data. The goal of this patch is to automatically id and sideline overlapping grandparent regions.
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/4649/#review6713
          -----------------------------------------------------------

          Nice feature. Can we call it something other than "breakXxx"? Maybe "-sidelineLargeOverlap"

          src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          <https://reviews.apache.org/r/4649/#comment14511>

          why commented?

          src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          <https://reviews.apache.org/r/4649/#comment14512>

          why commented?

          src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          <https://reviews.apache.org/r/4649/#comment14513>

          break? maybe a different word?

          src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          <https://reviews.apache.org/r/4649/#comment14514>

          instead of nesting, maybe set hfiles to an empty array?

          if (hfiles==null)

          { hfiles = new FileStatus[0]; }

          for (FileStatus hfile : hfiles)
          ...

          src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          <https://reviews.apache.org/r/4649/#comment14565>

          Instead of "None/Multiple" just say how many htds?

          src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          <https://reviews.apache.org/r/4649/#comment14516>

          We lost info here.

          src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          <https://reviews.apache.org/r/4649/#comment14608>

          Pretty important to note that we only "break" groups that exceed the max number of regions to merge!

          src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          <https://reviews.apache.org/r/4649/#comment14569>

          Comment about what you are trying to accomplish with this method?

          src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          <https://reviews.apache.org/r/4649/#comment14607>

          Is this really a failure?

          src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          <https://reviews.apache.org/r/4649/#comment14570>

          I think we should bail out in this case.

          src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          <https://reviews.apache.org/r/4649/#comment14571>

          LOG.debug/trace?

          src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          <https://reviews.apache.org/r/4649/#comment14572>

          LOG.debug/trace?

          src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          <https://reviews.apache.org/r/4649/#comment14562>

          wrong comment for this method

          src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          <https://reviews.apache.org/r/4649/#comment14563>

          Please update usage with new options.

          src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java
          <https://reviews.apache.org/r/4649/#comment14568>

          Why this change?

          src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java
          <https://reviews.apache.org/r/4649/#comment14567>

          This is a really important function.

          Please java doc (maybe an example?) and at least add a unit tests that cover edge cases here for this.

          What is the definition of a "megaOverlap"?

          What are the properties of the argument and the return values?

          What is the intuition behind how the regions selected are selected and returned?

          • jmhsieh

          On 2012-04-04 23:52:50, Jimmy Xiang wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/4649/

          -----------------------------------------------------------

          (Updated 2012-04-04 23:52:50)

          Review request for hbase and jmhsieh.

          Summary

          -------

          Make it configurable to sideline some regions in big overlapped groups which hbck doesn't handle currently.

          The regions chose to sideline are those which overlap with most other regions.

          This addresses bug HBASE-5719.

          https://issues.apache.org/jira/browse/HBASE-5719

          Diffs

          -----

          src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 54f9b21

          src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java 17678dd

          Diff: https://reviews.apache.org/r/4649/diff

          Testing

          -------

          mvn -PlocalTests -Dtest=TestHBaseFsck* clean test

          Also tested in real system to fix inconsistencies.

          Thanks,

          Jimmy

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4649/#review6713 ----------------------------------------------------------- Nice feature. Can we call it something other than "breakXxx"? Maybe "-sidelineLargeOverlap" src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java < https://reviews.apache.org/r/4649/#comment14511 > why commented? src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java < https://reviews.apache.org/r/4649/#comment14512 > why commented? src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java < https://reviews.apache.org/r/4649/#comment14513 > break? maybe a different word? src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java < https://reviews.apache.org/r/4649/#comment14514 > instead of nesting, maybe set hfiles to an empty array? if (hfiles==null) { hfiles = new FileStatus[0]; } for (FileStatus hfile : hfiles) ... src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java < https://reviews.apache.org/r/4649/#comment14565 > Instead of "None/Multiple" just say how many htds? src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java < https://reviews.apache.org/r/4649/#comment14516 > We lost info here. src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java < https://reviews.apache.org/r/4649/#comment14608 > Pretty important to note that we only "break" groups that exceed the max number of regions to merge! src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java < https://reviews.apache.org/r/4649/#comment14569 > Comment about what you are trying to accomplish with this method? src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java < https://reviews.apache.org/r/4649/#comment14607 > Is this really a failure? src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java < https://reviews.apache.org/r/4649/#comment14570 > I think we should bail out in this case. src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java < https://reviews.apache.org/r/4649/#comment14571 > LOG.debug/trace? src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java < https://reviews.apache.org/r/4649/#comment14572 > LOG.debug/trace? src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java < https://reviews.apache.org/r/4649/#comment14562 > wrong comment for this method src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java < https://reviews.apache.org/r/4649/#comment14563 > Please update usage with new options. src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java < https://reviews.apache.org/r/4649/#comment14568 > Why this change? src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java < https://reviews.apache.org/r/4649/#comment14567 > This is a really important function. Please java doc (maybe an example?) and at least add a unit tests that cover edge cases here for this. What is the definition of a "megaOverlap"? What are the properties of the argument and the return values? What is the intuition behind how the regions selected are selected and returned? jmhsieh On 2012-04-04 23:52:50, Jimmy Xiang wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4649/ ----------------------------------------------------------- (Updated 2012-04-04 23:52:50) Review request for hbase and jmhsieh. Summary ------- Make it configurable to sideline some regions in big overlapped groups which hbck doesn't handle currently. The regions chose to sideline are those which overlap with most other regions. This addresses bug HBASE-5719 . https://issues.apache.org/jira/browse/HBASE-5719 Diffs ----- src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 54f9b21 src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java 17678dd Diff: https://reviews.apache.org/r/4649/diff Testing ------- mvn -PlocalTests -Dtest=TestHBaseFsck* clean test Also tested in real system to fix inconsistencies. Thanks, Jimmy
          Hide
          jiraposter@reviews.apache.org added a comment -

          On 2012-04-06 02:26:10, jmhsieh wrote:

          > Nice feature. Can we call it something other than "breakXxx"? Maybe "-sidelineLargeOverlap"

          Sure. Will do.

          On 2012-04-06 02:26:10, jmhsieh wrote:

          > src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java, line 142

          > <https://reviews.apache.org/r/4649/diff/1/?file=100073#file100073line142>

          >

          > why commented?

          >

          It is not used so I commented it out.

          On 2012-04-06 02:26:10, jmhsieh wrote:

          > src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java, line 157

          > <https://reviews.apache.org/r/4649/diff/1/?file=100073#file100073line157>

          >

          > why commented?

          It is not used so I commented it out.

          On 2012-04-06 02:26:10, jmhsieh wrote:

          > src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java, line 174

          > <https://reviews.apache.org/r/4649/diff/1/?file=100073#file100073line174>

          >

          > break? maybe a different word?

          sideline.

          On 2012-04-06 02:26:10, jmhsieh wrote:

          > src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java, line 880

          > <https://reviews.apache.org/r/4649/diff/1/?file=100073#file100073line880>

          >

          > instead of nesting, maybe set hfiles to an empty array?

          >

          > if (hfiles==null) { bq. > hfiles = new FileStatus[0]; bq. > }

          > for (FileStatus hfile : hfiles)

          > ...

          That means an extra object. I think the current checking is fine.

          On 2012-04-06 02:26:10, jmhsieh wrote:

          > src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java, lines 1572-1574

          > <https://reviews.apache.org/r/4649/diff/1/?file=100073#file100073line1572>

          >

          > Instead of "None/Multiple" just say how many htds?

          >

          >

          All the htds are printed out, so it should be clear enough.

          On 2012-04-06 02:26:10, jmhsieh wrote:

          > src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java, line 1834

          > <https://reviews.apache.org/r/4649/diff/1/?file=100073#file100073line1834>

          >

          > Comment about what you are trying to accomplish with this method?

          Will do.

          On 2012-04-06 02:26:10, jmhsieh wrote:

          > src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java, line 1876

          > <https://reviews.apache.org/r/4649/diff/1/?file=100073#file100073line1876>

          >

          > LOG.debug/trace?

          Will change to LOG.debug

          On 2012-04-06 02:26:10, jmhsieh wrote:

          > src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java, line 1872

          > <https://reviews.apache.org/r/4649/diff/1/?file=100073#file100073line1872>

          >

          > LOG.debug/trace?

          >

          Will change to LOG.debug, good catch.

          On 2012-04-06 02:26:10, jmhsieh wrote:

          > src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java, lines 167-215

          > <https://reviews.apache.org/r/4649/diff/1/?file=100074#file100074line167>

          >

          > This is a really important function.

          >

          > Please java doc (maybe an example?) and at least add a unit tests that cover edge cases here for this.

          >

          > What is the definition of a "megaOverlap"?

          >

          > What are the properties of the argument and the return values?

          >

          > What is the intuition behind how the regions selected are selected and returned?

          Sure, will do.

          On 2012-04-06 02:26:10, jmhsieh wrote:

          > src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java, lines 2826-2831

          > <https://reviews.apache.org/r/4649/diff/1/?file=100073#file100073line2826>

          >

          > wrong comment for this method

          Will fix it.

          On 2012-04-06 02:26:10, jmhsieh wrote:

          > src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java, lines 2896-2904

          > <https://reviews.apache.org/r/4649/diff/1/?file=100073#file100073line2896>

          >

          > Please update usage with new options.

          Will do.

          On 2012-04-06 02:26:10, jmhsieh wrote:

          > src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java, line 1843

          > <https://reviews.apache.org/r/4649/diff/1/?file=100073#file100073line1843>

          >

          > Is this really a failure?

          This should not happen. Let me remove this checking.

          On 2012-04-06 02:26:10, jmhsieh wrote:

          > src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java, line 1755

          > <https://reviews.apache.org/r/4649/diff/1/?file=100073#file100073line1755>

          >

          > We lost info here.

          Will add it back.

          On 2012-04-06 02:26:10, jmhsieh wrote:

          > src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java, lines 1756-1757

          > <https://reviews.apache.org/r/4649/diff/1/?file=100073#file100073line1756>

          >

          > Pretty important to note that we only "break" groups that exceed the max number of regions to merge!

          Right, I will add some comment.

          On 2012-04-06 02:26:10, jmhsieh wrote:

          > src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java, line 1858

          > <https://reviews.apache.org/r/4649/diff/1/?file=100073#file100073line1858>

          >

          > I think we should bail out in this case.

          Agree, will fix it.

          • Jimmy

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/4649/#review6713
          -----------------------------------------------------------

          On 2012-04-04 23:52:50, Jimmy Xiang wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/4649/

          -----------------------------------------------------------

          (Updated 2012-04-04 23:52:50)

          Review request for hbase and jmhsieh.

          Summary

          -------

          Make it configurable to sideline some regions in big overlapped groups which hbck doesn't handle currently.

          The regions chose to sideline are those which overlap with most other regions.

          This addresses bug HBASE-5719.

          https://issues.apache.org/jira/browse/HBASE-5719

          Diffs

          -----

          src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 54f9b21

          src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java 17678dd

          Diff: https://reviews.apache.org/r/4649/diff

          Testing

          -------

          mvn -PlocalTests -Dtest=TestHBaseFsck* clean test

          Also tested in real system to fix inconsistencies.

          Thanks,

          Jimmy

          Show
          jiraposter@reviews.apache.org added a comment - On 2012-04-06 02:26:10, jmhsieh wrote: > Nice feature. Can we call it something other than "breakXxx"? Maybe "-sidelineLargeOverlap" Sure. Will do. On 2012-04-06 02:26:10, jmhsieh wrote: > src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java, line 142 > < https://reviews.apache.org/r/4649/diff/1/?file=100073#file100073line142 > > > why commented? > It is not used so I commented it out. On 2012-04-06 02:26:10, jmhsieh wrote: > src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java, line 157 > < https://reviews.apache.org/r/4649/diff/1/?file=100073#file100073line157 > > > why commented? It is not used so I commented it out. On 2012-04-06 02:26:10, jmhsieh wrote: > src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java, line 174 > < https://reviews.apache.org/r/4649/diff/1/?file=100073#file100073line174 > > > break? maybe a different word? sideline. On 2012-04-06 02:26:10, jmhsieh wrote: > src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java, line 880 > < https://reviews.apache.org/r/4649/diff/1/?file=100073#file100073line880 > > > instead of nesting, maybe set hfiles to an empty array? > > if (hfiles==null) { bq. > hfiles = new FileStatus[0]; bq. > } > for (FileStatus hfile : hfiles) > ... That means an extra object. I think the current checking is fine. On 2012-04-06 02:26:10, jmhsieh wrote: > src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java, lines 1572-1574 > < https://reviews.apache.org/r/4649/diff/1/?file=100073#file100073line1572 > > > Instead of "None/Multiple" just say how many htds? > > All the htds are printed out, so it should be clear enough. On 2012-04-06 02:26:10, jmhsieh wrote: > src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java, line 1834 > < https://reviews.apache.org/r/4649/diff/1/?file=100073#file100073line1834 > > > Comment about what you are trying to accomplish with this method? Will do. On 2012-04-06 02:26:10, jmhsieh wrote: > src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java, line 1876 > < https://reviews.apache.org/r/4649/diff/1/?file=100073#file100073line1876 > > > LOG.debug/trace? Will change to LOG.debug On 2012-04-06 02:26:10, jmhsieh wrote: > src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java, line 1872 > < https://reviews.apache.org/r/4649/diff/1/?file=100073#file100073line1872 > > > LOG.debug/trace? > Will change to LOG.debug, good catch. On 2012-04-06 02:26:10, jmhsieh wrote: > src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java, lines 167-215 > < https://reviews.apache.org/r/4649/diff/1/?file=100074#file100074line167 > > > This is a really important function. > > Please java doc (maybe an example?) and at least add a unit tests that cover edge cases here for this. > > What is the definition of a "megaOverlap"? > > What are the properties of the argument and the return values? > > What is the intuition behind how the regions selected are selected and returned? Sure, will do. On 2012-04-06 02:26:10, jmhsieh wrote: > src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java, lines 2826-2831 > < https://reviews.apache.org/r/4649/diff/1/?file=100073#file100073line2826 > > > wrong comment for this method Will fix it. On 2012-04-06 02:26:10, jmhsieh wrote: > src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java, lines 2896-2904 > < https://reviews.apache.org/r/4649/diff/1/?file=100073#file100073line2896 > > > Please update usage with new options. Will do. On 2012-04-06 02:26:10, jmhsieh wrote: > src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java, line 1843 > < https://reviews.apache.org/r/4649/diff/1/?file=100073#file100073line1843 > > > Is this really a failure? This should not happen. Let me remove this checking. On 2012-04-06 02:26:10, jmhsieh wrote: > src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java, line 1755 > < https://reviews.apache.org/r/4649/diff/1/?file=100073#file100073line1755 > > > We lost info here. Will add it back. On 2012-04-06 02:26:10, jmhsieh wrote: > src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java, lines 1756-1757 > < https://reviews.apache.org/r/4649/diff/1/?file=100073#file100073line1756 > > > Pretty important to note that we only "break" groups that exceed the max number of regions to merge! Right, I will add some comment. On 2012-04-06 02:26:10, jmhsieh wrote: > src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java, line 1858 > < https://reviews.apache.org/r/4649/diff/1/?file=100073#file100073line1858 > > > I think we should bail out in this case. Agree, will fix it. Jimmy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4649/#review6713 ----------------------------------------------------------- On 2012-04-04 23:52:50, Jimmy Xiang wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4649/ ----------------------------------------------------------- (Updated 2012-04-04 23:52:50) Review request for hbase and jmhsieh. Summary ------- Make it configurable to sideline some regions in big overlapped groups which hbck doesn't handle currently. The regions chose to sideline are those which overlap with most other regions. This addresses bug HBASE-5719 . https://issues.apache.org/jira/browse/HBASE-5719 Diffs ----- src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 54f9b21 src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java 17678dd Diff: https://reviews.apache.org/r/4649/diff Testing ------- mvn -PlocalTests -Dtest=TestHBaseFsck* clean test Also tested in real system to fix inconsistencies. Thanks, Jimmy
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/4649/
          -----------------------------------------------------------

          (Updated 2012-04-06 18:27:34.615205)

          Review request for hbase and jmhsieh.

          Changes
          -------

          Addressed Jon's comments.

          Summary
          -------

          Make it configurable to sideline some regions in big overlapped groups which hbck doesn't handle currently.

          The regions chose to sideline are those which overlap with most other regions.

          This addresses bug HBASE-5719.
          https://issues.apache.org/jira/browse/HBASE-5719

          Diffs (updated)


          src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 54f9b21
          src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java 17678dd
          src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitCalculator.java ac3b225

          Diff: https://reviews.apache.org/r/4649/diff

          Testing
          -------

          mvn -PlocalTests -Dtest=TestHBaseFsck* clean test

          Also tested in real system to fix inconsistencies.

          Thanks,

          Jimmy

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4649/ ----------------------------------------------------------- (Updated 2012-04-06 18:27:34.615205) Review request for hbase and jmhsieh. Changes ------- Addressed Jon's comments. Summary ------- Make it configurable to sideline some regions in big overlapped groups which hbck doesn't handle currently. The regions chose to sideline are those which overlap with most other regions. This addresses bug HBASE-5719 . https://issues.apache.org/jira/browse/HBASE-5719 Diffs (updated) src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 54f9b21 src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java 17678dd src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitCalculator.java ac3b225 Diff: https://reviews.apache.org/r/4649/diff Testing ------- mvn -PlocalTests -Dtest=TestHBaseFsck* clean test Also tested in real system to fix inconsistencies. Thanks, Jimmy
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/4649/#review6764
          -----------------------------------------------------------

          Jimmy,

          Looks good to me. Mostly some questions and a little bit of of follow up to make it easier to read and to provide user more info.

          src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          <https://reviews.apache.org/r/4649/#comment14916>

          nice catch.

          src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          <https://reviews.apache.org/r/4649/#comment15130>

          Maybe this one is at info level?

          src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          <https://reviews.apache.org/r/4649/#comment14917>

          nit: typo (old was correct)

          src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          <https://reviews.apache.org/r/4649/#comment14918>

          Is this <n> per group or globally? please make it clear in usage

          src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          <https://reviews.apache.org/r/4649/#comment14919>

          nit: should be like previous -maxMerge's comments.

          src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java
          <https://reviews.apache.org/r/4649/#comment15129>

          To find? Would returning a sort make sense? if there are no overlaps will this return the specified number (or less?)

          Could this return several regions that now leave holes?

          nit: It might make testing clearer to return the overlapCount -> regions map and check that.

          src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java
          <https://reviews.apache.org/r/4649/#comment15132>

          Add comment about structure contents. something like: Integer key is overlap count and List is regions that have that many overlaps.
          maybe rename to overlapRangeMap?

          src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java
          <https://reviews.apache.org/r/4649/#comment15135>

          add comment: calculates the # of overlaps for each region and populates rangeOverlapMap

          src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java
          <https://reviews.apache.org/r/4649/#comment15133>

          add comment?

          We always overlap with ourselves – which is why > 1 is the condition below..

          src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java
          <https://reviews.apache.org/r/4649/#comment15136>

          what is the intuition here?

          src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitCalculator.java
          <https://reviews.apache.org/r/4649/#comment15140>

          nit: it would easer to read if this was called ai, the next ae, and the one after that ac.

          Also would help if you put the expected overlap count in comments!

          • jmhsieh

          On 2012-04-06 18:27:34, Jimmy Xiang wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/4649/

          -----------------------------------------------------------

          (Updated 2012-04-06 18:27:34)

          Review request for hbase and jmhsieh.

          Summary

          -------

          Make it configurable to sideline some regions in big overlapped groups which hbck doesn't handle currently.

          The regions chose to sideline are those which overlap with most other regions.

          This addresses bug HBASE-5719.

          https://issues.apache.org/jira/browse/HBASE-5719

          Diffs

          -----

          src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 54f9b21

          src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java 17678dd

          src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitCalculator.java ac3b225

          Diff: https://reviews.apache.org/r/4649/diff

          Testing

          -------

          mvn -PlocalTests -Dtest=TestHBaseFsck* clean test

          Also tested in real system to fix inconsistencies.

          Thanks,

          Jimmy

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4649/#review6764 ----------------------------------------------------------- Jimmy, Looks good to me. Mostly some questions and a little bit of of follow up to make it easier to read and to provide user more info. src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java < https://reviews.apache.org/r/4649/#comment14916 > nice catch. src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java < https://reviews.apache.org/r/4649/#comment15130 > Maybe this one is at info level? src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java < https://reviews.apache.org/r/4649/#comment14917 > nit: typo (old was correct) src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java < https://reviews.apache.org/r/4649/#comment14918 > Is this <n> per group or globally? please make it clear in usage src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java < https://reviews.apache.org/r/4649/#comment14919 > nit: should be like previous -maxMerge's comments. src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java < https://reviews.apache.org/r/4649/#comment15129 > To find? Would returning a sort make sense? if there are no overlaps will this return the specified number (or less?) Could this return several regions that now leave holes? nit: It might make testing clearer to return the overlapCount -> regions map and check that. src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java < https://reviews.apache.org/r/4649/#comment15132 > Add comment about structure contents. something like: Integer key is overlap count and List is regions that have that many overlaps. maybe rename to overlapRangeMap? src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java < https://reviews.apache.org/r/4649/#comment15135 > add comment: calculates the # of overlaps for each region and populates rangeOverlapMap src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java < https://reviews.apache.org/r/4649/#comment15133 > add comment? We always overlap with ourselves – which is why > 1 is the condition below.. src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java < https://reviews.apache.org/r/4649/#comment15136 > what is the intuition here? src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitCalculator.java < https://reviews.apache.org/r/4649/#comment15140 > nit: it would easer to read if this was called ai, the next ae, and the one after that ac. Also would help if you put the expected overlap count in comments! jmhsieh On 2012-04-06 18:27:34, Jimmy Xiang wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4649/ ----------------------------------------------------------- (Updated 2012-04-06 18:27:34) Review request for hbase and jmhsieh. Summary ------- Make it configurable to sideline some regions in big overlapped groups which hbck doesn't handle currently. The regions chose to sideline are those which overlap with most other regions. This addresses bug HBASE-5719 . https://issues.apache.org/jira/browse/HBASE-5719 Diffs ----- src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 54f9b21 src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java 17678dd src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitCalculator.java ac3b225 Diff: https://reviews.apache.org/r/4649/diff Testing ------- mvn -PlocalTests -Dtest=TestHBaseFsck* clean test Also tested in real system to fix inconsistencies. Thanks, Jimmy
          Hide
          jiraposter@reviews.apache.org added a comment -

          On 2012-04-09 18:20:11, jmhsieh wrote:

          > src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java, line 1869

          > <https://reviews.apache.org/r/4649/diff/2/?file=100672#file100672line1869>

          >

          > Maybe this one is at info level?

          Will change to info level.

          On 2012-04-09 18:20:11, jmhsieh wrote:

          > src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java, line 2828

          > <https://reviews.apache.org/r/4649/diff/2/?file=100672#file100672line2828>

          >

          > nit: typo (old was correct)

          Changed it back. It must be because the mouse moved when I was typing something. I didn't remember I changed it.

          On 2012-04-09 18:20:11, jmhsieh wrote:

          > src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java, line 2895

          > <https://reviews.apache.org/r/4649/diff/2/?file=100672#file100672line2895>

          >

          > Is this <n> per group or globally? please make it clear in usage

          It is per group. Will fix it.

          On 2012-04-09 18:20:11, jmhsieh wrote:

          > src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java, line 2981

          > <https://reviews.apache.org/r/4649/diff/2/?file=100672#file100672line2981>

          >

          > nit: should be like previous -maxMerge's comments.

          Will fix it.

          On 2012-04-09 18:20:11, jmhsieh wrote:

          > src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitCalculator.java, line 360

          > <https://reviews.apache.org/r/4649/diff/2/?file=100674#file100674line360>

          >

          > nit: it would easer to read if this was called ai, the next ae, and the one after that ac.

          >

          > Also would help if you put the expected overlap count in comments!

          Sure.

          On 2012-04-09 18:20:11, jmhsieh wrote:

          > src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java, line 212

          > <https://reviews.apache.org/r/4649/diff/2/?file=100673#file100673line212>

          >

          > what is the intuition here?

          Added comment

          On 2012-04-09 18:20:11, jmhsieh wrote:

          > src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java, line 189

          > <https://reviews.apache.org/r/4649/diff/2/?file=100673#file100673line189>

          >

          > add comment?

          >

          > We always overlap with ourselves – which is why > 1 is the condition below..

          Will do.

          On 2012-04-09 18:20:11, jmhsieh wrote:

          > src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java, line 178

          > <https://reviews.apache.org/r/4649/diff/2/?file=100673#file100673line178>

          >

          > add comment: calculates the # of overlaps for each region and populates rangeOverlapMap

          Sure

          On 2012-04-09 18:20:11, jmhsieh wrote:

          > src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java, line 177

          > <https://reviews.apache.org/r/4649/diff/2/?file=100673#file100673line177>

          >

          > Add comment about structure contents. something like: Integer key is overlap count and List is regions that have that many overlaps.

          > maybe rename to overlapRangeMap?

          Sure.

          On 2012-04-09 18:20:11, jmhsieh wrote:

          > src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java, line 171

          > <https://reviews.apache.org/r/4649/diff/2/?file=100673#file100673line171>

          >

          > To find? Would returning a sort make sense? if there are no overlaps will this return the specified number (or less?)

          >

          > Could this return several regions that now leave holes?

          >

          > nit: It might make testing clearer to return the overlapCount -> regions map and check that.

          Added comment.

          • Jimmy

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/4649/#review6764
          -----------------------------------------------------------

          On 2012-04-06 18:27:34, Jimmy Xiang wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/4649/

          -----------------------------------------------------------

          (Updated 2012-04-06 18:27:34)

          Review request for hbase and jmhsieh.

          Summary

          -------

          Make it configurable to sideline some regions in big overlapped groups which hbck doesn't handle currently.

          The regions chose to sideline are those which overlap with most other regions.

          This addresses bug HBASE-5719.

          https://issues.apache.org/jira/browse/HBASE-5719

          Diffs

          -----

          src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 54f9b21

          src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java 17678dd

          src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitCalculator.java ac3b225

          Diff: https://reviews.apache.org/r/4649/diff

          Testing

          -------

          mvn -PlocalTests -Dtest=TestHBaseFsck* clean test

          Also tested in real system to fix inconsistencies.

          Thanks,

          Jimmy

          Show
          jiraposter@reviews.apache.org added a comment - On 2012-04-09 18:20:11, jmhsieh wrote: > src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java, line 1869 > < https://reviews.apache.org/r/4649/diff/2/?file=100672#file100672line1869 > > > Maybe this one is at info level? Will change to info level. On 2012-04-09 18:20:11, jmhsieh wrote: > src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java, line 2828 > < https://reviews.apache.org/r/4649/diff/2/?file=100672#file100672line2828 > > > nit: typo (old was correct) Changed it back. It must be because the mouse moved when I was typing something. I didn't remember I changed it. On 2012-04-09 18:20:11, jmhsieh wrote: > src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java, line 2895 > < https://reviews.apache.org/r/4649/diff/2/?file=100672#file100672line2895 > > > Is this <n> per group or globally? please make it clear in usage It is per group. Will fix it. On 2012-04-09 18:20:11, jmhsieh wrote: > src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java, line 2981 > < https://reviews.apache.org/r/4649/diff/2/?file=100672#file100672line2981 > > > nit: should be like previous -maxMerge's comments. Will fix it. On 2012-04-09 18:20:11, jmhsieh wrote: > src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitCalculator.java, line 360 > < https://reviews.apache.org/r/4649/diff/2/?file=100674#file100674line360 > > > nit: it would easer to read if this was called ai, the next ae, and the one after that ac. > > Also would help if you put the expected overlap count in comments! Sure. On 2012-04-09 18:20:11, jmhsieh wrote: > src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java, line 212 > < https://reviews.apache.org/r/4649/diff/2/?file=100673#file100673line212 > > > what is the intuition here? Added comment On 2012-04-09 18:20:11, jmhsieh wrote: > src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java, line 189 > < https://reviews.apache.org/r/4649/diff/2/?file=100673#file100673line189 > > > add comment? > > We always overlap with ourselves – which is why > 1 is the condition below.. Will do. On 2012-04-09 18:20:11, jmhsieh wrote: > src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java, line 178 > < https://reviews.apache.org/r/4649/diff/2/?file=100673#file100673line178 > > > add comment: calculates the # of overlaps for each region and populates rangeOverlapMap Sure On 2012-04-09 18:20:11, jmhsieh wrote: > src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java, line 177 > < https://reviews.apache.org/r/4649/diff/2/?file=100673#file100673line177 > > > Add comment about structure contents. something like: Integer key is overlap count and List is regions that have that many overlaps. > maybe rename to overlapRangeMap? Sure. On 2012-04-09 18:20:11, jmhsieh wrote: > src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java, line 171 > < https://reviews.apache.org/r/4649/diff/2/?file=100673#file100673line171 > > > To find? Would returning a sort make sense? if there are no overlaps will this return the specified number (or less?) > > Could this return several regions that now leave holes? > > nit: It might make testing clearer to return the overlapCount -> regions map and check that. Added comment. Jimmy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4649/#review6764 ----------------------------------------------------------- On 2012-04-06 18:27:34, Jimmy Xiang wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4649/ ----------------------------------------------------------- (Updated 2012-04-06 18:27:34) Review request for hbase and jmhsieh. Summary ------- Make it configurable to sideline some regions in big overlapped groups which hbck doesn't handle currently. The regions chose to sideline are those which overlap with most other regions. This addresses bug HBASE-5719 . https://issues.apache.org/jira/browse/HBASE-5719 Diffs ----- src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 54f9b21 src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java 17678dd src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitCalculator.java ac3b225 Diff: https://reviews.apache.org/r/4649/diff Testing ------- mvn -PlocalTests -Dtest=TestHBaseFsck* clean test Also tested in real system to fix inconsistencies. Thanks, Jimmy
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/4649/
          -----------------------------------------------------------

          (Updated 2012-04-09 19:27:53.361210)

          Review request for hbase and jmhsieh.

          Changes
          -------

          Addressed Jon's second review comments.

          Summary
          -------

          Make it configurable to sideline some regions in big overlapped groups which hbck doesn't handle currently.

          The regions chose to sideline are those which overlap with most other regions.

          This addresses bug HBASE-5719.
          https://issues.apache.org/jira/browse/HBASE-5719

          Diffs (updated)


          src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 54f9b21
          src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java 17678dd
          src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitCalculator.java ac3b225

          Diff: https://reviews.apache.org/r/4649/diff

          Testing
          -------

          mvn -PlocalTests -Dtest=TestHBaseFsck* clean test

          Also tested in real system to fix inconsistencies.

          Thanks,

          Jimmy

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4649/ ----------------------------------------------------------- (Updated 2012-04-09 19:27:53.361210) Review request for hbase and jmhsieh. Changes ------- Addressed Jon's second review comments. Summary ------- Make it configurable to sideline some regions in big overlapped groups which hbck doesn't handle currently. The regions chose to sideline are those which overlap with most other regions. This addresses bug HBASE-5719 . https://issues.apache.org/jira/browse/HBASE-5719 Diffs (updated) src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 54f9b21 src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java 17678dd src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitCalculator.java ac3b225 Diff: https://reviews.apache.org/r/4649/diff Testing ------- mvn -PlocalTests -Dtest=TestHBaseFsck* clean test Also tested in real system to fix inconsistencies. Thanks, Jimmy
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/4649/#review6851
          -----------------------------------------------------------

          Ship it!

          Looks good to me Jimmy. Mind checking 0.90/0.92/0.94 and doing ports if necessary? Should be trivial.

          I have one nit that you can address or ignore.

          src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitCalculator.java
          <https://reviews.apache.org/r/4649/#comment15241>

          nit: would be easier to read if
          assertTrue((r1.equals(ac) && r2.equals(ae)) || (r1.equals(ae) && r2.equals(ac)));

          • jmhsieh

          On 2012-04-09 19:27:53, Jimmy Xiang wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/4649/

          -----------------------------------------------------------

          (Updated 2012-04-09 19:27:53)

          Review request for hbase and jmhsieh.

          Summary

          -------

          Make it configurable to sideline some regions in big overlapped groups which hbck doesn't handle currently.

          The regions chose to sideline are those which overlap with most other regions.

          This addresses bug HBASE-5719.

          https://issues.apache.org/jira/browse/HBASE-5719

          Diffs

          -----

          src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 54f9b21

          src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java 17678dd

          src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitCalculator.java ac3b225

          Diff: https://reviews.apache.org/r/4649/diff

          Testing

          -------

          mvn -PlocalTests -Dtest=TestHBaseFsck* clean test

          Also tested in real system to fix inconsistencies.

          Thanks,

          Jimmy

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4649/#review6851 ----------------------------------------------------------- Ship it! Looks good to me Jimmy. Mind checking 0.90/0.92/0.94 and doing ports if necessary? Should be trivial. I have one nit that you can address or ignore. src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitCalculator.java < https://reviews.apache.org/r/4649/#comment15241 > nit: would be easier to read if assertTrue((r1.equals(ac) && r2.equals(ae)) || (r1.equals(ae) && r2.equals(ac))); jmhsieh On 2012-04-09 19:27:53, Jimmy Xiang wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4649/ ----------------------------------------------------------- (Updated 2012-04-09 19:27:53) Review request for hbase and jmhsieh. Summary ------- Make it configurable to sideline some regions in big overlapped groups which hbck doesn't handle currently. The regions chose to sideline are those which overlap with most other regions. This addresses bug HBASE-5719 . https://issues.apache.org/jira/browse/HBASE-5719 Diffs ----- src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 54f9b21 src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java 17678dd src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitCalculator.java ac3b225 Diff: https://reviews.apache.org/r/4649/diff Testing ------- mvn -PlocalTests -Dtest=TestHBaseFsck* clean test Also tested in real system to fix inconsistencies. Thanks, Jimmy
          Hide
          jiraposter@reviews.apache.org added a comment -

          On 2012-04-11 15:44:08, jmhsieh wrote:

          > src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitCalculator.java, lines 384-392

          > <https://reviews.apache.org/r/4649/diff/2-3/?file=100674#file100674line384>

          >

          > nit: would be easier to read if

          > assertTrue((r1.equals(ac) && r2.equals(ae)) || (r1.equals(ae) && r2.equals(ac)));

          That's the original version actually. However, the equals method somehow doesn't work. I didn't try to implement the equals method in the SimpleRange class.

          • Jimmy

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/4649/#review6851
          -----------------------------------------------------------

          On 2012-04-09 19:27:53, Jimmy Xiang wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/4649/

          -----------------------------------------------------------

          (Updated 2012-04-09 19:27:53)

          Review request for hbase and jmhsieh.

          Summary

          -------

          Make it configurable to sideline some regions in big overlapped groups which hbck doesn't handle currently.

          The regions chose to sideline are those which overlap with most other regions.

          This addresses bug HBASE-5719.

          https://issues.apache.org/jira/browse/HBASE-5719

          Diffs

          -----

          src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 54f9b21

          src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java 17678dd

          src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitCalculator.java ac3b225

          Diff: https://reviews.apache.org/r/4649/diff

          Testing

          -------

          mvn -PlocalTests -Dtest=TestHBaseFsck* clean test

          Also tested in real system to fix inconsistencies.

          Thanks,

          Jimmy

          Show
          jiraposter@reviews.apache.org added a comment - On 2012-04-11 15:44:08, jmhsieh wrote: > src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitCalculator.java, lines 384-392 > < https://reviews.apache.org/r/4649/diff/2-3/?file=100674#file100674line384 > > > nit: would be easier to read if > assertTrue((r1.equals(ac) && r2.equals(ae)) || (r1.equals(ae) && r2.equals(ac))); That's the original version actually. However, the equals method somehow doesn't work. I didn't try to implement the equals method in the SimpleRange class. Jimmy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4649/#review6851 ----------------------------------------------------------- On 2012-04-09 19:27:53, Jimmy Xiang wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4649/ ----------------------------------------------------------- (Updated 2012-04-09 19:27:53) Review request for hbase and jmhsieh. Summary ------- Make it configurable to sideline some regions in big overlapped groups which hbck doesn't handle currently. The regions chose to sideline are those which overlap with most other regions. This addresses bug HBASE-5719 . https://issues.apache.org/jira/browse/HBASE-5719 Diffs ----- src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 54f9b21 src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java 17678dd src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitCalculator.java ac3b225 Diff: https://reviews.apache.org/r/4649/diff Testing ------- mvn -PlocalTests -Dtest=TestHBaseFsck* clean test Also tested in real system to fix inconsistencies. Thanks, Jimmy
          Hide
          jiraposter@reviews.apache.org added a comment -

          On 2012-04-11 15:44:08, jmhsieh wrote:

          > src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitCalculator.java, lines 384-392

          > <https://reviews.apache.org/r/4649/diff/2-3/?file=100674#file100674line384>

          >

          > nit: would be easier to read if

          > assertTrue((r1.equals(ac) && r2.equals(ae)) || (r1.equals(ae) && r2.equals(ac)));

          Jimmy Xiang wrote:

          That's the original version actually. However, the equals method somehow doesn't work. I didn't try to implement the equals method in the SimpleRange class.

          I see. Either is fine by me – as is or you can make the change.

          • jmhsieh

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/4649/#review6851
          -----------------------------------------------------------

          On 2012-04-09 19:27:53, Jimmy Xiang wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/4649/

          -----------------------------------------------------------

          (Updated 2012-04-09 19:27:53)

          Review request for hbase and jmhsieh.

          Summary

          -------

          Make it configurable to sideline some regions in big overlapped groups which hbck doesn't handle currently.

          The regions chose to sideline are those which overlap with most other regions.

          This addresses bug HBASE-5719.

          https://issues.apache.org/jira/browse/HBASE-5719

          Diffs

          -----

          src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 54f9b21

          src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java 17678dd

          src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitCalculator.java ac3b225

          Diff: https://reviews.apache.org/r/4649/diff

          Testing

          -------

          mvn -PlocalTests -Dtest=TestHBaseFsck* clean test

          Also tested in real system to fix inconsistencies.

          Thanks,

          Jimmy

          Show
          jiraposter@reviews.apache.org added a comment - On 2012-04-11 15:44:08, jmhsieh wrote: > src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitCalculator.java, lines 384-392 > < https://reviews.apache.org/r/4649/diff/2-3/?file=100674#file100674line384 > > > nit: would be easier to read if > assertTrue((r1.equals(ac) && r2.equals(ae)) || (r1.equals(ae) && r2.equals(ac))); Jimmy Xiang wrote: That's the original version actually. However, the equals method somehow doesn't work. I didn't try to implement the equals method in the SimpleRange class. I see. Either is fine by me – as is or you can make the change. jmhsieh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4649/#review6851 ----------------------------------------------------------- On 2012-04-09 19:27:53, Jimmy Xiang wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4649/ ----------------------------------------------------------- (Updated 2012-04-09 19:27:53) Review request for hbase and jmhsieh. Summary ------- Make it configurable to sideline some regions in big overlapped groups which hbck doesn't handle currently. The regions chose to sideline are those which overlap with most other regions. This addresses bug HBASE-5719 . https://issues.apache.org/jira/browse/HBASE-5719 Diffs ----- src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 54f9b21 src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java 17678dd src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitCalculator.java ac3b225 Diff: https://reviews.apache.org/r/4649/diff Testing ------- mvn -PlocalTests -Dtest=TestHBaseFsck* clean test Also tested in real system to fix inconsistencies. Thanks, Jimmy
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12522283/hbase-5719_v3.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1479//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12522283/hbase-5719_v3.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1479//console This message is automatically generated.
          Hide
          Jimmy Xiang added a comment -

          Try it again. The patch applies fine for me.

          Show
          Jimmy Xiang added a comment - Try it again. The patch applies fine for me.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12522285/hbase-5719_v3-new.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1481//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12522285/hbase-5719_v3-new.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1481//console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12522366/5719.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.TestRegionRebalancing

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1491//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1491//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1491//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12522366/5719.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.TestRegionRebalancing Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1491//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1491//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1491//console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12522372/5719_0.94.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.client.TestFromClientSide

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1492//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1492//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1492//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12522372/5719_0.94.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.client.TestFromClientSide Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1492//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1492//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1492//console This message is automatically generated.
          Hide
          Jonathan Hsieh added a comment -

          Thanks for the patch and the backports Jimmy!

          Commited to 0.96/0.94/0.92/0.90.

          Show
          Jonathan Hsieh added a comment - Thanks for the patch and the backports Jimmy! Commited to 0.96/0.94/0.92/0.90.
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK #2746 (See https://builds.apache.org/job/HBase-TRUNK/2746/)
          HBASE-5719 Enhance hbck to sideline overlapped mega regions (Jimmy Xiang) (Revision 1325404)

          Result = SUCCESS
          jmhsieh :
          Files :

          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitCalculator.java
          Show
          Hudson added a comment - Integrated in HBase-TRUNK #2746 (See https://builds.apache.org/job/HBase-TRUNK/2746/ ) HBASE-5719 Enhance hbck to sideline overlapped mega regions (Jimmy Xiang) (Revision 1325404) Result = SUCCESS jmhsieh : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitCalculator.java
          Hide
          Hudson added a comment -

          Integrated in HBase-0.94 #106 (See https://builds.apache.org/job/HBase-0.94/106/)
          HBASE-5719 Enhance hbck to sideline overlapped mega regions (Jimmy Xiang) (Revision 1325403)

          Result = SUCCESS
          jmhsieh :
          Files :

          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitCalculator.java
          Show
          Hudson added a comment - Integrated in HBase-0.94 #106 (See https://builds.apache.org/job/HBase-0.94/106/ ) HBASE-5719 Enhance hbck to sideline overlapped mega regions (Jimmy Xiang) (Revision 1325403) Result = SUCCESS jmhsieh : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitCalculator.java
          Hide
          Hudson added a comment -

          Integrated in HBase-0.92 #369 (See https://builds.apache.org/job/HBase-0.92/369/)
          HBASE-5719 Enhance hbck to sideline overlapped mega regions (Jimmy Xiang) (Revision 1325405)

          Result = FAILURE
          jmhsieh :
          Files :

          • /hbase/branches/0.92/CHANGES.txt
          • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java
          • /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitCalculator.java
          Show
          Hudson added a comment - Integrated in HBase-0.92 #369 (See https://builds.apache.org/job/HBase-0.92/369/ ) HBASE-5719 Enhance hbck to sideline overlapped mega regions (Jimmy Xiang) (Revision 1325405) Result = FAILURE jmhsieh : Files : /hbase/branches/0.92/CHANGES.txt /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitCalculator.java
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK-security #169 (See https://builds.apache.org/job/HBase-TRUNK-security/169/)
          HBASE-5719 Enhance hbck to sideline overlapped mega regions (Jimmy Xiang) (Revision 1325404)

          Result = FAILURE
          jmhsieh :
          Files :

          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitCalculator.java
          Show
          Hudson added a comment - Integrated in HBase-TRUNK-security #169 (See https://builds.apache.org/job/HBase-TRUNK-security/169/ ) HBASE-5719 Enhance hbck to sideline overlapped mega regions (Jimmy Xiang) (Revision 1325404) Result = FAILURE jmhsieh : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitCalculator.java
          Hide
          Hudson added a comment -

          Integrated in HBase-0.94-security #9 (See https://builds.apache.org/job/HBase-0.94-security/9/)
          HBASE-5719 Enhance hbck to sideline overlapped mega regions (Jimmy Xiang) (Revision 1325403)

          Result = SUCCESS
          jmhsieh :
          Files :

          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitCalculator.java
          Show
          Hudson added a comment - Integrated in HBase-0.94-security #9 (See https://builds.apache.org/job/HBase-0.94-security/9/ ) HBASE-5719 Enhance hbck to sideline overlapped mega regions (Jimmy Xiang) (Revision 1325403) Result = SUCCESS jmhsieh : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitCalculator.java
          Hide
          Hudson added a comment -

          Integrated in HBase-0.92-security #105 (See https://builds.apache.org/job/HBase-0.92-security/105/)
          HBASE-5719 Enhance hbck to sideline overlapped mega regions (Jimmy Xiang) (Revision 1325405)

          Result = FAILURE
          jmhsieh :
          Files :

          • /hbase/branches/0.92/CHANGES.txt
          • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java
          • /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitCalculator.java
          Show
          Hudson added a comment - Integrated in HBase-0.92-security #105 (See https://builds.apache.org/job/HBase-0.92-security/105/ ) HBASE-5719 Enhance hbck to sideline overlapped mega regions (Jimmy Xiang) (Revision 1325405) Result = FAILURE jmhsieh : Files : /hbase/branches/0.92/CHANGES.txt /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitCalculator.java

            People

            • Assignee:
              Jimmy Xiang
              Reporter:
              Jimmy Xiang
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development