HBase
  1. HBase
  2. HBASE-5715

Revert 'Instant schema alter' for now, HBASE-4213

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.94.0
    • Component/s: None
    • Labels:
      None

      Description

      1. patch1.patch
        21 kB
        Subbu M Iyer
      2. revert.txt
        150 kB
        stack
      3. revert.v2.txt
        151 kB
        stack
      4. revert.v3.txt
        205 kB
        stack
      5. revert.v4.txt
        151 kB
        stack
      6. revert094.v4.txt
        146 kB
        stack

        Issue Links

          Activity

          Hide
          Ted Yu added a comment -

          @Subbu:
          Thanks for following up.

          I think this work should be discussed under HBASE-5713. I will provide review comments there.

          Have you run all unit tests under instant_schema_alter branch ?

          Show
          Ted Yu added a comment - @Subbu: Thanks for following up. I think this work should be discussed under HBASE-5713 . I will provide review comments there. Have you run all unit tests under instant_schema_alter branch ?
          Hide
          Subbu M Iyer added a comment -

          1. Completely removed the monitoring code. The thought is since schema change is supposed to happen rather quickly we dont get much from the monitoring capability. We can add it later if there is a real need for same.

          2. Added a rudimentary throttling when the RS closes/opens the regions.

          3. Increased the sleep time during concurrent split plus schema change executions.

          Show
          Subbu M Iyer added a comment - 1. Completely removed the monitoring code. The thought is since schema change is supposed to happen rather quickly we dont get much from the monitoring capability. We can add it later if there is a real need for same. 2. Added a rudimentary throttling when the RS closes/opens the regions. 3. Increased the sleep time during concurrent split plus schema change executions.
          Hide
          Hudson added a comment -

          Integrated in HBase-0.94-security #8 (See https://builds.apache.org/job/HBase-0.94-security/8/)
          HBASE-5715 Revert 'Instant schema alter' for now, HBASE-4213 (Revision 1310017)

          Result = SUCCESS
          stack :
          Files :

          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/MasterServices.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/DeleteTableHandler.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/ModifyTableHandler.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/TableAddFamilyHandler.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/TableDeleteFamilyHandler.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/TableModifyFamilyHandler.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/OnlineRegions.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterSchemaChangeTracker.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/SchemaChangeTracker.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java
          • /hbase/branches/0.94/src/main/resources/hbase-default.xml
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/InstantSchemaChangeTestBase.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChange.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChangeFailover.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChangeSplit.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/util/MockRegionServerServices.java
          Show
          Hudson added a comment - Integrated in HBase-0.94-security #8 (See https://builds.apache.org/job/HBase-0.94-security/8/ ) HBASE-5715 Revert 'Instant schema alter' for now, HBASE-4213 (Revision 1310017) Result = SUCCESS stack : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/HMaster.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/MasterServices.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/DeleteTableHandler.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/ModifyTableHandler.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/TableAddFamilyHandler.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/TableDeleteFamilyHandler.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/TableModifyFamilyHandler.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/OnlineRegions.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterSchemaChangeTracker.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/SchemaChangeTracker.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java /hbase/branches/0.94/src/main/resources/hbase-default.xml /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/InstantSchemaChangeTestBase.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChange.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChangeFailover.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChangeSplit.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/util/MockRegionServerServices.java
          Hide
          Subbu M Iyer added a comment -

          @Lars

          Thanks for the helping hands. Do you want to address the open/close throttling while I redo the monitoring part?

          Let me know.

          @Ted: Thanks for your help with the testing. Will post my patch once I am done to this Jira.

          Show
          Subbu M Iyer added a comment - @Lars Thanks for the helping hands. Do you want to address the open/close throttling while I redo the monitoring part? Let me know. @Ted: Thanks for your help with the testing. Will post my patch once I am done to this Jira.
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK-security #158 (See https://builds.apache.org/job/HBase-TRUNK-security/158/)
          HBASE-5715 Revert 'Instant schema alter' for now, HBASE-4213 (Revision 1310012)

          Result = FAILURE
          stack :
          Files :

          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/MasterServices.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/DeleteTableHandler.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/ModifyTableHandler.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/TableAddFamilyHandler.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/TableDeleteFamilyHandler.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/TableModifyFamilyHandler.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/OnlineRegions.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterSchemaChangeTracker.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/SchemaChangeTracker.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java
          • /hbase/trunk/src/main/resources/hbase-default.xml
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/InstantSchemaChangeTestBase.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChange.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChangeFailover.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChangeSplit.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/MockRegionServerServices.java
          Show
          Hudson added a comment - Integrated in HBase-TRUNK-security #158 (See https://builds.apache.org/job/HBase-TRUNK-security/158/ ) HBASE-5715 Revert 'Instant schema alter' for now, HBASE-4213 (Revision 1310012) Result = FAILURE stack : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/MasterServices.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/DeleteTableHandler.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/ModifyTableHandler.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/TableAddFamilyHandler.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/TableDeleteFamilyHandler.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/TableModifyFamilyHandler.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/OnlineRegions.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterSchemaChangeTracker.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/SchemaChangeTracker.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java /hbase/trunk/src/main/resources/hbase-default.xml /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/InstantSchemaChangeTestBase.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChange.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChangeFailover.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChangeSplit.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/MockRegionServerServices.java
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK #2714 (See https://builds.apache.org/job/HBase-TRUNK/2714/)
          HBASE-5715 Revert 'Instant schema alter' for now, HBASE-4213 (Revision 1310012)

          Result = SUCCESS
          stack :
          Files :

          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/MasterServices.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/DeleteTableHandler.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/ModifyTableHandler.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/TableAddFamilyHandler.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/TableDeleteFamilyHandler.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/TableModifyFamilyHandler.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/OnlineRegions.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterSchemaChangeTracker.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/SchemaChangeTracker.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java
          • /hbase/trunk/src/main/resources/hbase-default.xml
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/InstantSchemaChangeTestBase.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChange.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChangeFailover.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChangeSplit.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/MockRegionServerServices.java
          Show
          Hudson added a comment - Integrated in HBase-TRUNK #2714 (See https://builds.apache.org/job/HBase-TRUNK/2714/ ) HBASE-5715 Revert 'Instant schema alter' for now, HBASE-4213 (Revision 1310012) Result = SUCCESS stack : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/MasterServices.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/DeleteTableHandler.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/ModifyTableHandler.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/TableAddFamilyHandler.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/TableDeleteFamilyHandler.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/TableModifyFamilyHandler.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/OnlineRegions.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterSchemaChangeTracker.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/SchemaChangeTracker.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java /hbase/trunk/src/main/resources/hbase-default.xml /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/InstantSchemaChangeTestBase.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChange.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChangeFailover.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChangeSplit.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/MockRegionServerServices.java
          Hide
          Hudson added a comment -

          Integrated in HBase-0.94 #89 (See https://builds.apache.org/job/HBase-0.94/89/)
          HBASE-5715 Revert 'Instant schema alter' for now, HBASE-4213 (Revision 1310017)

          Result = FAILURE
          stack :
          Files :

          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/MasterServices.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/DeleteTableHandler.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/ModifyTableHandler.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/TableAddFamilyHandler.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/TableDeleteFamilyHandler.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/TableModifyFamilyHandler.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/OnlineRegions.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterSchemaChangeTracker.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/SchemaChangeTracker.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java
          • /hbase/branches/0.94/src/main/resources/hbase-default.xml
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/InstantSchemaChangeTestBase.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChange.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChangeFailover.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChangeSplit.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/util/MockRegionServerServices.java
          Show
          Hudson added a comment - Integrated in HBase-0.94 #89 (See https://builds.apache.org/job/HBase-0.94/89/ ) HBASE-5715 Revert 'Instant schema alter' for now, HBASE-4213 (Revision 1310017) Result = FAILURE stack : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/HMaster.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/MasterServices.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/DeleteTableHandler.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/ModifyTableHandler.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/TableAddFamilyHandler.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/TableDeleteFamilyHandler.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/TableModifyFamilyHandler.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/OnlineRegions.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterSchemaChangeTracker.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/SchemaChangeTracker.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java /hbase/branches/0.94/src/main/resources/hbase-default.xml /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/InstantSchemaChangeTestBase.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChange.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChangeFailover.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChangeSplit.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/util/MockRegionServerServices.java
          Hide
          stack added a comment -

          What I applied to 0.94. 0.94 is currently missing the Nicolas patch on clients returning too fast from master when doing table mods and its also missing annotation stuff on private/public, etc.

          Show
          stack added a comment - What I applied to 0.94. 0.94 is currently missing the Nicolas patch on clients returning too fast from master when doing table mods and its also missing annotation stuff on private/public, etc.
          Hide
          Jean-Daniel Cryans added a comment -

          +1 on the revert patch.

          Show
          Jean-Daniel Cryans added a comment - +1 on the revert patch.
          Hide
          Ted Yu added a comment -

          @Subbu:
          I will review your patches and run through test cases.

          Show
          Ted Yu added a comment - @Subbu: I will review your patches and run through test cases.
          Hide
          stack added a comment -

          I'm going to commit this in next few hours unless objection, to trunk and 0.94.

          Show
          stack added a comment - I'm going to commit this in next few hours unless objection, to trunk and 0.94.
          Hide
          Lars Hofhansl added a comment -

          @Subbu: I might have some spare cycles to help with this.

          Show
          Lars Hofhansl added a comment - @Subbu: I might have some spare cycles to help with this.
          Hide
          stack added a comment -

          @Subbu Add testing and doc. to the list. I made you a branch for playing on here: https://svn.apache.org/repos/asf/hbase/branches/instant_schema_alter One of us committers will need to do the commits for you but thats no problem. Thanks boss.

          Show
          stack added a comment - @Subbu Add testing and doc. to the list. I made you a branch for playing on here: https://svn.apache.org/repos/asf/hbase/branches/instant_schema_alter One of us committers will need to do the commits for you but thats no problem. Thanks boss.
          Hide
          Subbu M Iyer added a comment -

          Stack:

          Could you please help me with a branch for this as this definitely needs some baking time before we feel comfortable on a suitable release branch ?

          Show
          Subbu M Iyer added a comment - Stack: Could you please help me with a branch for this as this definitely needs some baking time before we feel comfortable on a suitable release branch ?
          Hide
          Subbu M Iyer added a comment -

          Lars:

          I have two issues to address (Please add more if I missed any)

          1. MonitoredTask usage is incorrect and needs a revisit.
          2. Introduce throttling during the Region open/close requests.

          Given my current schedules i would imagine that this will be couple of days of effort.

          I would like to understand how are we going to address like track it as part of original Jira or create new one? Patches will be based on trunk or branch et al.

          Show
          Subbu M Iyer added a comment - Lars: I have two issues to address (Please add more if I missed any) 1. MonitoredTask usage is incorrect and needs a revisit. 2. Introduce throttling during the Region open/close requests. Given my current schedules i would imagine that this will be couple of days of effort. I would like to understand how are we going to address like track it as part of original Jira or create new one? Patches will be based on trunk or branch et al.
          Hide
          stack added a comment -

          I tried some of the failed tests and they pass locally so I don't think this patch responsible.

          Show
          stack added a comment - I tried some of the failed tests and they pass locally so I don't think this patch responsible.
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/4656/
          -----------------------------------------------------------

          Review request for hbase.

          Summary
          -------

          Revert hbase-4213 instant schema alter.

          Reviewing, you probably want to do follow along w/ the original 4213 patch v7. This patch is a reverse of that.

          This addresses bug hbase-5715.
          https://issues.apache.org/jira/browse/hbase-5715

          Diffs


          src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java 9c9c7cc
          src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java 6229858
          src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java ea7ae45
          src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 26e9552
          src/main/java/org/apache/hadoop/hbase/master/HMaster.java daf3b07
          src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java 8a7da2e
          src/main/java/org/apache/hadoop/hbase/master/MasterServices.java e1e6685
          src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 3515d4a
          src/main/java/org/apache/hadoop/hbase/master/handler/DeleteTableHandler.java 02bec37
          src/main/java/org/apache/hadoop/hbase/master/handler/ModifyTableHandler.java 4a735ec
          src/main/java/org/apache/hadoop/hbase/master/handler/TableAddFamilyHandler.java 4ec3d68
          src/main/java/org/apache/hadoop/hbase/master/handler/TableDeleteFamilyHandler.java bfa624b
          src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java 6d173bb
          src/main/java/org/apache/hadoop/hbase/master/handler/TableModifyFamilyHandler.java b4f8cd4
          src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java 2913c2b
          src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 4f80999
          src/main/java/org/apache/hadoop/hbase/regionserver/OnlineRegions.java da9e5cf
          src/main/java/org/apache/hadoop/hbase/zookeeper/MasterSchemaChangeTracker.java 6c723b4
          src/main/java/org/apache/hadoop/hbase/zookeeper/SchemaChangeTracker.java 48d4ff7
          src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java 0f83655
          src/main/resources/hbase-default.xml 341431a
          src/test/java/org/apache/hadoop/hbase/client/InstantSchemaChangeTestBase.java 378c2b4
          src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChange.java 4ac2847
          src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChangeFailover.java c1490eb
          src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChangeSplit.java 8f3124b
          src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java d2b3060
          src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java 227c5f2
          src/test/java/org/apache/hadoop/hbase/util/MockRegionServerServices.java bb3ddd7

          Diff: https://reviews.apache.org/r/4656/diff

          Testing
          -------

          Thanks,

          Michael

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4656/ ----------------------------------------------------------- Review request for hbase. Summary ------- Revert hbase-4213 instant schema alter. Reviewing, you probably want to do follow along w/ the original 4213 patch v7. This patch is a reverse of that. This addresses bug hbase-5715. https://issues.apache.org/jira/browse/hbase-5715 Diffs src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java 9c9c7cc src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java 6229858 src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java ea7ae45 src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 26e9552 src/main/java/org/apache/hadoop/hbase/master/HMaster.java daf3b07 src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java 8a7da2e src/main/java/org/apache/hadoop/hbase/master/MasterServices.java e1e6685 src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 3515d4a src/main/java/org/apache/hadoop/hbase/master/handler/DeleteTableHandler.java 02bec37 src/main/java/org/apache/hadoop/hbase/master/handler/ModifyTableHandler.java 4a735ec src/main/java/org/apache/hadoop/hbase/master/handler/TableAddFamilyHandler.java 4ec3d68 src/main/java/org/apache/hadoop/hbase/master/handler/TableDeleteFamilyHandler.java bfa624b src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java 6d173bb src/main/java/org/apache/hadoop/hbase/master/handler/TableModifyFamilyHandler.java b4f8cd4 src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java 2913c2b src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 4f80999 src/main/java/org/apache/hadoop/hbase/regionserver/OnlineRegions.java da9e5cf src/main/java/org/apache/hadoop/hbase/zookeeper/MasterSchemaChangeTracker.java 6c723b4 src/main/java/org/apache/hadoop/hbase/zookeeper/SchemaChangeTracker.java 48d4ff7 src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java 0f83655 src/main/resources/hbase-default.xml 341431a src/test/java/org/apache/hadoop/hbase/client/InstantSchemaChangeTestBase.java 378c2b4 src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChange.java 4ac2847 src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChangeFailover.java c1490eb src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChangeSplit.java 8f3124b src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java d2b3060 src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java 227c5f2 src/test/java/org/apache/hadoop/hbase/util/MockRegionServerServices.java bb3ddd7 Diff: https://reviews.apache.org/r/4656/diff Testing ------- Thanks, Michael
          Hide
          stack added a comment -

          These are the usual 'failures'.

          Show
          stack added a comment - These are the usual 'failures'.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12521454/revert.v4.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 18 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.mapreduce.TestMultithreadedTableMapper
          org.apache.hadoop.hbase.mapreduce.TestImportTsv
          org.apache.hadoop.hbase.mapred.TestTableMapReduce
          org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
          org.apache.hadoop.hbase.mapreduce.TestTableMapReduce

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1401//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1401//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1401//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12521454/revert.v4.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 18 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.mapreduce.TestMultithreadedTableMapper org.apache.hadoop.hbase.mapreduce.TestImportTsv org.apache.hadoop.hbase.mapred.TestTableMapReduce org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat org.apache.hadoop.hbase.mapreduce.TestTableMapReduce Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1401//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1401//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1401//console This message is automatically generated.
          Hide
          stack added a comment -

          Retry

          Show
          stack added a comment - Retry
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12521417/revert.v3.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 27 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.master.TestMasterShutdown
          org.apache.hadoop.hbase.mapreduce.TestMultithreadedTableMapper
          org.apache.hadoop.hbase.master.TestActiveMasterManager
          org.apache.hadoop.hbase.master.TestMasterFailover
          org.apache.hadoop.hbase.mapreduce.TestImportTsv
          org.apache.hadoop.hbase.mapred.TestTableMapReduce
          org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
          org.apache.hadoop.hbase.mapreduce.TestTableMapReduce

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1398//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1398//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1398//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12521417/revert.v3.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 27 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.master.TestMasterShutdown org.apache.hadoop.hbase.mapreduce.TestMultithreadedTableMapper org.apache.hadoop.hbase.master.TestActiveMasterManager org.apache.hadoop.hbase.master.TestMasterFailover org.apache.hadoop.hbase.mapreduce.TestImportTsv org.apache.hadoop.hbase.mapred.TestTableMapReduce org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat org.apache.hadoop.hbase.mapreduce.TestTableMapReduce Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1398//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1398//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1398//console This message is automatically generated.
          Hide
          stack added a comment -

          Nicolas's recent commit made it so this no longer applied. Rebase.

          Show
          stack added a comment - Nicolas's recent commit made it so this no longer applied. Rebase.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12521407/revert.v2.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 18 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1397//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12521407/revert.v2.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 18 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1397//console This message is automatically generated.
          Hide
          stack added a comment -

          A short-cut I made was a mistake. Fixing failing tests (I love unit tests!)

          Show
          stack added a comment - A short-cut I made was a mistake. Fixing failing tests (I love unit tests!)
          Hide
          stack added a comment -

          Did another review. I think this is good to go if it passes hadoopqa. Its 95% a revert of hbase-4213. We keep the getOnlineRegions(byte [] tablename), otherwise all else goes.

          Show
          stack added a comment - Did another review. I think this is good to go if it passes hadoopqa. Its 95% a revert of hbase-4213. We keep the getOnlineRegions(byte [] tablename), otherwise all else goes.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12521395/revert.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 18 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.client.TestShell
          org.apache.hadoop.hbase.client.TestAdmin

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1391//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1391//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1391//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12521395/revert.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 18 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.client.TestShell org.apache.hadoop.hbase.client.TestAdmin Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1391//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1391//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1391//console This message is automatically generated.
          Hide
          stack added a comment -

          Here is first cut. Went over it once. Need to do another check to make sure I cut out the right pieces (one piece of functionality added by 4218 is used elsewhere, the getOnlineRegions(byte [] tablename).

          Show
          stack added a comment - Here is first cut. Went over it once. Need to do another check to make sure I cut out the right pieces (one piece of functionality added by 4218 is used elsewhere, the getOnlineRegions(byte [] tablename).
          Hide
          Lars Hofhansl added a comment -

          Comment crossing

          Show
          Lars Hofhansl added a comment - Comment crossing
          Hide
          Lars Hofhansl added a comment -

          @Subbu: How much work do you think this is?
          I want to cut RC1 soon (with a week or so), do you think you can address the issues by then?
          While I really like this feature (and Salesforce would definitely make use of this - or online schema update), we shouldn't ship with a feature that does not work.

          One option would be to pull this only from 0.94 and then make it work in 0.96.

          Show
          Lars Hofhansl added a comment - @Subbu: How much work do you think this is? I want to cut RC1 soon (with a week or so), do you think you can address the issues by then? While I really like this feature (and Salesforce would definitely make use of this - or online schema update), we shouldn't ship with a feature that does not work. One option would be to pull this only from 0.94 and then make it work in 0.96.
          Hide
          stack added a comment -

          @Subbu Thanks for showing up again. On the issues, sure, would appreciate the fixes. We can't put them in the way of a 0.94RC though so I suggest removing 4213 while the above are being addressed (including the 'rock solid testing ina production kind-of environment'). I can make a branch if that will help while this stuff is being worked on?

          Show
          stack added a comment - @Subbu Thanks for showing up again. On the issues, sure, would appreciate the fixes. We can't put them in the way of a 0.94RC though so I suggest removing 4213 while the above are being addressed (including the 'rock solid testing ina production kind-of environment'). I can make a branch if that will help while this stuff is being worked on?
          Hide
          Subbu M Iyer added a comment -

          I reviewed the thread above and I do see mixed feeling about this.

          So, just wanted to clarify whether addressing the monitoring leaks (5702), introduce throttling to address rapid open/close region concerns (5713) and addressing the ambiguity in the flags that enables/disables this feature is even an option or not?

          I can take up addressing the above two minor issues if that's an option. Also, since the default alter does not go through this path the impact to the common user should be none.

          Please note that what we have is based on loose set of requirements and I sincerely think that what is lacking is rock solid testing in a production kind-of environment and having cycles to address the issues if any.

          Show
          Subbu M Iyer added a comment - I reviewed the thread above and I do see mixed feeling about this. So, just wanted to clarify whether addressing the monitoring leaks (5702), introduce throttling to address rapid open/close region concerns (5713) and addressing the ambiguity in the flags that enables/disables this feature is even an option or not? I can take up addressing the above two minor issues if that's an option. Also, since the default alter does not go through this path the impact to the common user should be none. Please note that what we have is based on loose set of requirements and I sincerely think that what is lacking is rock solid testing in a production kind-of environment and having cycles to address the issues if any.

            People

            • Assignee:
              stack
              Reporter:
              stack
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development