HBase
  1. HBase
  2. HBASE-5709

Move active master and backup master znodes to use pbs

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.95.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    1. 5709v3.txt
      56 kB
      stack
    2. 5709v2.txt
      55 kB
      stack
    3. 5709.txt
      54 kB
      stack

      Issue Links

        Activity

        Hide
        stack added a comment -

        Serialize active master using pb. Do same for backup masters.

        D  src/main/java/org/apache/hadoop/hbase/MasterAddressTracker.java
          Moved under zookeeper.  All other Trackers are under zookeeper but this one.
        M  src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
          Use new utility method for getting current master that is over in MasterAddressTracker.
        M src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java
          Move dup code out into a new handle function.
          watcher.masterAddressZNode is no longer public. Use accessor.
          Use new setMasterAddress,getMasterAddress function on
          MasterAddressTracker for setting znode and backup master znode.
        M src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java
          Generated code.
        M src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
          Fix up import because MasterAddressTracker moved.
        A src/main/java/org/apache/hadoop/hbase/zookeeper/MasterAddressTracker.java
          Add back MasterAddressTracker here.  Add some utility functions for setting
          and getting the master address.
        M src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java
          Move dataToServerName into ZKUtil.  Its useful beyond this class only.
        M src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
          Go via accessor to get master znode path and use new utility method
          to get current master address.  dataToServerName moved here from
          RootRegionTracker.
        M src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java
          Shutdown access to masterAddressZNode.  Add an accessor method.
        M  src/main/protobuf/ZooKeeper.proto
          Add new master message class.
        M src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java
        M src/test/java/org/apache/hadoop/hbase/regionserver/TestMasterAddressManager.java
          Go via new accessor and use utility over in MasterAddressTracker.
        M src/test/java/org/apache/hadoop/hbase/regionserver/TestRSStatusServlet.java
          Fix import to point at new location.
        
        Show
        stack added a comment - Serialize active master using pb. Do same for backup masters. D src/main/java/org/apache/hadoop/hbase/MasterAddressTracker.java Moved under zookeeper. All other Trackers are under zookeeper but this one. M src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java Use new utility method for getting current master that is over in MasterAddressTracker. M src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java Move dup code out into a new handle function. watcher.masterAddressZNode is no longer public . Use accessor. Use new setMasterAddress,getMasterAddress function on MasterAddressTracker for setting znode and backup master znode. M src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java Generated code. M src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java Fix up import because MasterAddressTracker moved. A src/main/java/org/apache/hadoop/hbase/zookeeper/MasterAddressTracker.java Add back MasterAddressTracker here. Add some utility functions for setting and getting the master address. M src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java Move dataToServerName into ZKUtil. Its useful beyond this class only. M src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java Go via accessor to get master znode path and use new utility method to get current master address. dataToServerName moved here from RootRegionTracker. M src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java Shutdown access to masterAddressZNode. Add an accessor method. M src/main/protobuf/ZooKeeper.proto Add new master message class. M src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java M src/test/java/org/apache/hadoop/hbase/regionserver/TestMasterAddressManager.java Go via new accessor and use utility over in MasterAddressTracker. M src/test/java/org/apache/hadoop/hbase/regionserver/TestRSStatusServlet.java Fix import to point at new location.
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4630/
        -----------------------------------------------------------

        Review request for hbase.

        Summary
        -------

        Serialize active master using pb. Do same for backup masters.

        D src/main/java/org/apache/hadoop/hbase/MasterAddressTracker.java
        Moved under zookeeper. All other Trackers are under zookeeper but this one.
        M src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
        Use new utility method for getting current master that is over in MasterAddressTracker.
        M src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java
        Move dup code out into a new handle function.
        watcher.masterAddressZNode is no longer public. Use accessor.
        Use new setMasterAddress,getMasterAddress function on
        MasterAddressTracker for setting znode and backup master znode.
        M src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java
        Generated code.
        M src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
        Fix up import because MasterAddressTracker moved.
        A src/main/java/org/apache/hadoop/hbase/zookeeper/MasterAddressTracker.java
        Add back MasterAddressTracker here. Add some utility functions for setting
        and getting the master address.
        M src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java
        Move dataToServerName into ZKUtil. Its useful beyond this class only.
        M src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
        Go via accessor to get master znode path and use new utility method
        to get current master address. dataToServerName moved here from
        RootRegionTracker.
        M src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java
        Shutdown access to masterAddressZNode. Add an accessor method.
        M src/main/protobuf/ZooKeeper.proto
        Add new master message class.
        M src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java
        M src/test/java/org/apache/hadoop/hbase/regionserver/TestMasterAddressManager.java
        Go via new accessor and use utility over in MasterAddressTracker.
        M src/test/java/org/apache/hadoop/hbase/regionserver/TestRSStatusServlet.java
        Fix import to point at new location.

        This addresses bug hbase-5709.
        https://issues.apache.org/jira/browse/hbase-5709

        Diffs


        src/main/java/org/apache/hadoop/hbase/MasterAddressTracker.java a246abe
        src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java aa30969
        src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java ef19cb9
        src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java 8ff87fe
        src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 4f80999
        src/main/java/org/apache/hadoop/hbase/zookeeper/MasterAddressTracker.java PRE-CREATION
        src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java 6b2ea57
        src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java 037e354
        src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java 0f83655
        src/main/protobuf/ZooKeeper.proto 20f8eb0
        src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java 05f6b1a
        src/test/java/org/apache/hadoop/hbase/regionserver/TestMasterAddressManager.java e91d83c
        src/test/java/org/apache/hadoop/hbase/regionserver/TestRSStatusServlet.java 8478260

        Diff: https://reviews.apache.org/r/4630/diff

        Testing
        -------

        Thanks,

        Michael

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4630/ ----------------------------------------------------------- Review request for hbase. Summary ------- Serialize active master using pb. Do same for backup masters. D src/main/java/org/apache/hadoop/hbase/MasterAddressTracker.java Moved under zookeeper. All other Trackers are under zookeeper but this one. M src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java Use new utility method for getting current master that is over in MasterAddressTracker. M src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java Move dup code out into a new handle function. watcher.masterAddressZNode is no longer public. Use accessor. Use new setMasterAddress,getMasterAddress function on MasterAddressTracker for setting znode and backup master znode. M src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java Generated code. M src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java Fix up import because MasterAddressTracker moved. A src/main/java/org/apache/hadoop/hbase/zookeeper/MasterAddressTracker.java Add back MasterAddressTracker here. Add some utility functions for setting and getting the master address. M src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java Move dataToServerName into ZKUtil. Its useful beyond this class only. M src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java Go via accessor to get master znode path and use new utility method to get current master address. dataToServerName moved here from RootRegionTracker. M src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java Shutdown access to masterAddressZNode. Add an accessor method. M src/main/protobuf/ZooKeeper.proto Add new master message class. M src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java M src/test/java/org/apache/hadoop/hbase/regionserver/TestMasterAddressManager.java Go via new accessor and use utility over in MasterAddressTracker. M src/test/java/org/apache/hadoop/hbase/regionserver/TestRSStatusServlet.java Fix import to point at new location. This addresses bug hbase-5709. https://issues.apache.org/jira/browse/hbase-5709 Diffs src/main/java/org/apache/hadoop/hbase/MasterAddressTracker.java a246abe src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java aa30969 src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java ef19cb9 src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java 8ff87fe src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 4f80999 src/main/java/org/apache/hadoop/hbase/zookeeper/MasterAddressTracker.java PRE-CREATION src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java 6b2ea57 src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java 037e354 src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java 0f83655 src/main/protobuf/ZooKeeper.proto 20f8eb0 src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java 05f6b1a src/test/java/org/apache/hadoop/hbase/regionserver/TestMasterAddressManager.java e91d83c src/test/java/org/apache/hadoop/hbase/regionserver/TestRSStatusServlet.java 8478260 Diff: https://reviews.apache.org/r/4630/diff Testing ------- Thanks, Michael
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12521241/5709.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 9 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        -1 javac. The patch appears to cause mvn compile goal to fail.

        -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1382//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1382//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12521241/5709.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause mvn compile goal to fail. -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1382//testReport/ Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1382//console This message is automatically generated.
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4630/#review6667
        -----------------------------------------------------------

        For ServerName, port and startcode are unassigned in pb, how do you handle those -1 default values? For example, hbck uses -1 port.

        • Jimmy

        On 2012-04-03 23:38:15, Michael Stack wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4630/

        -----------------------------------------------------------

        (Updated 2012-04-03 23:38:15)

        Review request for hbase.

        Summary

        -------

        Serialize active master using pb. Do same for backup masters.

        D src/main/java/org/apache/hadoop/hbase/MasterAddressTracker.java

        Moved under zookeeper. All other Trackers are under zookeeper but this one.

        M src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java

        Use new utility method for getting current master that is over in MasterAddressTracker.

        M src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java

        Move dup code out into a new handle function.

        watcher.masterAddressZNode is no longer public. Use accessor.

        Use new setMasterAddress,getMasterAddress function on

        MasterAddressTracker for setting znode and backup master znode.

        M src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java

        Generated code.

        M src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java

        Fix up import because MasterAddressTracker moved.

        A src/main/java/org/apache/hadoop/hbase/zookeeper/MasterAddressTracker.java

        Add back MasterAddressTracker here. Add some utility functions for setting

        and getting the master address.

        M src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java

        Move dataToServerName into ZKUtil. Its useful beyond this class only.

        M src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java

        Go via accessor to get master znode path and use new utility method

        to get current master address. dataToServerName moved here from

        RootRegionTracker.

        M src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java

        Shutdown access to masterAddressZNode. Add an accessor method.

        M src/main/protobuf/ZooKeeper.proto

        Add new master message class.

        M src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java

        M src/test/java/org/apache/hadoop/hbase/regionserver/TestMasterAddressManager.java

        Go via new accessor and use utility over in MasterAddressTracker.

        M src/test/java/org/apache/hadoop/hbase/regionserver/TestRSStatusServlet.java

        Fix import to point at new location.

        This addresses bug hbase-5709.

        https://issues.apache.org/jira/browse/hbase-5709

        Diffs

        -----

        src/main/java/org/apache/hadoop/hbase/MasterAddressTracker.java a246abe

        src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java aa30969

        src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java ef19cb9

        src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java 8ff87fe

        src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 4f80999

        src/main/java/org/apache/hadoop/hbase/zookeeper/MasterAddressTracker.java PRE-CREATION

        src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java 6b2ea57

        src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java 037e354

        src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java 0f83655

        src/main/protobuf/ZooKeeper.proto 20f8eb0

        src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java 05f6b1a

        src/test/java/org/apache/hadoop/hbase/regionserver/TestMasterAddressManager.java e91d83c

        src/test/java/org/apache/hadoop/hbase/regionserver/TestRSStatusServlet.java 8478260

        Diff: https://reviews.apache.org/r/4630/diff

        Testing

        -------

        Thanks,

        Michael

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4630/#review6667 ----------------------------------------------------------- For ServerName, port and startcode are unassigned in pb, how do you handle those -1 default values? For example, hbck uses -1 port. Jimmy On 2012-04-03 23:38:15, Michael Stack wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4630/ ----------------------------------------------------------- (Updated 2012-04-03 23:38:15) Review request for hbase. Summary ------- Serialize active master using pb. Do same for backup masters. D src/main/java/org/apache/hadoop/hbase/MasterAddressTracker.java Moved under zookeeper. All other Trackers are under zookeeper but this one. M src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java Use new utility method for getting current master that is over in MasterAddressTracker. M src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java Move dup code out into a new handle function. watcher.masterAddressZNode is no longer public. Use accessor. Use new setMasterAddress,getMasterAddress function on MasterAddressTracker for setting znode and backup master znode. M src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java Generated code. M src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java Fix up import because MasterAddressTracker moved. A src/main/java/org/apache/hadoop/hbase/zookeeper/MasterAddressTracker.java Add back MasterAddressTracker here. Add some utility functions for setting and getting the master address. M src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java Move dataToServerName into ZKUtil. Its useful beyond this class only. M src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java Go via accessor to get master znode path and use new utility method to get current master address. dataToServerName moved here from RootRegionTracker. M src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java Shutdown access to masterAddressZNode. Add an accessor method. M src/main/protobuf/ZooKeeper.proto Add new master message class. M src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java M src/test/java/org/apache/hadoop/hbase/regionserver/TestMasterAddressManager.java Go via new accessor and use utility over in MasterAddressTracker. M src/test/java/org/apache/hadoop/hbase/regionserver/TestRSStatusServlet.java Fix import to point at new location. This addresses bug hbase-5709. https://issues.apache.org/jira/browse/hbase-5709 Diffs ----- src/main/java/org/apache/hadoop/hbase/MasterAddressTracker.java a246abe src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java aa30969 src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java ef19cb9 src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java 8ff87fe src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 4f80999 src/main/java/org/apache/hadoop/hbase/zookeeper/MasterAddressTracker.java PRE-CREATION src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java 6b2ea57 src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java 037e354 src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java 0f83655 src/main/protobuf/ZooKeeper.proto 20f8eb0 src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java 05f6b1a src/test/java/org/apache/hadoop/hbase/regionserver/TestMasterAddressManager.java e91d83c src/test/java/org/apache/hadoop/hbase/regionserver/TestRSStatusServlet.java 8478260 Diff: https://reviews.apache.org/r/4630/diff Testing ------- Thanks, Michael
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2012-04-04 00:21:57, Jimmy Xiang wrote:

        > For ServerName, port and startcode are unassigned in pb, how do you handle those -1 default values? For example, hbck uses -1 port.

        Am I not creating a ServerName passing port and startcode? This code just does what the old code does. It did not intercept -1s, etc., so neither does this patch.

        I think I'm not understanding. Help me out. Give it another go Jimmy.

        • Michael

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4630/#review6667
        -----------------------------------------------------------

        On 2012-04-03 23:38:15, Michael Stack wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4630/

        -----------------------------------------------------------

        (Updated 2012-04-03 23:38:15)

        Review request for hbase.

        Summary

        -------

        Serialize active master using pb. Do same for backup masters.

        D src/main/java/org/apache/hadoop/hbase/MasterAddressTracker.java

        Moved under zookeeper. All other Trackers are under zookeeper but this one.

        M src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java

        Use new utility method for getting current master that is over in MasterAddressTracker.

        M src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java

        Move dup code out into a new handle function.

        watcher.masterAddressZNode is no longer public. Use accessor.

        Use new setMasterAddress,getMasterAddress function on

        MasterAddressTracker for setting znode and backup master znode.

        M src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java

        Generated code.

        M src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java

        Fix up import because MasterAddressTracker moved.

        A src/main/java/org/apache/hadoop/hbase/zookeeper/MasterAddressTracker.java

        Add back MasterAddressTracker here. Add some utility functions for setting

        and getting the master address.

        M src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java

        Move dataToServerName into ZKUtil. Its useful beyond this class only.

        M src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java

        Go via accessor to get master znode path and use new utility method

        to get current master address. dataToServerName moved here from

        RootRegionTracker.

        M src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java

        Shutdown access to masterAddressZNode. Add an accessor method.

        M src/main/protobuf/ZooKeeper.proto

        Add new master message class.

        M src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java

        M src/test/java/org/apache/hadoop/hbase/regionserver/TestMasterAddressManager.java

        Go via new accessor and use utility over in MasterAddressTracker.

        M src/test/java/org/apache/hadoop/hbase/regionserver/TestRSStatusServlet.java

        Fix import to point at new location.

        This addresses bug hbase-5709.

        https://issues.apache.org/jira/browse/hbase-5709

        Diffs

        -----

        src/main/java/org/apache/hadoop/hbase/MasterAddressTracker.java a246abe

        src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java aa30969

        src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java ef19cb9

        src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java 8ff87fe

        src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 4f80999

        src/main/java/org/apache/hadoop/hbase/zookeeper/MasterAddressTracker.java PRE-CREATION

        src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java 6b2ea57

        src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java 037e354

        src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java 0f83655

        src/main/protobuf/ZooKeeper.proto 20f8eb0

        src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java 05f6b1a

        src/test/java/org/apache/hadoop/hbase/regionserver/TestMasterAddressManager.java e91d83c

        src/test/java/org/apache/hadoop/hbase/regionserver/TestRSStatusServlet.java 8478260

        Diff: https://reviews.apache.org/r/4630/diff

        Testing

        -------

        Thanks,

        Michael

        Show
        jiraposter@reviews.apache.org added a comment - On 2012-04-04 00:21:57, Jimmy Xiang wrote: > For ServerName, port and startcode are unassigned in pb, how do you handle those -1 default values? For example, hbck uses -1 port. Am I not creating a ServerName passing port and startcode? This code just does what the old code does. It did not intercept -1s, etc., so neither does this patch. I think I'm not understanding. Help me out. Give it another go Jimmy. Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4630/#review6667 ----------------------------------------------------------- On 2012-04-03 23:38:15, Michael Stack wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4630/ ----------------------------------------------------------- (Updated 2012-04-03 23:38:15) Review request for hbase. Summary ------- Serialize active master using pb. Do same for backup masters. D src/main/java/org/apache/hadoop/hbase/MasterAddressTracker.java Moved under zookeeper. All other Trackers are under zookeeper but this one. M src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java Use new utility method for getting current master that is over in MasterAddressTracker. M src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java Move dup code out into a new handle function. watcher.masterAddressZNode is no longer public. Use accessor. Use new setMasterAddress,getMasterAddress function on MasterAddressTracker for setting znode and backup master znode. M src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java Generated code. M src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java Fix up import because MasterAddressTracker moved. A src/main/java/org/apache/hadoop/hbase/zookeeper/MasterAddressTracker.java Add back MasterAddressTracker here. Add some utility functions for setting and getting the master address. M src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java Move dataToServerName into ZKUtil. Its useful beyond this class only. M src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java Go via accessor to get master znode path and use new utility method to get current master address. dataToServerName moved here from RootRegionTracker. M src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java Shutdown access to masterAddressZNode. Add an accessor method. M src/main/protobuf/ZooKeeper.proto Add new master message class. M src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java M src/test/java/org/apache/hadoop/hbase/regionserver/TestMasterAddressManager.java Go via new accessor and use utility over in MasterAddressTracker. M src/test/java/org/apache/hadoop/hbase/regionserver/TestRSStatusServlet.java Fix import to point at new location. This addresses bug hbase-5709. https://issues.apache.org/jira/browse/hbase-5709 Diffs ----- src/main/java/org/apache/hadoop/hbase/MasterAddressTracker.java a246abe src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java aa30969 src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java ef19cb9 src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java 8ff87fe src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 4f80999 src/main/java/org/apache/hadoop/hbase/zookeeper/MasterAddressTracker.java PRE-CREATION src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java 6b2ea57 src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java 037e354 src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java 0f83655 src/main/protobuf/ZooKeeper.proto 20f8eb0 src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java 05f6b1a src/test/java/org/apache/hadoop/hbase/regionserver/TestMasterAddressManager.java e91d83c src/test/java/org/apache/hadoop/hbase/regionserver/TestRSStatusServlet.java 8478260 Diff: https://reviews.apache.org/r/4630/diff Testing ------- Thanks, Michael
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2012-04-04 00:21:57, Jimmy Xiang wrote:

        > For ServerName, port and startcode are unassigned in pb, how do you handle those -1 default values? For example, hbck uses -1 port.

        Michael Stack wrote:

        Am I not creating a ServerName passing port and startcode? This code just does what the old code does. It did not intercept -1s, etc., so neither does this patch.

        I think I'm not understanding. Help me out. Give it another go Jimmy.

        This patch is good to me. What I was thinking about is the region transition data. Sorry for the confusion.

        • Jimmy

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4630/#review6667
        -----------------------------------------------------------

        On 2012-04-03 23:38:15, Michael Stack wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4630/

        -----------------------------------------------------------

        (Updated 2012-04-03 23:38:15)

        Review request for hbase.

        Summary

        -------

        Serialize active master using pb. Do same for backup masters.

        D src/main/java/org/apache/hadoop/hbase/MasterAddressTracker.java

        Moved under zookeeper. All other Trackers are under zookeeper but this one.

        M src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java

        Use new utility method for getting current master that is over in MasterAddressTracker.

        M src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java

        Move dup code out into a new handle function.

        watcher.masterAddressZNode is no longer public. Use accessor.

        Use new setMasterAddress,getMasterAddress function on

        MasterAddressTracker for setting znode and backup master znode.

        M src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java

        Generated code.

        M src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java

        Fix up import because MasterAddressTracker moved.

        A src/main/java/org/apache/hadoop/hbase/zookeeper/MasterAddressTracker.java

        Add back MasterAddressTracker here. Add some utility functions for setting

        and getting the master address.

        M src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java

        Move dataToServerName into ZKUtil. Its useful beyond this class only.

        M src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java

        Go via accessor to get master znode path and use new utility method

        to get current master address. dataToServerName moved here from

        RootRegionTracker.

        M src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java

        Shutdown access to masterAddressZNode. Add an accessor method.

        M src/main/protobuf/ZooKeeper.proto

        Add new master message class.

        M src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java

        M src/test/java/org/apache/hadoop/hbase/regionserver/TestMasterAddressManager.java

        Go via new accessor and use utility over in MasterAddressTracker.

        M src/test/java/org/apache/hadoop/hbase/regionserver/TestRSStatusServlet.java

        Fix import to point at new location.

        This addresses bug hbase-5709.

        https://issues.apache.org/jira/browse/hbase-5709

        Diffs

        -----

        src/main/java/org/apache/hadoop/hbase/MasterAddressTracker.java a246abe

        src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java aa30969

        src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java ef19cb9

        src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java 8ff87fe

        src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 4f80999

        src/main/java/org/apache/hadoop/hbase/zookeeper/MasterAddressTracker.java PRE-CREATION

        src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java 6b2ea57

        src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java 037e354

        src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java 0f83655

        src/main/protobuf/ZooKeeper.proto 20f8eb0

        src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java 05f6b1a

        src/test/java/org/apache/hadoop/hbase/regionserver/TestMasterAddressManager.java e91d83c

        src/test/java/org/apache/hadoop/hbase/regionserver/TestRSStatusServlet.java 8478260

        Diff: https://reviews.apache.org/r/4630/diff

        Testing

        -------

        Thanks,

        Michael

        Show
        jiraposter@reviews.apache.org added a comment - On 2012-04-04 00:21:57, Jimmy Xiang wrote: > For ServerName, port and startcode are unassigned in pb, how do you handle those -1 default values? For example, hbck uses -1 port. Michael Stack wrote: Am I not creating a ServerName passing port and startcode? This code just does what the old code does. It did not intercept -1s, etc., so neither does this patch. I think I'm not understanding. Help me out. Give it another go Jimmy. This patch is good to me. What I was thinking about is the region transition data. Sorry for the confusion. Jimmy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4630/#review6667 ----------------------------------------------------------- On 2012-04-03 23:38:15, Michael Stack wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4630/ ----------------------------------------------------------- (Updated 2012-04-03 23:38:15) Review request for hbase. Summary ------- Serialize active master using pb. Do same for backup masters. D src/main/java/org/apache/hadoop/hbase/MasterAddressTracker.java Moved under zookeeper. All other Trackers are under zookeeper but this one. M src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java Use new utility method for getting current master that is over in MasterAddressTracker. M src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java Move dup code out into a new handle function. watcher.masterAddressZNode is no longer public. Use accessor. Use new setMasterAddress,getMasterAddress function on MasterAddressTracker for setting znode and backup master znode. M src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java Generated code. M src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java Fix up import because MasterAddressTracker moved. A src/main/java/org/apache/hadoop/hbase/zookeeper/MasterAddressTracker.java Add back MasterAddressTracker here. Add some utility functions for setting and getting the master address. M src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java Move dataToServerName into ZKUtil. Its useful beyond this class only. M src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java Go via accessor to get master znode path and use new utility method to get current master address. dataToServerName moved here from RootRegionTracker. M src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java Shutdown access to masterAddressZNode. Add an accessor method. M src/main/protobuf/ZooKeeper.proto Add new master message class. M src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java M src/test/java/org/apache/hadoop/hbase/regionserver/TestMasterAddressManager.java Go via new accessor and use utility over in MasterAddressTracker. M src/test/java/org/apache/hadoop/hbase/regionserver/TestRSStatusServlet.java Fix import to point at new location. This addresses bug hbase-5709. https://issues.apache.org/jira/browse/hbase-5709 Diffs ----- src/main/java/org/apache/hadoop/hbase/MasterAddressTracker.java a246abe src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java aa30969 src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java ef19cb9 src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java 8ff87fe src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 4f80999 src/main/java/org/apache/hadoop/hbase/zookeeper/MasterAddressTracker.java PRE-CREATION src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java 6b2ea57 src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java 037e354 src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java 0f83655 src/main/protobuf/ZooKeeper.proto 20f8eb0 src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java 05f6b1a src/test/java/org/apache/hadoop/hbase/regionserver/TestMasterAddressManager.java e91d83c src/test/java/org/apache/hadoop/hbase/regionserver/TestRSStatusServlet.java 8478260 Diff: https://reviews.apache.org/r/4630/diff Testing ------- Thanks, Michael
        Hide
        stack added a comment -

        Fix a minor compilation issue (a method moved)

        Show
        stack added a comment - Fix a minor compilation issue (a method moved)
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12521332/5709v2.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 9 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.master.TestMasterShutdown
        org.apache.hadoop.hbase.client.TestFromClientSide
        org.apache.hadoop.hbase.mapreduce.TestMultithreadedTableMapper
        org.apache.hadoop.hbase.master.TestActiveMasterManager
        org.apache.hadoop.hbase.master.TestMasterFailover
        org.apache.hadoop.hbase.mapreduce.TestImportTsv
        org.apache.hadoop.hbase.mapred.TestTableMapReduce
        org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
        org.apache.hadoop.hbase.mapreduce.TestTableMapReduce

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1384//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1384//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1384//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12521332/5709v2.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.master.TestMasterShutdown org.apache.hadoop.hbase.client.TestFromClientSide org.apache.hadoop.hbase.mapreduce.TestMultithreadedTableMapper org.apache.hadoop.hbase.master.TestActiveMasterManager org.apache.hadoop.hbase.master.TestMasterFailover org.apache.hadoop.hbase.mapreduce.TestImportTsv org.apache.hadoop.hbase.mapred.TestTableMapReduce org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat org.apache.hadoop.hbase.mapreduce.TestTableMapReduce Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1384//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1384//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1384//console This message is automatically generated.
        Hide
        stack added a comment -

        Unit tests found place where a test was reading the raw znode.... fixed.

        Show
        stack added a comment - Unit tests found place where a test was reading the raw znode.... fixed.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12521369/5709v3.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 9 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.mapreduce.TestMultithreadedTableMapper
        org.apache.hadoop.hbase.mapreduce.TestImportTsv
        org.apache.hadoop.hbase.mapred.TestTableMapReduce
        org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
        org.apache.hadoop.hbase.mapreduce.TestTableMapReduce

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1389//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1389//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1389//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12521369/5709v3.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.mapreduce.TestMultithreadedTableMapper org.apache.hadoop.hbase.mapreduce.TestImportTsv org.apache.hadoop.hbase.mapred.TestTableMapReduce org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat org.apache.hadoop.hbase.mapreduce.TestTableMapReduce Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1389//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1389//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1389//console This message is automatically generated.
        Hide
        stack added a comment -

        Committed to trunk. Thanks for review Jimmy.

        Show
        stack added a comment - Committed to trunk. Thanks for review Jimmy.
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #2721 (See https://builds.apache.org/job/HBase-TRUNK/2721/)
        HBASE-5709 Move active master and backup master znodes to use pbs (Revision 1310553)

        Result = SUCCESS
        stack :
        Files :

        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/MasterAddressTracker.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterAddressTracker.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java
        • /hbase/trunk/src/main/protobuf/ZooKeeper.proto
        • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java
        • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestMasterAddressManager.java
        • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestRSStatusServlet.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #2721 (See https://builds.apache.org/job/HBase-TRUNK/2721/ ) HBASE-5709 Move active master and backup master znodes to use pbs (Revision 1310553) Result = SUCCESS stack : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/MasterAddressTracker.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterAddressTracker.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java /hbase/trunk/src/main/protobuf/ZooKeeper.proto /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestMasterAddressManager.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestRSStatusServlet.java
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-security #161 (See https://builds.apache.org/job/HBase-TRUNK-security/161/)
        HBASE-5709 Move active master and backup master znodes to use pbs (Revision 1310553)

        Result = FAILURE
        stack :
        Files :

        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/MasterAddressTracker.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterAddressTracker.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java
        • /hbase/trunk/src/main/protobuf/ZooKeeper.proto
        • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java
        • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestMasterAddressManager.java
        • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestRSStatusServlet.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-security #161 (See https://builds.apache.org/job/HBase-TRUNK-security/161/ ) HBASE-5709 Move active master and backup master znodes to use pbs (Revision 1310553) Result = FAILURE stack : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/MasterAddressTracker.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterAddressTracker.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java /hbase/trunk/src/main/protobuf/ZooKeeper.proto /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestMasterAddressManager.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestRSStatusServlet.java
        Hide
        stack added a comment -

        Marking closed.

        Show
        stack added a comment - Marking closed.

          People

          • Assignee:
            stack
            Reporter:
            stack
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development