HBase
  1. HBase
  2. HBASE-5696

Use Hadoop's DataOutputOutputStream instead of have a copy local

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Tags:
      noob

      Activity

      Hide
      stack added a comment -

      We have a DOOS and so does hadoop. If I diff them, the hadoop one is public where ours is not (but a patch that is coming in also makes our's public, the protobuf hbase-5451.

      Show
      stack added a comment - We have a DOOS and so does hadoop. If I diff them, the hadoop one is public where ours is not (but a patch that is coming in also makes our's public, the protobuf hbase-5451.
      Hide
      Talat UYARER added a comment -

      Hi stack,

      I fixed this issue. It just is used by HbaseObjectWritableFor96Migration class. Because of that I deleted DataOutputOutputStream class.

      Show
      Talat UYARER added a comment - Hi stack , I fixed this issue. It just is used by HbaseObjectWritableFor96Migration class. Because of that I deleted DataOutputOutputStream class.
      Hide
      Enis Soztutar added a comment -

      +1 if hadoopqa passes.

      Show
      Enis Soztutar added a comment - +1 if hadoopqa passes.
      Hide
      stack added a comment -

      +1

      Show
      stack added a comment - +1
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12656369/HBASE-5696.patch
      against trunk revision .
      ATTACHMENT ID: 12656369

      +1 @author. The patch does not contain any @author tags.

      -1 tests included. The patch doesn't appear to include any new or modified tests.
      Please justify why no new tests are needed for this patch.
      Also please list what manual steps were performed to verify this patch.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

      +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 lineLengths. The patch does not introduce lines longer than 100

      +1 site. The mvn site goal succeeds with this patch.

      -1 core tests. The patch failed these unit tests:
      org.apache.hadoop.hbase.io.hfile.TestCacheConfig

      Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10112//testReport/
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10112//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10112//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10112//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10112//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10112//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10112//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10112//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10112//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10112//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
      Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10112//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12656369/HBASE-5696.patch against trunk revision . ATTACHMENT ID: 12656369 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 1 warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.io.hfile.TestCacheConfig Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10112//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10112//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10112//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10112//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10112//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10112//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10112//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10112//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10112//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10112//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10112//console This message is automatically generated.
      Hide
      Talat UYARER added a comment -

      In my local environment (Eclipse and command line running) This test passed successfully. Furthermore my patch didn't relate with this test. IMHO jenkins has an error. Wdyt ?

      Show
      Talat UYARER added a comment - In my local environment (Eclipse and command line running) This test passed successfully. Furthermore my patch didn't relate with this test. IMHO jenkins has an error. Wdyt ?
      Hide
      stack added a comment -

      Talat UYARER Not your patch. That test has just started failing (it is my fault I believe).

      Show
      stack added a comment - Talat UYARER Not your patch. That test has just started failing (it is my fault I believe).
      Hide
      stack added a comment -

      Committed to master. Thank you Talat UYARER for the patch

      Show
      stack added a comment - Committed to master. Thank you Talat UYARER for the patch
      Hide
      Hudson added a comment -

      FAILURE: Integrated in HBase-TRUNK #5322 (See https://builds.apache.org/job/HBase-TRUNK/5322/)
      HBASE-5696 Use Hadoop's DataOutputOutputStream instead of have a copy local (Talat Uyarer) (stack: rev 15815791a67a98e2455880d92853a9bda7a3fc4f)

      • hbase-server/src/main/java/org/apache/hadoop/hbase/io/DataOutputOutputStream.java
      • hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/HbaseObjectWritableFor96Migration.java
      Show
      Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #5322 (See https://builds.apache.org/job/HBase-TRUNK/5322/ ) HBASE-5696 Use Hadoop's DataOutputOutputStream instead of have a copy local (Talat Uyarer) (stack: rev 15815791a67a98e2455880d92853a9bda7a3fc4f) hbase-server/src/main/java/org/apache/hadoop/hbase/io/DataOutputOutputStream.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/HbaseObjectWritableFor96Migration.java

        People

        • Assignee:
          Talat UYARER
          Reporter:
          stack
        • Votes:
          0 Vote for this issue
          Watchers:
          7 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development