HBase
  1. HBase
  2. HBASE-5692

Add real action time for HLogPrettyPrinter

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.95.0
    • Component/s: regionserver
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Now the HLogPrettyPrinter print the log without real op time but the timestamp

      Sequence 4 from region ee9877dfd55624f50b20acf572416a88 in table t5
      Action:
      row: r
      column: f3:q
      at time: Thu Jan 01 08:02:03 CST 1970

      Maybe we need to know the real op time like this

      Sequence 4 from region ee9877dfd55624f50b20acf572416a88 in table t5 at time: <Sun Apr 01 10:42:53 CST 2012>
      Action:
      row: r
      column: f3:q
      timestamp: Thu Jan 01 08:02:03 CST 1970

      1. 5692v2.patch
        2 kB
        stack
      2. HBASE-5665-trunk.v2.patch
        4 kB
        stack
      3. HBASE-5692.patch
        2 kB
        ShiXing

        Activity

        ShiXing created issue -
        ShiXing made changes -
        Field Original Value New Value
        Attachment HBASE-5692.patch [ 12520809 ]
        Hide
        stack added a comment -

        Same as v1 w/ some formatting changes. +1 on this patch.

        Show
        stack added a comment - Same as v1 w/ some formatting changes. +1 on this patch.
        stack made changes -
        Attachment HBASE-5665-trunk.v2.patch [ 12521048 ]
        stack made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12521048/HBASE-5665-trunk.v2.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1371//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12521048/HBASE-5665-trunk.v2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1371//console This message is automatically generated.
        Hide
        stack added a comment -

        Attach the 'right' patch

        Show
        stack added a comment - Attach the 'right' patch
        stack made changes -
        Attachment 5692v2.patch [ 12521058 ]
        stack made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        stack made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12521058/5692v2.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1372//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1372//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1372//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12521058/5692v2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1372//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1372//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1372//console This message is automatically generated.
        Hide
        stack added a comment -

        Committed Trunk. Thanks for the patch Xing.

        Show
        stack added a comment - Committed Trunk. Thanks for the patch Xing.
        stack made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s 0.96.0 [ 12320040 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-security #156 (See https://builds.apache.org/job/HBase-TRUNK-security/156/)
        HBASE-5692 Add real action time for HLogPrettyPrinter (Revision 1308609)

        Result = FAILURE
        stack :
        Files :

        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogPrettyPrinter.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-security #156 (See https://builds.apache.org/job/HBase-TRUNK-security/156/ ) HBASE-5692 Add real action time for HLogPrettyPrinter (Revision 1308609) Result = FAILURE stack : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogPrettyPrinter.java
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #2705 (See https://builds.apache.org/job/HBase-TRUNK/2705/)
        HBASE-5692 Add real action time for HLogPrettyPrinter (Revision 1308609)

        Result = FAILURE
        stack :
        Files :

        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogPrettyPrinter.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #2705 (See https://builds.apache.org/job/HBase-TRUNK/2705/ ) HBASE-5692 Add real action time for HLogPrettyPrinter (Revision 1308609) Result = FAILURE stack : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogPrettyPrinter.java
        stack made changes -
        Fix Version/s 0.95.0 [ 12324094 ]
        Fix Version/s 0.96.0 [ 12320040 ]
        stack made changes -
        Fix Version/s 0.98.0 [ 12323143 ]
        stack made changes -
        Fix Version/s 0.98.0 [ 12323143 ]
        stack made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            ShiXing
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development