Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.95.0
    • Component/s: scripts
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    1. HBASE-5653.patch
      16 kB
      Uma Maheswara Rao G
    2. HBASE-5653.patch
      16 kB
      Uma Maheswara Rao G

      Activity

      Hide
      Uma Maheswara Rao G added a comment -

      Updated the patch.

      in MultithreadedTableMapper file, I have removed one unused variable. I have no much idea in this file, please check whether that variable used in any other way. I am very happy to address your comments

             } catch (Throwable ie) {
      -        throwable = ie;
      +        LOG.error("Problem in running map.", ie);
      
      Show
      Uma Maheswara Rao G added a comment - Updated the patch. in MultithreadedTableMapper file, I have removed one unused variable. I have no much idea in this file, please check whether that variable used in any other way. I am very happy to address your comments } catch (Throwable ie) { - throwable = ie; + LOG.error( "Problem in running map." , ie);
      Hide
      Hadoop QA added a comment -

      +1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12521875/HBASE-5653.patch
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 6 new or modified tests.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 core tests. The patch passed unit tests in .

      Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1448//testReport/
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1448//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
      Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1448//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12521875/HBASE-5653.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1448//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1448//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1448//console This message is automatically generated.
      Hide
      Uma Maheswara Rao G added a comment -

      @Jon, please take a look, when you get some time.

      Show
      Uma Maheswara Rao G added a comment - @Jon, please take a look, when you get some time.
      Hide
      Jonathan Hsieh added a comment -

      Looks good to me. One suggestion:

               totalReplicated++;
             }
      -      for(byte [] table : rows.keySet()) {
      -        batch(table, rows.get(table));
      +      for (Iterator<Entry<byte[], List<Row>>> iterator = rows.entrySet()
      +          .iterator(); iterator.hasNext();) {
      +        Entry<byte[], List<Row>> keyValues = iterator.next();
      +        batch(keyValues.getKey(), keyValues.getValue());
             }
      

      Maybe write this way instead:

      for (Entry<byte[], List<Row>> entry : rows.entrySet()) {
        batch(entry.getKey(), entry.getValue());
      }
      
      Show
      Jonathan Hsieh added a comment - Looks good to me. One suggestion: totalReplicated++; } - for ( byte [] table : rows.keySet()) { - batch(table, rows.get(table)); + for (Iterator<Entry< byte [], List<Row>>> iterator = rows.entrySet() + .iterator(); iterator.hasNext();) { + Entry< byte [], List<Row>> keyValues = iterator.next(); + batch(keyValues.getKey(), keyValues.getValue()); } Maybe write this way instead: for (Entry< byte [], List<Row>> entry : rows.entrySet()) { batch(entry.getKey(), entry.getValue()); }
      Hide
      Uma Maheswara Rao G added a comment -

      Thanks a lot, Jon for the review!

      I should have done that before . Will update the patch with your suggestion.

      Show
      Uma Maheswara Rao G added a comment - Thanks a lot, Jon for the review! I should have done that before . Will update the patch with your suggestion.
      Hide
      Uma Maheswara Rao G added a comment -

      Updated the patch, which addresses your suggestion.

      Show
      Uma Maheswara Rao G added a comment - Updated the patch, which addresses your suggestion.
      Hide
      Hadoop QA added a comment -

      +1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12522122/HBASE-5653.patch
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 6 new or modified tests.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 core tests. The patch passed unit tests in .

      Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1463//testReport/
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1463//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
      Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1463//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12522122/HBASE-5653.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1463//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1463//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1463//console This message is automatically generated.
      Hide
      Jonathan Hsieh added a comment -

      Thanks for the patch! I've committed to trunk.

      Show
      Jonathan Hsieh added a comment - Thanks for the patch! I've committed to trunk.
      Hide
      Hudson added a comment -

      Integrated in HBase-TRUNK #2741 (See https://builds.apache.org/job/HBase-TRUNK/2741/)
      HBASE-5653 [findbugs] Fix perf warnings (Uma Maheswara Rao G) (Revision 1324547)

      Result = FAILURE
      jmhsieh :
      Files :

      • /hbase/trunk/dev-support/test-patch.properties
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/RetriesExhaustedWithDetailsException.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/executor/ExecutorService.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SingleSizeCache.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/MultithreadedTableMapper.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/DefaultLoadBalancer.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/metrics/HBaseInfo.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSinkMetrics.java
      • /hbase/trunk/src/main/resources/hbase-webapps/master/table.jsp
      • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/executor/TestExecutorService.java
      Show
      Hudson added a comment - Integrated in HBase-TRUNK #2741 (See https://builds.apache.org/job/HBase-TRUNK/2741/ ) HBASE-5653 [findbugs] Fix perf warnings (Uma Maheswara Rao G) (Revision 1324547) Result = FAILURE jmhsieh : Files : /hbase/trunk/dev-support/test-patch.properties /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/RetriesExhaustedWithDetailsException.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/executor/ExecutorService.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SingleSizeCache.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/MultithreadedTableMapper.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/DefaultLoadBalancer.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/metrics/HBaseInfo.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSinkMetrics.java /hbase/trunk/src/main/resources/hbase-webapps/master/table.jsp /hbase/trunk/src/test/java/org/apache/hadoop/hbase/executor/TestExecutorService.java
      Hide
      Hudson added a comment -

      Integrated in HBase-TRUNK-security #167 (See https://builds.apache.org/job/HBase-TRUNK-security/167/)
      HBASE-5653 [findbugs] Fix perf warnings (Uma Maheswara Rao G) (Revision 1324547)

      Result = SUCCESS
      jmhsieh :
      Files :

      • /hbase/trunk/dev-support/test-patch.properties
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/RetriesExhaustedWithDetailsException.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/executor/ExecutorService.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SingleSizeCache.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/MultithreadedTableMapper.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/DefaultLoadBalancer.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/metrics/HBaseInfo.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSinkMetrics.java
      • /hbase/trunk/src/main/resources/hbase-webapps/master/table.jsp
      • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/executor/TestExecutorService.java
      Show
      Hudson added a comment - Integrated in HBase-TRUNK-security #167 (See https://builds.apache.org/job/HBase-TRUNK-security/167/ ) HBASE-5653 [findbugs] Fix perf warnings (Uma Maheswara Rao G) (Revision 1324547) Result = SUCCESS jmhsieh : Files : /hbase/trunk/dev-support/test-patch.properties /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/RetriesExhaustedWithDetailsException.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/executor/ExecutorService.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SingleSizeCache.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/MultithreadedTableMapper.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/DefaultLoadBalancer.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/metrics/HBaseInfo.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSinkMetrics.java /hbase/trunk/src/main/resources/hbase-webapps/master/table.jsp /hbase/trunk/src/test/java/org/apache/hadoop/hbase/executor/TestExecutorService.java
      Hide
      stack added a comment -

      Marking closed.

      Show
      stack added a comment - Marking closed.

        People

        • Assignee:
          Uma Maheswara Rao G
          Reporter:
          Jonathan Hsieh
        • Votes:
          0 Vote for this issue
          Watchers:
          4 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development