Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.95.0
    • Component/s: scripts
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    1. HBASE-5645-3.patch
      11 kB
      Uma Maheswara Rao G
    2. hbase-5645-2-tweak.patch
      13 kB
      Jonathan Hsieh
    3. HBASE-5645-2.patch
      14 kB
      David S. Wang
    4. HBASE-5645.patch
      21 kB
      stack
    5. HBASE-5645.patch
      21 kB
      stack

      Activity

      Hide
      David S. Wang added a comment -

      Run this through the bot.

      Show
      David S. Wang added a comment - Run this through the bot.
      Hide
      jiraposter@reviews.apache.org added a comment -

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/4612/
      -----------------------------------------------------------

      (Updated 2012-04-03 22:54:54.016499)

      Review request for hbase.

      Changes
      -------

      Corrected JIRA number.

      Summary (updated)
      -------

      Fixes for issues reported in findbugs for "Correctness" category.

      This addresses bug HBASE-5645.
      https://issues.apache.org/jira/browse/HBASE-5645

      Diffs


      dev-support/test-patch.properties 2209d27
      src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon ae76204
      src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java 37bcaba
      src/main/java/org/apache/hadoop/hbase/mapreduce/CellCounter.java 32d66fb
      src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 64def15
      src/main/java/org/apache/hadoop/hbase/master/DefaultLoadBalancer.java 1676832
      src/main/java/org/apache/hadoop/hbase/master/HMaster.java 9bd4ace
      src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 3515d4a
      src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 8ae60a3
      src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreLAB.java 2694897
      src/main/java/org/apache/hadoop/hbase/regionserver/ShutdownHook.java e3b230e
      src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 0c7b396
      src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java 2e98b39
      src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java 698bb3d
      src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java 8950c9f
      src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java 62cf6ac
      src/main/java/org/apache/hadoop/hbase/util/FSUtils.java aebe5b0
      src/main/java/org/apache/hadoop/hbase/util/JVMClusterUtil.java c21377c
      src/main/java/org/apache/hadoop/hbase/util/Merge.java 04f15d4
      src/main/java/org/apache/hadoop/hbase/util/PoolMap.java 8e2a856

      Diff: https://reviews.apache.org/r/4612/diff

      Testing
      -------

      Ran test-patch.sh and unit tests.

      Thanks,

      David

      Show
      jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4612/ ----------------------------------------------------------- (Updated 2012-04-03 22:54:54.016499) Review request for hbase. Changes ------- Corrected JIRA number. Summary (updated) ------- Fixes for issues reported in findbugs for "Correctness" category. This addresses bug HBASE-5645 . https://issues.apache.org/jira/browse/HBASE-5645 Diffs dev-support/test-patch.properties 2209d27 src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon ae76204 src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java 37bcaba src/main/java/org/apache/hadoop/hbase/mapreduce/CellCounter.java 32d66fb src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 64def15 src/main/java/org/apache/hadoop/hbase/master/DefaultLoadBalancer.java 1676832 src/main/java/org/apache/hadoop/hbase/master/HMaster.java 9bd4ace src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 3515d4a src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 8ae60a3 src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreLAB.java 2694897 src/main/java/org/apache/hadoop/hbase/regionserver/ShutdownHook.java e3b230e src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 0c7b396 src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java 2e98b39 src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java 698bb3d src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java 8950c9f src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java 62cf6ac src/main/java/org/apache/hadoop/hbase/util/FSUtils.java aebe5b0 src/main/java/org/apache/hadoop/hbase/util/JVMClusterUtil.java c21377c src/main/java/org/apache/hadoop/hbase/util/Merge.java 04f15d4 src/main/java/org/apache/hadoop/hbase/util/PoolMap.java 8e2a856 Diff: https://reviews.apache.org/r/4612/diff Testing ------- Ran test-patch.sh and unit tests. Thanks, David
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12521234/HBASE-5645.patch
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 3 new or modified tests.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      -1 core tests. The patch failed these unit tests:

      Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1381//testReport/
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1381//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
      Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1381//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12521234/HBASE-5645.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1381//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1381//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1381//console This message is automatically generated.
      Hide
      jiraposter@reviews.apache.org added a comment -

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/4612/#review6666
      -----------------------------------------------------------

      Ship it!

      Looks good to me.

      dev-support/test-patch.properties
      <https://reviews.apache.org/r/4612/#comment14421>

      Hurray!

      • Michael

      On 2012-04-03 22:54:54, David Wang wrote:

      -----------------------------------------------------------

      This is an automatically generated e-mail. To reply, visit:

      https://reviews.apache.org/r/4612/

      -----------------------------------------------------------

      (Updated 2012-04-03 22:54:54)

      Review request for hbase.

      Summary

      -------

      Fixes for issues reported in findbugs for "Correctness" category.

      This addresses bug HBASE-5645.

      https://issues.apache.org/jira/browse/HBASE-5645

      Diffs

      -----

      dev-support/test-patch.properties 2209d27

      src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon ae76204

      src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java 37bcaba

      src/main/java/org/apache/hadoop/hbase/mapreduce/CellCounter.java 32d66fb

      src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 64def15

      src/main/java/org/apache/hadoop/hbase/master/DefaultLoadBalancer.java 1676832

      src/main/java/org/apache/hadoop/hbase/master/HMaster.java 9bd4ace

      src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 3515d4a

      src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 8ae60a3

      src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreLAB.java 2694897

      src/main/java/org/apache/hadoop/hbase/regionserver/ShutdownHook.java e3b230e

      src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 0c7b396

      src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java 2e98b39

      src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java 698bb3d

      src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java 8950c9f

      src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java 62cf6ac

      src/main/java/org/apache/hadoop/hbase/util/FSUtils.java aebe5b0

      src/main/java/org/apache/hadoop/hbase/util/JVMClusterUtil.java c21377c

      src/main/java/org/apache/hadoop/hbase/util/Merge.java 04f15d4

      src/main/java/org/apache/hadoop/hbase/util/PoolMap.java 8e2a856

      Diff: https://reviews.apache.org/r/4612/diff

      Testing

      -------

      Ran test-patch.sh and unit tests.

      Thanks,

      David

      Show
      jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4612/#review6666 ----------------------------------------------------------- Ship it! Looks good to me. dev-support/test-patch.properties < https://reviews.apache.org/r/4612/#comment14421 > Hurray! Michael On 2012-04-03 22:54:54, David Wang wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4612/ ----------------------------------------------------------- (Updated 2012-04-03 22:54:54) Review request for hbase. Summary ------- Fixes for issues reported in findbugs for "Correctness" category. This addresses bug HBASE-5645 . https://issues.apache.org/jira/browse/HBASE-5645 Diffs ----- dev-support/test-patch.properties 2209d27 src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon ae76204 src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java 37bcaba src/main/java/org/apache/hadoop/hbase/mapreduce/CellCounter.java 32d66fb src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 64def15 src/main/java/org/apache/hadoop/hbase/master/DefaultLoadBalancer.java 1676832 src/main/java/org/apache/hadoop/hbase/master/HMaster.java 9bd4ace src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 3515d4a src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 8ae60a3 src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreLAB.java 2694897 src/main/java/org/apache/hadoop/hbase/regionserver/ShutdownHook.java e3b230e src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 0c7b396 src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java 2e98b39 src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java 698bb3d src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java 8950c9f src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java 62cf6ac src/main/java/org/apache/hadoop/hbase/util/FSUtils.java aebe5b0 src/main/java/org/apache/hadoop/hbase/util/JVMClusterUtil.java c21377c src/main/java/org/apache/hadoop/hbase/util/Merge.java 04f15d4 src/main/java/org/apache/hadoop/hbase/util/PoolMap.java 8e2a856 Diff: https://reviews.apache.org/r/4612/diff Testing ------- Ran test-patch.sh and unit tests. Thanks, David
      Hide
      David S. Wang added a comment -

      Thanks for the review, Stack. Can this be committed now?

      Show
      David S. Wang added a comment - Thanks for the review, Stack. Can this be committed now?
      Hide
      stack added a comment -

      What you think of the hadoopqa failure David? Let me try resubmitting your patch.

      Show
      stack added a comment - What you think of the hadoopqa failure David? Let me try resubmitting your patch.
      Hide
      stack added a comment -

      Resubmit of same patch

      Show
      stack added a comment - Resubmit of same patch
      Hide
      David S. Wang added a comment -

      I didn't see any actual failures in the results, though the summary says that something failed. Perhaps a bug in the summary code?

      Show
      David S. Wang added a comment - I didn't see any actual failures in the results, though the summary says that something failed. Perhaps a bug in the summary code?
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12521333/HBASE-5645.patch
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 3 new or modified tests.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      -1 core tests. The patch failed these unit tests:

      Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1385//testReport/
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1385//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
      Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1385//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12521333/HBASE-5645.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1385//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1385//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1385//console This message is automatically generated.
      Hide
      David S. Wang added a comment -

      OK I see that the tests timedout. Unfortunately, I cannot tell from the output what test actually timed out. Does anyone know what command I can use locally to try and reproduce this? I didn't see any timeouts when I can "mvn -PrunAllTests test" before but perhaps that is not the right command.

      Show
      David S. Wang added a comment - OK I see that the tests timedout. Unfortunately, I cannot tell from the output what test actually timed out. Does anyone know what command I can use locally to try and reproduce this? I didn't see any timeouts when I can "mvn -PrunAllTests test" before but perhaps that is not the right command.
      Hide
      stack added a comment -

      That is the right command. Let me try it here locally.

      Show
      stack added a comment - That is the right command. Let me try it here locally.
      Hide
      David S. Wang added a comment -

      OK I did get a timeout locally; I just didn't recognize it. However, I don't know where to get the information about which test timedout. It doesn't report it in the console output, and the surefire-reports stuff just contains the tests that were run to some sort of completion. Is there some place to see what was currently running when the test run timed out?

      Show
      David S. Wang added a comment - OK I did get a timeout locally; I just didn't recognize it. However, I don't know where to get the information about which test timedout. It doesn't report it in the console output, and the surefire-reports stuff just contains the tests that were run to some sort of completion. Is there some place to see what was currently running when the test run timed out?
      Hide
      stack added a comment -

      See dev-support/findHangingTest.sh

      Show
      stack added a comment - See dev-support/findHangingTest.sh
      Hide
      David S. Wang added a comment -

      Thanks for the pointer. Unfortunately, this doesn't seem to help:

      [dsw@c1502 hbase]$ dev-support/findHangingTest.sh https://builds.apache.org/job/PreCommit-HBASE-Build/1385//console
      % Total % Received % Xferd Average Speed Time Time Time Current
      Dload Upload Total Spent Left Speed
      100 142k 0 142k 0 0 315k 0 -::- -::- -::- 619k
      [dsw@c1502 hbase]$

      Looking at findHangingTest.sh, it seems to look for "Forking command line" which I do not see, though we know this test run times out.

      Show
      David S. Wang added a comment - Thanks for the pointer. Unfortunately, this doesn't seem to help: [dsw@c1502 hbase] $ dev-support/findHangingTest.sh https://builds.apache.org/job/PreCommit-HBASE-Build/1385//console % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 142k 0 142k 0 0 315k 0 - : : - - : : - - : : - 619k [dsw@c1502 hbase] $ Looking at findHangingTest.sh, it seems to look for "Forking command line" which I do not see, though we know this test run times out.
      Hide
      stack added a comment -

      retry

      Show
      stack added a comment - retry
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12521593/HBASE-5645.patch
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 3 new or modified tests.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      -1 core tests. The patch failed these unit tests:

      Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1416//testReport/
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1416//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
      Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1416//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12521593/HBASE-5645.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1416//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1416//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1416//console This message is automatically generated.
      Hide
      David S. Wang added a comment -

      Updated to latest trunk; fixed test hang. Passed -PrunAllTests and test-patch.sh. Will attach to reviewboard once this passes the robot.

      Show
      David S. Wang added a comment - Updated to latest trunk; fixed test hang. Passed -PrunAllTests and test-patch.sh. Will attach to reviewboard once this passes the robot.
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12522118/HBASE-5645-2.patch
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 3 new or modified tests.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      -1 core tests. The patch failed these unit tests:
      org.apache.hadoop.hbase.replication.TestReplication

      Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1462//testReport/
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1462//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
      Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1462//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12522118/HBASE-5645-2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.replication.TestReplication Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1462//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1462//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1462//console This message is automatically generated.
      Hide
      David S. Wang added a comment -

      TestReplication passed locally for me.

      Show
      David S. Wang added a comment - TestReplication passed locally for me.
      Hide
      jiraposter@reviews.apache.org added a comment -

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/4612/
      -----------------------------------------------------------

      (Updated 2012-04-10 19:11:48.808176)

      Review request for hbase.

      Changes
      -------

      Updated patch to work with trunk. Fixed hanging test. Ran test-patch.sh and -PrunAllTests.

      Summary
      -------

      Fixes for issues reported in findbugs for "Correctness" category.

      This addresses bug HBASE-5645.
      https://issues.apache.org/jira/browse/HBASE-5645

      Diffs (updated)


      dev-support/findHangingTest.sh 4518c68
      dev-support/test-patch.properties 203df69
      src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java c4a8a9e
      src/main/java/org/apache/hadoop/hbase/mapreduce/CellCounter.java 63b2ed5
      src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java de4b1e6
      src/main/java/org/apache/hadoop/hbase/master/DefaultLoadBalancer.java 1676832
      src/main/java/org/apache/hadoop/hbase/master/HMaster.java fb21bdd
      src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 1c253a0
      src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreLAB.java 2694897
      src/main/java/org/apache/hadoop/hbase/regionserver/ShutdownHook.java 00f8d99
      src/main/java/org/apache/hadoop/hbase/regionserver/Store.java bf1618e
      src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java 1636bfb
      src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java 698bb3d
      src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java 545bd02
      src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java 62cf6ac
      src/main/java/org/apache/hadoop/hbase/util/FSUtils.java aebe5b0
      src/main/java/org/apache/hadoop/hbase/util/JVMClusterUtil.java c21377c
      src/main/java/org/apache/hadoop/hbase/util/PoolMap.java 8e2a856

      Diff: https://reviews.apache.org/r/4612/diff

      Testing
      -------

      Ran test-patch.sh and unit tests.

      Thanks,

      David

      Show
      jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4612/ ----------------------------------------------------------- (Updated 2012-04-10 19:11:48.808176) Review request for hbase. Changes ------- Updated patch to work with trunk. Fixed hanging test. Ran test-patch.sh and -PrunAllTests. Summary ------- Fixes for issues reported in findbugs for "Correctness" category. This addresses bug HBASE-5645 . https://issues.apache.org/jira/browse/HBASE-5645 Diffs (updated) dev-support/findHangingTest.sh 4518c68 dev-support/test-patch.properties 203df69 src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java c4a8a9e src/main/java/org/apache/hadoop/hbase/mapreduce/CellCounter.java 63b2ed5 src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java de4b1e6 src/main/java/org/apache/hadoop/hbase/master/DefaultLoadBalancer.java 1676832 src/main/java/org/apache/hadoop/hbase/master/HMaster.java fb21bdd src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 1c253a0 src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreLAB.java 2694897 src/main/java/org/apache/hadoop/hbase/regionserver/ShutdownHook.java 00f8d99 src/main/java/org/apache/hadoop/hbase/regionserver/Store.java bf1618e src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java 1636bfb src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java 698bb3d src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java 545bd02 src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java 62cf6ac src/main/java/org/apache/hadoop/hbase/util/FSUtils.java aebe5b0 src/main/java/org/apache/hadoop/hbase/util/JVMClusterUtil.java c21377c src/main/java/org/apache/hadoop/hbase/util/PoolMap.java 8e2a856 Diff: https://reviews.apache.org/r/4612/diff Testing ------- Ran test-patch.sh and unit tests. Thanks, David
      Hide
      David S. Wang added a comment -

      Not high priority obviously, but if someone gets a chance to look at the new patch and commit it, I would appreciate it before the patch gets out of sync with trunk again.

      Show
      David S. Wang added a comment - Not high priority obviously, but if someone gets a chance to look at the new patch and commit it, I would appreciate it before the patch gets out of sync with trunk again.
      Hide
      Jonathan Hsieh added a comment - - edited

      lgtm.

      I just checked in HBASE-5653 that reduced the find bugs number, which likely "breaks" this patch. I'm going to submit patch to find out the new number and the tweak v2 to reflect this new number.

      Show
      Jonathan Hsieh added a comment - - edited lgtm. I just checked in HBASE-5653 that reduced the find bugs number, which likely "breaks" this patch. I'm going to submit patch to find out the new number and the tweak v2 to reflect this new number.
      Hide
      Uma Maheswara Rao G added a comment -

      1) ShutdownHook.java

       if (cache == null) {
              throw new RuntimeException(
                  "This should not happen. Could not find the cache class in FileSystem.");
            }
      
            Field field = null;
            try {
              field = cache.getDeclaredField(CLIENT_FINALIZER_DATA_METHOD);
            } catch (NoSuchFieldException e) {
              // We can get here if the Cache class does not have a clientFinalizer
              // instance: i.e. we're running on straight 0.20 w/o hadoop-4829.
            }
      

      2) In Store.java

       byte[] firstKey = reader.getFirstRowKey();
            Preconditions.checkState(firstKey != null, "First key can not be null");
            byte[] lk = reader.getLastKey();
            Preconditions.checkState(lk != null, "Last key can not be null");
            byte[] lastKey =  KeyValue.createKeyValueFromKey(lk).getRow();
      

      We already handled this with preconditions.

      3)

        int logCount = this.outputfiles == null? 0: this.outputfiles.size();
      +    int logCount = this.outputfiles.size();
      

      This change also already handled by Hbase-5653. So may need to update with latest.
      Mostly all are need to resolve the conflicts with fixed and committed changes.

      Show
      Uma Maheswara Rao G added a comment - 1) ShutdownHook.java if (cache == null ) { throw new RuntimeException( "This should not happen. Could not find the cache class in FileSystem." ); } Field field = null ; try { field = cache.getDeclaredField(CLIENT_FINALIZER_DATA_METHOD); } catch (NoSuchFieldException e) { // We can get here if the Cache class does not have a clientFinalizer // instance: i.e. we're running on straight 0.20 w/o hadoop-4829. } 2) In Store.java byte [] firstKey = reader.getFirstRowKey(); Preconditions.checkState(firstKey != null , "First key can not be null " ); byte [] lk = reader.getLastKey(); Preconditions.checkState(lk != null , "Last key can not be null " ); byte [] lastKey = KeyValue.createKeyValueFromKey(lk).getRow(); We already handled this with preconditions. 3) int logCount = this .outputfiles == null ? 0: this .outputfiles.size(); + int logCount = this .outputfiles.size(); This change also already handled by Hbase-5653. So may need to update with latest. Mostly all are need to resolve the conflicts with fixed and committed changes.
      Hide
      Jonathan Hsieh added a comment -

      Attached a tweaked version that excludes an HLog change already included by HBASE-5653 and removed count update so we can get new count.

      Letting bot run to get new findbugs count.

      Show
      Jonathan Hsieh added a comment - Attached a tweaked version that excludes an HLog change already included by HBASE-5653 and removed count update so we can get new count. Letting bot run to get new findbugs count.
      Hide
      Uma Maheswara Rao G added a comment -

      Jon, I think #1 and #2 also need to update in this patch right (ShutdownHook.java

      and Store.java changes). null checks might be redundant now.

      Show
      Uma Maheswara Rao G added a comment - Jon, I think #1 and #2 also need to update in this patch right (ShutdownHook.java and Store.java changes). null checks might be redundant now.
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12522212/hbase-5645-2-tweak.patch
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      -1 tests included. The patch doesn't appear to include any new or modified tests.
      Please justify why no new tests are needed for this patch.
      Also please list what manual steps were performed to verify this patch.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      -1 core tests. The patch failed these unit tests:
      org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks
      org.apache.hadoop.hbase.master.TestSplitLogManager

      Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1474//testReport/
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1474//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
      Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1474//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12522212/hbase-5645-2-tweak.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks org.apache.hadoop.hbase.master.TestSplitLogManager Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1474//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1474//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1474//console This message is automatically generated.
      Hide
      Uma Maheswara Rao G added a comment -

      Attached the same patch as David and exclude Hlog file as that was already handled. also not included ShutDownHook and Store changes as they already handled. Also updated the count in test-patch.properties.

      Show
      Uma Maheswara Rao G added a comment - Attached the same patch as David and exclude Hlog file as that was already handled. also not included ShutDownHook and Store changes as they already handled. Also updated the count in test-patch.properties.
      Hide
      Hadoop QA added a comment -

      +1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12522291/HBASE-5645-3.patch
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 3 new or modified tests.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 core tests. The patch passed unit tests in .

      Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1482//testReport/
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1482//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
      Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1482//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12522291/HBASE-5645-3.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1482//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1482//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1482//console This message is automatically generated.
      Hide
      Jonathan Hsieh added a comment -

      Lgtm. Thanks David and thanks Uma and Stack for taking a look. I've committed to trunk.

      Show
      Jonathan Hsieh added a comment - Lgtm. Thanks David and thanks Uma and Stack for taking a look. I've committed to trunk.
      Hide
      Hudson added a comment -

      Integrated in HBase-TRUNK #2744 (See https://builds.apache.org/job/HBase-TRUNK/2744/)
      HBASE-5645 [findbugs] Fix correctness warnings (David S Wang and Uma Maheswara Rao G) (Revision 1324969)

      Result = SUCCESS
      jmhsieh :
      Files :

      • /hbase/trunk/dev-support/findHangingTest.sh
      • /hbase/trunk/dev-support/test-patch.properties
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/CellCounter.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/DefaultLoadBalancer.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreLAB.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/JVMClusterUtil.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/PoolMap.java
      Show
      Hudson added a comment - Integrated in HBase-TRUNK #2744 (See https://builds.apache.org/job/HBase-TRUNK/2744/ ) HBASE-5645 [findbugs] Fix correctness warnings (David S Wang and Uma Maheswara Rao G) (Revision 1324969) Result = SUCCESS jmhsieh : Files : /hbase/trunk/dev-support/findHangingTest.sh /hbase/trunk/dev-support/test-patch.properties /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/CellCounter.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/DefaultLoadBalancer.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreLAB.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/JVMClusterUtil.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/PoolMap.java
      Hide
      Hudson added a comment -

      Integrated in HBase-TRUNK-security #168 (See https://builds.apache.org/job/HBase-TRUNK-security/168/)
      HBASE-5645 [findbugs] Fix correctness warnings (David S Wang and Uma Maheswara Rao G) (Revision 1324969)

      Result = FAILURE
      jmhsieh :
      Files :

      • /hbase/trunk/dev-support/findHangingTest.sh
      • /hbase/trunk/dev-support/test-patch.properties
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/CellCounter.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/DefaultLoadBalancer.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreLAB.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/JVMClusterUtil.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/PoolMap.java
      Show
      Hudson added a comment - Integrated in HBase-TRUNK-security #168 (See https://builds.apache.org/job/HBase-TRUNK-security/168/ ) HBASE-5645 [findbugs] Fix correctness warnings (David S Wang and Uma Maheswara Rao G) (Revision 1324969) Result = FAILURE jmhsieh : Files : /hbase/trunk/dev-support/findHangingTest.sh /hbase/trunk/dev-support/test-patch.properties /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/CellCounter.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/DefaultLoadBalancer.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreLAB.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/JVMClusterUtil.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/PoolMap.java
      Hide
      stack added a comment -

      Marking closed.

      Show
      stack added a comment - Marking closed.

        People

        • Assignee:
          David S. Wang
          Reporter:
          Jonathan Hsieh
        • Votes:
          0 Vote for this issue
          Watchers:
          1 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development