Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.95.2
    • Fix Version/s: 0.95.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Exclude thrift and protobuf warnings since these are machine generated.

      1. HBASE-5642.patch
        2 kB
        Uma Maheswara Rao G
      2. HBASE-5642.patch
        2 kB
        Uma Maheswara Rao G

        Activity

        stack made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        stack added a comment -

        Marking closed.

        Show
        stack added a comment - Marking closed.
        stack made changes -
        Fix Version/s 0.98.0 [ 12323143 ]
        stack made changes -
        Fix Version/s 0.98.0 [ 12323143 ]
        stack made changes -
        Fix Version/s 0.95.0 [ 12324094 ]
        Fix Version/s 0.96.0 [ 12320040 ]
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-security #153 (See https://builds.apache.org/job/HBase-TRUNK-security/153/)
        HBASE-5642 [findbugs] Exclude Thrift and Protobuf warnings (Uma Maheswara Rao G) (Revision 1306428)

        Result = FAILURE
        jmhsieh :
        Files :

        • /hbase/trunk/dev-support/findbugs-exclude.xml
        • /hbase/trunk/dev-support/test-patch.properties
        • /hbase/trunk/pom.xml
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-security #153 (See https://builds.apache.org/job/HBase-TRUNK-security/153/ ) HBASE-5642 [findbugs] Exclude Thrift and Protobuf warnings (Uma Maheswara Rao G) (Revision 1306428) Result = FAILURE jmhsieh : Files : /hbase/trunk/dev-support/findbugs-exclude.xml /hbase/trunk/dev-support/test-patch.properties /hbase/trunk/pom.xml
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #2697 (See https://builds.apache.org/job/HBase-TRUNK/2697/)
        HBASE-5642 [findbugs] Exclude Thrift and Protobuf warnings (Uma Maheswara Rao G) (Revision 1306428)

        Result = FAILURE
        jmhsieh :
        Files :

        • /hbase/trunk/dev-support/findbugs-exclude.xml
        • /hbase/trunk/dev-support/test-patch.properties
        • /hbase/trunk/pom.xml
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #2697 (See https://builds.apache.org/job/HBase-TRUNK/2697/ ) HBASE-5642 [findbugs] Exclude Thrift and Protobuf warnings (Uma Maheswara Rao G) (Revision 1306428) Result = FAILURE jmhsieh : Files : /hbase/trunk/dev-support/findbugs-exclude.xml /hbase/trunk/dev-support/test-patch.properties /hbase/trunk/pom.xml
        Jonathan Hsieh made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s 0.96.0 [ 12320040 ]
        Resolution Fixed [ 1 ]
        Hide
        Jonathan Hsieh added a comment -

        Committed to trunk

        Show
        Jonathan Hsieh added a comment - Committed to trunk
        Hide
        Jonathan Hsieh added a comment -

        Yup, I'm in the process of doing a quick test and committing. Thanks Uma!

        Show
        Jonathan Hsieh added a comment - Yup, I'm in the process of doing a quick test and committing. Thanks Uma!
        Hide
        Uma Maheswara Rao G added a comment -

        I got you, Thanks a lot Jon for explanation.

        Lets committ the current patch in this JIRA if your reviews are ok.

        Show
        Uma Maheswara Rao G added a comment - I got you, Thanks a lot Jon for explanation. Lets committ the current patch in this JIRA if your reviews are ok.
        Hide
        Jonathan Hsieh added a comment -

        The o.a.h.h.generated.master code looks to be generated from jsp's/jamon code and seems more potentially serious. From the warning there, that the string needs to be sanitized before being re-displayed (as opposed to being ignored).

        Show
        Jonathan Hsieh added a comment - The o.a.h.h.generated.master code looks to be generated from jsp's/jamon code and seems more potentially serious. From the warning there, that the string needs to be sanitized before being re-displayed (as opposed to being ignored).
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12520157/HBASE-5642.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        -1 javac. The applied patch generated 13 javac compiler warnings (more than the trunk's current 5 warnings).

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1325//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1325//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1325//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12520157/HBASE-5642.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The applied patch generated 13 javac compiler warnings (more than the trunk's current 5 warnings). +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1325//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1325//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1325//console This message is automatically generated.
        Uma Maheswara Rao G made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Uma Maheswara Rao G added a comment -

        We don't have any comments from avro generated code. .
        I can see the comments only from org.apache.hadoop.hbase.generated.master. For this we have separate category of bug.HBASE-5649. I wanted to know one thing, whether we have rights to change the code under org.apache.hadoop.hbase.generated.master package? Anyway this question unrelated to this JIRA, but curious to know the fact.. If we are not allowed to change, I will exclude that package also in HBASE-5649.

        Show
        Uma Maheswara Rao G added a comment - We don't have any comments from avro generated code. . I can see the comments only from org.apache.hadoop.hbase.generated.master. For this we have separate category of bug. HBASE-5649 . I wanted to know one thing, whether we have rights to change the code under org.apache.hadoop.hbase.generated.master package? Anyway this question unrelated to this JIRA, but curious to know the fact. . If we are not allowed to change, I will exclude that package also in HBASE-5649 .
        Hide
        stack added a comment -

        You are missing the avro generated files?

        Show
        stack added a comment - You are missing the avro generated files?
        Uma Maheswara Rao G made changes -
        Attachment HBASE-5642.patch [ 12520157 ]
        Hide
        Uma Maheswara Rao G added a comment -

        Attaching the patch with updating the OK_FINDBUGS_WARNINGS to 601 in test-patch.properties. So, that QA can catch if any new bugs introduced by other patches.

        Show
        Uma Maheswara Rao G added a comment - Attaching the patch with updating the OK_FINDBUGS_WARNINGS to 601 in test-patch.properties. So, that QA can catch if any new bugs introduced by other patches.
        Hide
        Uma Maheswara Rao G added a comment -

        @Stack, attached the same patch from HBASE-5598. (Jon asked to move that patch here.)

        Patch added exclude filter file and added the thrift, protobuf packages to exclude list.

        Could you please take a look?

        Show
        Uma Maheswara Rao G added a comment - @Stack, attached the same patch from HBASE-5598 . (Jon asked to move that patch here.) Patch added exclude filter file and added the thrift, protobuf packages to exclude list. Could you please take a look?
        Uma Maheswara Rao G made changes -
        Attachment HBASE-5642.patch [ 12520146 ]
        Uma Maheswara Rao G made changes -
        Field Original Value New Value
        Assignee Uma Maheswara Rao G [ umamaheswararao ]
        Jonathan Hsieh created issue -

          People

          • Assignee:
            Uma Maheswara Rao G
            Reporter:
            Jonathan Hsieh
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development