Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.90.6, 0.92.1
    • Fix Version/s: 0.94.0, 0.95.0
    • Component/s: Zookeeper
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    1. HBASE-5633-0.90.patch
      1 kB
      Matteo Bertozzi
    2. HBASE-5633-0.92.patch
      1 kB
      Matteo Bertozzi
    3. HBASE-5638-0.90-v1.patch
      2 kB
      Matteo Bertozzi
    4. HBASE-5638-0.92-v1.patch
      3 kB
      Matteo Bertozzi
    5. HBASE-5638-trunk-v1.patch
      3 kB
      Matteo Bertozzi
    6. HBASE-5638-0.90-v2.patch
      3 kB
      Matteo Bertozzi
    7. HBASE-5638-0.92-v2.patch
      3 kB
      Matteo Bertozzi
    8. HBASE-5638-trunk-v2.patch
      3 kB
      Matteo Bertozzi

      Activity

      Hide
      Hudson added a comment -

      Integrated in HBase-0.92-security #104 (See https://builds.apache.org/job/HBase-0.92-security/104/)
      HBASE-5638 Readability improvements and backport HBASE-5633: NPE reading ZK config in HBase (Matteo Bertozzi) (Revision 1307087)

      Result = FAILURE
      jmhsieh :
      Files :

      • /hbase/branches/0.92/CHANGES.txt
      • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/HConstants.java
      • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java
      • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKConfig.java
      Show
      Hudson added a comment - Integrated in HBase-0.92-security #104 (See https://builds.apache.org/job/HBase-0.92-security/104/ ) HBASE-5638 Readability improvements and backport HBASE-5633 : NPE reading ZK config in HBase (Matteo Bertozzi) (Revision 1307087) Result = FAILURE jmhsieh : Files : /hbase/branches/0.92/CHANGES.txt /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/HConstants.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKConfig.java
      Hide
      Hudson added a comment -

      Integrated in HBase-TRUNK #2698 (See https://builds.apache.org/job/HBase-TRUNK/2698/)
      HBASE-5638 Readability improvements on HBASE-5633: NPE reading ZK config in HBase (Matteo Bertozzi) (Revision 1307085)

      Result = FAILURE
      jmhsieh :
      Files :

      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/HConstants.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKConfig.java
      Show
      Hudson added a comment - Integrated in HBase-TRUNK #2698 (See https://builds.apache.org/job/HBase-TRUNK/2698/ ) HBASE-5638 Readability improvements on HBASE-5633 : NPE reading ZK config in HBase (Matteo Bertozzi) (Revision 1307085) Result = FAILURE jmhsieh : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/HConstants.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKConfig.java
      Hide
      Hudson added a comment -

      Integrated in HBase-0.94-security #6 (See https://builds.apache.org/job/HBase-0.94-security/6/)
      HBASE-5638 Readability improvements on HBASE-5633: NPE reading ZK config in HBase (Matteo Bertozzi) (Revision 1307086)

      Result = SUCCESS
      jmhsieh :
      Files :

      • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/HConstants.java
      • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java
      • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKConfig.java
      Show
      Hudson added a comment - Integrated in HBase-0.94-security #6 (See https://builds.apache.org/job/HBase-0.94-security/6/ ) HBASE-5638 Readability improvements on HBASE-5633 : NPE reading ZK config in HBase (Matteo Bertozzi) (Revision 1307086) Result = SUCCESS jmhsieh : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/HConstants.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKConfig.java
      Hide
      Hudson added a comment -

      Integrated in HBase-TRUNK-security #154 (See https://builds.apache.org/job/HBase-TRUNK-security/154/)
      HBASE-5638 Readability improvements on HBASE-5633: NPE reading ZK config in HBase (Matteo Bertozzi) (Revision 1307085)

      Result = FAILURE
      jmhsieh :
      Files :

      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/HConstants.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKConfig.java
      Show
      Hudson added a comment - Integrated in HBase-TRUNK-security #154 (See https://builds.apache.org/job/HBase-TRUNK-security/154/ ) HBASE-5638 Readability improvements on HBASE-5633 : NPE reading ZK config in HBase (Matteo Bertozzi) (Revision 1307085) Result = FAILURE jmhsieh : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/HConstants.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKConfig.java
      Hide
      Hudson added a comment -

      Integrated in HBase-0.92 #343 (See https://builds.apache.org/job/HBase-0.92/343/)
      HBASE-5638 Readability improvements and backport HBASE-5633: NPE reading ZK config in HBase (Matteo Bertozzi) (Revision 1307087)

      Result = SUCCESS
      jmhsieh :
      Files :

      • /hbase/branches/0.92/CHANGES.txt
      • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/HConstants.java
      • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java
      • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKConfig.java
      Show
      Hudson added a comment - Integrated in HBase-0.92 #343 (See https://builds.apache.org/job/HBase-0.92/343/ ) HBASE-5638 Readability improvements and backport HBASE-5633 : NPE reading ZK config in HBase (Matteo Bertozzi) (Revision 1307087) Result = SUCCESS jmhsieh : Files : /hbase/branches/0.92/CHANGES.txt /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/HConstants.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKConfig.java
      Hide
      Hudson added a comment -

      Integrated in HBase-0.94 #66 (See https://builds.apache.org/job/HBase-0.94/66/)
      HBASE-5638 Readability improvements on HBASE-5633: NPE reading ZK config in HBase (Matteo Bertozzi) (Revision 1307086)

      Result = SUCCESS
      jmhsieh :
      Files :

      • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/HConstants.java
      • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java
      • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKConfig.java
      Show
      Hudson added a comment - Integrated in HBase-0.94 #66 (See https://builds.apache.org/job/HBase-0.94/66/ ) HBASE-5638 Readability improvements on HBASE-5633 : NPE reading ZK config in HBase (Matteo Bertozzi) (Revision 1307086) Result = SUCCESS jmhsieh : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/HConstants.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKConfig.java
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12520493/HBASE-5638-trunk-v2.patch
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      -1 tests included. The patch doesn't appear to include any new or modified tests.
      Please justify why no new tests are needed for this patch.
      Also please list what manual steps were performed to verify this patch.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      -1 core tests. The patch failed these unit tests:
      org.apache.hadoop.hbase.mapreduce.TestImportTsv
      org.apache.hadoop.hbase.mapred.TestTableMapReduce
      org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat

      Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1346//testReport/
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1346//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
      Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1346//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12520493/HBASE-5638-trunk-v2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.mapreduce.TestImportTsv org.apache.hadoop.hbase.mapred.TestTableMapReduce org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1346//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1346//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1346//console This message is automatically generated.
      Hide
      Jonathan Hsieh added a comment -

      Thanks Matteo, and thanks for review stack.

      Show
      Jonathan Hsieh added a comment - Thanks Matteo, and thanks for review stack.
      Hide
      Jonathan Hsieh added a comment -

      Lgtm. I'll do a quick test and commit to 0.90/0.92/0.94/trunk branches.

      Show
      Jonathan Hsieh added a comment - Lgtm. I'll do a quick test and commit to 0.90/0.92/0.94/trunk branches.
      Hide
      Matteo Bertozzi added a comment -

      Improve the readability by explicit check against LOCAL or DISTRIBUTED constant

      Show
      Matteo Bertozzi added a comment - Improve the readability by explicit check against LOCAL or DISTRIBUTED constant
      Hide
      stack added a comment -

      lgtm

      Show
      stack added a comment - lgtm
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12520466/HBASE-5638-trunk-v1.patch
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      -1 tests included. The patch doesn't appear to include any new or modified tests.
      Please justify why no new tests are needed for this patch.
      Also please list what manual steps were performed to verify this patch.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      -1 core tests. The patch failed these unit tests:
      org.apache.hadoop.hbase.mapreduce.TestImportTsv

      Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1345//testReport/
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1345//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
      Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1345//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12520466/HBASE-5638-trunk-v1.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.mapreduce.TestImportTsv Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1345//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1345//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1345//console This message is automatically generated.
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12520408/HBASE-5638-trunk-v1.patch
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      -1 tests included. The patch doesn't appear to include any new or modified tests.
      Please justify why no new tests are needed for this patch.
      Also please list what manual steps were performed to verify this patch.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      -1 core tests. The patch failed these unit tests:
      org.apache.hadoop.hbase.mapreduce.TestImportTsv
      org.apache.hadoop.hbase.mapred.TestTableMapReduce
      org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat

      Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1339//testReport/
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1339//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
      Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1339//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12520408/HBASE-5638-trunk-v1.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.mapreduce.TestImportTsv org.apache.hadoop.hbase.mapred.TestTableMapReduce org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1339//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1339//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1339//console This message is automatically generated.
      Hide
      Matteo Bertozzi added a comment -

      patch updated for 0.90, 0.92 and trunk to use conf.getBoolean()

      Show
      Matteo Bertozzi added a comment - patch updated for 0.90, 0.92 and trunk to use conf.getBoolean()
      Hide
      Jonathan Hsieh added a comment -

      Matteo,

      We should probably use the built-in boolean parser in configuration instead of doing a the string compare – something like this:

      if (conf.getBoolean(HConstants.CLUSTER_DISTRIBUTED, HConstants.DEFAULT_CLUSTER_DISTRIBUTED))
      

      see: http://hadoop.apache.org/common/docs/current/api/org/apache/hadoop/conf/Configuration.html#getBoolean(java.lang.String, boolean)

      We'd also end up changing HConstants.DEFAULT_CLUSTER_DISTRBUTED to be a boolean type instead of a string as well.

      Show
      Jonathan Hsieh added a comment - Matteo, We should probably use the built-in boolean parser in configuration instead of doing a the string compare – something like this: if (conf.getBoolean(HConstants.CLUSTER_DISTRIBUTED, HConstants.DEFAULT_CLUSTER_DISTRIBUTED)) see: http://hadoop.apache.org/common/docs/current/api/org/apache/hadoop/conf/Configuration.html#getBoolean(java.lang.String , boolean) We'd also end up changing HConstants.DEFAULT_CLUSTER_DISTRBUTED to be a boolean type instead of a string as well.
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12519985/HBASE-5633-0.92.patch
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      -1 tests included. The patch doesn't appear to include any new or modified tests.
      Please justify why no new tests are needed for this patch.
      Also please list what manual steps were performed to verify this patch.

      -1 patch. The patch command could not apply the patch.

      Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1309//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12519985/HBASE-5633-0.92.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1309//console This message is automatically generated.
      Hide
      Matteo Bertozzi added a comment -

      I've attached the 0.90 and 0.92 patches to backport HBASE-5633 fix

      Show
      Matteo Bertozzi added a comment - I've attached the 0.90 and 0.92 patches to backport HBASE-5633 fix

        People

        • Assignee:
          Matteo Bertozzi
          Reporter:
          Matteo Bertozzi
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development