HBase
  1. HBase
  2. HBASE-5635

If getTaskList() returns null, splitlogWorker would go down and it won't serve any requests

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.92.1
    • Fix Version/s: 0.94.0, 0.95.0
    • Component/s: wal
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      During the hlog split operation if all the zookeepers are down ,then the paths will be returned as null and the splitworker thread wil be exited
      Now this regionserver wil not be able to acquire any other tasks since the splitworker thread is exited
      Please find the attached code for more details

      private List<String> getTaskList() {
          for (int i = 0; i < zkretries; i++) {
            try {
              return (ZKUtil.listChildrenAndWatchForNewChildren(this.watcher,
                  this.watcher.splitLogZNode));
            } catch (KeeperException e) {
              LOG.warn("Could not get children of znode " +
                  this.watcher.splitLogZNode, e);
              try {
                Thread.sleep(1000);
              } catch (InterruptedException e1) {
                LOG.warn("Interrupted while trying to get task list ...", e1);
                Thread.currentThread().interrupt();
                return null;
              }
            }
          }
      

      in the org.apache.hadoop.hbase.regionserver.SplitLogWorker

      1. HBASE-5635_0.94.patch
        2 kB
        ramkrishna.s.vasudevan
      2. HBASE-5635._trunk.patch
        2 kB
        ramkrishna.s.vasudevan
      3. HBASE-5635.1.patch
        2 kB
        Chinna Rao Lalam
      4. HBASE-5635.2.patch
        2 kB
        Chinna Rao Lalam
      5. HBASE-5635.patch
        2 kB
        Chinna Rao Lalam

        Activity

        Lars Hofhansl made changes -
        Fix Version/s 0.94.0 [ 12316419 ]
        Fix Version/s 0.94.1 [ 12320257 ]
        Lars Hofhansl made changes -
        Fix Version/s 0.94.1 [ 12320257 ]
        Fix Version/s 0.94.0 [ 12316419 ]
        Lars Hofhansl made changes -
        Fix Version/s 0.94.0 [ 12316419 ]
        stack made changes -
        Fix Version/s 0.95.0 [ 12324094 ]
        Fix Version/s 0.94.0 [ 12316419 ]
        Fix Version/s 0.96.0 [ 12320040 ]
        Lars Hofhansl made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Lars Hofhansl made changes -
        Fix Version/s 0.94.0 [ 12316419 ]
        Fix Version/s 0.94.1 [ 12320257 ]
        ramkrishna.s.vasudevan made changes -
        Fix Version/s 0.96.0 [ 12320040 ]
        Fix Version/s 0.94.1 [ 12320257 ]
        ramkrishna.s.vasudevan made changes -
        Assignee chinna [ chinna ] Chinna Rao Lalam [ chinnalalam ]
        ramkrishna.s.vasudevan made changes -
        Assignee Christopher Gist [ cgist ] chinna [ chinna ]
        ramkrishna.s.vasudevan made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Assignee Christopher Gist [ cgist ]
        Resolution Fixed [ 1 ]
        Ted Yu made changes -
        Summary If getTaskList() returns null splitlogWorker is down. It wont serve any requests. If getTaskList() returns null, splitlogWorker would go down and it won't serve any requests
        ramkrishna.s.vasudevan made changes -
        Attachment HBASE-5635_0.94.patch [ 12523534 ]
        ramkrishna.s.vasudevan made changes -
        Attachment HBASE-5635._trunk.patch [ 12523533 ]
        Ted Yu made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hadoop Flags Reviewed [ 10343 ]
        Chinna Rao Lalam made changes -
        Attachment HBASE-5635.2.patch [ 12521175 ]
        Chinna Rao Lalam made changes -
        Attachment HBASE-5635.1.patch [ 12520636 ]
        Ted Yu made changes -
        Description During the hlog split operation if all the zookeepers are down ,then the paths will be returned as null and the splitworker thread wil be exited
        Now this regionserver wil not be able to acquire any other tasks since the splitworker thread is exited
        Please find the attached code for more details
        ------------------------------------------
        private List<String> getTaskList() {
            for (int i = 0; i < zkretries; i++) {
              try {
                return (ZKUtil.listChildrenAndWatchForNewChildren(this.watcher,
                    this.watcher.splitLogZNode));
              } catch (KeeperException e) {
                LOG.warn("Could not get children of znode " +
                    this.watcher.splitLogZNode, e);
                try {
                  Thread.sleep(1000);
                } catch (InterruptedException e1) {
                  LOG.warn("Interrupted while trying to get task list ...", e1);
                  Thread.currentThread().interrupt();
                  return null;
                }
              }
            }

        in the org.apache.hadoop.hbase.regionserver.SplitLogWorker


         

        During the hlog split operation if all the zookeepers are down ,then the paths will be returned as null and the splitworker thread wil be exited
        Now this regionserver wil not be able to acquire any other tasks since the splitworker thread is exited
        Please find the attached code for more details
        {code}
        private List<String> getTaskList() {
            for (int i = 0; i < zkretries; i++) {
              try {
                return (ZKUtil.listChildrenAndWatchForNewChildren(this.watcher,
                    this.watcher.splitLogZNode));
              } catch (KeeperException e) {
                LOG.warn("Could not get children of znode " +
                    this.watcher.splitLogZNode, e);
                try {
                  Thread.sleep(1000);
                } catch (InterruptedException e1) {
                  LOG.warn("Interrupted while trying to get task list ...", e1);
                  Thread.currentThread().interrupt();
                  return null;
                }
              }
            }
        {code}

        in the org.apache.hadoop.hbase.regionserver.SplitLogWorker


         

        Chinna Rao Lalam made changes -
        Field Original Value New Value
        Attachment HBASE-5635.patch [ 12520149 ]
        Kristam Subba Swathi created issue -

          People

          • Assignee:
            Chinna Rao Lalam
            Reporter:
            Kristam Subba Swathi
          • Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development