Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.94.0
    • Component/s: Zookeeper
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      If zoo.cfg contains server.* ("server.0=server0:2888:3888\n") and cluster.distributed property (in hbase-site.xml) is empty we get an NPE in parseZooCfg().

      The easy way to reproduce the bug is running org.apache.hbase.zookeeper.TestHQuorumPeer with hbase-site.xml containing:

      <property>
        <name>hbase.cluster.distributed</name>
        <value></value>
      </property>
      
      1. HBASE-5633-v2.patch
        2 kB
        stack
      2. HBASE-5633-v1.patch
        1 kB
        Matteo Bertozzi
      3. HBASE-5633-0.92.patch
        1 kB
        Matteo Bertozzi
      4. HBASE-5633-0.90.patch
        1 kB
        Matteo Bertozzi

        Activity

        Hide
        Matteo Bertozzi added a comment -

        Added a default value (HConstants.DEFAULT_CLUSTER_DISTRIBUTED) for the cluster.distributed property to config.get(HConstants.CLUSTER_DISTRIBUTED) in parseZooCfg().

        We get a Null if the property doesn't exists, and the result of conf.get() is compared directly without checking for Null.

        Show
        Matteo Bertozzi added a comment - Added a default value (HConstants.DEFAULT_CLUSTER_DISTRIBUTED) for the cluster.distributed property to config.get(HConstants.CLUSTER_DISTRIBUTED) in parseZooCfg(). We get a Null if the property doesn't exists, and the result of conf.get() is compared directly without checking for Null.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12519785/HBASE-5633-v1.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks
        org.apache.hadoop.hbase.mapreduce.TestImportTsv
        org.apache.hadoop.hbase.mapred.TestTableMapReduce
        org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1297//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1297//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1297//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12519785/HBASE-5633-v1.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks org.apache.hadoop.hbase.mapreduce.TestImportTsv org.apache.hadoop.hbase.mapred.TestTableMapReduce org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1297//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1297//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1297//console This message is automatically generated.
        Hide
        stack added a comment -

        What I'm committing... wraps a very long line else what Matteo suppied.

        Show
        stack added a comment - What I'm committing... wraps a very long line else what Matteo suppied.
        Hide
        stack added a comment -

        Committed 0.94 branch and trunk

        Show
        stack added a comment - Committed 0.94 branch and trunk
        Hide
        stack added a comment -

        Thanks for the patch Matteo

        Show
        stack added a comment - Thanks for the patch Matteo
        Hide
        Lars Hofhansl added a comment -

        +1

        Show
        Lars Hofhansl added a comment - +1
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94 #53 (See https://builds.apache.org/job/HBase-0.94/53/)
        HBASE-5633 NPE reading ZK config in HBase (Revision 1304925)

        Result = SUCCESS
        stack :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/HConstants.java
        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKConfig.java
        Show
        Hudson added a comment - Integrated in HBase-0.94 #53 (See https://builds.apache.org/job/HBase-0.94/53/ ) HBASE-5633 NPE reading ZK config in HBase (Revision 1304925) Result = SUCCESS stack : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/HConstants.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKConfig.java
        Hide
        Matteo Bertozzi added a comment -

        I've attached two patches to backport on 0.90 and 0.92

        Show
        Matteo Bertozzi added a comment - I've attached two patches to backport on 0.90 and 0.92
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12519868/HBASE-5633-0.92.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1300//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12519868/HBASE-5633-0.92.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1300//console This message is automatically generated.
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #2695 (See https://builds.apache.org/job/HBase-TRUNK/2695/)
        HBASE-5633 NPE reading ZK config in HBase (Revision 1304924)

        Result = FAILURE
        stack :
        Files :

        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/HConstants.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKConfig.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #2695 (See https://builds.apache.org/job/HBase-TRUNK/2695/ ) HBASE-5633 NPE reading ZK config in HBase (Revision 1304924) Result = FAILURE stack : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/HConstants.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKConfig.java
        Hide
        Lars Hofhansl added a comment -

        Let's move the 0.90 and 0.92 into a sub-task, so that this issue can be kept closed.

        Show
        Lars Hofhansl added a comment - Let's move the 0.90 and 0.92 into a sub-task, so that this issue can be kept closed.
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94 #66 (See https://builds.apache.org/job/HBase-0.94/66/)
        HBASE-5638 Readability improvements on HBASE-5633: NPE reading ZK config in HBase (Matteo Bertozzi) (Revision 1307086)

        Result = SUCCESS
        jmhsieh :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/HConstants.java
        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java
        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKConfig.java
        Show
        Hudson added a comment - Integrated in HBase-0.94 #66 (See https://builds.apache.org/job/HBase-0.94/66/ ) HBASE-5638 Readability improvements on HBASE-5633 : NPE reading ZK config in HBase (Matteo Bertozzi) (Revision 1307086) Result = SUCCESS jmhsieh : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/HConstants.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKConfig.java
        Hide
        Hudson added a comment -

        Integrated in HBase-0.92 #343 (See https://builds.apache.org/job/HBase-0.92/343/)
        HBASE-5638 Readability improvements and backport HBASE-5633: NPE reading ZK config in HBase (Matteo Bertozzi) (Revision 1307087)

        Result = SUCCESS
        jmhsieh :
        Files :

        • /hbase/branches/0.92/CHANGES.txt
        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/HConstants.java
        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java
        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKConfig.java
        Show
        Hudson added a comment - Integrated in HBase-0.92 #343 (See https://builds.apache.org/job/HBase-0.92/343/ ) HBASE-5638 Readability improvements and backport HBASE-5633 : NPE reading ZK config in HBase (Matteo Bertozzi) (Revision 1307087) Result = SUCCESS jmhsieh : Files : /hbase/branches/0.92/CHANGES.txt /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/HConstants.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKConfig.java
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-security #154 (See https://builds.apache.org/job/HBase-TRUNK-security/154/)
        HBASE-5638 Readability improvements on HBASE-5633: NPE reading ZK config in HBase (Matteo Bertozzi) (Revision 1307085)

        Result = FAILURE
        jmhsieh :
        Files :

        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/HConstants.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKConfig.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-security #154 (See https://builds.apache.org/job/HBase-TRUNK-security/154/ ) HBASE-5638 Readability improvements on HBASE-5633 : NPE reading ZK config in HBase (Matteo Bertozzi) (Revision 1307085) Result = FAILURE jmhsieh : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/HConstants.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKConfig.java
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94-security #6 (See https://builds.apache.org/job/HBase-0.94-security/6/)
        HBASE-5638 Readability improvements on HBASE-5633: NPE reading ZK config in HBase (Matteo Bertozzi) (Revision 1307086)

        Result = SUCCESS
        jmhsieh :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/HConstants.java
        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java
        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKConfig.java
        Show
        Hudson added a comment - Integrated in HBase-0.94-security #6 (See https://builds.apache.org/job/HBase-0.94-security/6/ ) HBASE-5638 Readability improvements on HBASE-5633 : NPE reading ZK config in HBase (Matteo Bertozzi) (Revision 1307086) Result = SUCCESS jmhsieh : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/HConstants.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKConfig.java
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #2698 (See https://builds.apache.org/job/HBase-TRUNK/2698/)
        HBASE-5638 Readability improvements on HBASE-5633: NPE reading ZK config in HBase (Matteo Bertozzi) (Revision 1307085)

        Result = FAILURE
        jmhsieh :
        Files :

        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/HConstants.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKConfig.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #2698 (See https://builds.apache.org/job/HBase-TRUNK/2698/ ) HBASE-5638 Readability improvements on HBASE-5633 : NPE reading ZK config in HBase (Matteo Bertozzi) (Revision 1307085) Result = FAILURE jmhsieh : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/HConstants.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKConfig.java
        Hide
        Hudson added a comment -

        Integrated in HBase-0.92-security #104 (See https://builds.apache.org/job/HBase-0.92-security/104/)
        HBASE-5638 Readability improvements and backport HBASE-5633: NPE reading ZK config in HBase (Matteo Bertozzi) (Revision 1307087)

        Result = FAILURE
        jmhsieh :
        Files :

        • /hbase/branches/0.92/CHANGES.txt
        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/HConstants.java
        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java
        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKConfig.java
        Show
        Hudson added a comment - Integrated in HBase-0.92-security #104 (See https://builds.apache.org/job/HBase-0.92-security/104/ ) HBASE-5638 Readability improvements and backport HBASE-5633 : NPE reading ZK config in HBase (Matteo Bertozzi) (Revision 1307087) Result = FAILURE jmhsieh : Files : /hbase/branches/0.92/CHANGES.txt /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/HConstants.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKConfig.java

          People

          • Assignee:
            Matteo Bertozzi
            Reporter:
            Matteo Bertozzi
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development