Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Incomplete
    • Affects Version/s: 0.90.7, 0.92.2, 0.94.0, 0.95.2
    • Fix Version/s: None
    • Component/s: hbck
    • Labels:
      None

      Description

      During reviews of HBASE-5128 there are several opportunities investigate for improving the performance of the tool.

      • Change regionInfoMap and tablesInfo from TreeMap to HashMap.
      • Change some full region set reloads to be incremental to require fewer passes.
      • Cache meta for subsequent calls of closeRegionSileneglyAndWait

        Issue Links

          Activity

          Jonathan Hsieh created issue -
          Jonathan Hsieh made changes -
          Field Original Value New Value
          Description During reviews of HBASE-5128 there are several opportunities investigate for improving the performance of the tool.

          - Change regionInfoMap and tablesInfo from TreeMap to HashMap.
          - Change some full region set reloads to be incremental to require fewer passes.
          During reviews of HBASE-5128 there are several opportunities investigate for improving the performance of the tool.

          - Change regionInfoMap and tablesInfo from TreeMap to HashMap.
          - Change some full region set reloads to be incremental to require fewer passes.
          - Cache meta for subsequent calls of closeRegionSileneglyAndWait
          Hide
          Jonathan Hsieh added a comment -

          Minor optimization:

          in HBaseFsck#loadHdfsRegionInfos we could consolidate.

          if (modTInfo = null) {
           ...
          }
          ..
          tablesInfo.put(tableNAme, modTInfo);
          

          to be

          if (modTInfo = null) {
            ...
            tablesInfo.put(tableNAme, modTInfo);
          }
          ..
          
          Show
          Jonathan Hsieh added a comment - Minor optimization: in HBaseFsck#loadHdfsRegionInfos we could consolidate. if (modTInfo = null ) { ... } .. tablesInfo.put(tableNAme, modTInfo); to be if (modTInfo = null ) { ... tablesInfo.put(tableNAme, modTInfo); } ..
          Hide
          Jonathan Hsieh added a comment -
          • parallelize the reads of .regioninfo files in the "diagnostic" section of repairs.
          Show
          Jonathan Hsieh added a comment - parallelize the reads of .regioninfo files in the "diagnostic" section of repairs.
          Jonathan Hsieh made changes -
          Comment [ - parallelize the reads of .regioninfo files in the "diagnostic" section of repairs. ]
          Jonathan Hsieh made changes -
          Link This issue is related to HBASE-5712 [ HBASE-5712 ]
          Jeff Hammerbacher made changes -
          Link This issue is related to HBASE-5128 [ HBASE-5128 ]
          Andrew Purtell made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Incomplete [ 4 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Resolved Resolved
          1113d 1h 5m 1 Andrew Purtell 11/Apr/15 02:28

            People

            • Assignee:
              Unassigned
              Reporter:
              Jonathan Hsieh
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development