HBase
  1. HBase
  2. HBASE-5611

Replayed edits from regions that failed to open during recovery aren't removed from the global MemStore size

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 0.90.6
    • Fix Version/s: 0.92.2, 0.94.0, 0.95.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      This bug is rather easy to get if the TimeoutMonitor is on, else I think it's still possible to hit it if a region fails to open for more obscure reasons like HDFS errors.

      Consider a region that just went through distributed splitting and that's now being opened by a new RS. The first thing it does is to read the recovery files and put the edits in the MemStores. If this process takes a long time, the master will move that region away. At that point the edits are still accounted for in the global MemStore size but they are dropped when the HRegion gets cleaned up. It's completely invisible until the MemStoreFlusher needs to force flush a region and that none of them have edits:

      2012-03-21 00:33:39,303 DEBUG org.apache.hadoop.hbase.regionserver.MemStoreFlusher: Flush thread woke up because memory above low water=5.9g
      2012-03-21 00:33:39,303 ERROR org.apache.hadoop.hbase.regionserver.MemStoreFlusher: Cache flusher failed for entry null
      java.lang.IllegalStateException
              at com.google.common.base.Preconditions.checkState(Preconditions.java:129)
              at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushOneForGlobalPressure(MemStoreFlusher.java:199)
              at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.run(MemStoreFlusher.java:223)
              at java.lang.Thread.run(Thread.java:662)
      

      The null here is a region. In my case I had so many edits in the MemStore during recovery that I'm over the low barrier although in fact I'm at 0. It happened yesterday and it still printing this out.

      To fix this we need to be able to decrease the global MemStore size when the region can't open.

      1. 5611-94.addendum
        3 kB
        Ted Yu
      2. 5611-94-v2.txt
        7 kB
        Ted Yu
      3. HBASE-5611-92.patch
        7 kB
        Jieshan Bean
      4. HBASE-5611-94-minorchange.patch
        7 kB
        Jieshan Bean
      5. HBASE-5611-trunk-v2-minorchange.patch
        7 kB
        Jieshan Bean

        Activity

        Hide
        Jieshan Bean added a comment -

        Patch for review. Thanks.

        Show
        Jieshan Bean added a comment - Patch for review. Thanks.
        Hide
        Ted Yu added a comment -
        +  // global memstore size once a region opening failed.
        

        'region opening failed' -> 'region failed opening'.

        +  private final ConcurrentMap<HRegionInfo, AtomicLong> replayEditsPerRegion = 
        

        Do we need HRegionInfo as the key to the Map ? Can we use region name ?
        For rollbackRegionReplayEditsSize():

        +      addAndGetGlobalMemstoreSize(-replayEdistsSize.get());
        +      clearRegionReplayEditsSize(hri);
        

        I suggest remembering the value of -replayEdistsSize.get() in a variable so that we can exchange the order of the two statements above and return directly from the if block.
        If replayEdistsSize is null, would that indicate certain race condition ?

        Show
        Ted Yu added a comment - + // global memstore size once a region opening failed. 'region opening failed' -> 'region failed opening'. + private final ConcurrentMap<HRegionInfo, AtomicLong> replayEditsPerRegion = Do we need HRegionInfo as the key to the Map ? Can we use region name ? For rollbackRegionReplayEditsSize(): + addAndGetGlobalMemstoreSize(-replayEdistsSize.get()); + clearRegionReplayEditsSize(hri); I suggest remembering the value of -replayEdistsSize.get() in a variable so that we can exchange the order of the two statements above and return directly from the if block. If replayEdistsSize is null, would that indicate certain race condition ?
        Hide
        ramkrishna.s.vasudevan added a comment -

        @Lars
        Want this in 0.94.0?

        Show
        ramkrishna.s.vasudevan added a comment - @Lars Want this in 0.94.0?
        Hide
        Lars Hofhansl added a comment -

        Yep... Looks bad.

        Show
        Lars Hofhansl added a comment - Yep... Looks bad.
        Hide
        Lars Hofhansl added a comment -

        Actually... It seems we had this problem since 0.90.
        I'll pull it in if it gets done in time, otherwise it'll be in the next point release.

        Show
        Lars Hofhansl added a comment - Actually... It seems we had this problem since 0.90. I'll pull it in if it gets done in time, otherwise it'll be in the next point release.
        Hide
        Jieshan Bean added a comment -

        Thank you, Ted. I will update the patch immediately. And will make the patch for 94 today.

        Show
        Jieshan Bean added a comment - Thank you, Ted. I will update the patch immediately. And will make the patch for 94 today.
        Hide
        Jieshan Bean added a comment -

        If replayEdistsSize is null, would that indicate certain race condition ?

        If no edits needed to replay, it should be null. Only during region openning process, those new methods will be called. It's should not be a race condition.

        Show
        Jieshan Bean added a comment - If replayEdistsSize is null, would that indicate certain race condition ? If no edits needed to replay, it should be null. Only during region openning process, those new methods will be called. It's should not be a race condition.
        Hide
        Ted Yu added a comment -

        @Jieshan:
        When you have multiple patches for different branches, attach patch for trunk apart from the other patches.
        Otherwise Hadoop QA may pick up the wrong patch.

        Show
        Ted Yu added a comment - @Jieshan: When you have multiple patches for different branches, attach patch for trunk apart from the other patches. Otherwise Hadoop QA may pick up the wrong patch.
        Hide
        Jieshan Bean added a comment -

        Thank you, Ted. I will take care.

        Show
        Jieshan Bean added a comment - Thank you, Ted. I will take care.
        Hide
        Ted Yu added a comment - - edited

        Patch v2 looks good in general.
        Comment on formatting:

        +   * @param regionName
        +   *          region name.
        

        The line length limit is 100 chars. Please put javadoc for param on the same line as param name.

        You can wait for Hadoop QA result to come back before attaching new patches.

        Show
        Ted Yu added a comment - - edited Patch v2 looks good in general. Comment on formatting: + * @param regionName + * region name. The line length limit is 100 chars. Please put javadoc for param on the same line as param name. You can wait for Hadoop QA result to come back before attaching new patches.
        Hide
        Jieshan Bean added a comment -

        I use the formatter from HBASE-3678. Every time, it format my code like that.
        I will change after QA result.

        Show
        Jieshan Bean added a comment - I use the formatter from HBASE-3678 . Every time, it format my code like that. I will change after QA result.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12524416/HBASE-5611-trunk-v2.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1656//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1656//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1656//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12524416/HBASE-5611-trunk-v2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1656//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1656//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1656//console This message is automatically generated.
        Hide
        Ted Yu added a comment -

        Tests were clear.

        @Jieshan:
        Please address formatting and prepare patches for each branch.

        We should also run test suite for 0.90 and 0.92 once patches are available.

        Good job.

        Show
        Ted Yu added a comment - Tests were clear. @Jieshan: Please address formatting and prepare patches for each branch. We should also run test suite for 0.90 and 0.92 once patches are available. Good job.
        Hide
        Jieshan Bean added a comment -

        Will upload the patches for 92 and 90 today

        Show
        Jieshan Bean added a comment - Will upload the patches for 92 and 90 today
        Hide
        Ted Yu added a comment -
        +   * Roll back the global MemStore size when a region can't open.
        

        The above is not accurate: we're only rolling back the replay edits size for specified region from global MemStore size.

        Show
        Ted Yu added a comment - + * Roll back the global MemStore size when a region can't open. The above is not accurate: we're only rolling back the replay edits size for specified region from global MemStore size.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12524809/HBASE-5611-trunk-v2.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.regionserver.TestServerCustomProtocol
        org.apache.hadoop.hbase.util.TestHBaseFsck

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1664//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1664//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1664//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12524809/HBASE-5611-trunk-v2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.TestServerCustomProtocol org.apache.hadoop.hbase.util.TestHBaseFsck Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1664//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1664//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1664//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12524812/HBASE-5611-94-minorchange.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1667//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12524812/HBASE-5611-94-minorchange.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1667//console This message is automatically generated.
        Hide
        Jieshan Bean added a comment -

        This problem seems not present in 90 branch. RegionServerAccounting is not in 90. And the global memstore size is calculated by below methods:

          public long getGlobalMemStoreSize() {
            long total = 0;
            for (HRegion region : onlineRegions.values()) {
              total += region.memstoreSize.get();
            }
            return total;
          }
        
        Show
        Jieshan Bean added a comment - This problem seems not present in 90 branch. RegionServerAccounting is not in 90. And the global memstore size is calculated by below methods: public long getGlobalMemStoreSize() { long total = 0; for (HRegion region : onlineRegions.values()) { total += region.memstoreSize.get(); } return total; }
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12524810/HBASE-5611-trunk-v2-minorchange.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1666//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1666//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1666//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12524810/HBASE-5611-trunk-v2-minorchange.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1666//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1666//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1666//console This message is automatically generated.
        Hide
        Ted Yu added a comment -

        I ran 0.92 test suite over 0.92 patch and didn't find regression.

        Will integrate tomorrow if there is no objection.

        Show
        Ted Yu added a comment - I ran 0.92 test suite over 0.92 patch and didn't find regression. Will integrate tomorrow if there is no objection.
        Hide
        Lars Hofhansl added a comment -

        Still waiting for a 0.94.0 blocker. +1 on 0.94 commit as well.

        Show
        Lars Hofhansl added a comment - Still waiting for a 0.94.0 blocker. +1 on 0.94 commit as well.
        Hide
        Ted Yu added a comment -

        Integrated to 0.92, 0.94 and trunk.

        Thanks for the patch, Jieshan.

        Thanks for the review, Lars.

        Show
        Ted Yu added a comment - Integrated to 0.92, 0.94 and trunk. Thanks for the patch, Jieshan. Thanks for the review, Lars.
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94 #153 (See https://builds.apache.org/job/HBase-0.94/153/)
        HBASE-5611 Replayed edits from regions that failed to open during recovery aren't removed from the global MemStore size (Jieshan) (Revision 1331683)

        Result = FAILURE
        tedyu :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerAccounting.java
        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java
        Show
        Hudson added a comment - Integrated in HBase-0.94 #153 (See https://builds.apache.org/job/HBase-0.94/153/ ) HBASE-5611 Replayed edits from regions that failed to open during recovery aren't removed from the global MemStore size (Jieshan) (Revision 1331683) Result = FAILURE tedyu : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerAccounting.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #2823 (See https://builds.apache.org/job/HBase-TRUNK/2823/)
        HBASE-5611 Replayed edits from regions that failed to open during recovery aren't removed from the global MemStore size (Jieshan) (Revision 1331681)

        Result = FAILURE
        tedyu :
        Files :

        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerAccounting.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #2823 (See https://builds.apache.org/job/HBase-TRUNK/2823/ ) HBASE-5611 Replayed edits from regions that failed to open during recovery aren't removed from the global MemStore size (Jieshan) (Revision 1331681) Result = FAILURE tedyu : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerAccounting.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-security #187 (See https://builds.apache.org/job/HBase-TRUNK-security/187/)
        HBASE-5611 Replayed edits from regions that failed to open during recovery aren't removed from the global MemStore size (Jieshan) (Revision 1331681)

        Result = SUCCESS
        tedyu :
        Files :

        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerAccounting.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-security #187 (See https://builds.apache.org/job/HBase-TRUNK-security/187/ ) HBASE-5611 Replayed edits from regions that failed to open during recovery aren't removed from the global MemStore size (Jieshan) (Revision 1331681) Result = SUCCESS tedyu : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerAccounting.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java
        Hide
        Hudson added a comment -

        Integrated in HBase-0.92 #392 (See https://builds.apache.org/job/HBase-0.92/392/)
        HBASE-5611 Replayed edits from regions that failed to open during recovery aren't removed from the global MemStore size (Jieshan) (Revision 1331684)

        Result = SUCCESS
        tedyu :
        Files :

        • /hbase/branches/0.92/CHANGES.txt
        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerAccounting.java
        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java
        Show
        Hudson added a comment - Integrated in HBase-0.92 #392 (See https://builds.apache.org/job/HBase-0.92/392/ ) HBASE-5611 Replayed edits from regions that failed to open during recovery aren't removed from the global MemStore size (Jieshan) (Revision 1331684) Result = SUCCESS tedyu : Files : /hbase/branches/0.92/CHANGES.txt /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerAccounting.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java
        Hide
        Ted Yu added a comment -

        Addendum for 0.94

        Show
        Ted Yu added a comment - Addendum for 0.94
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94 #155 (See https://builds.apache.org/job/HBase-0.94/155/)
        HBASE-5611 Addendum fixes test failure in TestHeapSize#testSizes (Revision 1331769)

        Result = FAILURE
        tedyu :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
        Show
        Hudson added a comment - Integrated in HBase-0.94 #155 (See https://builds.apache.org/job/HBase-0.94/155/ ) HBASE-5611 Addendum fixes test failure in TestHeapSize#testSizes (Revision 1331769) Result = FAILURE tedyu : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
        Hide
        Ted Yu added a comment -

        Changes for 0.94 reverted due to TestChangingEncoding failure.

        Show
        Ted Yu added a comment - Changes for 0.94 reverted due to TestChangingEncoding failure.
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94 #158 (See https://builds.apache.org/job/HBase-0.94/158/)
        HBASE-5611 Revert due to consistent TestChangingEncoding failure in 0.94 branch (Revision 1331826)

        Result = FAILURE
        tedyu :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerAccounting.java
        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java
        Show
        Hudson added a comment - Integrated in HBase-0.94 #158 (See https://builds.apache.org/job/HBase-0.94/158/ ) HBASE-5611 Revert due to consistent TestChangingEncoding failure in 0.94 branch (Revision 1331826) Result = FAILURE tedyu : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerAccounting.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94-security #24 (See https://builds.apache.org/job/HBase-0.94-security/24/)
        HBASE-5611 Revert due to consistent TestChangingEncoding failure in 0.94 branch (Revision 1331826)
        HBASE-5611 Addendum fixes test failure in TestHeapSize#testSizes (Revision 1331769)
        HBASE-5611 Replayed edits from regions that failed to open during recovery aren't removed from the global MemStore size (Jieshan) (Revision 1331683)

        Result = FAILURE
        tedyu :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerAccounting.java
        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java

        tedyu :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java

        tedyu :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerAccounting.java
        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java
        Show
        Hudson added a comment - Integrated in HBase-0.94-security #24 (See https://builds.apache.org/job/HBase-0.94-security/24/ ) HBASE-5611 Revert due to consistent TestChangingEncoding failure in 0.94 branch (Revision 1331826) HBASE-5611 Addendum fixes test failure in TestHeapSize#testSizes (Revision 1331769) HBASE-5611 Replayed edits from regions that failed to open during recovery aren't removed from the global MemStore size (Jieshan) (Revision 1331683) Result = FAILURE tedyu : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerAccounting.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java tedyu : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java tedyu : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerAccounting.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java
        Hide
        Jieshan Bean added a comment -

        Thank you, Ted.
        I will check that failure in 94 version.

        Show
        Jieshan Bean added a comment - Thank you, Ted. I will check that failure in 94 version.
        Hide
        Jieshan Bean added a comment -

        TestHeapSize failure on a 32-bit machine in 94 is caused by HBASE-5900.

        Show
        Jieshan Bean added a comment - TestHeapSize failure on a 32-bit machine in 94 is caused by HBASE-5900 .
        Hide
        Jieshan Bean added a comment -

        The new version patch for 94 will be uploaded after HBASE-5900 get fixed.

        Show
        Jieshan Bean added a comment - The new version patch for 94 will be uploaded after HBASE-5900 get fixed.
        Hide
        Ted Yu added a comment -

        Patch for 0.94 branch which fixes FIXED_OVERHEAD.

        Show
        Ted Yu added a comment - Patch for 0.94 branch which fixes FIXED_OVERHEAD.
        Hide
        Ted Yu added a comment -

        Integrated 5611-94-v2.txt to 0.94 branch.

        Show
        Ted Yu added a comment - Integrated 5611-94-v2.txt to 0.94 branch.
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94 #161 (See https://builds.apache.org/job/HBase-0.94/161/)
        HBASE-5611 Replayed edits from regions that failed to open during recovery aren't removed from the global MemStore size - v2 (Jieshan) (Revision 1332344)

        Result = FAILURE
        tedyu :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerAccounting.java
        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java
        Show
        Hudson added a comment - Integrated in HBase-0.94 #161 (See https://builds.apache.org/job/HBase-0.94/161/ ) HBASE-5611 Replayed edits from regions that failed to open during recovery aren't removed from the global MemStore size - v2 (Jieshan) (Revision 1332344) Result = FAILURE tedyu : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerAccounting.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94-security #25 (See https://builds.apache.org/job/HBase-0.94-security/25/)
        HBASE-5611 Replayed edits from regions that failed to open during recovery aren't removed from the global MemStore size - v2 (Jieshan) (Revision 1332344)

        Result = SUCCESS
        tedyu :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerAccounting.java
        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java
        Show
        Hudson added a comment - Integrated in HBase-0.94-security #25 (See https://builds.apache.org/job/HBase-0.94-security/25/ ) HBASE-5611 Replayed edits from regions that failed to open during recovery aren't removed from the global MemStore size - v2 (Jieshan) (Revision 1332344) Result = SUCCESS tedyu : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerAccounting.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java
        Hide
        Jieshan Bean added a comment -

        Thank you very much, Ted.

        Show
        Jieshan Bean added a comment - Thank you very much, Ted.
        Hide
        Hudson added a comment -

        Integrated in HBase-0.92-security #106 (See https://builds.apache.org/job/HBase-0.92-security/106/)
        HBASE-5611 Replayed edits from regions that failed to open during recovery aren't removed from the global MemStore size (Jieshan) (Revision 1331684)

        Result = SUCCESS
        tedyu :
        Files :

        • /hbase/branches/0.92/CHANGES.txt
        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerAccounting.java
        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java
        Show
        Hudson added a comment - Integrated in HBase-0.92-security #106 (See https://builds.apache.org/job/HBase-0.92-security/106/ ) HBASE-5611 Replayed edits from regions that failed to open during recovery aren't removed from the global MemStore size (Jieshan) (Revision 1331684) Result = SUCCESS tedyu : Files : /hbase/branches/0.92/CHANGES.txt /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerAccounting.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java

          People

          • Assignee:
            Jieshan Bean
            Reporter:
            Jean-Daniel Cryans
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development