[HBASE-5598] Analyse and fix the findbugs reporting by QA and add invalid bugs into findbugs-excludeFilter file

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 0.92.1, 0.94.0, 0.95.2
• Fix Version/s: 0.95.0
• Component/s: scripts

Release Note

Developers can generate the findbugs report for analysing the findbugs violations.
Execute this maven command for running and generating the findbugs report: mvn findbugs:gui
This generates the report in GUI, by which will directly show the code instances where exactly the issue is reported.

If the developer finds any invalid bug, then that bug pattern can be updated in dev-support/findbugs-exclude.xml file.
example:
<Match>
   <Class name="org.apache.hadoop.hbase.regionserver.HRegion" />
   <Method name="getRecentFlushInfo" />
   <Bug pattern="UL_UNRELEASED_LOCK_EXCEPTION_PATH" />
</Match>

• Tags: noob
• Assignee: Uma Maheswara Rao G
• Reporter: Uma Maheswara Rao G
• Created: 18/Mar/12 01:46
• Updated: 23/Sep/13 18:31
• Resolved: 25/Feb/13 19:54

Description

There are many findbugs errors reporting by HbaseQA. HBASE-5597 is going to up the OK count.
This may lead to other issues when we re-factor the code, if we induce new valid ones and remove invalid bugs also can not be reported by QA.

So, I would propose to add the exclude filter file for findbugs(for the invalid bugs). If we find any valid ones, we can fix under this JIRA.

Issue Links

• relates to: HBASE-7443 More findbugs fixes

Sub-Tasks

• [findbugs] Exclude Thrift and Protobuf warnings: Closed
• [findbugs] Fix compareTo/equals/hashcode warnings: Closed
• [findbugs] Fix null pointer warnings.: Closed
• [findbugs] Fix correctness warnings: Closed
• [findbugs] Investigate experimental warnings: Closed
• [findbugs] Address "Exposed internal representation" warnings: Closed
• [findbugs] Fix final/protected/constant declarations.: Closed
• [findbugs] Fix security warning: Closed
• [findbugs] Address extra synchronization on CLSM, Atomic*: Closed
• [findbugs] Address wait/notify synchronization/inconsistency in sync: Closed
• [findbugs] Fix lock release on all paths: Closed
• [findbugs] fix perf warnings: Closed
• [findbugs] Address dodgy bugs: Closed
• [findbugs] Exclude Protobuf warnings from wire compat patches.: Closed
• [findbugs] Fix hbck findbugs warnings: Closed
• [findbugs] address remaining findbugs warnings: Closed
• Suppress Findbugs warnings links in Hadoop QA report if there was no Findbugs warning: Closed