HBase
  1. HBase
  2. HBASE-5598

Analyse and fix the findbugs reporting by QA and add invalid bugs into findbugs-excludeFilter file

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 0.92.1, 0.94.0, 0.95.2
    • Fix Version/s: 0.95.0
    • Component/s: scripts
    • Labels:
      None
    • Release Note:
      Hide
      Developers can generate the findbugs report for analysing the findbugs violations.
      Execute this maven command for running and generating the findbugs report: mvn findbugs:gui
      This generates the report in GUI, by which will directly show the code instances where exactly the issue is reported.

      If the developer finds any invalid bug, then that bug pattern can be updated in dev-support/findbugs-exclude.xml file.
      example:
      <Match>
         <Class name="org.apache.hadoop.hbase.regionserver.HRegion" />
         <Method name="getRecentFlushInfo" />
         <Bug pattern="UL_UNRELEASED_LOCK_EXCEPTION_PATH" />
      </Match>
      Show
      Developers can generate the findbugs report for analysing the findbugs violations. Execute this maven command for running and generating the findbugs report: mvn findbugs:gui This generates the report in GUI, by which will directly show the code instances where exactly the issue is reported. If the developer finds any invalid bug, then that bug pattern can be updated in dev-support/findbugs-exclude.xml file. example: <Match>    <Class name="org.apache.hadoop.hbase.regionserver.HRegion" />    <Method name="getRecentFlushInfo" />    <Bug pattern="UL_UNRELEASED_LOCK_EXCEPTION_PATH" /> </Match>
    • Tags:
      noob

      Description

      There are many findbugs errors reporting by HbaseQA. HBASE-5597 is going to up the OK count.
      This may lead to other issues when we re-factor the code, if we induce new valid ones and remove invalid bugs also can not be reported by QA.

      So, I would propose to add the exclude filter file for findbugs(for the invalid bugs). If we find any valid ones, we can fix under this JIRA.

      1. HBASE-5598.patch
        2 kB
        Uma Maheswara Rao G
      2. ASF.LICENSE.NOT.GRANTED--findbugs-gui-report.jpg
        175 kB
        Uma Maheswara Rao G
      3. 5598.part1.patch
        23 kB
        Nicolas Liochon
      4. 5598.part2.patch
        24 kB
        Nicolas Liochon
      5. 5598.part2.patch
        24 kB
        Nicolas Liochon

        Issue Links

          Activity

          stack made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Gavin made changes -
          Link This issue relates to HBASE-7443 [ HBASE-7443 ]
          Gavin made changes -
          Link This issue relates to HBASE-7443 [ HBASE-7443 ]
          stack made changes -
          Fix Version/s 0.98.0 [ 12323143 ]
          stack made changes -
          Fix Version/s 0.98.0 [ 12323143 ]
          stack made changes -
          Fix Version/s 0.95.0 [ 12324094 ]
          Fix Version/s 0.96.0 [ 12320040 ]
          stack made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Nicolas Liochon made changes -
          Link This issue relates HBASE-7443 [ HBASE-7443 ]
          Nicolas Liochon made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Nicolas Liochon made changes -
          Attachment 5598.part2.patch [ 12562482 ]
          Nicolas Liochon made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Nicolas Liochon made changes -
          Attachment 5598.part2.patch [ 12562481 ]
          Nicolas Liochon made changes -
          Attachment 5598.part1.patch [ 12562223 ]
          Nicolas Liochon made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Fix Version/s 0.96.0 [ 12320040 ]
          Nicolas Liochon made changes -
          Attachment 5598.part1.patch [ 12562225 ]
          Nicolas Liochon made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Nicolas Liochon made changes -
          Attachment 5598.part1.patch [ 12562223 ]
          stack made changes -
          Tags noob
          Priority Minor [ 4 ] Critical [ 2 ]
          Uma Maheswara Rao G made changes -
          Release Note Developers can generate the findbugs report for analysing the findbugs violations.
          Execute this maven command for running and generating the findbugs report: mvn findbugs:gui
          This generates the report in GUI, by which will directly show the code instances where exactly the issue is reported.

          If the developer finds any invalid bug, then that bug pattern can be updated in dev-support/findbugs-exclude.xml file.
          example:
          <Match>
             <Class name="org.apache.hadoop.hbase.regionserver.HRegion" />
             <Method name="getRecentFlushInfo" />
             <Bug pattern="UL_UNRELEASED_LOCK_EXCEPTION_PATH" />
          </Match>
          Uma Maheswara Rao G made changes -
          Attachment findbugs-gui-report.jpg [ 12520103 ]
          Uma Maheswara Rao G made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Uma Maheswara Rao G made changes -
          Attachment HBASE-5598.patch [ 12520025 ]
          Uma Maheswara Rao G made changes -
          Assignee Uma Maheswara Rao G [ umamaheswararao ]
          Uma Maheswara Rao G made changes -
          Field Original Value New Value
          Description There are many findbugs errors reporting by HbaseQA. HBASE-5597 is going to up the OK count.
          This may lead to other issues when we re-factor the code, if we induce new valid ones and remove invalid bugs also can not be reported by QA.

          So, I would propose to add the exclude filter file for findbugs for the invalid bugs. If we find any valid ond we can fix under this JIRA.
          There are many findbugs errors reporting by HbaseQA. HBASE-5597 is going to up the OK count.
          This may lead to other issues when we re-factor the code, if we induce new valid ones and remove invalid bugs also can not be reported by QA.

          So, I would propose to add the exclude filter file for findbugs(for the invalid bugs). If we find any valid ones, we can fix under this JIRA.
          Uma Maheswara Rao G created issue -

            People

            • Assignee:
              Uma Maheswara Rao G
              Reporter:
              Uma Maheswara Rao G
            • Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development