HBase
  1. HBase
  2. HBASE-5597

Findbugs check in test-patch.sh always fails

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.92.1, 0.94.0, 0.95.2
    • Fix Version/s: 0.94.0
    • Component/s: scripts
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      "Fix" is to bump up OK findbugs count in test-patch.properties. Agreed to on the list.

      1. HBASE-5597.patch
        0.4 kB
        David S. Wang

        Activity

        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12518754/HBASE-5597.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 161 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
        org.apache.hadoop.hbase.mapred.TestTableMapReduce
        org.apache.hadoop.hbase.mapreduce.TestImportTsv

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1213//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1213//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1213//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12518754/HBASE-5597.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 161 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat org.apache.hadoop.hbase.mapred.TestTableMapReduce org.apache.hadoop.hbase.mapreduce.TestImportTsv Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1213//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1213//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1213//console This message is automatically generated.
        Hide
        Uma Maheswara Rao G added a comment -

        Hi David,
        Problem with just upping the count is, later if you remove some code(contains current findbugs warnings) and add new code(introduce some valid findbugs). Then test-patch may not make difference due to this OK count.

        Instead, we can add findbugs-exclude file right? this may point the exact place of the findbug to ignore.

        What do you say?

        Show
        Uma Maheswara Rao G added a comment - Hi David, Problem with just upping the count is, later if you remove some code(contains current findbugs warnings) and add new code(introduce some valid findbugs). Then test-patch may not make difference due to this OK count. Instead, we can add findbugs-exclude file right? this may point the exact place of the findbug to ignore. What do you say?
        Hide
        David S. Wang added a comment -

        My original goal is to get test-patch.sh to pass. Actually, it would be great to just fix all of the findbugs errors, instead of having either this count or the exclude files. But evidently it has not been important enough to fix so far, or else we would not have an "OK findbugs count" in the first place.

        So I am fine with either bumping the OK findbugs count, or creating a findbugs exclusion file. Others can chime in.

        Show
        David S. Wang added a comment - My original goal is to get test-patch.sh to pass. Actually, it would be great to just fix all of the findbugs errors, instead of having either this count or the exclude files. But evidently it has not been important enough to fix so far, or else we would not have an "OK findbugs count" in the first place. So I am fine with either bumping the OK findbugs count, or creating a findbugs exclusion file. Others can chime in.
        Hide
        Uma Maheswara Rao G added a comment -

        My original goal is to get test-patch.sh to pass.
        ....
        So I am fine with either bumping the OK findbugs count, or creating a findbugs exclusion file. Others can chime in.

        Hi David,
        If our goal is just to make it pass , then both the ways would work.
        But only my concern with upping the count is, it will create above issue which I mentioned in my previous comment. Finally we will get trapped with the test-patch results. And we may induce valid findbugs later( may not be reported by test-patch results due to above issue ).

        Show
        Uma Maheswara Rao G added a comment - My original goal is to get test-patch.sh to pass. .... So I am fine with either bumping the OK findbugs count, or creating a findbugs exclusion file. Others can chime in. Hi David, If our goal is just to make it pass , then both the ways would work. But only my concern with upping the count is, it will create above issue which I mentioned in my previous comment. Finally we will get trapped with the test-patch results. And we may induce valid findbugs later( may not be reported by test-patch results due to above issue ).
        Hide
        stack added a comment -

        I'd be fine committing this patch for now and opening another to address findbugs issues. I agree w/ Uma but truth be told, no one that I know of is looking at findbugs output and for sure no one is trying to keep the count down. We need to foreground the findbugs reporting and perhaps have someone dig in. In my experience there are many false positives but it'll find the odd good one. What do ye think?

        Show
        stack added a comment - I'd be fine committing this patch for now and opening another to address findbugs issues. I agree w/ Uma but truth be told, no one that I know of is looking at findbugs output and for sure no one is trying to keep the count down. We need to foreground the findbugs reporting and perhaps have someone dig in. In my experience there are many false positives but it'll find the odd good one. What do ye think?
        Hide
        Uma Maheswara Rao G added a comment -

        I am ok to file another JIRA. Just filed HBASE-5598.
        ok, let's commit this for now.
        +1

        Show
        Uma Maheswara Rao G added a comment - I am ok to file another JIRA. Just filed HBASE-5598 . ok, let's commit this for now. +1
        Hide
        stack added a comment -

        Committed to 0.94 and trunk. Thanks for patch David and review Uma.

        Show
        stack added a comment - Committed to 0.94 and trunk. Thanks for patch David and review Uma.
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94 #43 (See https://builds.apache.org/job/HBase-0.94/43/)
        HBASE-5597 Findbugs check in test-patch.sh always fails (Revision 1303197)

        Result = SUCCESS
        stack :
        Files :

        • /hbase/branches/0.94/dev-support/test-patch.properties
        Show
        Hudson added a comment - Integrated in HBase-0.94 #43 (See https://builds.apache.org/job/HBase-0.94/43/ ) HBASE-5597 Findbugs check in test-patch.sh always fails (Revision 1303197) Result = SUCCESS stack : Files : /hbase/branches/0.94/dev-support/test-patch.properties
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-security #144 (See https://builds.apache.org/job/HBase-TRUNK-security/144/)
        HBASE-5597 Findbugs check in test-patch.sh always fails (Revision 1303196)

        Result = FAILURE
        stack :
        Files :

        • /hbase/trunk/dev-support/test-patch.properties
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-security #144 (See https://builds.apache.org/job/HBase-TRUNK-security/144/ ) HBASE-5597 Findbugs check in test-patch.sh always fails (Revision 1303196) Result = FAILURE stack : Files : /hbase/trunk/dev-support/test-patch.properties
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #2689 (See https://builds.apache.org/job/HBase-TRUNK/2689/)
        HBASE-5597 Findbugs check in test-patch.sh always fails (Revision 1303196)

        Result = FAILURE
        stack :
        Files :

        • /hbase/trunk/dev-support/test-patch.properties
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #2689 (See https://builds.apache.org/job/HBase-TRUNK/2689/ ) HBASE-5597 Findbugs check in test-patch.sh always fails (Revision 1303196) Result = FAILURE stack : Files : /hbase/trunk/dev-support/test-patch.properties

          People

          • Assignee:
            David S. Wang
            Reporter:
            David S. Wang
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development