Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-5592

Make it easier to get a table from shell

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.94.0
    • Fix Version/s: 0.94.0, 0.95.0
    • Component/s: shell
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      The one argument constructor to HTable was removed at some point, which means that you now have to pass in a Configuration to instantiate an HTable. This is annoying for me when I create quick scripts.

      This JIRA is a tiny patch which lets you get an HTable instance in the shell by doing

      foo_table = @shell.hbase_table('foo').table

      Basically, it is changing table to be a public member rather than a private one.

        Activity

        Hide
        stack stack added a comment -

        Committed trunk, 0.94, and 0.92 branches. Thanks for the patch Ben.

        Show
        stack stack added a comment - Committed trunk, 0.94, and 0.92 branches. Thanks for the patch Ben.
        Hide
        jesse_yates Jesse Yates added a comment -

        This is a duplicate of 5548 and a worse way to go about it. Prefer to revert this and go with the impl in 5548 (a little biased here, as I'm working on 5548).

        Show
        jesse_yates Jesse Yates added a comment - This is a duplicate of 5548 and a worse way to go about it. Prefer to revert this and go with the impl in 5548 (a little biased here, as I'm working on 5548).
        Hide
        hudson Hudson added a comment -

        Integrated in HBase-0.94 #35 (See https://builds.apache.org/job/HBase-0.94/35/)
        HBASE-5592 Make it easier to get a table from shell (Revision 1301716)

        Result = SUCCESS
        stack :
        Files :

        • /hbase/branches/0.94/src/main/ruby/hbase/table.rb
        Show
        hudson Hudson added a comment - Integrated in HBase-0.94 #35 (See https://builds.apache.org/job/HBase-0.94/35/ ) HBASE-5592 Make it easier to get a table from shell (Revision 1301716) Result = SUCCESS stack : Files : /hbase/branches/0.94/src/main/ruby/hbase/table.rb
        Hide
        hudson Hudson added a comment -

        Integrated in HBase-0.92 #324 (See https://builds.apache.org/job/HBase-0.92/324/)
        HBASE-5592 Make it easier to get a table from shell (Revision 1301717)

        Result = FAILURE
        stack :
        Files :

        • /hbase/branches/0.92/CHANGES.txt
        • /hbase/branches/0.92/src/main/ruby/hbase/table.rb
        Show
        hudson Hudson added a comment - Integrated in HBase-0.92 #324 (See https://builds.apache.org/job/HBase-0.92/324/ ) HBASE-5592 Make it easier to get a table from shell (Revision 1301717) Result = FAILURE stack : Files : /hbase/branches/0.92/CHANGES.txt /hbase/branches/0.92/src/main/ruby/hbase/table.rb
        Hide
        hudson Hudson added a comment -

        Integrated in HBase-TRUNK #2686 (See https://builds.apache.org/job/HBase-TRUNK/2686/)
        HBASE-5592 Make it easier to get a table from shell (Revision 1301715)

        Result = SUCCESS
        stack :
        Files :

        • /hbase/trunk/src/main/ruby/hbase/table.rb
        Show
        hudson Hudson added a comment - Integrated in HBase-TRUNK #2686 (See https://builds.apache.org/job/HBase-TRUNK/2686/ ) HBASE-5592 Make it easier to get a table from shell (Revision 1301715) Result = SUCCESS stack : Files : /hbase/trunk/src/main/ruby/hbase/table.rb
        Hide
        stack stack added a comment -

        I can revert. Would be interested in Bens' opinion first.

        What if we left this in 0.92 and did your version in 0.94+ Jesse? Do they interfere?

        Show
        stack stack added a comment - I can revert. Would be interested in Bens' opinion first. What if we left this in 0.92 and did your version in 0.94+ Jesse? Do they interfere?
        Hide
        jesse_yates Jesse Yates added a comment -

        They aren't going to interfere, just don't see the point of having Ben's when 5548 goes in. I can revert his change when doing the commit on mine, but that seems a bit roundabout to me

        Show
        jesse_yates Jesse Yates added a comment - They aren't going to interfere, just don't see the point of having Ben's when 5548 goes in. I can revert his change when doing the commit on mine, but that seems a bit roundabout to me
        Hide
        jesse_yates Jesse Yates added a comment -

        Oh, btw my issue with this patch is that it requires a knowledge much deeper than previously required to get a reference to the table and breaks the current paradigm of using the simple, one-word commands. Also, the table obtained this way isn't going to have any of the nice formatting we are all used to (a little superfluous, but nice smile).

        Show
        jesse_yates Jesse Yates added a comment - Oh, btw my issue with this patch is that it requires a knowledge much deeper than previously required to get a reference to the table and breaks the current paradigm of using the simple, one-word commands. Also, the table obtained this way isn't going to have any of the nice formatting we are all used to (a little superfluous, but nice smile).
        Hide
        zhihyu@ebaysf.com Ted Yu added a comment -

        This is an improvement, right ?
        Should it go into 0.92 which becomes stable release ?

        Show
        zhihyu@ebaysf.com Ted Yu added a comment - This is an improvement, right ? Should it go into 0.92 which becomes stable release ?
        Hide
        hudson Hudson added a comment -

        Integrated in HBase-TRUNK-security #140 (See https://builds.apache.org/job/HBase-TRUNK-security/140/)
        HBASE-5592 Make it easier to get a table from shell (Revision 1301715)

        Result = SUCCESS
        stack :
        Files :

        • /hbase/trunk/src/main/ruby/hbase/table.rb
        Show
        hudson Hudson added a comment - Integrated in HBase-TRUNK-security #140 (See https://builds.apache.org/job/HBase-TRUNK-security/140/ ) HBASE-5592 Make it easier to get a table from shell (Revision 1301715) Result = SUCCESS stack : Files : /hbase/trunk/src/main/ruby/hbase/table.rb
        Hide
        yuzhihong@gmail.com Ted Yu added a comment -

        Jesse and I object to this going into 0.92

        Show
        yuzhihong@gmail.com Ted Yu added a comment - Jesse and I object to this going into 0.92
        Hide
        xodarap Ben West added a comment -

        I would prefer HBASE-5548 as well. Fine with closing this.

        Show
        xodarap Ben West added a comment - I would prefer HBASE-5548 as well. Fine with closing this.
        Hide
        jesse_yates Jesse Yates added a comment -

        Thanks for taking a look Ben (and being cool with the reversion).

        Show
        jesse_yates Jesse Yates added a comment - Thanks for taking a look Ben (and being cool with the reversion).
        Hide
        lhofhansl Lars Hofhansl added a comment -

        Made versions reflect the comments. Closing this issue.

        Show
        lhofhansl Lars Hofhansl added a comment - Made versions reflect the comments. Closing this issue.
        Hide
        zhihyu@ebaysf.com Ted Yu added a comment -

        The reversion didn't happen, right ?

        This would be in conflict with Jesse's current work.

        Show
        zhihyu@ebaysf.com Ted Yu added a comment - The reversion didn't happen, right ? This would be in conflict with Jesse's current work.
        Hide
        jesse_yates Jesse Yates added a comment -

        It wouldn't conflict necessarily, as I can just revert it in the next version - the one liner is not a big deal

        Show
        jesse_yates Jesse Yates added a comment - It wouldn't conflict necessarily, as I can just revert it in the next version - the one liner is not a big deal
        Hide
        lhofhansl Lars Hofhansl added a comment -

        Oh right. It was commited to 0.92, 0.94, and trunk.

        Show
        lhofhansl Lars Hofhansl added a comment - Oh right. It was commited to 0.92, 0.94, and trunk.
        Hide
        lhofhansl Lars Hofhansl added a comment - - edited

        Let's just mark this one fixed.
        Jesse will revert with his changes (in 0.94+) if necessary.

        Show
        lhofhansl Lars Hofhansl added a comment - - edited Let's just mark this one fixed. Jesse will revert with his changes (in 0.94+) if necessary.

          People

          • Assignee:
            xodarap Ben West
            Reporter:
            xodarap Ben West
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development