HBase
  1. HBase
  2. HBASE-5588

Deprecate/remove AssignmentManager#clearRegionFromTransition

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.90.5, 0.92.0, 0.94.0, 0.95.2
    • Fix Version/s: 0.94.0, 0.95.0
    • Component/s: hbck
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      This method is essentially a dupe of Assignment#regionOffline. As suggested in early review of HBASE-5128 - deprecate up to 0.94 and remove from 0.96/trunk.

      1. hbase-5588.patch
        3 kB
        Jonathan Hsieh
      2. hbase-5588-0.90.patch
        3 kB
        Jonathan Hsieh
      3. hbase-5588-0.94.patch
        3 kB
        Jonathan Hsieh

        Issue Links

          Activity

          Jonathan Hsieh created issue -
          Jonathan Hsieh made changes -
          Field Original Value New Value
          Component/s hbck [ 12315702 ]
          Jonathan Hsieh made changes -
          Assignee Jonathan Hsieh [ jmhsieh ]
          Hide
          Jonathan Hsieh added a comment -

          hbase-5588.patch removes clearRegionFromTransition
          hbase-5588-0.94.patch deprecates and is also applicable to 0.92
          hbase-5588-0.90.patch deprecates.

          Show
          Jonathan Hsieh added a comment - hbase-5588.patch removes clearRegionFromTransition hbase-5588-0.94.patch deprecates and is also applicable to 0.92 hbase-5588-0.90.patch deprecates.
          Jonathan Hsieh made changes -
          Attachment hbase-5588.patch [ 12518690 ]
          Attachment hbase-5588-0.94.patch [ 12518691 ]
          Attachment hbase-5588-0.90.patch [ 12518692 ]
          Hide
          Jonathan Hsieh added a comment -

          Suite against the four versions is running.

          Show
          Jonathan Hsieh added a comment - Suite against the four versions is running.
          Jonathan Hsieh made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12518692/hbase-5588-0.90.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1205//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12518692/hbase-5588-0.90.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1205//console This message is automatically generated.
          Hide
          Ted Yu added a comment -

          +1 on patches.

          Hopefully Hadoop QA can pick up hbase-5588.patch

          Show
          Ted Yu added a comment - +1 on patches. Hopefully Hadoop QA can pick up hbase-5588.patch
          Hide
          Jonathan Hsieh added a comment -

          I submitted them all together so it seems hadoopqa has gotten confused. I'm running all the test against all the versions currently, will commit if the come back cleanly.

          Show
          Jonathan Hsieh added a comment - I submitted them all together so it seems hadoopqa has gotten confused. I'm running all the test against all the versions currently, will commit if the come back cleanly.
          Hide
          stack added a comment -

          +1 on patch set

          Show
          stack added a comment - +1 on patch set
          Jonathan Hsieh made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags Reviewed [ 10343 ]
          Fix Version/s 0.90.7 [ 12319481 ]
          Fix Version/s 0.92.2 [ 12319888 ]
          Fix Version/s 0.94.0 [ 12316419 ]
          Fix Version/s 0.96.0 [ 12320040 ]
          Resolution Fixed [ 1 ]
          Hide
          Jonathan Hsieh added a comment -

          Tests came back clean (or tests that failed were run locally and passed). Committed to 0.90/0.92/0.94/0.96. Thanks for reviews stack + ted.

          Show
          Jonathan Hsieh added a comment - Tests came back clean (or tests that failed were run locally and passed). Committed to 0.90/0.92/0.94/0.96. Thanks for reviews stack + ted.
          Jonathan Hsieh made changes -
          Parent HBASE-5128 [ 12537273 ]
          Issue Type Sub-task [ 7 ] Improvement [ 4 ]
          Jonathan Hsieh made changes -
          Link This issue is required by HBASE-5128 [ HBASE-5128 ]
          Hide
          Hudson added a comment -

          Integrated in HBase-0.94 #39 (See https://builds.apache.org/job/HBase-0.94/39/)
          HBASE-5588 Deprecate/remove AssignmentManager#clearRegionFromTransition (Revision 1301884)

          Result = SUCCESS
          jmhsieh :
          Files :

          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
          Show
          Hudson added a comment - Integrated in HBase-0.94 #39 (See https://builds.apache.org/job/HBase-0.94/39/ ) HBASE-5588 Deprecate/remove AssignmentManager#clearRegionFromTransition (Revision 1301884) Result = SUCCESS jmhsieh : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK-security #141 (See https://builds.apache.org/job/HBase-TRUNK-security/141/)
          HBASE-5588 Deprecate/remove AssignmentManager#clearRegionFromTransition (Revision 1301885)

          Result = FAILURE
          jmhsieh :
          Files :

          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
          Show
          Hudson added a comment - Integrated in HBase-TRUNK-security #141 (See https://builds.apache.org/job/HBase-TRUNK-security/141/ ) HBASE-5588 Deprecate/remove AssignmentManager#clearRegionFromTransition (Revision 1301885) Result = FAILURE jmhsieh : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
          Lars Hofhansl made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          stack made changes -
          Fix Version/s 0.95.0 [ 12324094 ]
          Fix Version/s 0.94.0 [ 12316419 ]
          Fix Version/s 0.90.7 [ 12319481 ]
          Fix Version/s 0.92.2 [ 12319888 ]
          Fix Version/s 0.96.0 [ 12320040 ]
          Lars Hofhansl made changes -
          Fix Version/s 0.94.0 [ 12316419 ]

            People

            • Assignee:
              Jonathan Hsieh
              Reporter:
              Jonathan Hsieh
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development