Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-5577

improve 'patch submission' section in HBase book

    Details

    • Hadoop Flags:
      Reviewed

      Description

      Improve patch section in the book http://hbase.apache.org/book/submitting.patches.html

      1. HBASE_5577-v3.patch
        6 kB
        Sujee Maniyam
      2. HBASE-5577-v1.txt
        2 kB
        Sujee Maniyam
      3. HBASE-5577-v2.txt
        2 kB
        Sujee Maniyam

        Activity

        Hide
        sujee Sujee Maniyam added a comment -

        submitting HBASE-5577-v2.txt

        Show
        sujee Sujee Maniyam added a comment - submitting HBASE-5577 -v2.txt
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12520210/HBASE-5577-v2.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +0 tests included. The patch appears to be a documentation patch that doesn't require tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1324//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12520210/HBASE-5577-v2.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1324//console This message is automatically generated.
        Hide
        sujee Sujee Maniyam added a comment -

        hmm, looks like build system is trying to apply this 'patch' against trunk.
        should I have pasted the doc-changes, in the comment section?

        Show
        sujee Sujee Maniyam added a comment - hmm, looks like build system is trying to apply this 'patch' against trunk. should I have pasted the doc-changes, in the comment section?
        Hide
        jmhsieh Jonathan Hsieh added a comment -

        Sujee – ideally you'd modify the docs source code – I believe the files is src/docbkx/developer.xml – and submit a patch.

        Show
        jmhsieh Jonathan Hsieh added a comment - Sujee – ideally you'd modify the docs source code – I believe the files is src/docbkx/developer.xml – and submit a patch.
        Hide
        jmspaggi Jean-Marc Spaggiari added a comment -

        I recommand to close this issue. The documentation changed a lot since this was opened. The modifications proposed in the attached files are almost already all there and are not really applicable anymore in this format. So I don't think there is much doable with/for this issue.

        Show
        jmspaggi Jean-Marc Spaggiari added a comment - I recommand to close this issue. The documentation changed a lot since this was opened. The modifications proposed in the attached files are almost already all there and are not really applicable anymore in this format. So I don't think there is much doable with/for this issue.
        Hide
        sujee Sujee Maniyam added a comment -

        actual docbooks edits

        Show
        sujee Sujee Maniyam added a comment - actual docbooks edits
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12580199/HBASE_5577-v3.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +0 tests included. The patch appears to be a documentation patch that doesn't require tests.

        +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 lineLengths. The patch introduces lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5423//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5423//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5423//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5423//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5423//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5423//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5423//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5423//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5423//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5423//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12580199/HBASE_5577-v3.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +0 tests included . The patch appears to be a documentation patch that doesn't require tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5423//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5423//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5423//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5423//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5423//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5423//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5423//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5423//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5423//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5423//console This message is automatically generated.
        Hide
        stack stack added a comment -

        Excellent. Thanks Sujee. Committed to trunk. Will show on site next time we regen it.

        Show
        stack stack added a comment - Excellent. Thanks Sujee. Committed to trunk. Will show on site next time we regen it.
        Hide
        hudson Hudson added a comment -

        Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #508 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/508/)
        HBASE-5577 improve 'patch submission' section in HBase book (Revision 1471252)

        Result = FAILURE
        stack :
        Files :

        • /hbase/trunk/src/main/docbkx/developer.xml
        Show
        hudson Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #508 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/508/ ) HBASE-5577 improve 'patch submission' section in HBase book (Revision 1471252) Result = FAILURE stack : Files : /hbase/trunk/src/main/docbkx/developer.xml
        Hide
        hudson Hudson added a comment -

        Integrated in HBase-TRUNK #4077 (See https://builds.apache.org/job/HBase-TRUNK/4077/)
        HBASE-5577 improve 'patch submission' section in HBase book (Revision 1471252)

        Result = FAILURE
        stack :
        Files :

        • /hbase/trunk/src/main/docbkx/developer.xml
        Show
        hudson Hudson added a comment - Integrated in HBase-TRUNK #4077 (See https://builds.apache.org/job/HBase-TRUNK/4077/ ) HBASE-5577 improve 'patch submission' section in HBase book (Revision 1471252) Result = FAILURE stack : Files : /hbase/trunk/src/main/docbkx/developer.xml

          People

          • Assignee:
            sujee Sujee Maniyam
            Reporter:
            sujee Sujee Maniyam
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development