HBase
  1. HBase
  2. HBASE-5575

Configure Arcanist lint engine for HBase

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.95.0
    • Component/s: build
    • Labels:
      None

      Description

      We need to enable Arcanist lint engine in HBase, so that a commit could be checked by running "arc lint".

        Issue Links

          Activity

          Hide
          stack added a comment -

          Marking closed.

          Show
          stack added a comment - Marking closed.
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK-security #140 (See https://builds.apache.org/job/HBase-TRUNK-security/140/)
          [jira] HBASE-5575 Configure Arcanist lint engine for HBase

          Summary: Adding Java lint engine to HBase's .arcconfig. The lint engine itself
          is part of the arc-jira repository that lives at
          https://github.com/facebook/arc-jira/. There are some changes to be made there
          to prevent lint from reporting errors for unmodified lines.

          Test Plan: arc lint

          Reviewers: nspiegelberg, Kannan, Karthik, JIRA, Liyin

          Reviewed By: Liyin

          Differential Revision: https://reviews.facebook.net/D2289 (Revision 1301751)

          Result = SUCCESS
          mbautin :
          Files :

          • /hbase/trunk/.arcconfig
          Show
          Hudson added a comment - Integrated in HBase-TRUNK-security #140 (See https://builds.apache.org/job/HBase-TRUNK-security/140/ ) [jira] HBASE-5575 Configure Arcanist lint engine for HBase Summary: Adding Java lint engine to HBase's .arcconfig. The lint engine itself is part of the arc-jira repository that lives at https://github.com/facebook/arc-jira/ . There are some changes to be made there to prevent lint from reporting errors for unmodified lines. Test Plan: arc lint Reviewers: nspiegelberg, Kannan, Karthik, JIRA, Liyin Reviewed By: Liyin Differential Revision: https://reviews.facebook.net/D2289 (Revision 1301751) Result = SUCCESS mbautin : Files : /hbase/trunk/.arcconfig
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK #2686 (See https://builds.apache.org/job/HBase-TRUNK/2686/)
          [jira] HBASE-5575 Configure Arcanist lint engine for HBase

          Summary: Adding Java lint engine to HBase's .arcconfig. The lint engine itself
          is part of the arc-jira repository that lives at
          https://github.com/facebook/arc-jira/. There are some changes to be made there
          to prevent lint from reporting errors for unmodified lines.

          Test Plan: arc lint

          Reviewers: nspiegelberg, Kannan, Karthik, JIRA, Liyin

          Reviewed By: Liyin

          Differential Revision: https://reviews.facebook.net/D2289 (Revision 1301751)

          Result = SUCCESS
          mbautin :
          Files :

          • /hbase/trunk/.arcconfig
          Show
          Hudson added a comment - Integrated in HBase-TRUNK #2686 (See https://builds.apache.org/job/HBase-TRUNK/2686/ ) [jira] HBASE-5575 Configure Arcanist lint engine for HBase Summary: Adding Java lint engine to HBase's .arcconfig. The lint engine itself is part of the arc-jira repository that lives at https://github.com/facebook/arc-jira/ . There are some changes to be made there to prevent lint from reporting errors for unmodified lines. Test Plan: arc lint Reviewers: nspiegelberg, Kannan, Karthik, JIRA, Liyin Reviewed By: Liyin Differential Revision: https://reviews.facebook.net/D2289 (Revision 1301751) Result = SUCCESS mbautin : Files : /hbase/trunk/.arcconfig
          Hide
          Phabricator added a comment -

          mbautin has committed the revision "[jira] HBASE-5575 Configure Arcanist lint engine for HBase".

          REVISION DETAIL
          https://reviews.facebook.net/D2289

          COMMIT
          https://reviews.facebook.net/rHBASE1301751

          Show
          Phabricator added a comment - mbautin has committed the revision " [jira] HBASE-5575 Configure Arcanist lint engine for HBase". REVISION DETAIL https://reviews.facebook.net/D2289 COMMIT https://reviews.facebook.net/rHBASE1301751
          Hide
          Mikhail Bautin added a comment -

          Committed to trunk.

          Show
          Mikhail Bautin added a comment - Committed to trunk.
          Hide
          Mikhail Bautin added a comment -
          Show
          Mikhail Bautin added a comment - Reviewed at https://reviews.facebook.net/D2289 .
          Hide
          Nicolas Spiegelberg added a comment -

          +1. This should make every patch writer's job easier and committers can run 'arc lint' before checkin instead of having to focus on style issues during peer review.

          Show
          Nicolas Spiegelberg added a comment - +1. This should make every patch writer's job easier and committers can run 'arc lint' before checkin instead of having to focus on style issues during peer review.

            People

            • Assignee:
              Mikhail Bautin
              Reporter:
              Mikhail Bautin
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development