HBase
  1. HBase
  2. HBASE-5563

HRegionInfo#compareTo should compare regionId as well

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.90.5, 0.92.0, 0.94.0, 0.95.2
    • Fix Version/s: 0.94.0, 0.95.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In the one region multi assigned case, we could find that two regions have the same table name, same startKey, same endKey, and different regionId, so these two regions are same in TreeMap but different in HashMap.

      1. hbase-5563-0.90.patch
        3 kB
        Jonathan Hsieh
      2. hbase-5563-v3-0.92.patch
        3 kB
        Jonathan Hsieh
      3. hbase-5563-v3.patch
        3 kB
        Jonathan Hsieh
      4. HBASE-5563v2.patch
        0.6 kB
        stack
      5. HBASE-5563v2.patch
        0.6 kB
        chunhui shen
      6. HBASE-5563.patch
        0.6 kB
        chunhui shen

        Issue Links

          Activity

          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12517985/HBASE-5563.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 javadoc. The javadoc tool appears to have generated -123 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 159 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.master.TestRollingRestart
          org.apache.hadoop.hbase.io.hfile.TestLruBlockCache
          org.apache.hadoop.hbase.coprocessor.TestClassLoading
          org.apache.hadoop.hbase.client.TestAdmin
          org.apache.hadoop.hbase.master.TestDistributedLogSplitting
          org.apache.hadoop.hbase.client.TestShell
          org.apache.hadoop.hbase.master.TestMasterRestartAfterDisablingTable
          org.apache.hadoop.hbase.coprocessor.TestRegionObserverInterface
          org.apache.hadoop.hbase.mapreduce.TestImportTsv
          org.apache.hadoop.hbase.mapred.TestTableMapReduce
          org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1163//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1163//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1163//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12517985/HBASE-5563.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javadoc. The javadoc tool appears to have generated -123 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 159 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.master.TestRollingRestart org.apache.hadoop.hbase.io.hfile.TestLruBlockCache org.apache.hadoop.hbase.coprocessor.TestClassLoading org.apache.hadoop.hbase.client.TestAdmin org.apache.hadoop.hbase.master.TestDistributedLogSplitting org.apache.hadoop.hbase.client.TestShell org.apache.hadoop.hbase.master.TestMasterRestartAfterDisablingTable org.apache.hadoop.hbase.coprocessor.TestRegionObserverInterface org.apache.hadoop.hbase.mapreduce.TestImportTsv org.apache.hadoop.hbase.mapred.TestTableMapReduce org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1163//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1163//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1163//console This message is automatically generated.
          Hide
          stack added a comment -

          Both regions were online?

          Does this patch make the newest made region – the one with the larger regionid – sort AFTER the region with the lesser regionid? I think it does but am not sure.

          +1 on this patch...

          Show
          stack added a comment - Both regions were online? Does this patch make the newest made region – the one with the larger regionid – sort AFTER the region with the lesser regionid? I think it does but am not sure. +1 on this patch...
          Hide
          stack added a comment -

          Although, thats a bunch of failures. Want to retry your patch against hadoopqa again Chunhui? Or try the build locally. Do you see the same amount of failures?

          Show
          stack added a comment - Although, thats a bunch of failures. Want to retry your patch against hadoopqa again Chunhui? Or try the build locally. Do you see the same amount of failures?
          Hide
          chunhui shen added a comment -

          @stack
          Because of some bug, we find same region assigned twice on two RS, however these two regions will both be splitted and the new four regions has the same startKey and endKey, caused serious unconsistent.

          I find the one with the larger regionid should sort before the region with the lesser regionid, otherwise AssignmentManager#getRegionsOfTable() will return error regions.

          Could run hadoopqa with patchv2 again?
          Thanks.

          Show
          chunhui shen added a comment - @stack Because of some bug, we find same region assigned twice on two RS, however these two regions will both be splitted and the new four regions has the same startKey and endKey, caused serious unconsistent. I find the one with the larger regionid should sort before the region with the lesser regionid, otherwise AssignmentManager#getRegionsOfTable() will return error regions. Could run hadoopqa with patchv2 again? Thanks.
          Hide
          stack added a comment -

          I just saw that this fix shows up in Jonathon's hbck fixup for similar reasons you cite above. Let me try it in hadoopqa again.

          Show
          stack added a comment - I just saw that this fix shows up in Jonathon's hbck fixup for similar reasons you cite above. Let me try it in hadoopqa again.
          Hide
          stack added a comment -

          Retry of v2 patch against hadoopqa.

          Show
          stack added a comment - Retry of v2 patch against hadoopqa.
          Hide
          Jonathan Hsieh added a comment -

          @chunhui

          Check out the review patch in HBASE-5128 (its big but in there) – there is a fix for TestRegionObserverInterface in that patch which can probably go over here. We need to look into the other faliures as well (the one I fixed was a Medium test – the others are likely Large tests that aren't run until small and medium pass)

          Show
          Jonathan Hsieh added a comment - @chunhui Check out the review patch in HBASE-5128 (its big but in there) – there is a fix for TestRegionObserverInterface in that patch which can probably go over here. We need to look into the other faliures as well (the one I fixed was a Medium test – the others are likely Large tests that aren't run until small and medium pass)
          Hide
          chunhui shen added a comment -

          @Jonathan
          I have seen HBASE-5128. So we could close this issue.
          Thanks.

          Show
          chunhui shen added a comment - @Jonathan I have seen HBASE-5128 . So we could close this issue. Thanks.
          Hide
          Jonathan Hsieh added a comment -

          @Chenhui – lets keep this open amd take care of this issue particular here. The HBASE-5128 is too big already and this a more manageable hunk to review / commit.

          I'm starting to hunt down the failures new – I think TestClassLoading is intermittent.

          Show
          Jonathan Hsieh added a comment - @Chenhui – lets keep this open amd take care of this issue particular here. The HBASE-5128 is too big already and this a more manageable hunk to review / commit. I'm starting to hunt down the failures new – I think TestClassLoading is intermittent.
          Hide
          Jonathan Hsieh added a comment -

          A bunch of the failures have been fixed with this addition, but there are a still a few remaining to hunt down.

          diff --git a/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
          index 479861d..cad4314 100644
          --- a/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
          +++ b/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
          @@ -2705,8 +2705,10 @@ public class AssignmentManager extends ZooKeeperListener 
              */
             public List<HRegionInfo> getRegionsOfTable(byte[] tableName) {
               List<HRegionInfo> tableRegions = new ArrayList<HRegionInfo>();
          +    // boundary needs to have table's name but regionID 0 so that it is sorted 
          +    // before all table's regions.
               HRegionInfo boundary =
          -      new HRegionInfo(tableName, null, null);
          +      new HRegionInfo(tableName, null, null, false, 0L);
               synchronized (this.regions) {
                 for (HRegionInfo regionInfo: this.regions.tailMap(boundary).keySet()) {
                   if(Bytes.equals(regionInfo.getTableName(), tableName)) {
          
          Show
          Jonathan Hsieh added a comment - A bunch of the failures have been fixed with this addition, but there are a still a few remaining to hunt down. diff --git a/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java index 479861d..cad4314 100644 --- a/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java +++ b/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java @@ -2705,8 +2705,10 @@ public class AssignmentManager extends ZooKeeperListener */ public List<HRegionInfo> getRegionsOfTable( byte [] tableName) { List<HRegionInfo> tableRegions = new ArrayList<HRegionInfo>(); + // boundary needs to have table's name but regionID 0 so that it is sorted + // before all table's regions. HRegionInfo boundary = - new HRegionInfo(tableName, null , null ); + new HRegionInfo(tableName, null , null , false , 0L); synchronized ( this .regions) { for (HRegionInfo regionInfo: this .regions.tailMap(boundary).keySet()) { if (Bytes.equals(regionInfo.getTableName(), tableName)) {
          Hide
          Jonathan Hsieh added a comment -

          Hey Chenhui, looked at your code and had a question (similar to stack's) – did you intend to have newer regions (larger timestamps) sorted before older HRegionInfos? If so why? My intuition says to to have newer regions sorted after older ones. At the moment nothing depends on one order vs another, so I would like to add some simple unit tests to make the desired behavior this explicitly tested.

          Also, I have a few runs with the broken test passing now (a bunch of tests seem to be flakey on my setup).

          Show
          Jonathan Hsieh added a comment - Hey Chenhui, looked at your code and had a question (similar to stack's) – did you intend to have newer regions (larger timestamps) sorted before older HRegionInfos? If so why? My intuition says to to have newer regions sorted after older ones. At the moment nothing depends on one order vs another, so I would like to add some simple unit tests to make the desired behavior this explicitly tested. Also, I have a few runs with the broken test passing now (a bunch of tests seem to be flakey on my setup).
          Hide
          Jonathan Hsieh added a comment -

          Updated Patch to add test case and to fix broken test cases.

          Show
          Jonathan Hsieh added a comment - Updated Patch to add test case and to fix broken test cases.
          Hide
          Jonathan Hsieh added a comment -

          This patch also makes older regions smaller than newer regions (reversing chenhui's sort order). This makes fixing the test cases easier.

          Oddly, TestAdmin.testEnableTableRoundRobinAssignement seems to fail for me locally but pass in my jenkins test runners.

          Show
          Jonathan Hsieh added a comment - This patch also makes older regions smaller than newer regions (reversing chenhui's sort order). This makes fixing the test cases easier. Oddly, TestAdmin.testEnableTableRoundRobinAssignement seems to fail for me locally but pass in my jenkins test runners.
          Hide
          Jonathan Hsieh added a comment -

          This will probably be needed for hbck in HBASE-5128 for 0.92, 0.94, and trunk/0.96. It was not required for 0.90.x hbck updates.

          Show
          Jonathan Hsieh added a comment - This will probably be needed for hbck in HBASE-5128 for 0.92, 0.94, and trunk/0.96. It was not required for 0.90.x hbck updates.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12518565/hbase-5563-v3.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 161 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.regionserver.TestColumnSeeking

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1195//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1195//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1195//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12518565/hbase-5563-v3.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 161 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.TestColumnSeeking Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1195//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1195//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1195//console This message is automatically generated.
          Hide
          stack added a comment -

          +1 on committing everywhere, even into 0.92 (I've tagged RC0; if we do an RC1 it should be included. Mark fix in 0.92.2 I'd say for now)

          Show
          stack added a comment - +1 on committing everywhere, even into 0.92 (I've tagged RC0; if we do an RC1 it should be included. Mark fix in 0.92.2 I'd say for now)
          Hide
          stack added a comment -

          Does TestColumnSeeking work locally for you? This patch shouldn't matter for that test?

          Show
          stack added a comment - Does TestColumnSeeking work locally for you? This patch shouldn't matter for that test?
          Hide
          Jonathan Hsieh added a comment -

          TestColumnSeeking passes for me locally, first time its ever failed for me.

          jon@swoop:~/proj/hbase-trunk$ mvn test -PlocalTests -Dtest=TestColumnSeeking
          ..
          -------------------------------------------------------
           T E S T S
          -------------------------------------------------------
          Running org.apache.hadoop.hbase.regionserver.TestColumnSeeking
          Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 19.061 sec
          
          Results :
          
          Tests run: 2, Failures: 0, Errors: 0, Skipped: 0
          
          Show
          Jonathan Hsieh added a comment - TestColumnSeeking passes for me locally, first time its ever failed for me. jon@swoop:~/proj/hbase-trunk$ mvn test -PlocalTests -Dtest=TestColumnSeeking .. ------------------------------------------------------- T E S T S ------------------------------------------------------- Running org.apache.hadoop.hbase.regionserver.TestColumnSeeking Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 19.061 sec Results : Tests run: 2, Failures: 0, Errors: 0, Skipped: 0
          Hide
          Jonathan Hsieh added a comment -

          hbase-5563-v3.patch applies cleanly to 0.94 branch.

          Attached 0.92 version – it passes the trouble cases from v1/v2.

          Show
          Jonathan Hsieh added a comment - hbase-5563-v3.patch applies cleanly to 0.94 branch. Attached 0.92 version – it passes the trouble cases from v1/v2.
          Hide
          Jonathan Hsieh added a comment -

          I have full tests suites running for the trunk, 0.94, and 0.92 versions. If they come back clean, I'll commit first thing tommorrow am.

          Show
          Jonathan Hsieh added a comment - I have full tests suites running for the trunk, 0.94, and 0.92 versions. If they come back clean, I'll commit first thing tommorrow am.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12518570/hbase-5563-v3-0.92.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1196//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12518570/hbase-5563-v3-0.92.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1196//console This message is automatically generated.
          Hide
          chunhui shen added a comment -

          @Jonathan

          have newer regions (larger timestamps) sorted before older HRegionInfos? If so why? My intuition says to to have newer regions sorted after older ones.

          I just in order to make AssignmentManager#getRegionsOfTable() returns correct without changing it.

          Show
          chunhui shen added a comment - @Jonathan have newer regions (larger timestamps) sorted before older HRegionInfos? If so why? My intuition says to to have newer regions sorted after older ones. I just in order to make AssignmentManager#getRegionsOfTable() returns correct without changing it.
          Hide
          Jonathan Hsieh added a comment -

          @Chunhui

          I get it – we just didn't see the robot run the v2 to show that it fixed the problem.

          Are you ok with the newer patch (and test?) that fixes getRegionsOfTable? I think it is more intuitive since older HRI's with smaller datestamp/regionIds are smaller than newer HRI's with larger datestamp/regionIds.

          It's helpful to add comments and tests to show what you intend – hopefully the updated patch I provided makes it clear.

          Show
          Jonathan Hsieh added a comment - @Chunhui I get it – we just didn't see the robot run the v2 to show that it fixed the problem. Are you ok with the newer patch (and test?) that fixes getRegionsOfTable? I think it is more intuitive since older HRI's with smaller datestamp/regionIds are smaller than newer HRI's with larger datestamp/regionIds. It's helpful to add comments and tests to show what you intend – hopefully the updated patch I provided makes it clear.
          Hide
          Jonathan Hsieh added a comment -

          Tests came back clean or came back with failures that were intermittent but clean when run locally on all version.

          Show
          Jonathan Hsieh added a comment - Tests came back clean or came back with failures that were intermittent but clean when run locally on all version.
          Hide
          stack added a comment -

          +1 on patch for trunk and 0.92 (again). Older regionids should appear earlier in a sorted list than newer regionids as per this patch.

          Show
          stack added a comment - +1 on patch for trunk and 0.92 (again). Older regionids should appear earlier in a sorted list than newer regionids as per this patch.
          Hide
          Jonathan Hsieh added a comment -

          @stack @lars – 0.94 ok too?

          Show
          Jonathan Hsieh added a comment - @stack @lars – 0.94 ok too?
          Hide
          Jonathan Hsieh added a comment -

          Committed to 0.92/0.94/trunk. Thanks for initial patch chunhui, thanks for review stack.

          Show
          Jonathan Hsieh added a comment - Committed to 0.92/0.94/trunk. Thanks for initial patch chunhui, thanks for review stack.
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK #2686 (See https://builds.apache.org/job/HBase-TRUNK/2686/)
          HBASE-5563 Add comparison of regionId to HRegionInfo#compareTo (chunhui and jmhsieh) (Revision 1301779)

          Result = SUCCESS
          jmhsieh :
          Files :

          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java
          Show
          Hudson added a comment - Integrated in HBase-TRUNK #2686 (See https://builds.apache.org/job/HBase-TRUNK/2686/ ) HBASE-5563 Add comparison of regionId to HRegionInfo#compareTo (chunhui and jmhsieh) (Revision 1301779) Result = SUCCESS jmhsieh : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java
          Hide
          Hudson added a comment -

          Integrated in HBase-0.94 #37 (See https://builds.apache.org/job/HBase-0.94/37/)
          HBASE-5563 Add comparison of regionId to HRegionInfo#compareTo (chunhui and jmhsieh) (Revision 1301783)

          Result = SUCCESS
          jmhsieh :
          Files :

          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java
          Show
          Hudson added a comment - Integrated in HBase-0.94 #37 (See https://builds.apache.org/job/HBase-0.94/37/ ) HBASE-5563 Add comparison of regionId to HRegionInfo#compareTo (chunhui and jmhsieh) (Revision 1301783) Result = SUCCESS jmhsieh : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java
          Hide
          Hudson added a comment -

          Integrated in HBase-0.92 #325 (See https://builds.apache.org/job/HBase-0.92/325/)
          HBASE-5563 Addendum: Updating CHANGES.txt (Revision 1301782)
          HBASE-5563 Add comparison of regionId to HRegionInfo#compareTo (chunhui and jmhsieh) (Revision 1301780)

          Result = FAILURE
          jmhsieh :
          Files :

          • /hbase/branches/0.92/CHANGES.txt

          jmhsieh :
          Files :

          • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java
          • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
          • /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java
          Show
          Hudson added a comment - Integrated in HBase-0.92 #325 (See https://builds.apache.org/job/HBase-0.92/325/ ) HBASE-5563 Addendum: Updating CHANGES.txt (Revision 1301782) HBASE-5563 Add comparison of regionId to HRegionInfo#compareTo (chunhui and jmhsieh) (Revision 1301780) Result = FAILURE jmhsieh : Files : /hbase/branches/0.92/CHANGES.txt jmhsieh : Files : /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK-security #140 (See https://builds.apache.org/job/HBase-TRUNK-security/140/)
          HBASE-5563 Add comparison of regionId to HRegionInfo#compareTo (chunhui and jmhsieh) (Revision 1301779)

          Result = SUCCESS
          jmhsieh :
          Files :

          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java
          Show
          Hudson added a comment - Integrated in HBase-TRUNK-security #140 (See https://builds.apache.org/job/HBase-TRUNK-security/140/ ) HBASE-5563 Add comparison of regionId to HRegionInfo#compareTo (chunhui and jmhsieh) (Revision 1301779) Result = SUCCESS jmhsieh : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java
          Hide
          Jonathan Hsieh added a comment -

          The 0.90 version of this patch is required for 0.90 HBASE-5128's unit tests to pass consistently.

          Show
          Jonathan Hsieh added a comment - The 0.90 version of this patch is required for 0.90 HBASE-5128 's unit tests to pass consistently.
          Hide
          stack added a comment -

          +1 on committing it

          Show
          stack added a comment - +1 on committing it
          Hide
          Jonathan Hsieh added a comment -

          Committed to 0.90 branch as well. Thanks for review stack!

          Show
          Jonathan Hsieh added a comment - Committed to 0.90 branch as well. Thanks for review stack!

            People

            • Assignee:
              chunhui shen
              Reporter:
              chunhui shen
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development