HBase
  1. HBase
  2. HBASE-5552

Clean up our jmx view; its a bit of a mess

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.92.1, 0.94.0
    • Component/s: None
    • Labels:
      None

      Description

      Fix before we release 0.92.1

      1. patchedjmxview.png
        72 kB
        stack
      2. currentjmxview.png
        79 kB
        stack
      3. 5552.txt
        3 kB
        stack
      4. 0.92.0jmx.png
        199 kB
        stack

        Issue Links

          Activity

          stack created issue -
          Hide
          stack added a comment -

          This is a mess I for sure helped make.

          Here is 0.92.0 view.

          Its:

          hadoop
          HBase
          Master
          RegionServer

          ... which is wrong but thats how it is.

          Should have been....

          hadoop
          hbase
          Master
          RegionServer

          Show
          stack added a comment - This is a mess I for sure helped make. Here is 0.92.0 view. Its: hadoop HBase Master RegionServer ... which is wrong but thats how it is. Should have been.... hadoop hbase Master RegionServer
          stack made changes -
          Field Original Value New Value
          Attachment 0.92.0jmx.png [ 12517733 ]
          Hide
          stack added a comment -

          Let me fix formatting:

          hadoop
            HBase
            Master
            RegionServer
          

          It should be...

          hadoop
            hbase
              master
              regionserver
          
          Show
          stack added a comment - Let me fix formatting: hadoop HBase Master RegionServer It should be... hadoop hbase master regionserver
          Hide
          stack added a comment -

          As is, our naming is just broke. You can't have instances of different clusters on one machine. Our master bean is not uniquely named so you can't have multiple masters on the one machine.... ditto regionservers (The rpc servers publish their own bean distingushed by the port they run on which is better only should probably have master or regionserver prefix).

          The name of our master bean is 'MasterStatistics' though its metrics only (even the operation is a reset on metrics).

          Doing minimum so can get 0.92.1 in this issue but this stuff needs a revamp.

          Show
          stack added a comment - As is, our naming is just broke. You can't have instances of different clusters on one machine. Our master bean is not uniquely named so you can't have multiple masters on the one machine.... ditto regionservers (The rpc servers publish their own bean distingushed by the port they run on which is better only should probably have master or regionserver prefix). The name of our master bean is 'MasterStatistics' though its metrics only (even the operation is a reset on metrics). Doing minimum so can get 0.92.1 in this issue but this stuff needs a revamp.
          Hide
          stack added a comment -

          Here is the current 0.92 tip view. Its got the broke org.apache.hbase (which was my suggestion made w/o looking at the context into which I was suggesting... thought our beans pegged at root, not under hadoop which makes the suggestion silly).

          Show
          stack added a comment - Here is the current 0.92 tip view. Its got the broke org.apache.hbase (which was my suggestion made w/o looking at the context into which I was suggesting... thought our beans pegged at root, not under hadoop which makes the suggestion silly).
          stack made changes -
          Attachment currentjmxview.png [ 12517740 ]
          Hide
          stack added a comment -

          Here is what this patch does... it makes new beans Master and Regionserver which have Master and RegionServer vitals in them. They sit beside the statistics on each. I think this is what the lads over in hbase-5325 originally suggested and I thought it wrong – I still do.. but its less egregious that this o.a.h stuff)

          Show
          stack added a comment - Here is what this patch does... it makes new beans Master and Regionserver which have Master and RegionServer vitals in them. They sit beside the statistics on each. I think this is what the lads over in hbase-5325 originally suggested and I thought it wrong – I still do.. but its less egregious that this o.a.h stuff)
          stack made changes -
          Attachment patchedjmxview.png [ 12517741 ]
          stack made changes -
          Attachment 5552.txt [ 12517742 ]
          Hide
          stack added a comment -

          Committed small patch to 0.92, 0.94 and trunk. Only person I'm messing up is Benoit I believe (he amended tsdb to read beans in new location... will talk to him)

          Show
          stack added a comment - Committed small patch to 0.92, 0.94 and trunk. Only person I'm messing up is Benoit I believe (he amended tsdb to read beans in new location... will talk to him)
          stack made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Assignee stack [ stack ]
          Fix Version/s 0.92.1 [ 12318551 ]
          Fix Version/s 0.94.0 [ 12316419 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in HBase-0.94 #24 (See https://builds.apache.org/job/HBase-0.94/24/)
          HBASE-5552 Clean up our jmx view; its a bit of a mess (Revision 1298922)

          Result = SUCCESS
          stack :
          Files :

          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPCStatistics.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/HBaseInfo.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
          Show
          Hudson added a comment - Integrated in HBase-0.94 #24 (See https://builds.apache.org/job/HBase-0.94/24/ ) HBASE-5552 Clean up our jmx view; its a bit of a mess (Revision 1298922) Result = SUCCESS stack : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPCStatistics.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/HMaster.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/HBaseInfo.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
          Hide
          Todd Lipcon added a comment -

          Changing the nesting of beans in 0.92 and 0.94 seems like an incompatible change. I'm pretty sure it will screw up our monitoring upon upgrade (Benoit isn't the only one who uses JMX!) Is it possible to have a conf to switch this? Otherwise, should defer to 96.

          Show
          Todd Lipcon added a comment - Changing the nesting of beans in 0.92 and 0.94 seems like an incompatible change. I'm pretty sure it will screw up our monitoring upon upgrade (Benoit isn't the only one who uses JMX!) Is it possible to have a conf to switch this? Otherwise, should defer to 96.
          Todd Lipcon made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Todd Lipcon made changes -
          Hadoop Flags Incompatible change [ 10342 ]
          Hide
          stack added a comment -

          Its not incompatible change Todd because we've not had a release w/ these new mbeans yet.

          On the rename, yeah, over in 'HBASE-5553 Revisit our jmx view', it suggests we'd have to wait till the singularity.

          Show
          stack added a comment - Its not incompatible change Todd because we've not had a release w/ these new mbeans yet. On the rename, yeah, over in ' HBASE-5553 Revisit our jmx view', it suggests we'd have to wait till the singularity.
          Hide
          Todd Lipcon added a comment -

          Oh, does this not affect the other metrics published at /jmx in the servlet? Sorry for confusion.

          Show
          Todd Lipcon added a comment - Oh, does this not affect the other metrics published at /jmx in the servlet? Sorry for confusion.
          Hide
          Hudson added a comment -

          Integrated in HBase-0.92 #323 (See https://builds.apache.org/job/HBase-0.92/323/)
          HBASE-5552 Clean up our jmx view; its a bit of a mess (Revision 1298924)
          HBASE-5552 Clean up our jmx view; its a bit of a mess (Revision 1298919)

          Result = SUCCESS
          stack :
          Files :

          • /hbase/branches/0.92/CHANGES.txt

          stack :
          Files :

          • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPCStatistics.java
          • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
          • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/metrics/HBaseInfo.java
          • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
          Show
          Hudson added a comment - Integrated in HBase-0.92 #323 (See https://builds.apache.org/job/HBase-0.92/323/ ) HBASE-5552 Clean up our jmx view; its a bit of a mess (Revision 1298924) HBASE-5552 Clean up our jmx view; its a bit of a mess (Revision 1298919) Result = SUCCESS stack : Files : /hbase/branches/0.92/CHANGES.txt stack : Files : /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPCStatistics.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/master/HMaster.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/metrics/HBaseInfo.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
          Hide
          stack added a comment -

          Oh, does this not affect the other metrics published at /jmx in the servlet? Sorry for confusion.

          It should, but it doesn't (smile). Its just a renaming of the beans added by HBASE-5325 (0.92.1 is their first airing in a release).

          I should have been more clear.

          Show
          stack added a comment - Oh, does this not affect the other metrics published at /jmx in the servlet? Sorry for confusion. It should, but it doesn't (smile). Its just a renaming of the beans added by HBASE-5325 (0.92.1 is their first airing in a release). I should have been more clear.
          Hide
          Hudson added a comment -

          Integrated in HBase-0.92-security #102 (See https://builds.apache.org/job/HBase-0.92-security/102/)
          HBASE-5552 Clean up our jmx view; its a bit of a mess (Revision 1298924)
          HBASE-5552 Clean up our jmx view; its a bit of a mess (Revision 1298919)

          Result = SUCCESS
          stack :
          Files :

          • /hbase/branches/0.92/CHANGES.txt

          stack :
          Files :

          • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPCStatistics.java
          • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
          • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/metrics/HBaseInfo.java
          • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
          Show
          Hudson added a comment - Integrated in HBase-0.92-security #102 (See https://builds.apache.org/job/HBase-0.92-security/102/ ) HBASE-5552 Clean up our jmx view; its a bit of a mess (Revision 1298924) HBASE-5552 Clean up our jmx view; its a bit of a mess (Revision 1298919) Result = SUCCESS stack : Files : /hbase/branches/0.92/CHANGES.txt stack : Files : /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPCStatistics.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/master/HMaster.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/metrics/HBaseInfo.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
          Hide
          stack added a comment -

          Committed to 0.92, 0.94, and trunk

          Show
          stack added a comment - Committed to 0.92, 0.94, and trunk
          stack made changes -
          Status Reopened [ 4 ] Resolved [ 5 ]
          Hadoop Flags Incompatible change [ 10342 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK-security #133 (See https://builds.apache.org/job/HBase-TRUNK-security/133/)
          HBASE-5552 Clean up our jmx view; its a bit of a mess (Revision 1298923)

          Result = FAILURE
          stack :
          Files :

          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPCStatistics.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/metrics/HBaseInfo.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
          Show
          Hudson added a comment - Integrated in HBase-TRUNK-security #133 (See https://builds.apache.org/job/HBase-TRUNK-security/133/ ) HBASE-5552 Clean up our jmx view; its a bit of a mess (Revision 1298923) Result = FAILURE stack : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPCStatistics.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/metrics/HBaseInfo.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK #2676 (See https://builds.apache.org/job/HBase-TRUNK/2676/)
          HBASE-5552 Clean up our jmx view; its a bit of a mess (Revision 1298923)

          Result = FAILURE
          stack :
          Files :

          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPCStatistics.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/metrics/HBaseInfo.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
          Show
          Hudson added a comment - Integrated in HBase-TRUNK #2676 (See https://builds.apache.org/job/HBase-TRUNK/2676/ ) HBASE-5552 Clean up our jmx view; its a bit of a mess (Revision 1298923) Result = FAILURE stack : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPCStatistics.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/metrics/HBaseInfo.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
          Jeff Hammerbacher made changes -
          Link This issue relates to HBASE-5325 [ HBASE-5325 ]
          Jeff Hammerbacher made changes -
          Link This issue is related to HBASE-5553 [ HBASE-5553 ]
          Lars Hofhansl made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Resolved Resolved
          1h 13m 1 stack 09/Mar/12 16:55
          Resolved Resolved Reopened Reopened
          53m 46s 1 Todd Lipcon 09/Mar/12 17:49
          Reopened Reopened Resolved Resolved
          3h 57m 1 stack 09/Mar/12 21:47
          Resolved Resolved Closed Closed
          216d 7h 47m 1 Lars Hofhansl 12/Oct/12 06:34

            People

            • Assignee:
              stack
              Reporter:
              stack
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development