HBase
  1. HBase
  2. HBASE-5525

Truncate and preserve region boundaries option

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.95.2
    • Fix Version/s: 0.95.1
    • Component/s: None
    • Labels:
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Adds 'truncate_preserve' to shell; removes all data but preserves region count and region boundaries
    • Tags:
      noob

      Description

      A tool that would be useful for testing (and maybe in prod too) would be a truncate option to keep the current region boundaries. Right now what you have to do is completely kill the table and recreate it with the correct regions.

      1. HBASE-5525.patch
        3 kB
        Kevin Odell
      2. HBASE-5525-v1-0.94.patch
        3 kB
        Jean-Marc Spaggiari
      3. HBASE-5525-v1-0.95.patch
        4 kB
        Jean-Marc Spaggiari
      4. HBASE-5525-v1-trunk.patch
        4 kB
        stack
      5. HBASE-5525-v1-trunk.patch
        4 kB
        Jean-Marc Spaggiari
      6. HBASE-5525-v1-trunk-addendum.patch
        0.9 kB
        Jean-Marc Spaggiari

        Activity

        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #518 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/518/)
        HBASE-5525 Truncate and preserve region boundaries option (Revision 1479778)

        Result = FAILURE
        stack :
        Files :

        • /hbase/trunk/hbase-server/src/main/ruby/hbase/admin.rb
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #518 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/518/ ) HBASE-5525 Truncate and preserve region boundaries option (Revision 1479778) Result = FAILURE stack : Files : /hbase/trunk/hbase-server/src/main/ruby/hbase/admin.rb
        Hide
        Hudson added a comment -

        Integrated in hbase-0.95-on-hadoop2 #89 (See https://builds.apache.org/job/hbase-0.95-on-hadoop2/89/)
        HBASE-5525 Truncate and preserve region boundaries option (Revision 1479779)

        Result = FAILURE
        stack :
        Files :

        • /hbase/branches/0.95/hbase-server/src/main/ruby/hbase/admin.rb
        Show
        Hudson added a comment - Integrated in hbase-0.95-on-hadoop2 #89 (See https://builds.apache.org/job/hbase-0.95-on-hadoop2/89/ ) HBASE-5525 Truncate and preserve region boundaries option (Revision 1479779) Result = FAILURE stack : Files : /hbase/branches/0.95/hbase-server/src/main/ruby/hbase/admin.rb
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #4100 (See https://builds.apache.org/job/HBase-TRUNK/4100/)
        HBASE-5525 Truncate and preserve region boundaries option (Revision 1479778)

        Result = FAILURE
        stack :
        Files :

        • /hbase/trunk/hbase-server/src/main/ruby/hbase/admin.rb
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #4100 (See https://builds.apache.org/job/HBase-TRUNK/4100/ ) HBASE-5525 Truncate and preserve region boundaries option (Revision 1479778) Result = FAILURE stack : Files : /hbase/trunk/hbase-server/src/main/ruby/hbase/admin.rb
        Hide
        Hudson added a comment -

        Integrated in hbase-0.95 #179 (See https://builds.apache.org/job/hbase-0.95/179/)
        HBASE-5525 Truncate and preserve region boundaries option (Revision 1479779)

        Result = SUCCESS
        stack :
        Files :

        • /hbase/branches/0.95/hbase-server/src/main/ruby/hbase/admin.rb
        Show
        Hudson added a comment - Integrated in hbase-0.95 #179 (See https://builds.apache.org/job/hbase-0.95/179/ ) HBASE-5525 Truncate and preserve region boundaries option (Revision 1479779) Result = SUCCESS stack : Files : /hbase/branches/0.95/hbase-server/src/main/ruby/hbase/admin.rb
        Hide
        stack added a comment -

        Committed addendum after poke by jd. Thanks for addition Jean-Marc Spaggiari

        Show
        stack added a comment - Committed addendum after poke by jd. Thanks for addition Jean-Marc Spaggiari
        Hide
        Jean-Marc Spaggiari added a comment -

        Addendum for trunk attached.

        Show
        Jean-Marc Spaggiari added a comment - Addendum for trunk attached.
        Hide
        stack added a comment -

        Jean-Marc Spaggiari Yes please. An addendum would be dandy.

        Ricky Saltzer Good catch boss. Thanks.

        Show
        stack added a comment - Jean-Marc Spaggiari Yes please. An addendum would be dandy. Ricky Saltzer Good catch boss. Thanks.
        Hide
        Jean-Marc Spaggiari added a comment -

        Good catch.

        I just tried the same patch by replacing getRegionsInfo by getRegionLocations and it's working fine.

        stack, do you want me to update the attached patchs?

        Show
        Jean-Marc Spaggiari added a comment - Good catch. I just tried the same patch by replacing getRegionsInfo by getRegionLocations and it's working fine. stack , do you want me to update the attached patchs?
        Hide
        Ricky Saltzer added a comment -

        Hey Guys -

        Is this patch using a deprecated API call? I was under the impression that getRegionsInfo() was deprecated and we should now use getRegionLocations()

        Line in question

        splits = h_table.getRegionsInfo().keys().map{|i| Bytes.toString(i.getStartKey)}.delete_if{|k| k == ""}.to_java :String
        

        Deprecated here -> https://hbase.apache.org/0.94/apidocs/org/apache/hadoop/hbase/client/HTable.html#getRegionsInfo()

        Missing here -> https://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/HTable.html

        Show
        Ricky Saltzer added a comment - Hey Guys - Is this patch using a deprecated API call? I was under the impression that getRegionsInfo() was deprecated and we should now use getRegionLocations() Line in question splits = h_table.getRegionsInfo().keys().map{|i| Bytes.toString(i.getStartKey)}.delete_if{|k| k == ""}.to_java :String Deprecated here -> https://hbase.apache.org/0.94/apidocs/org/apache/hadoop/hbase/client/HTable.html#getRegionsInfo( ) Missing here -> https://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/HTable.html
        Hide
        stack added a comment -

        Thanks lads for fixing my messup (just noticed missing file this morning but see you lot took care of it – thanks)

        Show
        stack added a comment - Thanks lads for fixing my messup (just noticed missing file this morning but see you lot took care of it – thanks)
        Hide
        Hudson added a comment -

        Integrated in hbase-0.95-on-hadoop2 #54 (See https://builds.apache.org/job/hbase-0.95-on-hadoop2/54/)
        HBASE-5525 Truncate and preserve region boundaries option, addendum (Revision 1464426)
        HBASE-5525 Truncate and preserve region boundaries option (Revision 1464291)

        Result = FAILURE
        mbertozzi :
        Files :

        • /hbase/branches/0.95/hbase-server/src/main/ruby/shell/commands/truncate_preserve.rb

        stack :
        Files :

        • /hbase/branches/0.95/hbase-server/src/main/ruby/hbase/admin.rb
        • /hbase/branches/0.95/hbase-server/src/main/ruby/shell.rb
        Show
        Hudson added a comment - Integrated in hbase-0.95-on-hadoop2 #54 (See https://builds.apache.org/job/hbase-0.95-on-hadoop2/54/ ) HBASE-5525 Truncate and preserve region boundaries option, addendum (Revision 1464426) HBASE-5525 Truncate and preserve region boundaries option (Revision 1464291) Result = FAILURE mbertozzi : Files : /hbase/branches/0.95/hbase-server/src/main/ruby/shell/commands/truncate_preserve.rb stack : Files : /hbase/branches/0.95/hbase-server/src/main/ruby/hbase/admin.rb /hbase/branches/0.95/hbase-server/src/main/ruby/shell.rb
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #476 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/476/)
        HBASE-5525 Truncate and preserve region boundaries option, addendum (Revision 1464425)
        HBASE-5525 Truncate and preserve region boundaries option (Revision 1464290)

        Result = FAILURE
        mbertozzi :
        Files :

        • /hbase/trunk/hbase-server/src/main/ruby/shell/commands/truncate_preserve.rb

        stack :
        Files :

        • /hbase/trunk/hbase-server/src/main/ruby/hbase/admin.rb
        • /hbase/trunk/hbase-server/src/main/ruby/shell.rb
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #476 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/476/ ) HBASE-5525 Truncate and preserve region boundaries option, addendum (Revision 1464425) HBASE-5525 Truncate and preserve region boundaries option (Revision 1464290) Result = FAILURE mbertozzi : Files : /hbase/trunk/hbase-server/src/main/ruby/shell/commands/truncate_preserve.rb stack : Files : /hbase/trunk/hbase-server/src/main/ruby/hbase/admin.rb /hbase/trunk/hbase-server/src/main/ruby/shell.rb
        Hide
        Hudson added a comment -

        Integrated in hbase-0.95 #123 (See https://builds.apache.org/job/hbase-0.95/123/)
        HBASE-5525 Truncate and preserve region boundaries option, addendum (Revision 1464426)

        Result = FAILURE
        mbertozzi :
        Files :

        • /hbase/branches/0.95/hbase-server/src/main/ruby/shell/commands/truncate_preserve.rb
        Show
        Hudson added a comment - Integrated in hbase-0.95 #123 (See https://builds.apache.org/job/hbase-0.95/123/ ) HBASE-5525 Truncate and preserve region boundaries option, addendum (Revision 1464426) Result = FAILURE mbertozzi : Files : /hbase/branches/0.95/hbase-server/src/main/ruby/shell/commands/truncate_preserve.rb
        Hide
        Jean-Marc Spaggiari added a comment -

        Matteo Bertozzi, I applied it locally to test it and it works fine. Patch for 0.94 is already attached. It's a very simple patch and useful for testing. So I think it should be applied to 0.94 too.

        Show
        Jean-Marc Spaggiari added a comment - Matteo Bertozzi , I applied it locally to test it and it works fine. Patch for 0.94 is already attached. It's a very simple patch and useful for testing. So I think it should be applied to 0.94 too.
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #4012 (See https://builds.apache.org/job/HBase-TRUNK/4012/)
        HBASE-5525 Truncate and preserve region boundaries option, addendum (Revision 1464425)

        Result = FAILURE
        mbertozzi :
        Files :

        • /hbase/trunk/hbase-server/src/main/ruby/shell/commands/truncate_preserve.rb
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #4012 (See https://builds.apache.org/job/HBase-TRUNK/4012/ ) HBASE-5525 Truncate and preserve region boundaries option, addendum (Revision 1464425) Result = FAILURE mbertozzi : Files : /hbase/trunk/hbase-server/src/main/ruby/shell/commands/truncate_preserve.rb
        Hide
        Matteo Bertozzi added a comment -

        I've committed the missing file in trunk and 95, so the shell should work again.

        Jean-Marc Spaggiari I don't see this patch in 94 yet, it should be backported?

        Show
        Matteo Bertozzi added a comment - I've committed the missing file in trunk and 95, so the shell should work again. Jean-Marc Spaggiari I don't see this patch in 94 yet, it should be backported?
        Hide
        Jean-Marc Spaggiari added a comment -

        I tested it on 0.94 and it's working fine. Let me know if you are experiencing any issue with the patch applied.

        Show
        Jean-Marc Spaggiari added a comment - I tested it on 0.94 and it's working fine. Let me know if you are experiencing any issue with the patch applied.
        Hide
        Matteo Bertozzi added a comment -

        The shell is now broken in 95/trunk hbase-server/src/main/ruby/shell/commands/truncate_preserve.rb was not added to the repo. I'll commit that.

        Show
        Matteo Bertozzi added a comment - The shell is now broken in 95/trunk hbase-server/src/main/ruby/shell/commands/truncate_preserve.rb was not added to the repo. I'll commit that.
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #4011 (See https://builds.apache.org/job/HBase-TRUNK/4011/)
        HBASE-5525 Truncate and preserve region boundaries option (Revision 1464290)

        Result = FAILURE
        stack :
        Files :

        • /hbase/trunk/hbase-server/src/main/ruby/hbase/admin.rb
        • /hbase/trunk/hbase-server/src/main/ruby/shell.rb
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #4011 (See https://builds.apache.org/job/HBase-TRUNK/4011/ ) HBASE-5525 Truncate and preserve region boundaries option (Revision 1464290) Result = FAILURE stack : Files : /hbase/trunk/hbase-server/src/main/ruby/hbase/admin.rb /hbase/trunk/hbase-server/src/main/ruby/shell.rb
        Hide
        rajeshbabu added a comment -

        @stack,
        truncate_preserve.rb(new file) in the patch is not committed by mistake.
        In some QA TestShell is failing

        Tests in error: 
          testRunShellTests(org.apache.hadoop.hbase.client.TestShell): (LoadError) no such file to load -- shell/commands/truncate_preserve
        
        Show
        rajeshbabu added a comment - @stack, truncate_preserve.rb(new file) in the patch is not committed by mistake. In some QA TestShell is failing Tests in error: testRunShellTests(org.apache.hadoop.hbase.client.TestShell): (LoadError) no such file to load -- shell/commands/truncate_preserve
        Hide
        Hudson added a comment -

        Integrated in hbase-0.95 #122 (See https://builds.apache.org/job/hbase-0.95/122/)
        HBASE-5525 Truncate and preserve region boundaries option (Revision 1464291)

        Result = FAILURE
        stack :
        Files :

        • /hbase/branches/0.95/hbase-server/src/main/ruby/hbase/admin.rb
        • /hbase/branches/0.95/hbase-server/src/main/ruby/shell.rb
        Show
        Hudson added a comment - Integrated in hbase-0.95 #122 (See https://builds.apache.org/job/hbase-0.95/122/ ) HBASE-5525 Truncate and preserve region boundaries option (Revision 1464291) Result = FAILURE stack : Files : /hbase/branches/0.95/hbase-server/src/main/ruby/hbase/admin.rb /hbase/branches/0.95/hbase-server/src/main/ruby/shell.rb
        Hide
        stack added a comment -

        Thanks for the patch lads. Applied to 0.95 branch and trunk.

        Show
        stack added a comment - Thanks for the patch lads. Applied to 0.95 branch and trunk.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12576911/HBASE-5525-v1-trunk.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 lineLengths. The patch introduces lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5128//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5128//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5128//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5128//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5128//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5128//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5128//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5128//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5128//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5128//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12576911/HBASE-5525-v1-trunk.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5128//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5128//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5128//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5128//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5128//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5128//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5128//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5128//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5128//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5128//console This message is automatically generated.
        Hide
        stack added a comment -

        Reapply trunk patch so it shows last and will be run instead of the 0.94 patch when I submit to hadoopqa

        Show
        stack added a comment - Reapply trunk patch so it shows last and will be run instead of the 0.94 patch when I submit to hadoopqa
        Hide
        Jean-Marc Spaggiari added a comment -

        And finally, version for 0.94. Just pickup the one you need...

        Show
        Jean-Marc Spaggiari added a comment - And finally, version for 0.94. Just pickup the one you need...
        Hide
        Jean-Marc Spaggiari added a comment -

        Rebased for trunk took...

        Show
        Jean-Marc Spaggiari added a comment - Rebased for trunk took...
        Hide
        Jean-Marc Spaggiari added a comment -

        0.95 Rebased patch attached

        Show
        Jean-Marc Spaggiari added a comment - 0.95 Rebased patch attached
        Hide
        Jean-Marc Spaggiari added a comment -

        Any chance to get it rebased and applied to 0.95?

        Show
        Jean-Marc Spaggiari added a comment - Any chance to get it rebased and applied to 0.95?
        Hide
        Kevin Odell added a comment -

        Great feedback I will work on that as soon as I have time.

        Show
        Kevin Odell added a comment - Great feedback I will work on that as soon as I have time.
        Hide
        Ricky Saltzer added a comment -

        +1 Greg, something like would be great, also updating the docs to reflect what

        truncate 'users_table', {PRESERVE => true}
        
        Show
        Ricky Saltzer added a comment - +1 Greg, something like would be great, also updating the docs to reflect what truncate 'users_table', {PRESERVE => true}
        Hide
        Ricky Saltzer added a comment -

        Would it make more sense to have one truncate command, and have an optional parameter which preserves the truncate? Rather than having a separate command for truncating and truncating while preserving region keys?

        Show
        Ricky Saltzer added a comment - Would it make more sense to have one truncate command, and have an optional parameter which preserves the truncate? Rather than having a separate command for truncating and truncating while preserving region keys?
        Hide
        Gregory Chanan added a comment -

        Looks pretty good.

        Maybe truncate_preservebounds instead of truncate_preserve (so it is clear what you are preserving)? Or make preserve a parameter to truncate, default false? (the later would be my personal preference).

        Also, you could avoid duplicating some code if you had truncate and truncate_preserve call a common function (or just have preserve be a parameter to truncate, as above).

        Show
        Gregory Chanan added a comment - Looks pretty good. Maybe truncate_preservebounds instead of truncate_preserve (so it is clear what you are preserving)? Or make preserve a parameter to truncate, default false? (the later would be my personal preference). Also, you could avoid duplicating some code if you had truncate and truncate_preserve call a common function (or just have preserve be a parameter to truncate, as above).
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12548513/HBASE-5525.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        -1 javadoc. The javadoc tool appears to have generated 81 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 5 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.client.TestFromClientSide

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3025//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3025//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3025//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3025//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3025//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3025//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3025//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12548513/HBASE-5525.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 81 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 findbugs . The patch appears to introduce 5 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.client.TestFromClientSide Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3025//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3025//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3025//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3025//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3025//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3025//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3025//console This message is automatically generated.
        Hide
        Kevin Odell added a comment -

        So I added a new command truncate_preserve, it seemed to fit with the flow of the other commands:

        disable_all
        disable_peer

        enable_all
        enable_peer

        alter
        alter_async
        alter_status

        I am not too attached to the name so I am open for suggestions. I tested this out by altering the ruby code on my box and it worked. Let me know if you see anything strange.

        Show
        Kevin Odell added a comment - So I added a new command truncate_preserve, it seemed to fit with the flow of the other commands: disable_all disable_peer enable_all enable_peer alter alter_async alter_status I am not too attached to the name so I am open for suggestions. I tested this out by altering the ruby code on my box and it worked. Let me know if you see anything strange.
        Hide
        stack added a comment -

        Out of 0.96.

        Show
        stack added a comment - Out of 0.96.
        Hide
        Jean-Daniel Cryans added a comment -

        Sounds like a plan, if by "remove all content from fs under the table's dir" you mean under the table's regions' dir.

        Show
        Jean-Daniel Cryans added a comment - Sounds like a plan, if by "remove all content from fs under the table's dir" you mean under the table's regions' dir.
        Hide
        stack added a comment -

        Disable table, remove all content from fs under the table's dir, then reenable?

        Show
        stack added a comment - Disable table, remove all content from fs under the table's dir, then reenable?

          People

          • Assignee:
            Kevin Odell
            Reporter:
            Jean-Daniel Cryans
          • Votes:
            0 Vote for this issue
            Watchers:
            13 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development