HBase
  1. HBase
  2. HBASE-5488

OfflineMetaRepair doesn't support hadoop 0.20's fs.default.name property

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.90.6
    • Fix Version/s: 0.94.0, 0.95.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      I want to use "OfflineMetaRepair" tools and found onbody fix this bugs. I will make a patch.

      > 12/01/05 23:23:30 ERROR util.HBaseFsck: Bailed out due to:
      > java.lang.IllegalArgumentException: Wrong FS: hdfs://
      > us01-ciqps1-name01.carrieriq.com:9000/hbase/M2M-INTEGRATION-MM_TION-13
      > 25190318714/0003d2ede27668737e192d8430dbe5d0/.regioninfo,
      > expected: file:///
      > at org.apache.hadoop.fs.FileSystem.checkPath(FileSystem.java:352)
      > at
      > org.apache.hadoop.fs.RawLocalFileSystem.pathToFile(RawLocalFileSystem.java:47)
      > at
      > org.apache.hadoop.fs.RawLocalFileSystem.getFileStatus(RawLocalFileSystem.java:368)
      > at
      > org.apache.hadoop.fs.FilterFileSystem.getFileStatus(FilterFileSystem.java:251)
      > at
      > org.apache.hadoop.fs.ChecksumFileSystem$ChecksumFSInputChecker.<init>(ChecksumFileSystem.java:126)
      > at
      > org.apache.hadoop.fs.ChecksumFileSystem.open(ChecksumFileSystem.java:284)
      > at org.apache.hadoop.fs.FileSystem.open(FileSystem.java:398)
      > at
      > org.apache.hadoop.hbase.util.HBaseFsck.loadMetaEntry(HBaseFsck.java:256)
      > at
      > org.apache.hadoop.hbase.util.HBaseFsck.loadTableInfo(HBaseFsck.java:284)
      > at
      > org.apache.hadoop.hbase.util.HBaseFsck.rebuildMeta(HBaseFsck.java:402)
      > at
      > org.apache.hadoop.hbase.util.hbck.OfflineMetaRepair.main(OfflineMetaRe

      1. hbase-5488-v2.patch
        1 kB
        Jonathan Hsieh
      2. HBASE-5488-trunk.patch
        1 kB
        gaojinchao
      3. HBASE-5488-branch92.patch
        1 kB
        gaojinchao
      4. HBASE-5488_branch90.txt
        1 kB
        gaojinchao

        Activity

        Hide
        Ted Yu added a comment -

        Patch looks good.

        Can you submit a patch for TRUNK ?

        Thanks

        Show
        Ted Yu added a comment - Patch looks good. Can you submit a patch for TRUNK ? Thanks
        Hide
        gaojinchao added a comment -

        patch for trunk

        Show
        gaojinchao added a comment - patch for trunk
        Hide
        gaojinchao added a comment -

        Thanks for your review.

        Show
        gaojinchao added a comment - Thanks for your review.
        Hide
        ramkrishna.s.vasudevan added a comment -

        Patch looks good. +1

        Show
        ramkrishna.s.vasudevan added a comment - Patch looks good. +1
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12516530/HBASE-5488-branch92.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 javadoc. The javadoc tool appears to have generated -131 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 155 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.mapreduce.TestImportTsv
        org.apache.hadoop.hbase.mapred.TestTableMapReduce
        org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1060//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1060//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1060//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12516530/HBASE-5488-branch92.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javadoc. The javadoc tool appears to have generated -131 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 155 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.mapreduce.TestImportTsv org.apache.hadoop.hbase.mapred.TestTableMapReduce org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1060//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1060//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1060//console This message is automatically generated.
        Hide
        stack added a comment -

        +1

        Show
        stack added a comment - +1
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12516530/HBASE-5488-branch92.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 javadoc. The javadoc tool appears to have generated -131 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 155 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
        org.apache.hadoop.hbase.mapred.TestTableMapReduce
        org.apache.hadoop.hbase.mapreduce.TestImportTsv

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1063//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1063//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1063//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12516530/HBASE-5488-branch92.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javadoc. The javadoc tool appears to have generated -131 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 155 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat org.apache.hadoop.hbase.mapred.TestTableMapReduce org.apache.hadoop.hbase.mapreduce.TestImportTsv Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1063//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1063//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1063//console This message is automatically generated.
        Hide
        Anoop Sam John added a comment -

        Is this fix needed for 0.94 also?

        Show
        Anoop Sam John added a comment - Is this fix needed for 0.94 also?
        Hide
        Jonathan Hsieh added a comment -

        Updated patch applies to trunk/0.94/0.92

        Show
        Jonathan Hsieh added a comment - Updated patch applies to trunk/0.94/0.92
        Hide
        Jonathan Hsieh added a comment -

        Changed jira title to be more descriptive

        Show
        Jonathan Hsieh added a comment - Changed jira title to be more descriptive
        Hide
        Jonathan Hsieh added a comment -

        @Anoop – Thanks for checking up on these (I missed this when it came in)

        @gaojinchao - Thanks for the useful patch!

        I've tested the failures and the work for me locally. Committed to 0.90/0.92/0.94/0.96-trunk

        Show
        Jonathan Hsieh added a comment - @Anoop – Thanks for checking up on these (I missed this when it came in) @gaojinchao - Thanks for the useful patch! I've tested the failures and the work for me locally. Committed to 0.90/0.92/0.94/0.96-trunk
        Hide
        ramkrishna.s.vasudevan added a comment -

        @Jon
        Thanks for committing it. Anoop reminded me about this.

        Show
        ramkrishna.s.vasudevan added a comment - @Jon Thanks for committing it. Anoop reminded me about this.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12522535/hbase-5488-v2.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 3 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.replication.TestReplication
        org.apache.hadoop.hbase.mapreduce.TestWALPlayer
        org.apache.hadoop.hbase.regionserver.wal.TestHLogSplit
        org.apache.hadoop.hbase.replication.TestMultiSlaveReplication
        org.apache.hadoop.hbase.regionserver.wal.TestHLog
        org.apache.hadoop.hbase.replication.TestMasterReplication

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1510//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1510//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1510//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12522535/hbase-5488-v2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 3 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.replication.TestReplication org.apache.hadoop.hbase.mapreduce.TestWALPlayer org.apache.hadoop.hbase.regionserver.wal.TestHLogSplit org.apache.hadoop.hbase.replication.TestMultiSlaveReplication org.apache.hadoop.hbase.regionserver.wal.TestHLog org.apache.hadoop.hbase.replication.TestMasterReplication Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1510//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1510//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1510//console This message is automatically generated.
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #2751 (See https://builds.apache.org/job/HBase-TRUNK/2751/)
        HBASE-5488 OfflineMetaRepair doesn't support hadoop 0.20's fs.default.name property (gaojinchao) (Revision 1325625)

        Result = SUCCESS
        jmhsieh :
        Files :

        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/hbck/OfflineMetaRepair.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #2751 (See https://builds.apache.org/job/HBase-TRUNK/2751/ ) HBASE-5488 OfflineMetaRepair doesn't support hadoop 0.20's fs.default.name property (gaojinchao) (Revision 1325625) Result = SUCCESS jmhsieh : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/hbck/OfflineMetaRepair.java
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94 #112 (See https://builds.apache.org/job/HBase-0.94/112/)
        HBASE-5488 OfflineMetaRepair doesn't support hadoop 0.20's fs.default.name property (gaojinchao) (Revision 1325626)

        Result = FAILURE
        jmhsieh :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/hbck/OfflineMetaRepair.java
        Show
        Hudson added a comment - Integrated in HBase-0.94 #112 (See https://builds.apache.org/job/HBase-0.94/112/ ) HBASE-5488 OfflineMetaRepair doesn't support hadoop 0.20's fs.default.name property (gaojinchao) (Revision 1325626) Result = FAILURE jmhsieh : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/hbck/OfflineMetaRepair.java
        Hide
        Jonathan Hsieh added a comment -

        This patch shows test failures that seem unrelated , likely due to HBASE-5778.

        Show
        Jonathan Hsieh added a comment - This patch shows test failures that seem unrelated , likely due to HBASE-5778 .
        Hide
        Hudson added a comment -

        Integrated in HBase-0.92 #370 (See https://builds.apache.org/job/HBase-0.92/370/)
        HBASE-5488 OfflineMetaRepair doesn't support hadoop 0.20's fs.default.name property (gaojinchao) (Revision 1325627)

        Result = FAILURE
        jmhsieh :
        Files :

        • /hbase/branches/0.92/CHANGES.txt
        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/hbck/OfflineMetaRepair.java
        Show
        Hudson added a comment - Integrated in HBase-0.92 #370 (See https://builds.apache.org/job/HBase-0.92/370/ ) HBASE-5488 OfflineMetaRepair doesn't support hadoop 0.20's fs.default.name property (gaojinchao) (Revision 1325627) Result = FAILURE jmhsieh : Files : /hbase/branches/0.92/CHANGES.txt /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/hbck/OfflineMetaRepair.java
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94-security #9 (See https://builds.apache.org/job/HBase-0.94-security/9/)
        HBASE-5488 OfflineMetaRepair doesn't support hadoop 0.20's fs.default.name property (gaojinchao) (Revision 1325626)

        Result = SUCCESS
        jmhsieh :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/hbck/OfflineMetaRepair.java
        Show
        Hudson added a comment - Integrated in HBase-0.94-security #9 (See https://builds.apache.org/job/HBase-0.94-security/9/ ) HBASE-5488 OfflineMetaRepair doesn't support hadoop 0.20's fs.default.name property (gaojinchao) (Revision 1325626) Result = SUCCESS jmhsieh : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/hbck/OfflineMetaRepair.java
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-security #170 (See https://builds.apache.org/job/HBase-TRUNK-security/170/)
        HBASE-5488 OfflineMetaRepair doesn't support hadoop 0.20's fs.default.name property (gaojinchao) (Revision 1325625)

        Result = FAILURE
        jmhsieh :
        Files :

        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/hbck/OfflineMetaRepair.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-security #170 (See https://builds.apache.org/job/HBase-TRUNK-security/170/ ) HBASE-5488 OfflineMetaRepair doesn't support hadoop 0.20's fs.default.name property (gaojinchao) (Revision 1325625) Result = FAILURE jmhsieh : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/hbck/OfflineMetaRepair.java
        Hide
        Hudson added a comment -

        Integrated in HBase-0.92-security #105 (See https://builds.apache.org/job/HBase-0.92-security/105/)
        HBASE-5488 OfflineMetaRepair doesn't support hadoop 0.20's fs.default.name property (gaojinchao) (Revision 1325627)

        Result = FAILURE
        jmhsieh :
        Files :

        • /hbase/branches/0.92/CHANGES.txt
        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/hbck/OfflineMetaRepair.java
        Show
        Hudson added a comment - Integrated in HBase-0.92-security #105 (See https://builds.apache.org/job/HBase-0.92-security/105/ ) HBASE-5488 OfflineMetaRepair doesn't support hadoop 0.20's fs.default.name property (gaojinchao) (Revision 1325627) Result = FAILURE jmhsieh : Files : /hbase/branches/0.92/CHANGES.txt /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/hbck/OfflineMetaRepair.java

          People

          • Assignee:
            gaojinchao
            Reporter:
            gaojinchao
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development