HBase
  1. HBase
  2. HBASE-5485

LogCleaner refers to non-existant SnapshotLogCleaner

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.94.0
    • Fix Version/s: 0.94.0
    • Component/s: documentation, wal
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      LogCleaner code refers to SnapshotLogCleaner, but no such class exists. Perhaps it refers to work done in HBASE-50 that was never checked in.

      1. HBASE-5485.patch
        2 kB
        Gregory Chanan
      2. HBASE-5485.patch
        2 kB
        Gregory Chanan

        Activity

        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-security #124 (See https://builds.apache.org/job/HBase-TRUNK-security/124/)
        HBASE-5485 LogCleaner refers to non-existant SnapshotLogCleaner (Revision 1294799)

        Result = SUCCESS
        stack :
        Files :

        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/LogCleaner.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/LogCleanerDelegate.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-security #124 (See https://builds.apache.org/job/HBase-TRUNK-security/124/ ) HBASE-5485 LogCleaner refers to non-existant SnapshotLogCleaner (Revision 1294799) Result = SUCCESS stack : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/LogCleaner.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/LogCleanerDelegate.java
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94 #3 (See https://builds.apache.org/job/HBase-0.94/3/)
        HBASE-5485 LogCleaner refers to non-existant SnapshotLogCleaner (Revision 1294800)

        Result = SUCCESS
        stack :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/LogCleaner.java
        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/LogCleanerDelegate.java
        Show
        Hudson added a comment - Integrated in HBase-0.94 #3 (See https://builds.apache.org/job/HBase-0.94/3/ ) HBASE-5485 LogCleaner refers to non-existant SnapshotLogCleaner (Revision 1294800) Result = SUCCESS stack : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/LogCleaner.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/LogCleanerDelegate.java
        Hide
        stack added a comment -

        Committed trunk and 0.94 branch. Thanks for patch Gregory (and review Ted).

        Show
        stack added a comment - Committed trunk and 0.94 branch. Thanks for patch Gregory (and review Ted).
        Hide
        Ted Yu added a comment -

        +1 on patch.

        Show
        Ted Yu added a comment - +1 on patch.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12516263/HBASE-5485.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +0 tests included. The patch appears to be a documentation patch that doesn't require tests.

        -1 javadoc. The javadoc tool appears to have generated -131 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 155 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
        org.apache.hadoop.hbase.mapred.TestTableMapReduce
        org.apache.hadoop.hbase.mapreduce.TestImportTsv

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1057//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1057//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1057//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12516263/HBASE-5485.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. -1 javadoc. The javadoc tool appears to have generated -131 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 155 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat org.apache.hadoop.hbase.mapred.TestTableMapReduce org.apache.hadoop.hbase.mapreduce.TestImportTsv Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1057//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1057//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1057//console This message is automatically generated.
        Hide
        Gregory Chanan added a comment -

        Forgot to grant license

        Show
        Gregory Chanan added a comment - Forgot to grant license
        Hide
        Gregory Chanan added a comment -

        Removes reference to SnapshotLogCleaner

        Show
        Gregory Chanan added a comment - Attached HBASE-5485 .patch * Removes reference to SnapshotLogCleaner

          People

          • Assignee:
            Gregory Chanan
            Reporter:
            Gregory Chanan
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development