HBase
  1. HBase
  2. HBASE-5484

Spelling mistake in error message in HMasterCommandLine

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.90.5, 0.92.0
    • Fix Version/s: 0.94.0
    • Component/s: master
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      If hadoop-zookeeper-server is installed and started, starting hbase-master in standalone mode will display this error message which has some typos.

      $ sudo /etc/init.d/hadoop-hbase-master start
      Starting Hadoop HBase master daemon: starting master, logging to /usr/lib/hbase/logs/hbase-hbase-master/cloudera-vm.out
      Couldnt start ZK at requested address of 2181, instead got: 2182. Aborting. Why? Because clients (eg shell) wont be able to find this ZK quorum
      hbase-master.

      1. diff1.txt
        1 kB
        David S. Wang

        Activity

        Hide
        David S. Wang added a comment -

        Unit tested:

        Ran test suite without any new errors.
        Unit tested by starting HBase in standalone mode and setting the ZK port to a TCP port that was already bound to, to hit this message:

        java.io.IOException: Could not start ZK at requested port of 56071. ZK was started at port: 56074. Aborting as clients (e.g. shell) will not be able to find this ZK quorum.

        Ran test-patch.sh with the following results:

        -1 overall.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified tests.

        -1 javadoc. The javadoc tool appears to have generated -131 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version ) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        Show
        David S. Wang added a comment - Unit tested: Ran test suite without any new errors. Unit tested by starting HBase in standalone mode and setting the ZK port to a TCP port that was already bound to, to hit this message: java.io.IOException: Could not start ZK at requested port of 56071. ZK was started at port: 56074. Aborting as clients (e.g. shell) will not be able to find this ZK quorum. Ran test-patch.sh with the following results: -1 overall. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified tests. -1 javadoc. The javadoc tool appears to have generated -131 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version ) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings.
        Hide
        stack added a comment -

        Committed trunk and to 0.94 branch.

        Show
        stack added a comment - Committed trunk and to 0.94 branch.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12516365/diff1.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified tests.

        -1 javadoc. The javadoc tool appears to have generated -131 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 155 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
        org.apache.hadoop.hbase.mapred.TestTableMapReduce
        org.apache.hadoop.hbase.mapreduce.TestImportTsv

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1059//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1059//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1059//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12516365/diff1.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified tests. -1 javadoc. The javadoc tool appears to have generated -131 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 155 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat org.apache.hadoop.hbase.mapred.TestTableMapReduce org.apache.hadoop.hbase.mapreduce.TestImportTsv Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1059//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1059//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1059//console This message is automatically generated.
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94 #2 (See https://builds.apache.org/job/HBase-0.94/2/)
        HBASE-5484 Spelling mistake in error message in HMasterCommandLine (Revision 1294789)

        Result = SUCCESS
        stack :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java
        Show
        Hudson added a comment - Integrated in HBase-0.94 #2 (See https://builds.apache.org/job/HBase-0.94/2/ ) HBASE-5484 Spelling mistake in error message in HMasterCommandLine (Revision 1294789) Result = SUCCESS stack : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-security #124 (See https://builds.apache.org/job/HBase-TRUNK-security/124/)
        HBASE-5484 Spelling mistake in error message in HMasterCommandLine (Revision 1294790)

        Result = SUCCESS
        stack :
        Files :

        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-security #124 (See https://builds.apache.org/job/HBase-TRUNK-security/124/ ) HBASE-5484 Spelling mistake in error message in HMasterCommandLine (Revision 1294790) Result = SUCCESS stack : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java

          People

          • Assignee:
            David S. Wang
            Reporter:
            David S. Wang
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development