Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.94.0
    • Component/s: metrics
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The RegionServerMetrics is not pushing the pread times to the MetricsRecord

      1. ASF.LICENSE.NOT.GRANTED--D1947.1.patch
        0.6 kB
        Phabricator
      2. ASF.LICENSE.NOT.GRANTED--D1947.1.patch
        0.6 kB
        Phabricator
      3. ASF.LICENSE.NOT.GRANTED--D1947.1.patch
        0.6 kB
        Phabricator
      4. D1947.patch
        0.6 kB
        stack

        Activity

        Hide
        Phabricator added a comment -

        dhruba requested code review of "[jira] HBASE-5473 Metrics does not push pread time".
        Reviewers: sc, tedyu

        Metrics does not push pread time.

        TEST PLAN
        All unit tests pass. Also deployed on my local test cluster.

        REVISION DETAIL
        https://reviews.facebook.net/D1947

        AFFECTED FILES
        src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java

        MANAGE HERALD DIFFERENTIAL RULES
        https://reviews.facebook.net/herald/view/differential/

        WHY DID I GET THIS EMAIL?
        https://reviews.facebook.net/herald/transcript/4119/

        Tip: use the X-Herald-Rules header to filter Herald messages in your client.

        Show
        Phabricator added a comment - dhruba requested code review of " [jira] HBASE-5473 Metrics does not push pread time". Reviewers: sc, tedyu Metrics does not push pread time. TEST PLAN All unit tests pass. Also deployed on my local test cluster. REVISION DETAIL https://reviews.facebook.net/D1947 AFFECTED FILES src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/4119/ Tip: use the X-Herald-Rules header to filter Herald messages in your client.
        Hide
        Phabricator added a comment -

        dhruba requested code review of "[jira] HBASE-5473 Metrics does not push pread time".
        Reviewers: sc, tedyu

        Metrics does not push pread time.

        TEST PLAN
        All unit tests pass. Also deployed on my local test cluster.

        REVISION DETAIL
        https://reviews.facebook.net/D1947

        AFFECTED FILES
        src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java

        MANAGE HERALD DIFFERENTIAL RULES
        https://reviews.facebook.net/herald/view/differential/

        WHY DID I GET THIS EMAIL?
        https://reviews.facebook.net/herald/transcript/4119/

        Tip: use the X-Herald-Rules header to filter Herald messages in your client.

        Show
        Phabricator added a comment - dhruba requested code review of " [jira] HBASE-5473 Metrics does not push pread time". Reviewers: sc, tedyu Metrics does not push pread time. TEST PLAN All unit tests pass. Also deployed on my local test cluster. REVISION DETAIL https://reviews.facebook.net/D1947 AFFECTED FILES src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/4119/ Tip: use the X-Herald-Rules header to filter Herald messages in your client.
        Hide
        Phabricator added a comment -

        dhruba requested code review of "[jira] HBASE-5473 Metrics does not push pread time".
        Reviewers: sc, tedyu

        Metrics does not push pread time.

        TEST PLAN
        All unit tests pass. Also deployed on my local test cluster.

        REVISION DETAIL
        https://reviews.facebook.net/D1947

        AFFECTED FILES
        src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java

        MANAGE HERALD DIFFERENTIAL RULES
        https://reviews.facebook.net/herald/view/differential/

        WHY DID I GET THIS EMAIL?
        https://reviews.facebook.net/herald/transcript/4119/

        Tip: use the X-Herald-Rules header to filter Herald messages in your client.

        Show
        Phabricator added a comment - dhruba requested code review of " [jira] HBASE-5473 Metrics does not push pread time". Reviewers: sc, tedyu Metrics does not push pread time. TEST PLAN All unit tests pass. Also deployed on my local test cluster. REVISION DETAIL https://reviews.facebook.net/D1947 AFFECTED FILES src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/4119/ Tip: use the X-Herald-Rules header to filter Herald messages in your client.
        Hide
        Phabricator added a comment -

        sc has commented on the revision "[jira] HBASE-5473 Metrics does not push pread time".

        looks good to me

        REVISION DETAIL
        https://reviews.facebook.net/D1947

        Show
        Phabricator added a comment - sc has commented on the revision " [jira] HBASE-5473 Metrics does not push pread time". looks good to me REVISION DETAIL https://reviews.facebook.net/D1947
        Hide
        Phabricator added a comment -

        sc has commented on the revision "[jira] HBASE-5473 Metrics does not push pread time".

        looks good to me

        REVISION DETAIL
        https://reviews.facebook.net/D1947

        Show
        Phabricator added a comment - sc has commented on the revision " [jira] HBASE-5473 Metrics does not push pread time". looks good to me REVISION DETAIL https://reviews.facebook.net/D1947
        Hide
        Phabricator added a comment -

        sc has commented on the revision "[jira] HBASE-5473 Metrics does not push pread time".

        looks good to me

        REVISION DETAIL
        https://reviews.facebook.net/D1947

        Show
        Phabricator added a comment - sc has commented on the revision " [jira] HBASE-5473 Metrics does not push pread time". looks good to me REVISION DETAIL https://reviews.facebook.net/D1947
        Hide
        Phabricator added a comment -

        stack has accepted the revision "[jira] HBASE-5473 Metrics does not push pread time".

        +1

        REVISION DETAIL
        https://reviews.facebook.net/D1947

        BRANCH
        svn

        Show
        Phabricator added a comment - stack has accepted the revision " [jira] HBASE-5473 Metrics does not push pread time". +1 REVISION DETAIL https://reviews.facebook.net/D1947 BRANCH svn
        Hide
        Phabricator added a comment -

        stack has accepted the revision "[jira] HBASE-5473 Metrics does not push pread time".

        +1

        REVISION DETAIL
        https://reviews.facebook.net/D1947

        BRANCH
        svn

        Show
        Phabricator added a comment - stack has accepted the revision " [jira] HBASE-5473 Metrics does not push pread time". +1 REVISION DETAIL https://reviews.facebook.net/D1947 BRANCH svn
        Hide
        Phabricator added a comment -

        stack has accepted the revision "[jira] HBASE-5473 Metrics does not push pread time".

        +1

        REVISION DETAIL
        https://reviews.facebook.net/D1947

        BRANCH
        svn

        Show
        Phabricator added a comment - stack has accepted the revision " [jira] HBASE-5473 Metrics does not push pread time". +1 REVISION DETAIL https://reviews.facebook.net/D1947 BRANCH svn
        Hide
        Phabricator added a comment -

        stack has accepted the revision "[jira] HBASE-5473 Metrics does not push pread time".

        +1

        REVISION DETAIL
        https://reviews.facebook.net/D1947

        BRANCH
        svn

        Show
        Phabricator added a comment - stack has accepted the revision " [jira] HBASE-5473 Metrics does not push pread time". +1 REVISION DETAIL https://reviews.facebook.net/D1947 BRANCH svn
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12515992/D1947.1.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 javadoc. The javadoc tool appears to have generated -133 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 155 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.TestRegionRebalancing
        org.apache.hadoop.hbase.mapreduce.TestImportTsv
        org.apache.hadoop.hbase.mapred.TestTableMapReduce
        org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1049//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1049//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1049//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12515992/D1947.1.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javadoc. The javadoc tool appears to have generated -133 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 155 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.TestRegionRebalancing org.apache.hadoop.hbase.mapreduce.TestImportTsv org.apache.hadoop.hbase.mapred.TestTableMapReduce org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1049//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1049//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1049//console This message is automatically generated.
        Hide
        stack added a comment -

        Retrying patch

        Show
        stack added a comment - Retrying patch
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12516006/D1947.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 javadoc. The javadoc tool appears to have generated -131 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 155 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
        org.apache.hadoop.hbase.io.hfile.TestLruBlockCache
        org.apache.hadoop.hbase.mapred.TestTableMapReduce
        org.apache.hadoop.hbase.client.TestFromClientSide
        org.apache.hadoop.hbase.mapreduce.TestImportTsv

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1050//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1050//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1050//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12516006/D1947.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javadoc. The javadoc tool appears to have generated -131 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 155 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat org.apache.hadoop.hbase.io.hfile.TestLruBlockCache org.apache.hadoop.hbase.mapred.TestTableMapReduce org.apache.hadoop.hbase.client.TestFromClientSide org.apache.hadoop.hbase.mapreduce.TestImportTsv Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1050//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1050//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1050//console This message is automatically generated.
        Hide
        stack added a comment -

        Committed to 0.92 branch and to trunk. Thanks for the patch Dhruba. One line change in metrics can't be responsible for test failures.

        Show
        stack added a comment - Committed to 0.92 branch and to trunk. Thanks for the patch Dhruba. One line change in metrics can't be responsible for test failures.
        Hide
        Hudson added a comment -

        Integrated in HBase-0.92 #305 (See https://builds.apache.org/job/HBase-0.92/305/)
        HBASE-5473 Metrics does not push pread time (Revision 1293531)

        Result = FAILURE
        stack :
        Files :

        • /hbase/branches/0.92/CHANGES.txt
        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java
        Show
        Hudson added a comment - Integrated in HBase-0.92 #305 (See https://builds.apache.org/job/HBase-0.92/305/ ) HBASE-5473 Metrics does not push pread time (Revision 1293531) Result = FAILURE stack : Files : /hbase/branches/0.92/CHANGES.txt /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java
        Hide
        Ted Yu added a comment -

        0.92 build #305 failed due to compilation error:

        [ERROR] <https://builds.apache.org/job/HBase-0.92/ws/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java>:[313,10] cannot find symbol
        [ERROR] symbol  : variable fsPreadLatency
        [ERROR] location: class org.apache.hadoop.hbase.regionserver.metrics.RegionServerMetrics
        
        Show
        Ted Yu added a comment - 0.92 build #305 failed due to compilation error: [ERROR] <https: //builds.apache.org/job/HBase-0.92/ws/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java>:[313,10] cannot find symbol [ERROR] symbol : variable fsPreadLatency [ERROR] location: class org.apache.hadoop.hbase.regionserver.metrics.RegionServerMetrics
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-security #122 (See https://builds.apache.org/job/HBase-TRUNK-security/122/)
        HBASE-5473 Metrics does not push pread time (Revision 1293532)

        Result = FAILURE
        stack :
        Files :

        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-security #122 (See https://builds.apache.org/job/HBase-TRUNK-security/122/ ) HBASE-5473 Metrics does not push pread time (Revision 1293532) Result = FAILURE stack : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java
        Hide
        dhruba borthakur added a comment -

        I can compile and run unit tests on trunk just fine. I think HadoopQA ran into trouble while merging the patch. Bur svn trunk looks fine.

        Show
        dhruba borthakur added a comment - I can compile and run unit tests on trunk just fine. I think HadoopQA ran into trouble while merging the patch. Bur svn trunk looks fine.
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #2669 (See https://builds.apache.org/job/HBase-TRUNK/2669/)
        HBASE-5473 Metrics does not push pread time (Revision 1293532)

        Result = SUCCESS
        stack :
        Files :

        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #2669 (See https://builds.apache.org/job/HBase-TRUNK/2669/ ) HBASE-5473 Metrics does not push pread time (Revision 1293532) Result = SUCCESS stack : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java
        Hide
        stack added a comment -

        Reverted from branch. It doesn't belong there (broke build). Left it on trunk.

        Show
        stack added a comment - Reverted from branch. It doesn't belong there (broke build). Left it on trunk.
        Hide
        Hudson added a comment -

        Integrated in HBase-0.92 #306 (See https://builds.apache.org/job/HBase-0.92/306/)
        HBASE-5473 Metrics does not push pread time; REVERT – DOESN'T BELONG ON THIS BRANCH (Revision 1294197)

        Result = SUCCESS
        stack :
        Files :

        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java
        Show
        Hudson added a comment - Integrated in HBase-0.92 #306 (See https://builds.apache.org/job/HBase-0.92/306/ ) HBASE-5473 Metrics does not push pread time; REVERT – DOESN'T BELONG ON THIS BRANCH (Revision 1294197) Result = SUCCESS stack : Files : /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java
        Hide
        dhruba borthakur added a comment -

        This is committed to trunk. can this be closed?

        Show
        dhruba borthakur added a comment - This is committed to trunk. can this be closed?
        Hide
        Hudson added a comment -

        Integrated in HBase-0.92-security #96 (See https://builds.apache.org/job/HBase-0.92-security/96/)
        HBASE-5473 Metrics does not push pread time; REVERT – DOESN'T BELONG ON THIS BRANCH (Revision 1294197)
        HBASE-5473 Metrics does not push pread time (Revision 1293531)

        Result = FAILURE
        stack :
        Files :

        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java

        stack :
        Files :

        • /hbase/branches/0.92/CHANGES.txt
        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java
        Show
        Hudson added a comment - Integrated in HBase-0.92-security #96 (See https://builds.apache.org/job/HBase-0.92-security/96/ ) HBASE-5473 Metrics does not push pread time; REVERT – DOESN'T BELONG ON THIS BRANCH (Revision 1294197) HBASE-5473 Metrics does not push pread time (Revision 1293531) Result = FAILURE stack : Files : /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java stack : Files : /hbase/branches/0.92/CHANGES.txt /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java
        Hide
        stack added a comment -

        Committed to trunk a while back.

        Show
        stack added a comment - Committed to trunk a while back.
        Hide
        Phabricator added a comment -

        dhruba has closed the revision "[jira] HBASE-5473 Metrics does not push pread time".

        REVISION DETAIL
        https://reviews.facebook.net/D1947

        To: sc, tedyu, stack, dhruba
        Cc: JIRA

        Show
        Phabricator added a comment - dhruba has closed the revision " [jira] HBASE-5473 Metrics does not push pread time". REVISION DETAIL https://reviews.facebook.net/D1947 To: sc, tedyu, stack, dhruba Cc: JIRA

          People

          • Assignee:
            dhruba borthakur
            Reporter:
            dhruba borthakur
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development