HBase
  1. HBase
  2. HBASE-5437

HRegionThriftServer does not start because of a bug in HbaseHandlerMetricsProxy

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.94.0
    • Component/s: metrics, Thrift
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      3.facebook.com,60020,1329865516120: Initialization of RS failed. Hence aborting RS.
      java.lang.ClassCastException: $Proxy9 cannot be cast to org.apache.hadoop.hbase.thrift.generated.Hbase$Iface
      at org.apache.hadoop.hbase.thrift.HbaseHandlerMetricsProxy.newInstance(HbaseHandlerMetricsProxy.java:47)
      at org.apache.hadoop.hbase.thrift.ThriftServerRunner.<init>(ThriftServerRunner.java:239)
      at org.apache.hadoop.hbase.regionserver.HRegionThriftServer.<init>(HRegionThriftServer.java:74)
      at org.apache.hadoop.hbase.regionserver.HRegionServer.initializeThreads(HRegionServer.java:646)
      at org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:546)
      at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:658)
      at java.lang.Thread.run(Thread.java:662)
      2012-02-21 15:05:18,749 FATAL org.apache.hadoop.h

        Activity

        Hide
        Phabricator added a comment -

        dhruba has resigned from the revision "HBASE-5437 [jira] HRegionThriftServer does not start because of a bug in HbaseHandlerMetricsProxy".

        REVISION DETAIL
        https://reviews.facebook.net/D1887

        To: tedyu, JIRA, sc
        Cc: stack

        Show
        Phabricator added a comment - dhruba has resigned from the revision " HBASE-5437 [jira] HRegionThriftServer does not start because of a bug in HbaseHandlerMetricsProxy". REVISION DETAIL https://reviews.facebook.net/D1887 To: tedyu, JIRA, sc Cc: stack
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-security #121 (See https://builds.apache.org/job/HBase-TRUNK-security/121/)
        HBASE-5437 HRegionThriftServer does not start because of a bug in HbaseHandlerMetricsProxy (Scott Chen) (Revision 1293013)

        Result = SUCCESS
        tedyu :
        Files :

        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/HbaseHandlerMetricsProxy.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/ThriftMetrics.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftHBaseServiceHandler.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-security #121 (See https://builds.apache.org/job/HBase-TRUNK-security/121/ ) HBASE-5437 HRegionThriftServer does not start because of a bug in HbaseHandlerMetricsProxy (Scott Chen) (Revision 1293013) Result = SUCCESS tedyu : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/HbaseHandlerMetricsProxy.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/ThriftMetrics.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftHBaseServiceHandler.java
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #2668 (See https://builds.apache.org/job/HBase-TRUNK/2668/)
        HBASE-5437 HRegionThriftServer does not start because of a bug in HbaseHandlerMetricsProxy (Scott Chen) (Revision 1293013)

        Result = SUCCESS
        tedyu :
        Files :

        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/HbaseHandlerMetricsProxy.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/ThriftMetrics.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftHBaseServiceHandler.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #2668 (See https://builds.apache.org/job/HBase-TRUNK/2668/ ) HBASE-5437 HRegionThriftServer does not start because of a bug in HbaseHandlerMetricsProxy (Scott Chen) (Revision 1293013) Result = SUCCESS tedyu : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/HbaseHandlerMetricsProxy.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/ThriftMetrics.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftHBaseServiceHandler.java
        Hide
        Ted Yu added a comment -

        Integrated to TRUNK.

        Thanks for the patch, Scott.

        Thanks for the review, Stack.

        Show
        Ted Yu added a comment - Integrated to TRUNK. Thanks for the patch, Scott. Thanks for the review, Stack.
        Hide
        stack added a comment -

        +1

        Show
        stack added a comment - +1
        Hide
        Ted Yu added a comment -

        +1 on patch v2.

        Will integrate in the afternoon if there is no objection.

        Show
        Ted Yu added a comment - +1 on patch v2. Will integrate in the afternoon if there is no objection.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12515720/HBASE-5437.D1887.2.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 javadoc. The javadoc tool appears to have generated -136 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 152 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.mapreduce.TestImportTsv
        org.apache.hadoop.hbase.mapred.TestTableMapReduce
        org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1022//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1022//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1022//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12515720/HBASE-5437.D1887.2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javadoc. The javadoc tool appears to have generated -136 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 152 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.mapreduce.TestImportTsv org.apache.hadoop.hbase.mapred.TestTableMapReduce org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1022//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1022//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1022//console This message is automatically generated.
        Hide
        Phabricator added a comment -

        sc updated the revision "HBASE-5437 [jira] HRegionThriftServer does not start because of a bug in HbaseHandlerMetricsProxy".
        Reviewers: tedyu, dhruba, JIRA

        Fixed the typo. Sorry for being so careless.

        REVISION DETAIL
        https://reviews.facebook.net/D1887

        AFFECTED FILES
        src/main/java/org/apache/hadoop/hbase/thrift/HbaseHandlerMetricsProxy.java
        src/main/java/org/apache/hadoop/hbase/thrift/ThriftMetrics.java
        src/main/java/org/apache/hadoop/hbase/thrift2/ThriftHBaseServiceHandler.java

        Show
        Phabricator added a comment - sc updated the revision " HBASE-5437 [jira] HRegionThriftServer does not start because of a bug in HbaseHandlerMetricsProxy". Reviewers: tedyu, dhruba, JIRA Fixed the typo. Sorry for being so careless. REVISION DETAIL https://reviews.facebook.net/D1887 AFFECTED FILES src/main/java/org/apache/hadoop/hbase/thrift/HbaseHandlerMetricsProxy.java src/main/java/org/apache/hadoop/hbase/thrift/ThriftMetrics.java src/main/java/org/apache/hadoop/hbase/thrift2/ThriftHBaseServiceHandler.java
        Hide
        Phabricator added a comment -

        tedyu has commented on the revision "HBASE-5437 [jira] HRegionThriftServer does not start because of a bug in HbaseHandlerMetricsProxy".

        Hadoop QA reported:

        [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/src/main/java/org/apache/hadoop/hbase/thrift/ThriftMetrics.java:[118,55] cannot find symbol
        [ERROR] symbol : variable toString
        [ERROR] location: class java.lang.Class<capture#822 of ?>

        REVISION DETAIL
        https://reviews.facebook.net/D1887

        Show
        Phabricator added a comment - tedyu has commented on the revision " HBASE-5437 [jira] HRegionThriftServer does not start because of a bug in HbaseHandlerMetricsProxy". Hadoop QA reported: [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/src/main/java/org/apache/hadoop/hbase/thrift/ThriftMetrics.java: [118,55] cannot find symbol [ERROR] symbol : variable toString [ERROR] location: class java.lang.Class<capture#822 of ?> REVISION DETAIL https://reviews.facebook.net/D1887
        Hide
        stack added a comment -

        Scott: It failed compile?

        See above console output:

        [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/src/main/java/org/apache/hadoop/hbase/thrift/ThriftMetrics.java:[118,55] cannot find symbol
        [ERROR] symbol  : variable toString
        [ERROR] location: class java.lang.Class<capture#444 of ?>
        [ERROR] -> [Help 1]
        
        Show
        stack added a comment - Scott: It failed compile? See above console output: [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/src/main/java/org/apache/hadoop/hbase/thrift/ThriftMetrics.java:[118,55] cannot find symbol [ERROR] symbol : variable toString [ERROR] location: class java.lang. Class <capture#444 of ?> [ERROR] -> [Help 1]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12515693/HBASE-5437.D1887.1.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        -1 javac. The patch appears to cause mvn compile goal to fail.

        -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1016//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1016//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12515693/HBASE-5437.D1887.1.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause mvn compile goal to fail. -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1016//testReport/ Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1016//console This message is automatically generated.
        Hide
        Phabricator added a comment -

        stack has commented on the revision "HBASE-5437 [jira] HRegionThriftServer does not start because of a bug in HbaseHandlerMetricsProxy".

        +1

        REVISION DETAIL
        https://reviews.facebook.net/D1887

        Show
        Phabricator added a comment - stack has commented on the revision " HBASE-5437 [jira] HRegionThriftServer does not start because of a bug in HbaseHandlerMetricsProxy". +1 REVISION DETAIL https://reviews.facebook.net/D1887
        Hide
        Phabricator added a comment -

        tedyu has commented on the revision "HBASE-5437 [jira] HRegionThriftServer does not start because of a bug in HbaseHandlerMetricsProxy".

        Patch looks good.

        Please submit to Hadoop QA

        REVISION DETAIL
        https://reviews.facebook.net/D1887

        Show
        Phabricator added a comment - tedyu has commented on the revision " HBASE-5437 [jira] HRegionThriftServer does not start because of a bug in HbaseHandlerMetricsProxy". Patch looks good. Please submit to Hadoop QA REVISION DETAIL https://reviews.facebook.net/D1887
        Hide
        Phabricator added a comment -

        sc requested code review of "HBASE-5437 [jira] HRegionThriftServer does not start because of a bug in HbaseHandlerMetricsProxy".
        Reviewers: tedyu, dhruba, JIRA

        HRegionThriftServer does not start because of a bug in HbaseHandlerMetricsProxy

        This happens because HBaseHandlerRegion.class.getInterfaces() does not return
        Hbase.Iface.class. Hard-coding the class Hbase.Iface.class into the interface
        array solves the problem.

        3.facebook.com,60020,1329865516120: Initialization of RS failed. Hence aborting RS.
        java.lang.ClassCastException: $Proxy9 cannot be cast to org.apache.hadoop.hbase.thrift.generated.Hbase$Iface
        at org.apache.hadoop.hbase.thrift.HbaseHandlerMetricsProxy.newInstance(HbaseHandlerMetricsProxy.java:47)
        at org.apache.hadoop.hbase.thrift.ThriftServerRunner.<init>(ThriftServerRunner.java:239)
        at org.apache.hadoop.hbase.regionserver.HRegionThriftServer.<init>(HRegionThriftServer.java:74)
        at org.apache.hadoop.hbase.regionserver.HRegionServer.initializeThreads(HRegionServer.java:646)
        at org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:546)
        at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:658)
        at java.lang.Thread.run(Thread.java:662)
        2012-02-21 15:05:18,749 FATAL org.apache.hadoop.h

        TEST PLAN
        Start Region server with HRegionThriftServer

        Revert Plan:

        Tags:

        REVISION DETAIL
        https://reviews.facebook.net/D1887

        AFFECTED FILES
        src/main/java/org/apache/hadoop/hbase/thrift/HbaseHandlerMetricsProxy.java
        src/main/java/org/apache/hadoop/hbase/thrift/ThriftMetrics.java
        src/main/java/org/apache/hadoop/hbase/thrift2/ThriftHBaseServiceHandler.java

        MANAGE HERALD DIFFERENTIAL RULES
        https://reviews.facebook.net/herald/view/differential/

        WHY DID I GET THIS EMAIL?
        https://reviews.facebook.net/herald/transcript/4011/

        Tip: use the X-Herald-Rules header to filter Herald messages in your client.

        Show
        Phabricator added a comment - sc requested code review of " HBASE-5437 [jira] HRegionThriftServer does not start because of a bug in HbaseHandlerMetricsProxy". Reviewers: tedyu, dhruba, JIRA HRegionThriftServer does not start because of a bug in HbaseHandlerMetricsProxy This happens because HBaseHandlerRegion.class.getInterfaces() does not return Hbase.Iface.class. Hard-coding the class Hbase.Iface.class into the interface array solves the problem. 3.facebook.com,60020,1329865516120: Initialization of RS failed. Hence aborting RS. java.lang.ClassCastException: $Proxy9 cannot be cast to org.apache.hadoop.hbase.thrift.generated.Hbase$Iface at org.apache.hadoop.hbase.thrift.HbaseHandlerMetricsProxy.newInstance(HbaseHandlerMetricsProxy.java:47) at org.apache.hadoop.hbase.thrift.ThriftServerRunner.<init>(ThriftServerRunner.java:239) at org.apache.hadoop.hbase.regionserver.HRegionThriftServer.<init>(HRegionThriftServer.java:74) at org.apache.hadoop.hbase.regionserver.HRegionServer.initializeThreads(HRegionServer.java:646) at org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:546) at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:658) at java.lang.Thread.run(Thread.java:662) 2012-02-21 15:05:18,749 FATAL org.apache.hadoop.h TEST PLAN Start Region server with HRegionThriftServer Revert Plan: Tags: REVISION DETAIL https://reviews.facebook.net/D1887 AFFECTED FILES src/main/java/org/apache/hadoop/hbase/thrift/HbaseHandlerMetricsProxy.java src/main/java/org/apache/hadoop/hbase/thrift/ThriftMetrics.java src/main/java/org/apache/hadoop/hbase/thrift2/ThriftHBaseServiceHandler.java MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/4011/ Tip: use the X-Herald-Rules header to filter Herald messages in your client.
        Hide
        Scott Chen added a comment -

        @Zhihong: Thanks. I posted the wrong patch. I will upload the patch soon. Sorry for the confusion.

        Show
        Scott Chen added a comment - @Zhihong: Thanks. I posted the wrong patch. I will upload the patch soon. Sorry for the confusion.
        Hide
        Ted Yu added a comment -

        @Scott:
        I think D1857 is a cross-post: I don't find Hbase.Iface.class in the patch.
        It is for HBASE-5441

        Show
        Ted Yu added a comment - @Scott: I think D1857 is a cross-post: I don't find Hbase.Iface.class in the patch. It is for HBASE-5441
        Hide
        Phabricator added a comment -

        sc requested code review of "HBASE-5437 [jira] HRegionThriftServer does not start because of a bug in HbaseHandlerMetricsProxy".
        Reviewers: tedyu, dhruba, JIRA

        HRegionThriftServer does not start because of a bug in HbaseHandlerMetricsProxy

        This happens because HBaseHandlerRegion.class.getInterfaces() does not return
        Hbase.Iface.class. Hard-coding the class Hbase.Iface.class into the interface
        array solves the problem.

        3.facebook.com,60020,1329865516120: Initialization of RS failed. Hence aborting RS.
        java.lang.ClassCastException: $Proxy9 cannot be cast to org.apache.hadoop.hbase.thrift.generated.Hbase$Iface
        at org.apache.hadoop.hbase.thrift.HbaseHandlerMetricsProxy.newInstance(HbaseHandlerMetricsProxy.java:47)
        at org.apache.hadoop.hbase.thrift.ThriftServerRunner.<init>(ThriftServerRunner.java:239)
        at org.apache.hadoop.hbase.regionserver.HRegionThriftServer.<init>(HRegionThriftServer.java:74)
        at org.apache.hadoop.hbase.regionserver.HRegionServer.initializeThreads(HRegionServer.java:646)
        at org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:546)
        at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:658)
        at java.lang.Thread.run(Thread.java:662)
        2012-02-21 15:05:18,749 FATAL org.apache.hadoop.h

        TEST PLAN
        Start Region server with HRegionThriftServer

        REVISION DETAIL
        https://reviews.facebook.net/D1857

        AFFECTED FILES
        src/main/java/org/apache/hadoop/hbase/thrift/HbaseHandlerMetricsProxy.java

        MANAGE HERALD DIFFERENTIAL RULES
        https://reviews.facebook.net/herald/view/differential/

        WHY DID I GET THIS EMAIL?
        https://reviews.facebook.net/herald/transcript/3939/

        Tip: use the X-Herald-Rules header to filter Herald messages in your client.

        Show
        Phabricator added a comment - sc requested code review of " HBASE-5437 [jira] HRegionThriftServer does not start because of a bug in HbaseHandlerMetricsProxy". Reviewers: tedyu, dhruba, JIRA HRegionThriftServer does not start because of a bug in HbaseHandlerMetricsProxy This happens because HBaseHandlerRegion.class.getInterfaces() does not return Hbase.Iface.class. Hard-coding the class Hbase.Iface.class into the interface array solves the problem. 3.facebook.com,60020,1329865516120: Initialization of RS failed. Hence aborting RS. java.lang.ClassCastException: $Proxy9 cannot be cast to org.apache.hadoop.hbase.thrift.generated.Hbase$Iface at org.apache.hadoop.hbase.thrift.HbaseHandlerMetricsProxy.newInstance(HbaseHandlerMetricsProxy.java:47) at org.apache.hadoop.hbase.thrift.ThriftServerRunner.<init>(ThriftServerRunner.java:239) at org.apache.hadoop.hbase.regionserver.HRegionThriftServer.<init>(HRegionThriftServer.java:74) at org.apache.hadoop.hbase.regionserver.HRegionServer.initializeThreads(HRegionServer.java:646) at org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:546) at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:658) at java.lang.Thread.run(Thread.java:662) 2012-02-21 15:05:18,749 FATAL org.apache.hadoop.h TEST PLAN Start Region server with HRegionThriftServer REVISION DETAIL https://reviews.facebook.net/D1857 AFFECTED FILES src/main/java/org/apache/hadoop/hbase/thrift/HbaseHandlerMetricsProxy.java MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/3939/ Tip: use the X-Herald-Rules header to filter Herald messages in your client.

          People

          • Assignee:
            Scott Chen
            Reporter:
            Scott Chen
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development