[HBASE-5433] [REST] Add metrics to keep track of success/failure count

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.94.0
• Fix Version/s: 0.94.0, 0.95.0
• Component/s: metrics, REST
• Hadoop Flags: Reviewed
• Assignee: Mubarak Seyed
• Reporter: Mubarak Seyed
• Created: 19/Feb/12 01:38
• Updated: 05/Aug/14 20:11
• Resolved: 21/Mar/12 19:48

Description

In a production environment, the visibility of successful REST request(s) are not getting exposed to metric system as we have only one metric (requests) today.
Proposing to add more metrics such as successful_get_count, failed_get_count, successful_put_count, failed_put_count

The current implementation increases the request count at the beginning of the method implementation and it is very hard to monitor requests (unless turn on debug, find the row_key and validate it in get/scan using hbase shell), it will be very useful to ops to keep an eye as requests from cross data-centers are trying to write data to one cluster using REST gateway through load balancer (and there is no visibility of which REST-server/RS failed to write data)

 Response update(final CellSetModel model, final boolean replace) {
    // for requests
    servlet.getMetrics().incrementRequests(1);
       ..  
       ..
      table.put(puts);
      table.flushCommits();
      ResponseBuilder response = Response.ok(); 
      // for successful_get_count
      servlet.getMetrics().incrementSuccessfulGetRequests(1);
      return response.build();
    } catch (IOException e) {
      // for failed_get_count
      servlet.getMetrics().incrementFailedGetRequests(1);
      throw new WebApplicationException(e,
                  Response.Status.SERVICE_UNAVAILABLE);
    } finally {
    }
  }