HBase
  1. HBase
  2. HBASE-5421

use hadoop-client/hadoop-minicluster artifacts for Hadoop 0.23 build

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.92.0
    • Fix Version/s: 0.92.1, 0.94.0
    • Component/s: build
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      Hadoop recently added hadoop-client and hadoop-minicluster artifacts for Hadoop 0.23+ that don't export all the internal dependencies (HADOOP-8009).

      Let's use them instead of manually specifying transitive dependency exclusion lists (which is error prone and annoying).

      1. hbase-5421.patch
        7 kB
        Shaneal Manek

        Activity

        Hide
        Shaneal Manek added a comment -

        I ran tests and built an hbase jar after this patch was applied with no trouble.

        Show
        Shaneal Manek added a comment - I ran tests and built an hbase jar after this patch was applied with no trouble.
        Hide
        stack added a comment -

        I'm being lazy Shaneal. This patch effects the 0.23 profile section of the pom only?

        Show
        stack added a comment - I'm being lazy Shaneal. This patch effects the 0.23 profile section of the pom only?
        Hide
        stack added a comment -

        Let me submit the patch to hadoopqa.

        Show
        stack added a comment - Let me submit the patch to hadoopqa.
        Hide
        stack added a comment -

        Oh, you did it.

        Show
        stack added a comment - Oh, you did it.
        Hide
        Shaneal Manek added a comment -

        Yep - it just affects the 0.23 profile of the POM.

        I didn't knowingly submit anything to hadoopqa - I just uploaded my patch here. I don't know if that automatically submits there though ...

        Show
        Shaneal Manek added a comment - Yep - it just affects the 0.23 profile of the POM. I didn't knowingly submit anything to hadoopqa - I just uploaded my patch here. I don't know if that automatically submits there though ...
        Hide
        stack added a comment -

        @Shaneal Yeah, submit patch will trigger hadoopqa. Lets see what it says.

        Show
        stack added a comment - @Shaneal Yeah, submit patch will trigger hadoopqa. Lets see what it says.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12514914/hbase-5421.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 javadoc. The javadoc tool appears to have generated -136 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 157 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.mapreduce.TestImportTsv
        org.apache.hadoop.hbase.mapred.TestTableMapReduce
        org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/977//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/977//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/977//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12514914/hbase-5421.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javadoc. The javadoc tool appears to have generated -136 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 157 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.mapreduce.TestImportTsv org.apache.hadoop.hbase.mapred.TestTableMapReduce org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/977//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/977//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/977//console This message is automatically generated.
        Hide
        stack added a comment -

        Committed trunk and branch. Thanks for patch Shaneal.

        Show
        stack added a comment - Committed trunk and branch. Thanks for patch Shaneal.
        Hide
        Hudson added a comment -

        Integrated in HBase-0.92 #287 (See https://builds.apache.org/job/HBase-0.92/287/)
        HBASE-5421 use hadoop-client/hadoop-minicluster artifacts for Hadoop 0.23 build (Revision 1245742)

        Result = SUCCESS
        stack :
        Files :

        • /hbase/branches/0.92/CHANGES.txt
        • /hbase/branches/0.92/pom.xml
        Show
        Hudson added a comment - Integrated in HBase-0.92 #287 (See https://builds.apache.org/job/HBase-0.92/287/ ) HBASE-5421 use hadoop-client/hadoop-minicluster artifacts for Hadoop 0.23 build (Revision 1245742) Result = SUCCESS stack : Files : /hbase/branches/0.92/CHANGES.txt /hbase/branches/0.92/pom.xml
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-security #114 (See https://builds.apache.org/job/HBase-TRUNK-security/114/)
        HBASE-5421 use hadoop-client/hadoop-minicluster artifacts for Hadoop 0.23 build (Revision 1245743)

        Result = FAILURE
        stack :
        Files :

        • /hbase/trunk/pom.xml
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-security #114 (See https://builds.apache.org/job/HBase-TRUNK-security/114/ ) HBASE-5421 use hadoop-client/hadoop-minicluster artifacts for Hadoop 0.23 build (Revision 1245743) Result = FAILURE stack : Files : /hbase/trunk/pom.xml
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #2665 (See https://builds.apache.org/job/HBase-TRUNK/2665/)
        HBASE-5421 use hadoop-client/hadoop-minicluster artifacts for Hadoop 0.23 build (Revision 1245743)

        Result = FAILURE
        stack :
        Files :

        • /hbase/trunk/pom.xml
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #2665 (See https://builds.apache.org/job/HBase-TRUNK/2665/ ) HBASE-5421 use hadoop-client/hadoop-minicluster artifacts for Hadoop 0.23 build (Revision 1245743) Result = FAILURE stack : Files : /hbase/trunk/pom.xml
        Hide
        Hudson added a comment -

        Integrated in HBase-0.92-security #91 (See https://builds.apache.org/job/HBase-0.92-security/91/)
        HBASE-5421 use hadoop-client/hadoop-minicluster artifacts for Hadoop 0.23 build (Revision 1245742)

        Result = FAILURE
        stack :
        Files :

        • /hbase/branches/0.92/CHANGES.txt
        • /hbase/branches/0.92/pom.xml
        Show
        Hudson added a comment - Integrated in HBase-0.92-security #91 (See https://builds.apache.org/job/HBase-0.92-security/91/ ) HBASE-5421 use hadoop-client/hadoop-minicluster artifacts for Hadoop 0.23 build (Revision 1245742) Result = FAILURE stack : Files : /hbase/branches/0.92/CHANGES.txt /hbase/branches/0.92/pom.xml

          People

          • Assignee:
            Shaneal Manek
            Reporter:
            Shaneal Manek
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development