HBase
  1. HBase
  2. HBASE-5419

FileAlreadyExistsException has moved from mapred to fs package

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.95.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The FileAlreadyExistsException has moved from org.apache.hadoop.mapred.FileAlreadyExistsException to org.apache.hadoop.fs.FileAlreadyExistsException. HBase is currently using a class that is deprecated in hadoop trunk.

      1. ASF.LICENSE.NOT.GRANTED--D1767.1.patch
        1.0 kB
        Phabricator
      2. ASF.LICENSE.NOT.GRANTED--D1767.1.patch
        1.0 kB
        Phabricator
      3. 5419.txt
        0.8 kB
        stack

        Activity

        Hide
        Phabricator added a comment -

        dhruba requested code review of "[jira] HBASE-5419 FileAlreadyExistsException has moved from mapred to fs package".
        Reviewers: tedyu

        Change name of class to o.a.h.fs.FileAlreadyExistsException

        TEST PLAN
        recompile

        REVISION DETAIL
        https://reviews.facebook.net/D1767

        AFFECTED FILES
        src/main/java/org/apache/hadoop/hbase/mapred/TableOutputFormat.java

        MANAGE HERALD DIFFERENTIAL RULES
        https://reviews.facebook.net/herald/view/differential/

        WHY DID I GET THIS EMAIL?
        https://reviews.facebook.net/herald/transcript/3759/

        Tip: use the X-Herald-Rules header to filter Herald messages in your client.

        Show
        Phabricator added a comment - dhruba requested code review of " [jira] HBASE-5419 FileAlreadyExistsException has moved from mapred to fs package". Reviewers: tedyu Change name of class to o.a.h.fs.FileAlreadyExistsException TEST PLAN recompile REVISION DETAIL https://reviews.facebook.net/D1767 AFFECTED FILES src/main/java/org/apache/hadoop/hbase/mapred/TableOutputFormat.java MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/3759/ Tip: use the X-Herald-Rules header to filter Herald messages in your client.
        Hide
        Phabricator added a comment -

        dhruba requested code review of "[jira] HBASE-5419 FileAlreadyExistsException has moved from mapred to fs package".
        Reviewers: tedyu

        Change name of class to o.a.h.fs.FileAlreadyExistsException

        TEST PLAN
        recompile

        REVISION DETAIL
        https://reviews.facebook.net/D1767

        AFFECTED FILES
        src/main/java/org/apache/hadoop/hbase/mapred/TableOutputFormat.java

        MANAGE HERALD DIFFERENTIAL RULES
        https://reviews.facebook.net/herald/view/differential/

        WHY DID I GET THIS EMAIL?
        https://reviews.facebook.net/herald/transcript/3759/

        Tip: use the X-Herald-Rules header to filter Herald messages in your client.

        Show
        Phabricator added a comment - dhruba requested code review of " [jira] HBASE-5419 FileAlreadyExistsException has moved from mapred to fs package". Reviewers: tedyu Change name of class to o.a.h.fs.FileAlreadyExistsException TEST PLAN recompile REVISION DETAIL https://reviews.facebook.net/D1767 AFFECTED FILES src/main/java/org/apache/hadoop/hbase/mapred/TableOutputFormat.java MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/3759/ Tip: use the X-Herald-Rules header to filter Herald messages in your client.
        Hide
        dhruba borthakur added a comment -

        This is related to MAPREDUCE-963

        Show
        dhruba borthakur added a comment - This is related to MAPREDUCE-963
        Hide
        Nicolas Spiegelberg added a comment -

        @Dhruba: when was this class refactored? I think users are still running 0.20.X, so I'm assuming that it's deprecated in 0.19

        Show
        Nicolas Spiegelberg added a comment - @Dhruba: when was this class refactored? I think users are still running 0.20.X, so I'm assuming that it's deprecated in 0.19
        Hide
        dhruba borthakur added a comment -

        Yes, both the classes in hadoop exist now, but mapred.FileAlreadyExistsException is deprecated.

        Show
        dhruba borthakur added a comment - Yes, both the classes in hadoop exist now, but mapred.FileAlreadyExistsException is deprecated.
        Hide
        Phabricator added a comment -

        stack has commented on the revision "[jira] HBASE-5419 FileAlreadyExistsException has moved from mapred to fs package".

        In what version did it move Dhruba? If we make this change will it mean we can't compile against hadoop 0.20 or 1.0.0? Thanks.

        REVISION DETAIL
        https://reviews.facebook.net/D1767

        Show
        Phabricator added a comment - stack has commented on the revision " [jira] HBASE-5419 FileAlreadyExistsException has moved from mapred to fs package". In what version did it move Dhruba? If we make this change will it mean we can't compile against hadoop 0.20 or 1.0.0? Thanks. REVISION DETAIL https://reviews.facebook.net/D1767
        Hide
        Phabricator added a comment -

        stack has commented on the revision "[jira] HBASE-5419 FileAlreadyExistsException has moved from mapred to fs package".

        In what version did it move Dhruba? If we make this change will it mean we can't compile against hadoop 0.20 or 1.0.0? Thanks.

        REVISION DETAIL
        https://reviews.facebook.net/D1767

        Show
        Phabricator added a comment - stack has commented on the revision " [jira] HBASE-5419 FileAlreadyExistsException has moved from mapred to fs package". In what version did it move Dhruba? If we make this change will it mean we can't compile against hadoop 0.20 or 1.0.0? Thanks. REVISION DETAIL https://reviews.facebook.net/D1767
        Hide
        dhruba borthakur added a comment -

        The hadoop change was done in HADOOP-6229 for hadoop 0.21. This change is present in hadoop 1.0.

        hbase currently compiles with hadoop 1.0, so this change should be ok to make, is it not?

        Show
        dhruba borthakur added a comment - The hadoop change was done in HADOOP-6229 for hadoop 0.21. This change is present in hadoop 1.0. hbase currently compiles with hadoop 1.0, so this change should be ok to make, is it not?
        Hide
        stack added a comment -

        Ok if this is for 0.94 only? I think its fine to drop 'support' for hadoop 0.20/branch-0.20-append in 0.94.

        Show
        stack added a comment - Ok if this is for 0.94 only? I think its fine to drop 'support' for hadoop 0.20/branch-0.20-append in 0.94.
        Hide
        dhruba borthakur added a comment -

        Yes, this is for 0.94 only.

        Show
        dhruba borthakur added a comment - Yes, this is for 0.94 only.
        Hide
        stack added a comment -

        Marking this for 0.94.0 for Lars's attention.

        Lars, you good w/ saying that 0.94.0 requires hadoop 1.0.0 at least? If so, we can commit this to 0.94.0. I'm good w/ 0.94.0 requiring 1.0.0 hadoop at least (We'd need to check that CDH3 has exception....)

        Show
        stack added a comment - Marking this for 0.94.0 for Lars's attention. Lars, you good w/ saying that 0.94.0 requires hadoop 1.0.0 at least? If so, we can commit this to 0.94.0. I'm good w/ 0.94.0 requiring 1.0.0 hadoop at least (We'd need to check that CDH3 has exception....)
        Hide
        Lars Hofhansl added a comment -

        If we label 0.94 "performance release" we shouldn't deprecate support for formerly supported Hadoop versions.

        That said, I'm fine with only supporting hadoop 1.0+ in 0.94. It does change the nature of the release somewhat, though.

        Count me in as +0

        Show
        Lars Hofhansl added a comment - If we label 0.94 "performance release" we shouldn't deprecate support for formerly supported Hadoop versions. That said, I'm fine with only supporting hadoop 1.0+ in 0.94. It does change the nature of the release somewhat, though. Count me in as +0
        Hide
        stack added a comment -

        Well, maybe this is for 0.96 then? That ok w/ you Dhruba? 0.96 will be the singularity, the release that gets the protobuf rpcs.... will require cluster shutdown and restart but thereafter, we should be able to upgrade running hbase across major versions.

        Show
        stack added a comment - Well, maybe this is for 0.96 then? That ok w/ you Dhruba? 0.96 will be the singularity, the release that gets the protobuf rpcs.... will require cluster shutdown and restart but thereafter, we should be able to upgrade running hbase across major versions.
        Hide
        dhruba borthakur added a comment -

        sounds fine to me, thanks for checking Stack.

        Show
        dhruba borthakur added a comment - sounds fine to me, thanks for checking Stack.
        Hide
        stack added a comment -

        Patch based on Dhruba's.

        Show
        stack added a comment - Patch based on Dhruba's.
        Hide
        stack added a comment -

        Committed one line patch based on Dhrubas. Thanks D.

        Show
        stack added a comment - Committed one line patch based on Dhrubas. Thanks D.
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #3388 (See https://builds.apache.org/job/HBase-TRUNK/3388/)
        HBASE-5419 FileAlreadyExistsException has moved from mapred to fs package (Revision 1391306)

        Result = SUCCESS
        stack :
        Files :

        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableOutputFormat.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #3388 (See https://builds.apache.org/job/HBase-TRUNK/3388/ ) HBASE-5419 FileAlreadyExistsException has moved from mapred to fs package (Revision 1391306) Result = SUCCESS stack : Files : /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableOutputFormat.java
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #197 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/197/)
        HBASE-5419 FileAlreadyExistsException has moved from mapred to fs package (Revision 1391306)

        Result = FAILURE
        stack :
        Files :

        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableOutputFormat.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #197 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/197/ ) HBASE-5419 FileAlreadyExistsException has moved from mapred to fs package (Revision 1391306) Result = FAILURE stack : Files : /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableOutputFormat.java
        Hide
        stack added a comment -

        Marking closed.

        Show
        stack added a comment - Marking closed.

          People

          • Assignee:
            dhruba borthakur
            Reporter:
            dhruba borthakur
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development