HBase
  1. HBase
  2. HBASE-5304 Pluggable split key policy
  3. HBASE-5368

Move PrefixSplitKeyPolicy out of the src/test into src, so it is accessible in HBase installs

    Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.94.0
    • Fix Version/s: 0.94.0
    • Component/s: regionserver
    • Labels:
      None

      Description

      Very simple change to make PrefixSplitKeyPolicy accessible in HBase installs (user still needs to setup the table(s) accordingly).

      Right now it is in src/test/org.apache.hadoop.hbase.regionserver, I propose moving it to src/org.apache.hadoop.hbase.regionserver (alongside ConstantSizeRegionSplitPolicy), and maybe renaming it too.

      1. 5368.txt
        7 kB
        Lars Hofhansl

        Activity

        Hide
        Lars Hofhansl added a comment -

        Simple patch. Just moves/renames the class and adds safety checks.

        Show
        Lars Hofhansl added a comment - Simple patch. Just moves/renames the class and adds safety checks.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12514067/5368.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        -1 javadoc. The javadoc tool appears to have generated -136 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 157 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.mapreduce.TestImportTsv
        org.apache.hadoop.hbase.mapred.TestTableMapReduce
        org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/936//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/936//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/936//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12514067/5368.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. -1 javadoc. The javadoc tool appears to have generated -136 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 157 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.mapreduce.TestImportTsv org.apache.hadoop.hbase.mapred.TestTableMapReduce org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/936//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/936//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/936//console This message is automatically generated.
        Hide
        stack added a comment -

        +1

        Show
        stack added a comment - +1
        Hide
        stack added a comment -

        +1

        Show
        stack added a comment - +1
        Hide
        Lars Hofhansl added a comment -

        Committed to trunk. Thanks for the review.

        Show
        Lars Hofhansl added a comment - Committed to trunk. Thanks for the review.
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-security #108 (See https://builds.apache.org/job/HBase-TRUNK-security/108/)
        HBASE-5368 Move PrefixSplitKeyPolicy out of the src/test into src, so it is accessible in HBase installs

        larsh :
        Files :

        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/KeyPrefixRegionSplitPolicy.java
        • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/PrefixSplitKeyPolicy.java
        • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionSplitPolicy.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-security #108 (See https://builds.apache.org/job/HBase-TRUNK-security/108/ ) HBASE-5368 Move PrefixSplitKeyPolicy out of the src/test into src, so it is accessible in HBase installs larsh : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/KeyPrefixRegionSplitPolicy.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/PrefixSplitKeyPolicy.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionSplitPolicy.java
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #2659 (See https://builds.apache.org/job/HBase-TRUNK/2659/)
        HBASE-5368 Move PrefixSplitKeyPolicy out of the src/test into src, so it is accessible in HBase installs

        larsh :
        Files :

        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/KeyPrefixRegionSplitPolicy.java
        • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/PrefixSplitKeyPolicy.java
        • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionSplitPolicy.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #2659 (See https://builds.apache.org/job/HBase-TRUNK/2659/ ) HBASE-5368 Move PrefixSplitKeyPolicy out of the src/test into src, so it is accessible in HBase installs larsh : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/KeyPrefixRegionSplitPolicy.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/PrefixSplitKeyPolicy.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionSplitPolicy.java

          People

          • Assignee:
            Lars Hofhansl
            Reporter:
            Lars Hofhansl
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development