HBase
  1. HBase
  2. HBASE-5364

Fix source files missing licenses in 0.92 and trunk

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.92.0, 0.94.0
    • Fix Version/s: 0.90.6, 0.92.1, 0.94.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      running 'mvn rat:check' shows that a few files have snuck in that do not have proper apache licenses. Ideally we should fix these before we cut another release/release candidate.

      This is a blocker for 0.94, and probably should be for the other branches as well.

      1. hbase-5364-v2.patch
        8 kB
        Jonathan Hsieh
      2. HBASE-5364-1.patch
        7 kB
        Elliott Clark
      3. hbase-5364-0.92.patch
        1 kB
        Jonathan Hsieh
      4. hbase-5364-0.90.patch
        0.9 kB
        Shaneal Manek

        Activity

        Hide
        Jean-Daniel Cryans added a comment -

        I marked this as fixed for 0.90.6 but I'm not changing the title since it's all over the CHANGES.txt files.

        Show
        Jean-Daniel Cryans added a comment - I marked this as fixed for 0.90.6 but I'm not changing the title since it's all over the CHANGES.txt files.
        Hide
        stack added a comment -

        I applied Shaneal's addendum to 0.90 branch. Thanks for the cleanup Shaneal

        Show
        stack added a comment - I applied Shaneal's addendum to 0.90 branch. Thanks for the cleanup Shaneal
        Hide
        Hudson added a comment -

        Integrated in HBase-0.92-security #91 (See https://builds.apache.org/job/HBase-0.92-security/91/)
        HBASE-5364 Fix source files missing licenses in 0.92 and trunk (Revision 1242899)

        Result = FAILURE
        jmhsieh :
        Files :

        • /hbase/branches/0.92/CHANGES.txt
        • /hbase/branches/0.92/src/docbkx/build.xml
        Show
        Hudson added a comment - Integrated in HBase-0.92-security #91 (See https://builds.apache.org/job/HBase-0.92-security/91/ ) HBASE-5364 Fix source files missing licenses in 0.92 and trunk (Revision 1242899) Result = FAILURE jmhsieh : Files : /hbase/branches/0.92/CHANGES.txt /hbase/branches/0.92/src/docbkx/build.xml
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-security #108 (See https://builds.apache.org/job/HBase-TRUNK-security/108/)
        HBASE-5364 Fix source files missing license in 0.92 and trunk (Elliott Clark)

        jmhsieh :
        Files :

        • /hbase/trunk/bin/hbase-jruby
        • /hbase/trunk/dev-support/findHangingTest.sh
        • /hbase/trunk/src/main/python/hbase/merge_conf.py
        • /hbase/trunk/src/packages/deb/conf-pseudo.control/control
        • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/TestHTableDescriptor.java
        • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/constraint/RuntimeFailConstraint.java
        • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportExport.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-security #108 (See https://builds.apache.org/job/HBase-TRUNK-security/108/ ) HBASE-5364 Fix source files missing license in 0.92 and trunk (Elliott Clark) jmhsieh : Files : /hbase/trunk/bin/hbase-jruby /hbase/trunk/dev-support/findHangingTest.sh /hbase/trunk/src/main/python/hbase/merge_conf.py /hbase/trunk/src/packages/deb/conf-pseudo.control/control /hbase/trunk/src/test/java/org/apache/hadoop/hbase/TestHTableDescriptor.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/constraint/RuntimeFailConstraint.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportExport.java
        Hide
        Hudson added a comment -

        Integrated in HBase-0.92 #276 (See https://builds.apache.org/job/HBase-0.92/276/)
        HBASE-5364 Fix source files missing licenses in 0.92 and trunk

        jmhsieh :
        Files :

        • /hbase/branches/0.92/CHANGES.txt
        • /hbase/branches/0.92/src/docbkx/build.xml
        Show
        Hudson added a comment - Integrated in HBase-0.92 #276 (See https://builds.apache.org/job/HBase-0.92/276/ ) HBASE-5364 Fix source files missing licenses in 0.92 and trunk jmhsieh : Files : /hbase/branches/0.92/CHANGES.txt /hbase/branches/0.92/src/docbkx/build.xml
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #2658 (See https://builds.apache.org/job/HBase-TRUNK/2658/)
        HBASE-5364 Fix source files missing license in 0.92 and trunk (Elliott Clark)

        jmhsieh :
        Files :

        • /hbase/trunk/bin/hbase-jruby
        • /hbase/trunk/dev-support/findHangingTest.sh
        • /hbase/trunk/src/main/python/hbase/merge_conf.py
        • /hbase/trunk/src/packages/deb/conf-pseudo.control/control
        • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/TestHTableDescriptor.java
        • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/constraint/RuntimeFailConstraint.java
        • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportExport.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #2658 (See https://builds.apache.org/job/HBase-TRUNK/2658/ ) HBASE-5364 Fix source files missing license in 0.92 and trunk (Elliott Clark) jmhsieh : Files : /hbase/trunk/bin/hbase-jruby /hbase/trunk/dev-support/findHangingTest.sh /hbase/trunk/src/main/python/hbase/merge_conf.py /hbase/trunk/src/packages/deb/conf-pseudo.control/control /hbase/trunk/src/test/java/org/apache/hadoop/hbase/TestHTableDescriptor.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/constraint/RuntimeFailConstraint.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportExport.java
        Hide
        Jonathan Hsieh added a comment -

        Committed. Thanks for the patch Elliott!

        Show
        Jonathan Hsieh added a comment - Committed. Thanks for the patch Elliott!
        Hide
        Jonathan Hsieh added a comment -

        Includes update bin/hbase-jruby

        Show
        Jonathan Hsieh added a comment - Includes update bin/hbase-jruby
        Hide
        Jonathan Hsieh added a comment -

        @Stack

        I'll commit it. I need to do a tweak on the maven stuff HBASE-5363, and if you could take a look at HBASE-5377 (I check web pages and info port and they looked good, not completely sure about other things I might have to worry about.)

        Show
        Jonathan Hsieh added a comment - @Stack I'll commit it. I need to do a tweak on the maven stuff HBASE-5363 , and if you could take a look at HBASE-5377 (I check web pages and info port and they looked good, not completely sure about other things I might have to worry about.)
        Hide
        stack added a comment -

        You fellas going to commit?

        Show
        stack added a comment - You fellas going to commit?
        Hide
        Elliott Clark added a comment -

        Thanks

        Show
        Elliott Clark added a comment - Thanks
        Hide
        Jonathan Hsieh added a comment -

        Found an example of debian control files elsewhere where commented license included. Will include.

        Show
        Jonathan Hsieh added a comment - Found an example of debian control files elsewhere where commented license included. Will include.
        Hide
        Jonathan Hsieh added a comment -

        Patch for 0.92 license violation.

        Show
        Jonathan Hsieh added a comment - Patch for 0.92 license violation.
        Hide
        Jonathan Hsieh added a comment -

        Not clear to me if src/packages/deb/conf-pseudo.control/control needs to have license or not (and don't know how to test). I may exclude that one the trunk version.

        Show
        Jonathan Hsieh added a comment - Not clear to me if src/packages/deb/conf-pseudo.control/control needs to have license or not (and don't know how to test). I may exclude that one the trunk version.
        Hide
        Jonathan Hsieh added a comment -

        Not clear to me if src/packages/deb/conf-pseudo.control/control needs to have license or not (and don't know how to test). I may exclude that one the trunk version.

        Show
        Jonathan Hsieh added a comment - Not clear to me if src/packages/deb/conf-pseudo.control/control needs to have license or not (and don't know how to test). I may exclude that one the trunk version.
        Hide
        Jonathan Hsieh added a comment -

        I'll just take care of it before I commit.

        Show
        Jonathan Hsieh added a comment - I'll just take care of it before I commit.
        Hide
        Jonathan Hsieh added a comment -

        Elliot, After your patch and HBASE-5363, there is one other violation on trunk: bin/hbase-jruby

        Show
        Jonathan Hsieh added a comment - Elliot, After your patch and HBASE-5363 , there is one other violation on trunk: bin/hbase-jruby
        Hide
        Elliott Clark added a comment -

        Attach patch to fix files on master.

        Show
        Elliott Clark added a comment - Attach patch to fix files on master.

          People

          • Assignee:
            Elliott Clark
            Reporter:
            Jonathan Hsieh
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development