Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.94.0, 0.95.0
    • Component/s: metrics, Thrift
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      We have added thrift metrics collection in HBASE-5186.
      It will be good to have them in thrift2 as well.

        Activity

        Hide
        Phabricator added a comment -

        sc requested code review of "HBASE-5298 [jira] Add thrift metrics to thrift2".
        Reviewers: tedyu, JIRA

        Add thrift metrics to thrift2

        We have added thrift metrics collection in HBASE-5186.
        It will be good to have them in thrift2 as well.

        TEST PLAN
        EMPTY

        REVISION DETAIL
        https://reviews.facebook.net/D1629

        AFFECTED FILES
        src/main/java/org/apache/hadoop/hbase/thrift2/CallQueue.java
        src/main/java/org/apache/hadoop/hbase/thrift2/ThriftHBaseServiceHandler.java
        src/main/java/org/apache/hadoop/hbase/thrift2/ThriftMetrics.java
        src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java
        src/test/java/org/apache/hadoop/hbase/thrift2/TestCallQueue.java
        src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java

        MANAGE HERALD DIFFERENTIAL RULES
        https://reviews.facebook.net/herald/view/differential/

        WHY DID I GET THIS EMAIL?
        https://reviews.facebook.net/herald/transcript/3459/

        Tip: use the X-Herald-Rules header to filter Herald messages in your client.

        Show
        Phabricator added a comment - sc requested code review of " HBASE-5298 [jira] Add thrift metrics to thrift2". Reviewers: tedyu, JIRA Add thrift metrics to thrift2 We have added thrift metrics collection in HBASE-5186 . It will be good to have them in thrift2 as well. TEST PLAN EMPTY REVISION DETAIL https://reviews.facebook.net/D1629 AFFECTED FILES src/main/java/org/apache/hadoop/hbase/thrift2/CallQueue.java src/main/java/org/apache/hadoop/hbase/thrift2/ThriftHBaseServiceHandler.java src/main/java/org/apache/hadoop/hbase/thrift2/ThriftMetrics.java src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java src/test/java/org/apache/hadoop/hbase/thrift2/TestCallQueue.java src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/3459/ Tip: use the X-Herald-Rules header to filter Herald messages in your client.
        Hide
        Phabricator added a comment -

        tedyu has commented on the revision "HBASE-5298 [jira] Add thrift metrics to thrift2".

        Can we reuse the classes, CallQueue and ThriftMetrics, from src/main/java/org/apache/hadoop/hbase/thrift ?

        REVISION DETAIL
        https://reviews.facebook.net/D1629

        Show
        Phabricator added a comment - tedyu has commented on the revision " HBASE-5298 [jira] Add thrift metrics to thrift2". Can we reuse the classes, CallQueue and ThriftMetrics, from src/main/java/org/apache/hadoop/hbase/thrift ? REVISION DETAIL https://reviews.facebook.net/D1629
        Hide
        Phabricator added a comment -

        sc has commented on the revision "HBASE-5298 [jira] Add thrift metrics to thrift2".

        I thought about that also. I was just not sure if there can be dependency between thrift and thrift2. I don't understand thrift2 enough.

        Thanks for the comment Ted. I will make the change and update the patch soon.

        REVISION DETAIL
        https://reviews.facebook.net/D1629

        Show
        Phabricator added a comment - sc has commented on the revision " HBASE-5298 [jira] Add thrift metrics to thrift2". I thought about that also. I was just not sure if there can be dependency between thrift and thrift2. I don't understand thrift2 enough. Thanks for the comment Ted. I will make the change and update the patch soon. REVISION DETAIL https://reviews.facebook.net/D1629
        Hide
        Phabricator added a comment -

        sc updated the revision "HBASE-5298 [jira] Add thrift metrics to thrift2".
        Reviewers: tedyu, JIRA

        Addressed Ted's review comments

        REVISION DETAIL
        https://reviews.facebook.net/D1629

        AFFECTED FILES
        src/main/java/org/apache/hadoop/hbase/thrift/ThriftMetrics.java
        src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
        src/main/java/org/apache/hadoop/hbase/thrift2/ThriftHBaseServiceHandler.java
        src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java
        src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
        src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java

        Show
        Phabricator added a comment - sc updated the revision " HBASE-5298 [jira] Add thrift metrics to thrift2". Reviewers: tedyu, JIRA Addressed Ted's review comments REVISION DETAIL https://reviews.facebook.net/D1629 AFFECTED FILES src/main/java/org/apache/hadoop/hbase/thrift/ThriftMetrics.java src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java src/main/java/org/apache/hadoop/hbase/thrift2/ThriftHBaseServiceHandler.java src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java
        Hide
        Phabricator added a comment -

        tedyu has commented on the revision "HBASE-5298 [jira] Add thrift metrics to thrift2".

        Looks good overall.

        INLINE COMMENTS
        src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java:176 Should this be named thrift2-worker-%d ?
        src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java:583 Should we check whether DEBUG is enabled before entering the loop ?

        REVISION DETAIL
        https://reviews.facebook.net/D1629

        Show
        Phabricator added a comment - tedyu has commented on the revision " HBASE-5298 [jira] Add thrift metrics to thrift2". Looks good overall. INLINE COMMENTS src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java:176 Should this be named thrift2-worker-%d ? src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java:583 Should we check whether DEBUG is enabled before entering the loop ? REVISION DETAIL https://reviews.facebook.net/D1629
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12513750/HBASE-5298.D1629.2.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        -1 javadoc. The javadoc tool appears to have generated -136 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 156 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/920//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/920//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/920//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12513750/HBASE-5298.D1629.2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. -1 javadoc. The javadoc tool appears to have generated -136 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 156 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/920//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/920//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/920//console This message is automatically generated.
        Hide
        Phabricator added a comment -

        tedyu has commented on the revision "HBASE-5298 [jira] Add thrift metrics to thrift2".

        Please update thrift/TestCallQueue.java which currently produces the following:

        [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/src/test/java/org/apache/hadoop/hbase/thrift/TestCallQueue.java:[109,11] cannot find symbol
        [ERROR] symbol : constructor ThriftMetrics(int,org.apache.hadoop.conf.Configuration)
        [ERROR] location: class org.apache.hadoop.hbase.thrift.ThriftMetrics

        REVISION DETAIL
        https://reviews.facebook.net/D1629

        Show
        Phabricator added a comment - tedyu has commented on the revision " HBASE-5298 [jira] Add thrift metrics to thrift2". Please update thrift/TestCallQueue.java which currently produces the following: [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/src/test/java/org/apache/hadoop/hbase/thrift/TestCallQueue.java: [109,11] cannot find symbol [ERROR] symbol : constructor ThriftMetrics(int,org.apache.hadoop.conf.Configuration) [ERROR] location: class org.apache.hadoop.hbase.thrift.ThriftMetrics REVISION DETAIL https://reviews.facebook.net/D1629
        Hide
        Phabricator added a comment -

        stack has commented on the revision "HBASE-5298 [jira] Add thrift metrics to thrift2".

        lgtm

        REVISION DETAIL
        https://reviews.facebook.net/D1629

        Show
        Phabricator added a comment - stack has commented on the revision " HBASE-5298 [jira] Add thrift metrics to thrift2". lgtm REVISION DETAIL https://reviews.facebook.net/D1629
        Hide
        Ted Yu added a comment -

        Patch v3 compiles.
        Also addressed two of my earlier comments tonight.

        Show
        Ted Yu added a comment - Patch v3 compiles. Also addressed two of my earlier comments tonight.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12513760/5298-v3.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 9 new or modified tests.

        -1 javadoc. The javadoc tool appears to have generated -136 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 156 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.io.hfile.TestHFileBlock
        org.apache.hadoop.hbase.mapreduce.TestImportTsv
        org.apache.hadoop.hbase.mapred.TestTableMapReduce
        org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/921//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/921//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/921//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12513760/5298-v3.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified tests. -1 javadoc. The javadoc tool appears to have generated -136 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 156 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.io.hfile.TestHFileBlock org.apache.hadoop.hbase.mapreduce.TestImportTsv org.apache.hadoop.hbase.mapred.TestTableMapReduce org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/921//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/921//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/921//console This message is automatically generated.
        Hide
        Phabricator added a comment -

        sc updated the revision "HBASE-5298 [jira] Add thrift metrics to thrift2".
        Reviewers: tedyu, JIRA

        Fix TestCallQueue and remove a dead variable.

        REVISION DETAIL
        https://reviews.facebook.net/D1629

        AFFECTED FILES
        src/main/java/org/apache/hadoop/hbase/thrift/TBoundedThreadPoolServer.java
        src/main/java/org/apache/hadoop/hbase/thrift/ThriftMetrics.java
        src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
        src/main/java/org/apache/hadoop/hbase/thrift2/ThriftHBaseServiceHandler.java
        src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java
        src/test/java/org/apache/hadoop/hbase/thrift/TestCallQueue.java
        src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
        src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java

        Show
        Phabricator added a comment - sc updated the revision " HBASE-5298 [jira] Add thrift metrics to thrift2". Reviewers: tedyu, JIRA Fix TestCallQueue and remove a dead variable. REVISION DETAIL https://reviews.facebook.net/D1629 AFFECTED FILES src/main/java/org/apache/hadoop/hbase/thrift/TBoundedThreadPoolServer.java src/main/java/org/apache/hadoop/hbase/thrift/ThriftMetrics.java src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java src/main/java/org/apache/hadoop/hbase/thrift2/ThriftHBaseServiceHandler.java src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java src/test/java/org/apache/hadoop/hbase/thrift/TestCallQueue.java src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java
        Hide
        Phabricator added a comment -

        sc updated the revision "HBASE-5298 [jira] Add thrift metrics to thrift2".
        Reviewers: tedyu, JIRA

        Fixed the inline comments

        REVISION DETAIL
        https://reviews.facebook.net/D1629

        AFFECTED FILES
        src/main/java/org/apache/hadoop/hbase/thrift/TBoundedThreadPoolServer.java
        src/main/java/org/apache/hadoop/hbase/thrift/ThriftMetrics.java
        src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
        src/main/java/org/apache/hadoop/hbase/thrift2/ThriftHBaseServiceHandler.java
        src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java
        src/test/java/org/apache/hadoop/hbase/thrift/TestCallQueue.java
        src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
        src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java

        Show
        Phabricator added a comment - sc updated the revision " HBASE-5298 [jira] Add thrift metrics to thrift2". Reviewers: tedyu, JIRA Fixed the inline comments REVISION DETAIL https://reviews.facebook.net/D1629 AFFECTED FILES src/main/java/org/apache/hadoop/hbase/thrift/TBoundedThreadPoolServer.java src/main/java/org/apache/hadoop/hbase/thrift/ThriftMetrics.java src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java src/main/java/org/apache/hadoop/hbase/thrift2/ThriftHBaseServiceHandler.java src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java src/test/java/org/apache/hadoop/hbase/thrift/TestCallQueue.java src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12513778/HBASE-5298.D1629.4.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 9 new or modified tests.

        -1 javadoc. The javadoc tool appears to have generated -136 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 156 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
        org.apache.hadoop.hbase.mapred.TestTableMapReduce
        org.apache.hadoop.hbase.io.hfile.TestHFileBlock
        org.apache.hadoop.hbase.mapreduce.TestImportTsv

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/922//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/922//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/922//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12513778/HBASE-5298.D1629.4.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified tests. -1 javadoc. The javadoc tool appears to have generated -136 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 156 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat org.apache.hadoop.hbase.mapred.TestTableMapReduce org.apache.hadoop.hbase.io.hfile.TestHFileBlock org.apache.hadoop.hbase.mapreduce.TestImportTsv Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/922//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/922//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/922//console This message is automatically generated.
        Hide
        Phabricator added a comment -

        tedyu has accepted the revision "HBASE-5298 [jira] Add thrift metrics to thrift2".

        REVISION DETAIL
        https://reviews.facebook.net/D1629

        Show
        Phabricator added a comment - tedyu has accepted the revision " HBASE-5298 [jira] Add thrift metrics to thrift2". REVISION DETAIL https://reviews.facebook.net/D1629
        Hide
        Ted Yu added a comment -

        Integrated to TRUNK.

        Thanks for the patch, Scott.

        Show
        Ted Yu added a comment - Integrated to TRUNK. Thanks for the patch, Scott.
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-security #102 (See https://builds.apache.org/job/HBase-TRUNK-security/102/)
        HBASE-5298 Add thrift metrics to thrift2

        tedyu :
        Files :

        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/TBoundedThreadPoolServer.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/ThriftMetrics.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftHBaseServiceHandler.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java
        • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/thrift/TestCallQueue.java
        • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
        • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-security #102 (See https://builds.apache.org/job/HBase-TRUNK-security/102/ ) HBASE-5298 Add thrift metrics to thrift2 tedyu : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/TBoundedThreadPoolServer.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/ThriftMetrics.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftHBaseServiceHandler.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/thrift/TestCallQueue.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #2656 (See https://builds.apache.org/job/HBase-TRUNK/2656/)
        HBASE-5298 Add thrift metrics to thrift2

        tedyu :
        Files :

        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/TBoundedThreadPoolServer.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/ThriftMetrics.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftHBaseServiceHandler.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java
        • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/thrift/TestCallQueue.java
        • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
        • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #2656 (See https://builds.apache.org/job/HBase-TRUNK/2656/ ) HBASE-5298 Add thrift metrics to thrift2 tedyu : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/TBoundedThreadPoolServer.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/ThriftMetrics.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftHBaseServiceHandler.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/thrift/TestCallQueue.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java
        Hide
        Lars Hofhansl added a comment -

        What is the status of this? Wanna finish for 0.94, or should I move this to 0.96?

        Show
        Lars Hofhansl added a comment - What is the status of this? Wanna finish for 0.94, or should I move this to 0.96?
        Hide
        Scott Chen added a comment -

        0.96 is fine with me.
        @apurtell: What do you think?

        Show
        Scott Chen added a comment - 0.96 is fine with me. @apurtell: What do you think?
        Hide
        Lars Hofhansl added a comment -

        Never mind, I'm an idiot. Ted had committed this already on Feb 10th (which means it is in 0.94 and 0.96). I just need to mark this fixed.

        Show
        Lars Hofhansl added a comment - Never mind, I'm an idiot. Ted had committed this already on Feb 10th (which means it is in 0.94 and 0.96). I just need to mark this fixed.
        Hide
        Phabricator added a comment -

        sc has closed the revision "HBASE-5298 [jira] Add thrift metrics to thrift2".

        REVISION DETAIL
        https://reviews.facebook.net/D1629

        To: tedyu, JIRA, sc
        Cc: dhruba, tedyu, sc, stack

        Show
        Phabricator added a comment - sc has closed the revision " HBASE-5298 [jira] Add thrift metrics to thrift2". REVISION DETAIL https://reviews.facebook.net/D1629 To: tedyu, JIRA, sc Cc: dhruba, tedyu, sc, stack

          People

          • Assignee:
            Scott Chen
            Reporter:
            Scott Chen
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development