HBase
  1. HBase
  2. HBASE-5295

Improve the Thrift API to switch on/off writing to wal for Mutations

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Thrift
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The thrift api currently does not support switching off updating wal for Puts/Deletes. Support it.

      1. ASF.LICENSE.NOT.GRANTED--D3015.4.patch
        34 kB
        Phabricator
      2. ASF.LICENSE.NOT.GRANTED--D3015.3.patch
        34 kB
        Phabricator
      3. ASF.LICENSE.NOT.GRANTED--D3015.2.patch
        32 kB
        Phabricator
      4. ASF.LICENSE.NOT.GRANTED--D3015.1.patch
        30 kB
        Phabricator
      5. ASF.LICENSE.NOT.GRANTED--D1515.2.patch
        71 kB
        Phabricator
      6. ASF.LICENSE.NOT.GRANTED--D1515.2.patch
        71 kB
        Phabricator
      7. ASF.LICENSE.NOT.GRANTED--D1515.2.patch
        71 kB
        Phabricator
      8. ASF.LICENSE.NOT.GRANTED--D1515.2.patch
        71 kB
        Phabricator
      9. ASF.LICENSE.NOT.GRANTED--D1515.1.patch
        48 kB
        Phabricator
      10. ASF.LICENSE.NOT.GRANTED--D1515.1.patch
        48 kB
        Phabricator
      11. ASF.LICENSE.NOT.GRANTED--D1515.1.patch
        48 kB
        Phabricator
      12. ASF.LICENSE.NOT.GRANTED--D1515.1.patch
        48 kB
        Phabricator

        Activity

        Hide
        Phabricator added a comment -

        dhruba requested code review of "[jira] HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations".
        Reviewers: sc, tedyu, stack

        Enhance the thrift api to have the ability to switch of wal when doing a put or delete. The only change is adding a new field to the thrift Mutation object.

        TEST PLAN
        TestThriftServer

        REVISION DETAIL
        https://reviews.facebook.net/D1515

        AFFECTED FILES
        src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
        src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
        src/main/java/org/apache/hadoop/hbase/thrift/generated/Mutation.java
        src/main/java/org/apache/hadoop/hbase/thrift/generated/BatchMutation.java
        src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java
        src/main/java/org/apache/hadoop/hbase/thrift/generated/TScan.java
        src/main/java/org/apache/hadoop/hbase/thrift/generated/TRowResult.java
        src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift

        MANAGE HERALD DIFFERENTIAL RULES
        https://reviews.facebook.net/herald/view/differential/

        WHY DID I GET THIS EMAIL?
        https://reviews.facebook.net/herald/transcript/3165/

        Tip: use the X-Herald-Rules header to filter Herald messages in your client.

        Show
        Phabricator added a comment - dhruba requested code review of " [jira] HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations". Reviewers: sc, tedyu, stack Enhance the thrift api to have the ability to switch of wal when doing a put or delete. The only change is adding a new field to the thrift Mutation object. TEST PLAN TestThriftServer REVISION DETAIL https://reviews.facebook.net/D1515 AFFECTED FILES src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java src/main/java/org/apache/hadoop/hbase/thrift/generated/Mutation.java src/main/java/org/apache/hadoop/hbase/thrift/generated/BatchMutation.java src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java src/main/java/org/apache/hadoop/hbase/thrift/generated/TScan.java src/main/java/org/apache/hadoop/hbase/thrift/generated/TRowResult.java src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/3165/ Tip: use the X-Herald-Rules header to filter Herald messages in your client.
        Hide
        Phabricator added a comment -

        dhruba requested code review of "[jira] HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations".
        Reviewers: sc, tedyu, stack

        Enhance the thrift api to have the ability to switch of wal when doing a put or delete. The only change is adding a new field to the thrift Mutation object.

        TEST PLAN
        TestThriftServer

        REVISION DETAIL
        https://reviews.facebook.net/D1515

        AFFECTED FILES
        src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
        src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
        src/main/java/org/apache/hadoop/hbase/thrift/generated/Mutation.java
        src/main/java/org/apache/hadoop/hbase/thrift/generated/BatchMutation.java
        src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java
        src/main/java/org/apache/hadoop/hbase/thrift/generated/TScan.java
        src/main/java/org/apache/hadoop/hbase/thrift/generated/TRowResult.java
        src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift

        MANAGE HERALD DIFFERENTIAL RULES
        https://reviews.facebook.net/herald/view/differential/

        WHY DID I GET THIS EMAIL?
        https://reviews.facebook.net/herald/transcript/3165/

        Tip: use the X-Herald-Rules header to filter Herald messages in your client.

        Show
        Phabricator added a comment - dhruba requested code review of " [jira] HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations". Reviewers: sc, tedyu, stack Enhance the thrift api to have the ability to switch of wal when doing a put or delete. The only change is adding a new field to the thrift Mutation object. TEST PLAN TestThriftServer REVISION DETAIL https://reviews.facebook.net/D1515 AFFECTED FILES src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java src/main/java/org/apache/hadoop/hbase/thrift/generated/Mutation.java src/main/java/org/apache/hadoop/hbase/thrift/generated/BatchMutation.java src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java src/main/java/org/apache/hadoop/hbase/thrift/generated/TScan.java src/main/java/org/apache/hadoop/hbase/thrift/generated/TRowResult.java src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/3165/ Tip: use the X-Herald-Rules header to filter Herald messages in your client.
        Hide
        Phabricator added a comment -

        dhruba requested code review of "[jira] HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations".
        Reviewers: sc, tedyu, stack

        Enhance the thrift api to have the ability to switch of wal when doing a put or delete. The only change is adding a new field to the thrift Mutation object.

        TEST PLAN
        TestThriftServer

        REVISION DETAIL
        https://reviews.facebook.net/D1515

        AFFECTED FILES
        src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
        src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
        src/main/java/org/apache/hadoop/hbase/thrift/generated/Mutation.java
        src/main/java/org/apache/hadoop/hbase/thrift/generated/BatchMutation.java
        src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java
        src/main/java/org/apache/hadoop/hbase/thrift/generated/TScan.java
        src/main/java/org/apache/hadoop/hbase/thrift/generated/TRowResult.java
        src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift

        MANAGE HERALD DIFFERENTIAL RULES
        https://reviews.facebook.net/herald/view/differential/

        WHY DID I GET THIS EMAIL?
        https://reviews.facebook.net/herald/transcript/3165/

        Tip: use the X-Herald-Rules header to filter Herald messages in your client.

        Show
        Phabricator added a comment - dhruba requested code review of " [jira] HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations". Reviewers: sc, tedyu, stack Enhance the thrift api to have the ability to switch of wal when doing a put or delete. The only change is adding a new field to the thrift Mutation object. TEST PLAN TestThriftServer REVISION DETAIL https://reviews.facebook.net/D1515 AFFECTED FILES src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java src/main/java/org/apache/hadoop/hbase/thrift/generated/Mutation.java src/main/java/org/apache/hadoop/hbase/thrift/generated/BatchMutation.java src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java src/main/java/org/apache/hadoop/hbase/thrift/generated/TScan.java src/main/java/org/apache/hadoop/hbase/thrift/generated/TRowResult.java src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/3165/ Tip: use the X-Herald-Rules header to filter Herald messages in your client.
        Hide
        Phabricator added a comment -

        dhruba requested code review of "[jira] HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations".
        Reviewers: sc, tedyu, stack

        Enhance the thrift api to have the ability to switch of wal when doing a put or delete. The only change is adding a new field to the thrift Mutation object.

        TEST PLAN
        TestThriftServer

        REVISION DETAIL
        https://reviews.facebook.net/D1515

        AFFECTED FILES
        src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
        src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
        src/main/java/org/apache/hadoop/hbase/thrift/generated/Mutation.java
        src/main/java/org/apache/hadoop/hbase/thrift/generated/BatchMutation.java
        src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java
        src/main/java/org/apache/hadoop/hbase/thrift/generated/TScan.java
        src/main/java/org/apache/hadoop/hbase/thrift/generated/TRowResult.java
        src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift

        MANAGE HERALD DIFFERENTIAL RULES
        https://reviews.facebook.net/herald/view/differential/

        WHY DID I GET THIS EMAIL?
        https://reviews.facebook.net/herald/transcript/3165/

        Tip: use the X-Herald-Rules header to filter Herald messages in your client.

        Show
        Phabricator added a comment - dhruba requested code review of " [jira] HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations". Reviewers: sc, tedyu, stack Enhance the thrift api to have the ability to switch of wal when doing a put or delete. The only change is adding a new field to the thrift Mutation object. TEST PLAN TestThriftServer REVISION DETAIL https://reviews.facebook.net/D1515 AFFECTED FILES src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java src/main/java/org/apache/hadoop/hbase/thrift/generated/Mutation.java src/main/java/org/apache/hadoop/hbase/thrift/generated/BatchMutation.java src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java src/main/java/org/apache/hadoop/hbase/thrift/generated/TScan.java src/main/java/org/apache/hadoop/hbase/thrift/generated/TRowResult.java src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/3165/ Tip: use the X-Herald-Rules header to filter Herald messages in your client.
        Hide
        Phabricator added a comment -

        tedyu has commented on the revision "[jira] HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations".

        INLINE COMMENTS
        src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java:859 What about thrift2 ?
        e.g. src/main/java/org/apache/hadoop/hbase/thrift2/ThriftUtilities.java has counterparts for this method.

        REVISION DETAIL
        https://reviews.facebook.net/D1515

        Show
        Phabricator added a comment - tedyu has commented on the revision " [jira] HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations". INLINE COMMENTS src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java:859 What about thrift2 ? e.g. src/main/java/org/apache/hadoop/hbase/thrift2/ThriftUtilities.java has counterparts for this method. REVISION DETAIL https://reviews.facebook.net/D1515
        Hide
        Phabricator added a comment -

        tedyu has commented on the revision "[jira] HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations".

        INLINE COMMENTS
        src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java:859 What about thrift2 ?
        e.g. src/main/java/org/apache/hadoop/hbase/thrift2/ThriftUtilities.java has counterparts for this method.

        REVISION DETAIL
        https://reviews.facebook.net/D1515

        Show
        Phabricator added a comment - tedyu has commented on the revision " [jira] HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations". INLINE COMMENTS src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java:859 What about thrift2 ? e.g. src/main/java/org/apache/hadoop/hbase/thrift2/ThriftUtilities.java has counterparts for this method. REVISION DETAIL https://reviews.facebook.net/D1515
        Hide
        Phabricator added a comment -

        tedyu has commented on the revision "[jira] HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations".

        INLINE COMMENTS
        src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java:859 What about thrift2 ?
        e.g. src/main/java/org/apache/hadoop/hbase/thrift2/ThriftUtilities.java has counterparts for this method.

        REVISION DETAIL
        https://reviews.facebook.net/D1515

        Show
        Phabricator added a comment - tedyu has commented on the revision " [jira] HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations". INLINE COMMENTS src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java:859 What about thrift2 ? e.g. src/main/java/org/apache/hadoop/hbase/thrift2/ThriftUtilities.java has counterparts for this method. REVISION DETAIL https://reviews.facebook.net/D1515
        Hide
        Phabricator added a comment -

        tedyu has commented on the revision "[jira] HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations".

        INLINE COMMENTS
        src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java:859 What about thrift2 ?
        e.g. src/main/java/org/apache/hadoop/hbase/thrift2/ThriftUtilities.java has counterparts for this method.

        REVISION DETAIL
        https://reviews.facebook.net/D1515

        Show
        Phabricator added a comment - tedyu has commented on the revision " [jira] HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations". INLINE COMMENTS src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java:859 What about thrift2 ? e.g. src/main/java/org/apache/hadoop/hbase/thrift2/ThriftUtilities.java has counterparts for this method. REVISION DETAIL https://reviews.facebook.net/D1515
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12512345/D1515.1.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        -1 javadoc. The javadoc tool appears to have generated -140 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 161 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
        org.apache.hadoop.hbase.mapred.TestTableMapReduce
        org.apache.hadoop.hbase.client.TestFromClientSide
        org.apache.hadoop.hbase.io.hfile.TestHFileBlock
        org.apache.hadoop.hbase.mapreduce.TestImportTsv

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/866//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/866//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/866//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12512345/D1515.1.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 javadoc. The javadoc tool appears to have generated -140 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 161 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat org.apache.hadoop.hbase.mapred.TestTableMapReduce org.apache.hadoop.hbase.client.TestFromClientSide org.apache.hadoop.hbase.io.hfile.TestHFileBlock org.apache.hadoop.hbase.mapreduce.TestImportTsv Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/866//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/866//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/866//console This message is automatically generated.
        Hide
        Phabricator added a comment -

        dhruba has commented on the revision "[jira] HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations".

        INLINE COMMENTS
        src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java:859 thrift2/TPut already has the feature to switch off wal if needed, no further work is necessary.

        also, just curious: the two thrift apis are not same. there are some features exposed via thrift that are not exposed via thrift2 and vice-versa. can you pl educate me on the history on why we have two different thrift apis?

        REVISION DETAIL
        https://reviews.facebook.net/D1515

        Show
        Phabricator added a comment - dhruba has commented on the revision " [jira] HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations". INLINE COMMENTS src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java:859 thrift2/TPut already has the feature to switch off wal if needed, no further work is necessary. also, just curious: the two thrift apis are not same. there are some features exposed via thrift that are not exposed via thrift2 and vice-versa. can you pl educate me on the history on why we have two different thrift apis? REVISION DETAIL https://reviews.facebook.net/D1515
        Hide
        Phabricator added a comment -

        dhruba has commented on the revision "[jira] HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations".

        INLINE COMMENTS
        src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java:859 thrift2/TPut already has the feature to switch off wal if needed, no further work is necessary.

        also, just curious: the two thrift apis are not same. there are some features exposed via thrift that are not exposed via thrift2 and vice-versa. can you pl educate me on the history on why we have two different thrift apis?

        REVISION DETAIL
        https://reviews.facebook.net/D1515

        Show
        Phabricator added a comment - dhruba has commented on the revision " [jira] HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations". INLINE COMMENTS src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java:859 thrift2/TPut already has the feature to switch off wal if needed, no further work is necessary. also, just curious: the two thrift apis are not same. there are some features exposed via thrift that are not exposed via thrift2 and vice-versa. can you pl educate me on the history on why we have two different thrift apis? REVISION DETAIL https://reviews.facebook.net/D1515
        Hide
        Phabricator added a comment -

        dhruba has commented on the revision "[jira] HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations".

        INLINE COMMENTS
        src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java:859 thrift2/TPut already has the feature to switch off wal if needed, no further work is necessary.

        also, just curious: the two thrift apis are not same. there are some features exposed via thrift that are not exposed via thrift2 and vice-versa. can you pl educate me on the history on why we have two different thrift apis?

        REVISION DETAIL
        https://reviews.facebook.net/D1515

        Show
        Phabricator added a comment - dhruba has commented on the revision " [jira] HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations". INLINE COMMENTS src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java:859 thrift2/TPut already has the feature to switch off wal if needed, no further work is necessary. also, just curious: the two thrift apis are not same. there are some features exposed via thrift that are not exposed via thrift2 and vice-versa. can you pl educate me on the history on why we have two different thrift apis? REVISION DETAIL https://reviews.facebook.net/D1515
        Hide
        Phabricator added a comment -

        dhruba has commented on the revision "[jira] HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations".

        INLINE COMMENTS
        src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java:859 thrift2/TPut already has the feature to switch off wal if needed, no further work is necessary.

        also, just curious: the two thrift apis are not same. there are some features exposed via thrift that are not exposed via thrift2 and vice-versa. can you pl educate me on the history on why we have two different thrift apis?

        REVISION DETAIL
        https://reviews.facebook.net/D1515

        Show
        Phabricator added a comment - dhruba has commented on the revision " [jira] HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations". INLINE COMMENTS src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java:859 thrift2/TPut already has the feature to switch off wal if needed, no further work is necessary. also, just curious: the two thrift apis are not same. there are some features exposed via thrift that are not exposed via thrift2 and vice-versa. can you pl educate me on the history on why we have two different thrift apis? REVISION DETAIL https://reviews.facebook.net/D1515
        Hide
        Phabricator added a comment -

        tedyu has commented on the revision "[jira] HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations".

        thrift2/TDelete doesn't support WAL switch.
        Delete is a mutation:
        public class Delete extends Mutation

        thrift2/ThriftUtilities.java has out.setWriteToWAL() call for incrementFromThrift() and incrementFromThrift(). deleteFromThrift() should also have this call.

        w.r.t. why two thrift packages are maintained, you can find some discussions in this JIRA:

        https://issues.apache.org/jira/browse/HBASE-1744?focusedCommentId=12921845&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12921845

        There're so many Thrift experts at FB, I am sure they have better idea about the two packages.

        REVISION DETAIL
        https://reviews.facebook.net/D1515

        Show
        Phabricator added a comment - tedyu has commented on the revision " [jira] HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations". thrift2/TDelete doesn't support WAL switch. Delete is a mutation: public class Delete extends Mutation thrift2/ThriftUtilities.java has out.setWriteToWAL() call for incrementFromThrift() and incrementFromThrift(). deleteFromThrift() should also have this call. w.r.t. why two thrift packages are maintained, you can find some discussions in this JIRA: https://issues.apache.org/jira/browse/HBASE-1744?focusedCommentId=12921845&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12921845 There're so many Thrift experts at FB, I am sure they have better idea about the two packages. REVISION DETAIL https://reviews.facebook.net/D1515
        Hide
        Phabricator added a comment -

        tedyu has commented on the revision "[jira] HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations".

        thrift2/TDelete doesn't support WAL switch.
        Delete is a mutation:
        public class Delete extends Mutation

        thrift2/ThriftUtilities.java has out.setWriteToWAL() call for incrementFromThrift() and incrementFromThrift(). deleteFromThrift() should also have this call.

        w.r.t. why two thrift packages are maintained, you can find some discussions in this JIRA:

        https://issues.apache.org/jira/browse/HBASE-1744?focusedCommentId=12921845&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12921845

        There're so many Thrift experts at FB, I am sure they have better idea about the two packages.

        REVISION DETAIL
        https://reviews.facebook.net/D1515

        Show
        Phabricator added a comment - tedyu has commented on the revision " [jira] HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations". thrift2/TDelete doesn't support WAL switch. Delete is a mutation: public class Delete extends Mutation thrift2/ThriftUtilities.java has out.setWriteToWAL() call for incrementFromThrift() and incrementFromThrift(). deleteFromThrift() should also have this call. w.r.t. why two thrift packages are maintained, you can find some discussions in this JIRA: https://issues.apache.org/jira/browse/HBASE-1744?focusedCommentId=12921845&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12921845 There're so many Thrift experts at FB, I am sure they have better idea about the two packages. REVISION DETAIL https://reviews.facebook.net/D1515
        Hide
        Phabricator added a comment -

        tedyu has commented on the revision "[jira] HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations".

        thrift2/TDelete doesn't support WAL switch.
        Delete is a mutation:
        public class Delete extends Mutation

        thrift2/ThriftUtilities.java has out.setWriteToWAL() call for incrementFromThrift() and incrementFromThrift(). deleteFromThrift() should also have this call.

        w.r.t. why two thrift packages are maintained, you can find some discussions in this JIRA:

        https://issues.apache.org/jira/browse/HBASE-1744?focusedCommentId=12921845&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12921845

        There're so many Thrift experts at FB, I am sure they have better idea about the two packages.

        REVISION DETAIL
        https://reviews.facebook.net/D1515

        Show
        Phabricator added a comment - tedyu has commented on the revision " [jira] HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations". thrift2/TDelete doesn't support WAL switch. Delete is a mutation: public class Delete extends Mutation thrift2/ThriftUtilities.java has out.setWriteToWAL() call for incrementFromThrift() and incrementFromThrift(). deleteFromThrift() should also have this call. w.r.t. why two thrift packages are maintained, you can find some discussions in this JIRA: https://issues.apache.org/jira/browse/HBASE-1744?focusedCommentId=12921845&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12921845 There're so many Thrift experts at FB, I am sure they have better idea about the two packages. REVISION DETAIL https://reviews.facebook.net/D1515
        Hide
        Phabricator added a comment -

        tedyu has commented on the revision "[jira] HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations".

        thrift2/TDelete doesn't support WAL switch.
        Delete is a mutation:
        public class Delete extends Mutation

        thrift2/ThriftUtilities.java has out.setWriteToWAL() call for incrementFromThrift() and incrementFromThrift(). deleteFromThrift() should also have this call.

        w.r.t. why two thrift packages are maintained, you can find some discussions in this JIRA:

        https://issues.apache.org/jira/browse/HBASE-1744?focusedCommentId=12921845&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12921845

        There're so many Thrift experts at FB, I am sure they have better idea about the two packages.

        REVISION DETAIL
        https://reviews.facebook.net/D1515

        Show
        Phabricator added a comment - tedyu has commented on the revision " [jira] HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations". thrift2/TDelete doesn't support WAL switch. Delete is a mutation: public class Delete extends Mutation thrift2/ThriftUtilities.java has out.setWriteToWAL() call for incrementFromThrift() and incrementFromThrift(). deleteFromThrift() should also have this call. w.r.t. why two thrift packages are maintained, you can find some discussions in this JIRA: https://issues.apache.org/jira/browse/HBASE-1744?focusedCommentId=12921845&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12921845 There're so many Thrift experts at FB, I am sure they have better idea about the two packages. REVISION DETAIL https://reviews.facebook.net/D1515
        Hide
        Phabricator added a comment -

        dhruba updated the revision "[jira] HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations".
        Reviewers: sc, tedyu, stack

        Incorporated changes to thrift2 as well.

        REVISION DETAIL
        https://reviews.facebook.net/D1515

        AFFECTED FILES
        src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
        src/main/java/org/apache/hadoop/hbase/thrift2/ThriftUtilities.java
        src/main/java/org/apache/hadoop/hbase/thrift2/generated/TResult.java
        src/main/java/org/apache/hadoop/hbase/thrift2/generated/TGet.java
        src/main/java/org/apache/hadoop/hbase/thrift2/generated/TDelete.java
        src/main/java/org/apache/hadoop/hbase/thrift2/generated/THBaseService.java
        src/main/java/org/apache/hadoop/hbase/thrift2/generated/TIncrement.java
        src/main/java/org/apache/hadoop/hbase/thrift2/generated/TScan.java
        src/main/java/org/apache/hadoop/hbase/thrift2/generated/TPut.java
        src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
        src/main/java/org/apache/hadoop/hbase/thrift/generated/Mutation.java
        src/main/java/org/apache/hadoop/hbase/thrift/generated/BatchMutation.java
        src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java
        src/main/java/org/apache/hadoop/hbase/thrift/generated/TScan.java
        src/main/java/org/apache/hadoop/hbase/thrift/generated/TRowResult.java
        src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift
        src/main/resources/org/apache/hadoop/hbase/thrift2/hbase.thrift

        Show
        Phabricator added a comment - dhruba updated the revision " [jira] HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations". Reviewers: sc, tedyu, stack Incorporated changes to thrift2 as well. REVISION DETAIL https://reviews.facebook.net/D1515 AFFECTED FILES src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java src/main/java/org/apache/hadoop/hbase/thrift2/ThriftUtilities.java src/main/java/org/apache/hadoop/hbase/thrift2/generated/TResult.java src/main/java/org/apache/hadoop/hbase/thrift2/generated/TGet.java src/main/java/org/apache/hadoop/hbase/thrift2/generated/TDelete.java src/main/java/org/apache/hadoop/hbase/thrift2/generated/THBaseService.java src/main/java/org/apache/hadoop/hbase/thrift2/generated/TIncrement.java src/main/java/org/apache/hadoop/hbase/thrift2/generated/TScan.java src/main/java/org/apache/hadoop/hbase/thrift2/generated/TPut.java src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java src/main/java/org/apache/hadoop/hbase/thrift/generated/Mutation.java src/main/java/org/apache/hadoop/hbase/thrift/generated/BatchMutation.java src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java src/main/java/org/apache/hadoop/hbase/thrift/generated/TScan.java src/main/java/org/apache/hadoop/hbase/thrift/generated/TRowResult.java src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift src/main/resources/org/apache/hadoop/hbase/thrift2/hbase.thrift
        Hide
        Phabricator added a comment -

        dhruba updated the revision "[jira] HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations".
        Reviewers: sc, tedyu, stack

        Incorporated changes to thrift2 as well.

        REVISION DETAIL
        https://reviews.facebook.net/D1515

        AFFECTED FILES
        src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
        src/main/java/org/apache/hadoop/hbase/thrift2/ThriftUtilities.java
        src/main/java/org/apache/hadoop/hbase/thrift2/generated/TResult.java
        src/main/java/org/apache/hadoop/hbase/thrift2/generated/TGet.java
        src/main/java/org/apache/hadoop/hbase/thrift2/generated/TDelete.java
        src/main/java/org/apache/hadoop/hbase/thrift2/generated/THBaseService.java
        src/main/java/org/apache/hadoop/hbase/thrift2/generated/TIncrement.java
        src/main/java/org/apache/hadoop/hbase/thrift2/generated/TScan.java
        src/main/java/org/apache/hadoop/hbase/thrift2/generated/TPut.java
        src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
        src/main/java/org/apache/hadoop/hbase/thrift/generated/Mutation.java
        src/main/java/org/apache/hadoop/hbase/thrift/generated/BatchMutation.java
        src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java
        src/main/java/org/apache/hadoop/hbase/thrift/generated/TScan.java
        src/main/java/org/apache/hadoop/hbase/thrift/generated/TRowResult.java
        src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift
        src/main/resources/org/apache/hadoop/hbase/thrift2/hbase.thrift

        Show
        Phabricator added a comment - dhruba updated the revision " [jira] HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations". Reviewers: sc, tedyu, stack Incorporated changes to thrift2 as well. REVISION DETAIL https://reviews.facebook.net/D1515 AFFECTED FILES src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java src/main/java/org/apache/hadoop/hbase/thrift2/ThriftUtilities.java src/main/java/org/apache/hadoop/hbase/thrift2/generated/TResult.java src/main/java/org/apache/hadoop/hbase/thrift2/generated/TGet.java src/main/java/org/apache/hadoop/hbase/thrift2/generated/TDelete.java src/main/java/org/apache/hadoop/hbase/thrift2/generated/THBaseService.java src/main/java/org/apache/hadoop/hbase/thrift2/generated/TIncrement.java src/main/java/org/apache/hadoop/hbase/thrift2/generated/TScan.java src/main/java/org/apache/hadoop/hbase/thrift2/generated/TPut.java src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java src/main/java/org/apache/hadoop/hbase/thrift/generated/Mutation.java src/main/java/org/apache/hadoop/hbase/thrift/generated/BatchMutation.java src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java src/main/java/org/apache/hadoop/hbase/thrift/generated/TScan.java src/main/java/org/apache/hadoop/hbase/thrift/generated/TRowResult.java src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift src/main/resources/org/apache/hadoop/hbase/thrift2/hbase.thrift
        Hide
        Phabricator added a comment -

        dhruba updated the revision "[jira] HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations".
        Reviewers: sc, tedyu, stack

        Incorporated changes to thrift2 as well.

        REVISION DETAIL
        https://reviews.facebook.net/D1515

        AFFECTED FILES
        src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
        src/main/java/org/apache/hadoop/hbase/thrift2/ThriftUtilities.java
        src/main/java/org/apache/hadoop/hbase/thrift2/generated/TResult.java
        src/main/java/org/apache/hadoop/hbase/thrift2/generated/TGet.java
        src/main/java/org/apache/hadoop/hbase/thrift2/generated/TDelete.java
        src/main/java/org/apache/hadoop/hbase/thrift2/generated/THBaseService.java
        src/main/java/org/apache/hadoop/hbase/thrift2/generated/TIncrement.java
        src/main/java/org/apache/hadoop/hbase/thrift2/generated/TScan.java
        src/main/java/org/apache/hadoop/hbase/thrift2/generated/TPut.java
        src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
        src/main/java/org/apache/hadoop/hbase/thrift/generated/Mutation.java
        src/main/java/org/apache/hadoop/hbase/thrift/generated/BatchMutation.java
        src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java
        src/main/java/org/apache/hadoop/hbase/thrift/generated/TScan.java
        src/main/java/org/apache/hadoop/hbase/thrift/generated/TRowResult.java
        src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift
        src/main/resources/org/apache/hadoop/hbase/thrift2/hbase.thrift

        Show
        Phabricator added a comment - dhruba updated the revision " [jira] HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations". Reviewers: sc, tedyu, stack Incorporated changes to thrift2 as well. REVISION DETAIL https://reviews.facebook.net/D1515 AFFECTED FILES src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java src/main/java/org/apache/hadoop/hbase/thrift2/ThriftUtilities.java src/main/java/org/apache/hadoop/hbase/thrift2/generated/TResult.java src/main/java/org/apache/hadoop/hbase/thrift2/generated/TGet.java src/main/java/org/apache/hadoop/hbase/thrift2/generated/TDelete.java src/main/java/org/apache/hadoop/hbase/thrift2/generated/THBaseService.java src/main/java/org/apache/hadoop/hbase/thrift2/generated/TIncrement.java src/main/java/org/apache/hadoop/hbase/thrift2/generated/TScan.java src/main/java/org/apache/hadoop/hbase/thrift2/generated/TPut.java src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java src/main/java/org/apache/hadoop/hbase/thrift/generated/Mutation.java src/main/java/org/apache/hadoop/hbase/thrift/generated/BatchMutation.java src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java src/main/java/org/apache/hadoop/hbase/thrift/generated/TScan.java src/main/java/org/apache/hadoop/hbase/thrift/generated/TRowResult.java src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift src/main/resources/org/apache/hadoop/hbase/thrift2/hbase.thrift
        Hide
        Phabricator added a comment -

        dhruba updated the revision "[jira] HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations".
        Reviewers: sc, tedyu, stack

        Incorporated changes to thrift2 as well.

        REVISION DETAIL
        https://reviews.facebook.net/D1515

        AFFECTED FILES
        src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
        src/main/java/org/apache/hadoop/hbase/thrift2/ThriftUtilities.java
        src/main/java/org/apache/hadoop/hbase/thrift2/generated/TResult.java
        src/main/java/org/apache/hadoop/hbase/thrift2/generated/TGet.java
        src/main/java/org/apache/hadoop/hbase/thrift2/generated/TDelete.java
        src/main/java/org/apache/hadoop/hbase/thrift2/generated/THBaseService.java
        src/main/java/org/apache/hadoop/hbase/thrift2/generated/TIncrement.java
        src/main/java/org/apache/hadoop/hbase/thrift2/generated/TScan.java
        src/main/java/org/apache/hadoop/hbase/thrift2/generated/TPut.java
        src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
        src/main/java/org/apache/hadoop/hbase/thrift/generated/Mutation.java
        src/main/java/org/apache/hadoop/hbase/thrift/generated/BatchMutation.java
        src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java
        src/main/java/org/apache/hadoop/hbase/thrift/generated/TScan.java
        src/main/java/org/apache/hadoop/hbase/thrift/generated/TRowResult.java
        src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift
        src/main/resources/org/apache/hadoop/hbase/thrift2/hbase.thrift

        Show
        Phabricator added a comment - dhruba updated the revision " [jira] HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations". Reviewers: sc, tedyu, stack Incorporated changes to thrift2 as well. REVISION DETAIL https://reviews.facebook.net/D1515 AFFECTED FILES src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java src/main/java/org/apache/hadoop/hbase/thrift2/ThriftUtilities.java src/main/java/org/apache/hadoop/hbase/thrift2/generated/TResult.java src/main/java/org/apache/hadoop/hbase/thrift2/generated/TGet.java src/main/java/org/apache/hadoop/hbase/thrift2/generated/TDelete.java src/main/java/org/apache/hadoop/hbase/thrift2/generated/THBaseService.java src/main/java/org/apache/hadoop/hbase/thrift2/generated/TIncrement.java src/main/java/org/apache/hadoop/hbase/thrift2/generated/TScan.java src/main/java/org/apache/hadoop/hbase/thrift2/generated/TPut.java src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java src/main/java/org/apache/hadoop/hbase/thrift/generated/Mutation.java src/main/java/org/apache/hadoop/hbase/thrift/generated/BatchMutation.java src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java src/main/java/org/apache/hadoop/hbase/thrift/generated/TScan.java src/main/java/org/apache/hadoop/hbase/thrift/generated/TRowResult.java src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift src/main/resources/org/apache/hadoop/hbase/thrift2/hbase.thrift
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12512389/D1515.2.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        -1 javadoc. The javadoc tool appears to have generated -140 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 161 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
        org.apache.hadoop.hbase.mapred.TestTableMapReduce
        org.apache.hadoop.hbase.io.hfile.TestHFileBlock
        org.apache.hadoop.hbase.mapreduce.TestImportTsv

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/868//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/868//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/868//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12512389/D1515.2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 javadoc. The javadoc tool appears to have generated -140 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 161 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat org.apache.hadoop.hbase.mapred.TestTableMapReduce org.apache.hadoop.hbase.io.hfile.TestHFileBlock org.apache.hadoop.hbase.mapreduce.TestImportTsv Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/868//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/868//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/868//console This message is automatically generated.
        Hide
        Ted Yu added a comment -

        There were no hanging tests for patch v2.

        Show
        Ted Yu added a comment - There were no hanging tests for patch v2.
        Hide
        Phabricator added a comment -

        tedyu has accepted the revision "[jira] HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations".

        REVISION DETAIL
        https://reviews.facebook.net/D1515

        Show
        Phabricator added a comment - tedyu has accepted the revision " [jira] HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations". REVISION DETAIL https://reviews.facebook.net/D1515
        Hide
        Phabricator added a comment -

        tedyu has accepted the revision "[jira] HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations".

        REVISION DETAIL
        https://reviews.facebook.net/D1515

        Show
        Phabricator added a comment - tedyu has accepted the revision " [jira] HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations". REVISION DETAIL https://reviews.facebook.net/D1515
        Hide
        Phabricator added a comment -

        tedyu has accepted the revision "[jira] HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations".

        REVISION DETAIL
        https://reviews.facebook.net/D1515

        Show
        Phabricator added a comment - tedyu has accepted the revision " [jira] HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations". REVISION DETAIL https://reviews.facebook.net/D1515
        Hide
        Phabricator added a comment -

        tedyu has accepted the revision "[jira] HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations".

        REVISION DETAIL
        https://reviews.facebook.net/D1515

        Show
        Phabricator added a comment - tedyu has accepted the revision " [jira] HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations". REVISION DETAIL https://reviews.facebook.net/D1515
        Hide
        dhruba borthakur added a comment -

        Can some kind soul pl commit this one?

        Show
        dhruba borthakur added a comment - Can some kind soul pl commit this one?
        Hide
        Ted Yu added a comment -

        I was in the process of integrating the patch

        Integrated to TRUNK.

        Thanks for the patch, Dhruba.

        Show
        Ted Yu added a comment - I was in the process of integrating the patch Integrated to TRUNK. Thanks for the patch, Dhruba.
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #2650 (See https://builds.apache.org/job/HBase-TRUNK/2650/)
        HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations (Dhruba)

        tedyu :
        Files :

        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/generated/BatchMutation.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/generated/Mutation.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/generated/TRowResult.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/generated/TScan.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftUtilities.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TDelete.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TGet.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift2/generated/THBaseService.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TIncrement.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TPut.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TResult.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TScan.java
        • /hbase/trunk/src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift
        • /hbase/trunk/src/main/resources/org/apache/hadoop/hbase/thrift2/hbase.thrift
        • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #2650 (See https://builds.apache.org/job/HBase-TRUNK/2650/ ) HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations (Dhruba) tedyu : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/generated/BatchMutation.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/generated/Mutation.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/generated/TRowResult.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/generated/TScan.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftUtilities.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TDelete.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TGet.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift2/generated/THBaseService.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TIncrement.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TPut.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TResult.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TScan.java /hbase/trunk/src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift /hbase/trunk/src/main/resources/org/apache/hadoop/hbase/thrift2/hbase.thrift /hbase/trunk/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
        Hide
        Phabricator added a comment -

        mbautin requested code review of "[jira] HBASE-5295 [89-fb] Improve the Thrift API to switch on/off writing to wal for Mutations".
        Reviewers: Kannan, dhruba, sc, JIRA

        Porting Dhruba's patch from HBASE-5295 to 89-fb add a writeToWAL flag to the Mutation Thrift API. Also adding a new unit test and fixing an inconsistency in the mutateRow API in case different Mutation objects have different values of writeToWAL specified.

        TEST PLAN
        Exiting unit tests
        New unit test

        REVISION DETAIL
        https://reviews.facebook.net/D3015

        AFFECTED FILES
        src/main/java/org/apache/hadoop/hbase/KeyValue.java
        src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java
        src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
        src/main/java/org/apache/hadoop/hbase/thrift/ThriftUtilities.java
        src/main/java/org/apache/hadoop/hbase/thrift/generated/Mutation.java
        src/main/java/org/apache/hadoop/hbase/util/Bytes.java
        src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift
        src/test/java/org/apache/hadoop/hbase/HTestConst.java
        src/test/java/org/apache/hadoop/hbase/thrift/TestMutationWriteToWAL.java
        src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
        src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerLegacy.java

        MANAGE HERALD DIFFERENTIAL RULES
        https://reviews.facebook.net/herald/view/differential/

        WHY DID I GET THIS EMAIL?
        https://reviews.facebook.net/herald/transcript/6861/

        Tip: use the X-Herald-Rules header to filter Herald messages in your client.

        Show
        Phabricator added a comment - mbautin requested code review of " [jira] HBASE-5295 [89-fb] Improve the Thrift API to switch on/off writing to wal for Mutations". Reviewers: Kannan, dhruba, sc, JIRA Porting Dhruba's patch from HBASE-5295 to 89-fb add a writeToWAL flag to the Mutation Thrift API. Also adding a new unit test and fixing an inconsistency in the mutateRow API in case different Mutation objects have different values of writeToWAL specified. TEST PLAN Exiting unit tests New unit test REVISION DETAIL https://reviews.facebook.net/D3015 AFFECTED FILES src/main/java/org/apache/hadoop/hbase/KeyValue.java src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java src/main/java/org/apache/hadoop/hbase/thrift/ThriftUtilities.java src/main/java/org/apache/hadoop/hbase/thrift/generated/Mutation.java src/main/java/org/apache/hadoop/hbase/util/Bytes.java src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift src/test/java/org/apache/hadoop/hbase/HTestConst.java src/test/java/org/apache/hadoop/hbase/thrift/TestMutationWriteToWAL.java src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerLegacy.java MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/6861/ Tip: use the X-Herald-Rules header to filter Herald messages in your client.
        Hide
        Phabricator added a comment -

        Kannan has commented on the revision "[jira] HBASE-5295 [89-fb] Improve the Thrift API to switch on/off writing to wal for Mutations".

        INLINE COMMENTS
        src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java:989 @mikhail: the tighter check you added to make sure all mutations have the same writeToWAL setting should be added for this case too.

        Otherwise, rest of the diff looks really good. And nice test!

        REVISION DETAIL
        https://reviews.facebook.net/D3015

        Show
        Phabricator added a comment - Kannan has commented on the revision " [jira] HBASE-5295 [89-fb] Improve the Thrift API to switch on/off writing to wal for Mutations". INLINE COMMENTS src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java:989 @mikhail: the tighter check you added to make sure all mutations have the same writeToWAL setting should be added for this case too. Otherwise, rest of the diff looks really good. And nice test! REVISION DETAIL https://reviews.facebook.net/D3015
        Hide
        Phabricator added a comment -

        mbautin updated the revision "[jira] HBASE-5295 [89-fb] Improve the Thrift API to switch on/off writing to wal for Mutations".
        Reviewers: Kannan, dhruba, sc, JIRA

        Addressing Kannan's comment. Testing both API methods in the unit test.

        REVISION DETAIL
        https://reviews.facebook.net/D3015

        AFFECTED FILES
        src/main/java/org/apache/hadoop/hbase/KeyValue.java
        src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java
        src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
        src/main/java/org/apache/hadoop/hbase/thrift/ThriftUtilities.java
        src/main/java/org/apache/hadoop/hbase/thrift/generated/Mutation.java
        src/main/java/org/apache/hadoop/hbase/util/Bytes.java
        src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift
        src/test/java/org/apache/hadoop/hbase/HTestConst.java
        src/test/java/org/apache/hadoop/hbase/thrift/TestMutationWriteToWAL.java
        src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
        src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerLegacy.java

        Show
        Phabricator added a comment - mbautin updated the revision " [jira] HBASE-5295 [89-fb] Improve the Thrift API to switch on/off writing to wal for Mutations". Reviewers: Kannan, dhruba, sc, JIRA Addressing Kannan's comment. Testing both API methods in the unit test. REVISION DETAIL https://reviews.facebook.net/D3015 AFFECTED FILES src/main/java/org/apache/hadoop/hbase/KeyValue.java src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java src/main/java/org/apache/hadoop/hbase/thrift/ThriftUtilities.java src/main/java/org/apache/hadoop/hbase/thrift/generated/Mutation.java src/main/java/org/apache/hadoop/hbase/util/Bytes.java src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift src/test/java/org/apache/hadoop/hbase/HTestConst.java src/test/java/org/apache/hadoop/hbase/thrift/TestMutationWriteToWAL.java src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerLegacy.java
        Hide
        Phabricator added a comment -

        mbautin updated the revision "[jira] HBASE-5295 [89-fb] Improve the Thrift API to switch on/off writing to wal for Mutations".
        Reviewers: Kannan, dhruba, sc, JIRA

        Testing deletes. Fixed a bug: we were always writing deletes to WAL (this is fixed in trunk).

        REVISION DETAIL
        https://reviews.facebook.net/D3015

        AFFECTED FILES
        src/main/java/org/apache/hadoop/hbase/KeyValue.java
        src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
        src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java
        src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
        src/main/java/org/apache/hadoop/hbase/thrift/ThriftUtilities.java
        src/main/java/org/apache/hadoop/hbase/thrift/generated/Mutation.java
        src/main/java/org/apache/hadoop/hbase/util/Bytes.java
        src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift
        src/test/java/org/apache/hadoop/hbase/HTestConst.java
        src/test/java/org/apache/hadoop/hbase/thrift/TestMutationWriteToWAL.java
        src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
        src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerLegacy.java

        Show
        Phabricator added a comment - mbautin updated the revision " [jira] HBASE-5295 [89-fb] Improve the Thrift API to switch on/off writing to wal for Mutations". Reviewers: Kannan, dhruba, sc, JIRA Testing deletes. Fixed a bug: we were always writing deletes to WAL (this is fixed in trunk). REVISION DETAIL https://reviews.facebook.net/D3015 AFFECTED FILES src/main/java/org/apache/hadoop/hbase/KeyValue.java src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java src/main/java/org/apache/hadoop/hbase/thrift/ThriftUtilities.java src/main/java/org/apache/hadoop/hbase/thrift/generated/Mutation.java src/main/java/org/apache/hadoop/hbase/util/Bytes.java src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift src/test/java/org/apache/hadoop/hbase/HTestConst.java src/test/java/org/apache/hadoop/hbase/thrift/TestMutationWriteToWAL.java src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerLegacy.java
        Hide
        Phabricator added a comment -

        mbautin updated the revision "[jira] HBASE-5295 [89-fb] Improve the Thrift API to switch on/off writing to wal for Mutations".
        Reviewers: Kannan, dhruba, sc, JIRA

        Simplifying a couple of lines

        REVISION DETAIL
        https://reviews.facebook.net/D3015

        AFFECTED FILES
        src/main/java/org/apache/hadoop/hbase/KeyValue.java
        src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
        src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java
        src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
        src/main/java/org/apache/hadoop/hbase/thrift/ThriftUtilities.java
        src/main/java/org/apache/hadoop/hbase/thrift/generated/Mutation.java
        src/main/java/org/apache/hadoop/hbase/util/Bytes.java
        src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift
        src/test/java/org/apache/hadoop/hbase/HTestConst.java
        src/test/java/org/apache/hadoop/hbase/thrift/TestMutationWriteToWAL.java
        src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
        src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerLegacy.java

        Show
        Phabricator added a comment - mbautin updated the revision " [jira] HBASE-5295 [89-fb] Improve the Thrift API to switch on/off writing to wal for Mutations". Reviewers: Kannan, dhruba, sc, JIRA Simplifying a couple of lines REVISION DETAIL https://reviews.facebook.net/D3015 AFFECTED FILES src/main/java/org/apache/hadoop/hbase/KeyValue.java src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java src/main/java/org/apache/hadoop/hbase/thrift/ThriftUtilities.java src/main/java/org/apache/hadoop/hbase/thrift/generated/Mutation.java src/main/java/org/apache/hadoop/hbase/util/Bytes.java src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift src/test/java/org/apache/hadoop/hbase/HTestConst.java src/test/java/org/apache/hadoop/hbase/thrift/TestMutationWriteToWAL.java src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerLegacy.java
        Hide
        Phabricator added a comment -

        Kannan has commented on the revision "[jira] HBASE-5295 [89-fb] Improve the Thrift API to switch on/off writing to wal for Mutations".

        looks good! nice work as usual Mikhail.

        INLINE COMMENTS
        src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java:2370 good catch!

        REVISION DETAIL
        https://reviews.facebook.net/D3015

        Show
        Phabricator added a comment - Kannan has commented on the revision " [jira] HBASE-5295 [89-fb] Improve the Thrift API to switch on/off writing to wal for Mutations". looks good! nice work as usual Mikhail. INLINE COMMENTS src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java:2370 good catch! REVISION DETAIL https://reviews.facebook.net/D3015
        Hide
        Phabricator added a comment -

        mbautin has commented on the revision "[jira] HBASE-5295 [89-fb] Improve the Thrift API to switch on/off writing to wal for Mutations".

        @Kannan: thanks for reviewing! Could you please accept the diff if it looks good?

        REVISION DETAIL
        https://reviews.facebook.net/D3015

        Show
        Phabricator added a comment - mbautin has commented on the revision " [jira] HBASE-5295 [89-fb] Improve the Thrift API to switch on/off writing to wal for Mutations". @Kannan: thanks for reviewing! Could you please accept the diff if it looks good? REVISION DETAIL https://reviews.facebook.net/D3015
        Hide
        Phabricator added a comment -

        Kannan has accepted the revision "[jira] HBASE-5295 [89-fb] Improve the Thrift API to switch on/off writing to wal for Mutations".

        sorry for forgetting to hit accept last time

        REVISION DETAIL
        https://reviews.facebook.net/D3015

        BRANCH
        hbase_5295_improve_the_thrift_api_to_switch_v6

        Show
        Phabricator added a comment - Kannan has accepted the revision " [jira] HBASE-5295 [89-fb] Improve the Thrift API to switch on/off writing to wal for Mutations". sorry for forgetting to hit accept last time REVISION DETAIL https://reviews.facebook.net/D3015 BRANCH hbase_5295_improve_the_thrift_api_to_switch_v6
        Hide
        Phabricator added a comment -

        mbautin has committed the revision "[jira] HBASE-5295 [89-fb] Improve the Thrift API to switch on/off writing to wal for Mutations".

        REVISION DETAIL
        https://reviews.facebook.net/D3015

        COMMIT
        https://reviews.facebook.net/rHBASEEIGHTNINEFBBRANCH1335234

        Show
        Phabricator added a comment - mbautin has committed the revision " [jira] HBASE-5295 [89-fb] Improve the Thrift API to switch on/off writing to wal for Mutations". REVISION DETAIL https://reviews.facebook.net/D3015 COMMIT https://reviews.facebook.net/rHBASEEIGHTNINEFBBRANCH1335234
        Hide
        Phabricator added a comment -

        dhruba has closed the revision "[jira] HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations".

        REVISION DETAIL
        https://reviews.facebook.net/D1515

        To: sc, tedyu, stack, dhruba
        Cc: JIRA, tedyu, dhruba

        Show
        Phabricator added a comment - dhruba has closed the revision " [jira] HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations". REVISION DETAIL https://reviews.facebook.net/D1515 To: sc, tedyu, stack, dhruba Cc: JIRA, tedyu, dhruba

          People

          • Assignee:
            dhruba borthakur
            Reporter:
            dhruba borthakur
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development