HBase
  1. HBase
  2. HBASE-5294

Make sure javadoc is included in tarball bundle when we release

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 0.92.0
    • Fix Version/s: 0.92.1, 0.94.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      0.92.0 doesn't have javadoc in the tarball. Fix.

      1. hbase-5294.patch
        0.7 kB
        Shaneal Manek

        Activity

        Lars Hofhansl made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Hudson added a comment -

        Integrated in HBase-0.92-security #91 (See https://builds.apache.org/job/HBase-0.92-security/91/)
        HBASE-5294 Make sure javadoc is included in tarball bundle when we release (Revision 1245826)

        Result = FAILURE
        stack :
        Files :

        • /hbase/branches/0.92/pom.xml
        Show
        Hudson added a comment - Integrated in HBase-0.92-security #91 (See https://builds.apache.org/job/HBase-0.92-security/91/ ) HBASE-5294 Make sure javadoc is included in tarball bundle when we release (Revision 1245826) Result = FAILURE stack : Files : /hbase/branches/0.92/pom.xml
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #2665 (See https://builds.apache.org/job/HBase-TRUNK/2665/)
        HBASE-5294 Make sure javadoc is included in tarball bundle when we release (Revision 1245827)

        Result = FAILURE
        stack :
        Files :

        • /hbase/trunk/pom.xml
        • /hbase/trunk/src/docbkx/developer.xml
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #2665 (See https://builds.apache.org/job/HBase-TRUNK/2665/ ) HBASE-5294 Make sure javadoc is included in tarball bundle when we release (Revision 1245827) Result = FAILURE stack : Files : /hbase/trunk/pom.xml /hbase/trunk/src/docbkx/developer.xml
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-security #114 (See https://builds.apache.org/job/HBase-TRUNK-security/114/)
        HBASE-5294 Make sure javadoc is included in tarball bundle when we release (Revision 1245827)

        Result = FAILURE
        stack :
        Files :

        • /hbase/trunk/pom.xml
        • /hbase/trunk/src/docbkx/developer.xml
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-security #114 (See https://builds.apache.org/job/HBase-TRUNK-security/114/ ) HBASE-5294 Make sure javadoc is included in tarball bundle when we release (Revision 1245827) Result = FAILURE stack : Files : /hbase/trunk/pom.xml /hbase/trunk/src/docbkx/developer.xml
        Hide
        Hudson added a comment -

        Integrated in HBase-0.92 #290 (See https://builds.apache.org/job/HBase-0.92/290/)
        HBASE-5294 Make sure javadoc is included in tarball bundle when we release (Revision 1245826)

        Result = SUCCESS
        stack :
        Files :

        • /hbase/branches/0.92/pom.xml
        Show
        Hudson added a comment - Integrated in HBase-0.92 #290 (See https://builds.apache.org/job/HBase-0.92/290/ ) HBASE-5294 Make sure javadoc is included in tarball bundle when we release (Revision 1245826) Result = SUCCESS stack : Files : /hbase/branches/0.92/pom.xml
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12515054/hbase-5294.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 javadoc. The javadoc tool appears to have generated -136 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 158 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.mapreduce.TestImportTsv
        org.apache.hadoop.hbase.mapred.TestTableMapReduce
        org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/984//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/984//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/984//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12515054/hbase-5294.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javadoc. The javadoc tool appears to have generated -136 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 158 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.mapreduce.TestImportTsv org.apache.hadoop.hbase.mapred.TestTableMapReduce org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/984//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/984//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/984//console This message is automatically generated.
        stack made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s 0.94.0 [ 12316419 ]
        Resolution Fixed [ 1 ]
        Hide
        stack added a comment -

        Committed to branch and trunk. Thanks for the patch Shaneal (though now need to fix licenses – smile).

        Show
        stack added a comment - Committed to branch and trunk. Thanks for the patch Shaneal (though now need to fix licenses – smile).
        Shaneal Manek made changes -
        Assignee Shaneal Manek [ smanek ]
        Shaneal Manek made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Affects Version/s 0.92.0 [ 12314223 ]
        Hide
        Shaneal Manek added a comment -

        This patch only generates javadocs for the artifact when the release profile (-Prelease) is used.

        I figured the build is slow enough already - no need to slow down the common case.

        Tested with: 'mvn clean site install assembly:single -Dmaven.test.skip -Prelease' and manually verified the resulting tarball included javadocs.

        Show
        Shaneal Manek added a comment - This patch only generates javadocs for the artifact when the release profile (-Prelease) is used. I figured the build is slow enough already - no need to slow down the common case. Tested with: 'mvn clean site install assembly:single -Dmaven.test.skip -Prelease' and manually verified the resulting tarball included javadocs.
        Shaneal Manek made changes -
        Field Original Value New Value
        Attachment hbase-5294.patch [ 12515054 ]
        stack created issue -

          People

          • Assignee:
            Shaneal Manek
            Reporter:
            stack
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development