HBase
  1. HBase
  2. HBASE-5217

Reenable the thrift tests, and add a new one for getRegionInfo

    Details

    • Type: Improvement Improvement
    • Status: Patch Available
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      At some point we disabled tests for the thrift server. In addition, it looks like the getRegionInfo no longer functions. I'd like to reenable the tests and add one for getRegionInfo. I had to write this to test my changes in HBASE-2600 anyway. I figured I would break it out. We shouldn't commit it until we have fixed getting the regioninfo from the thriftserver.

      1. 0002-HBASE-5217-v5.patch
        11 kB
        Alex Newman
      2. 0002-HBASE-5217-v4.patch
        11 kB
        Alex Newman
      3. 0002-HBASE-5217-v3.patch
        11 kB
        Alex Newman
      4. 0002-HBASE-5217.-Reenable-the-thrift-tests-and-add-a-new-.patch
        12 kB
        Alex Newman
      5. zzzz-hbase-posix4e #92 Console [Jenkins].pdf
        366 kB
        Alex Newman
      6. 0001-Fixing-thrift-tests-v2.patch
        5 kB
        Alex Newman
      7. 0001-Fixing-thrift-tests.patch
        5 kB
        Alex Newman

        Issue Links

          Activity

          Hide
          Alex Newman added a comment -

          We depend on a functioning getRegionInfo in thrift.

          Show
          Alex Newman added a comment - We depend on a functioning getRegionInfo in thrift.
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/3514/
          -----------------------------------------------------------

          Review request for hbase.

          Summary
          -------

          At some point we disabled tests for the thrift server. In addition, it looks like the getRegionInfo no longer functions. I'd like to reenable the tests and add one for getRegionInfo.

          This addresses bug HBASE-5217.
          https://issues.apache.org/jira/browse/HBASE-5217

          Diffs


          src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java 12247d0

          Diff: https://reviews.apache.org/r/3514/diff

          Testing
          -------

          Ran the tests with my changes in HBASE-2600 to test.

          Thanks,

          Alex

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3514/ ----------------------------------------------------------- Review request for hbase. Summary ------- At some point we disabled tests for the thrift server. In addition, it looks like the getRegionInfo no longer functions. I'd like to reenable the tests and add one for getRegionInfo. This addresses bug HBASE-5217 . https://issues.apache.org/jira/browse/HBASE-5217 Diffs src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java 12247d0 Diff: https://reviews.apache.org/r/3514/diff Testing ------- Ran the tests with my changes in HBASE-2600 to test. Thanks, Alex
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/3514/
          -----------------------------------------------------------

          (Updated 2012-01-17 19:26:07.447407)

          Review request for hbase.

          Summary
          -------

          At some point we disabled tests for the thrift server. In addition, it looks like the getRegionInfo no longer functions. I'd like to reenable the tests and add one for getRegionInfo.

          This addresses bug HBASE-5217.
          https://issues.apache.org/jira/browse/HBASE-5217

          Diffs (updated)


          src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java 12247d0

          Diff: https://reviews.apache.org/r/3514/diff

          Testing
          -------

          Ran the tests with my changes in HBASE-2600 to test.

          Thanks,

          Alex

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3514/ ----------------------------------------------------------- (Updated 2012-01-17 19:26:07.447407) Review request for hbase. Summary ------- At some point we disabled tests for the thrift server. In addition, it looks like the getRegionInfo no longer functions. I'd like to reenable the tests and add one for getRegionInfo. This addresses bug HBASE-5217 . https://issues.apache.org/jira/browse/HBASE-5217 Diffs (updated) src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java 12247d0 Diff: https://reviews.apache.org/r/3514/diff Testing ------- Ran the tests with my changes in HBASE-2600 to test. Thanks, Alex
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12510881/0001-Fixing-thrift-tests-v2.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 4 new or modified tests.

          -1 javadoc. The javadoc tool appears to have generated -145 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 82 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/794//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/794//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/794//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12510881/0001-Fixing-thrift-tests-v2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified tests. -1 javadoc. The javadoc tool appears to have generated -145 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 82 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/794//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/794//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/794//console This message is automatically generated.
          Hide
          Alex Newman added a comment -

          Expect this build to fail until the dependent jira is done.

          Show
          Alex Newman added a comment - Expect this build to fail until the dependent jira is done.
          Hide
          Alex Newman added a comment -

          I attached my own jenkins run. The one failing test is due to 2600 not handling migrations yet.

          Show
          Alex Newman added a comment - I attached my own jenkins run. The one failing test is due to 2600 not handling migrations yet.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12510886/zzzz-hbase-posix4e+%2392+Console+%5BJenkins%5D.pdf
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/796//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12510886/zzzz-hbase-posix4e+%2392+Console+%5BJenkins%5D.pdf against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/796//console This message is automatically generated.
          Hide
          Alex Newman added a comment -

          remerged

          Show
          Alex Newman added a comment - remerged
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/3514/
          -----------------------------------------------------------

          (Updated 2012-01-18 19:20:58.494454)

          Review request for hbase.

          Summary
          -------

          At some point we disabled tests for the thrift server. In addition, it looks like the getRegionInfo no longer functions. I'd like to reenable the tests and add one for getRegionInfo.

          This addresses bug HBASE-5217.
          https://issues.apache.org/jira/browse/HBASE-5217

          Diffs (updated)


          src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java c3be6e3

          Diff: https://reviews.apache.org/r/3514/diff

          Testing
          -------

          Ran the tests with my changes in HBASE-2600 to test.

          Thanks,

          Alex

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3514/ ----------------------------------------------------------- (Updated 2012-01-18 19:20:58.494454) Review request for hbase. Summary ------- At some point we disabled tests for the thrift server. In addition, it looks like the getRegionInfo no longer functions. I'd like to reenable the tests and add one for getRegionInfo. This addresses bug HBASE-5217 . https://issues.apache.org/jira/browse/HBASE-5217 Diffs (updated) src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java c3be6e3 Diff: https://reviews.apache.org/r/3514/diff Testing ------- Ran the tests with my changes in HBASE-2600 to test. Thanks, Alex
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12511026/0002-HBASE-5217.-Reenable-the-thrift-tests-and-add-a-new-v2.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 4 new or modified tests.

          -1 javadoc. The javadoc tool appears to have generated -145 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 82 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/806//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/806//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/806//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12511026/0002-HBASE-5217.-Reenable-the-thrift-tests-and-add-a-new-v2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified tests. -1 javadoc. The javadoc tool appears to have generated -145 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 82 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/806//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/806//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/806//console This message is automatically generated.
          Hide
          Alex Newman added a comment -

          v2

          Show
          Alex Newman added a comment - v2
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/3514/
          -----------------------------------------------------------

          (Updated 2012-03-25 20:11:30.928544)

          Review request for hbase.

          Summary
          -------

          At some point we disabled tests for the thrift server. In addition, it looks like the getRegionInfo no longer functions. I'd like to reenable the tests and add one for getRegionInfo.

          This addresses bug HBASE-5217.
          https://issues.apache.org/jira/browse/HBASE-5217

          Diffs (updated)


          src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java 60eb426
          src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java 444d6d5

          Diff: https://reviews.apache.org/r/3514/diff

          Testing
          -------

          Ran the tests with my changes in HBASE-2600 to test.

          Thanks,

          Alex

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3514/ ----------------------------------------------------------- (Updated 2012-03-25 20:11:30.928544) Review request for hbase. Summary ------- At some point we disabled tests for the thrift server. In addition, it looks like the getRegionInfo no longer functions. I'd like to reenable the tests and add one for getRegionInfo. This addresses bug HBASE-5217 . https://issues.apache.org/jira/browse/HBASE-5217 Diffs (updated) src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java 60eb426 src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java 444d6d5 Diff: https://reviews.apache.org/r/3514/diff Testing ------- Ran the tests with my changes in HBASE-2600 to test. Thanks, Alex
          Hide
          stack added a comment -

          @Alex Is this dependent on another issue being committed first? In doTestGetRegionInfo the tabs are wrong. Should be two spaces like the rest of the file. With your changes are we going to start a cluster each time (Was the testAll method trying to avoid our making a cluster each time)?

          Show
          stack added a comment - @Alex Is this dependent on another issue being committed first? In doTestGetRegionInfo the tabs are wrong. Should be two spaces like the rest of the file. With your changes are we going to start a cluster each time (Was the testAll method trying to avoid our making a cluster each time)?
          Hide
          Alex Newman added a comment -

          This <bold>is</bold> dependent on the other being committed first. Sorry about the spacing will fix when I am back from vegas. I think the reason this patch had them consolidated was

          • Runs all of the tests under a single JUnit test method. We
          • * consolidate all testing to one method because HBaseClusterTestCase
          • * is prone to OutOfMemoryExceptions when there are three or more
          • * JUnit test methods.
          • *
          • * @throws Exception

          I think this is mostly fixed now though.

          Show
          Alex Newman added a comment - This <bold>is</bold> dependent on the other being committed first. Sorry about the spacing will fix when I am back from vegas. I think the reason this patch had them consolidated was Runs all of the tests under a single JUnit test method. We * consolidate all testing to one method because HBaseClusterTestCase * is prone to OutOfMemoryExceptions when there are three or more * JUnit test methods. * * @throws Exception I think this is mostly fixed now though.
          Hide
          Alex Newman added a comment -

          Fixed spacing

          Show
          Alex Newman added a comment - Fixed spacing
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12521535/0002-HBASE-5217-v3.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 4 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1406//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12521535/0002-HBASE-5217-v3.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1406//console This message is automatically generated.
          Hide
          stack added a comment -

          Attach a patch w/ --no-prefix Alex... jenkins don't know how to apply a/src... paths.

          Show
          stack added a comment - Attach a patch w/ --no-prefix Alex... jenkins don't know how to apply a/src... paths.
          Hide
          Alex Newman added a comment -

          done

          Show
          Alex Newman added a comment - done
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12521584/0002-HBASE-5217-v4.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 4 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1415//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12521584/0002-HBASE-5217-v4.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1415//console This message is automatically generated.
          Hide
          stack added a comment -

          Your patch still doesn't apply Boss.

          Show
          stack added a comment - Your patch still doesn't apply Boss.
          Hide
          Alex Newman added a comment -

          Indeed, it is tied to HBASE-2600.

          Show
          Alex Newman added a comment - Indeed, it is tied to HBASE-2600 .
          Hide
          Alex Newman added a comment -

          I rebased today

          Show
          Alex Newman added a comment - I rebased today
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12523232/0002-HBASE-5217-v5.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 4 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1569//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12523232/0002-HBASE-5217-v5.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1569//console This message is automatically generated.

            People

            • Assignee:
              Unassigned
              Reporter:
              Alex Newman
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:

                Development