HBase
  1. HBase
  2. HBASE-5193

Use TBoundedThreadPoolServer in HRegionThriftServer

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.94.0
    • Component/s: regionserver
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      TBoundedThreadPoolServer provides more control than TThreadPoolServer. We should also use it for HRegionThriftServer.

        Activity

        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-security #78 (See https://builds.apache.org/job/HBase-TRUNK-security/78/)
        HBASE-5193 Use TBoundedThreadPoolServer in HRegionThriftServer

        stack :
        Files :

        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionThriftServer.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-security #78 (See https://builds.apache.org/job/HBase-TRUNK-security/78/ ) HBASE-5193 Use TBoundedThreadPoolServer in HRegionThriftServer stack : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionThriftServer.java
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #2632 (See https://builds.apache.org/job/HBase-TRUNK/2632/)
        HBASE-5193 Use TBoundedThreadPoolServer in HRegionThriftServer

        stack :
        Files :

        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionThriftServer.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #2632 (See https://builds.apache.org/job/HBase-TRUNK/2632/ ) HBASE-5193 Use TBoundedThreadPoolServer in HRegionThriftServer stack : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionThriftServer.java
        Hide
        stack added a comment -

        Committed to TRUNK. Thanks for patch Scott (Thanks for pointing out needed class in trunk Zhihong)

        Show
        stack added a comment - Committed to TRUNK. Thanks for patch Scott (Thanks for pointing out needed class in trunk Zhihong)
        Hide
        Ted Yu added a comment -

        TBoundedThreadPoolServer.java is in TRUNK.

        Show
        Ted Yu added a comment - TBoundedThreadPoolServer.java is in TRUNK.
        Hide
        stack added a comment -

        Is TBoundedThreadPoolServer in the version of thrift we ship with? I did this:

        jar -tf  libthrift-0.7.0.jar |grep TBoundedThreadPoolServer

        ... and it came back nought. Do we need to update our thrift jar?

        Show
        stack added a comment - Is TBoundedThreadPoolServer in the version of thrift we ship with? I did this: jar -tf libthrift-0.7.0.jar |grep TBoundedThreadPoolServer ... and it came back nought. Do we need to update our thrift jar?
        Hide
        dhruba borthakur added a comment -

        Yes, we should start using TBoundedThreadPoolServer.

        Show
        dhruba borthakur added a comment - Yes, we should start using TBoundedThreadPoolServer.

          People

          • Assignee:
            Scott Chen
            Reporter:
            Scott Chen
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development