Details

    • Type: New Feature New Feature
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.92.0
    • Fix Version/s: 2.0.0
    • Component/s: None
    • Labels:
      None

      Description

      The current blocking we do when we are close to some limits (memstores over the multiplier factor, too many store files, global memstore memory) is bad, too coarse and confusing. After hitting HBASE-5161, it really becomes obvious that we need something better.

      I did a little brainstorm with Stack, we came up quickly with two solutions:

      • Send some exception to the client, like OverloadedException, that's thrown when some situation happens like getting past the low memory barrier. It would be thrown when the client gets a handler and does some check while putting or deleting. The client would treat this a retryable exception but ideally wouldn't check .META. for a new location. It could be fancy and have multiple levels of pushback, like send the exception to 25% of the clients, and then go up if the situation persists. Should be "easy" to implement but we'll be using a lot more IO to send the payload over and over again (but at least it wouldn't sit in the RS's memory).
      • Send a message alongside a successful put or delete to tell the client to slow down a little, this way we don't have to do back and forth with the payload between the client and the server. It's a cleaner (I think) but more involved solution.

      In every case the RS should do very obvious things to notify the operators of this situation, through logs, web UI, metrics, etc.

      Other ideas?

      1. java_HBASE-5162.patch
        39 kB
        Jesse Yates
      2. hbase-5162-trunk-v8.patch
        129 kB
        Jesse Yates
      3. hbase-5162-trunk-v7.patch
        109 kB
        Jesse Yates
      4. hbase-5162-trunk-v6.patch
        109 kB
        Jesse Yates
      5. hbase-5162-trunk-v5.patch
        107 kB
        Jesse Yates
      6. hbase-5162-trunk-v4.patch
        100 kB
        Jesse Yates
      7. hbase-5162-trunk-v3.patch
        100 kB
        Jesse Yates
      8. hbase-5162-trunk-v2.patch
        101 kB
        Jesse Yates
      9. hbase-5162-trunk-v12-committed.patch
        133 kB
        Jesse Yates
      10. hbase-5162-trunk-v11.patch
        133 kB
        Jesse Yates
      11. hbase-5162-trunk-v10.patch
        132 kB
        Jesse Yates
      12. hbase-5162-trunk-v1.patch
        95 kB
        Jesse Yates
      13. hbase-5162-trunk-v0.patch
        143 kB
        Jesse Yates
      14. hbase-5162-trunk-addendum.patch
        4 kB
        Jesse Yates
      15. hbase-5162-branch-1-v0.patch
        132 kB
        Jesse Yates
      16. 5162-addendum2.txt
        0.9 kB
        Ted Yu

        Issue Links

          Activity

          Jean-Daniel Cryans created issue -
          Hide
          Lars Hofhansl added a comment -

          The exception part is nice, because it works without touching RPC.

          I wonder if that should be a phased approach?
          I.e. if there is light pressure, just delay the operations in the server threads (uses up server threads and memory, but will be transparent to the client, who will just see a slightly less performant server).
          When the pressure gets higher despite the server delays, we'd throw exceptions back to the client, and if that is not enough we block as we do now.

          The interesting part is: How exactly would we measure the pressure? Based on the number of a storefiles and the current rate of updates?

          Show
          Lars Hofhansl added a comment - The exception part is nice, because it works without touching RPC. I wonder if that should be a phased approach? I.e. if there is light pressure, just delay the operations in the server threads (uses up server threads and memory, but will be transparent to the client, who will just see a slightly less performant server). When the pressure gets higher despite the server delays, we'd throw exceptions back to the client, and if that is not enough we block as we do now. The interesting part is: How exactly would we measure the pressure? Based on the number of a storefiles and the current rate of updates?
          Hide
          Jean-Daniel Cryans added a comment -

          Yeah to me the most interesting/challenging part is figuring out what's considered a "heavy load" plus all the nuances for the phases.

          Right now we have a pattern of "soft" and "hard" limits:

          • memstore multiplier, they can get by default up to 2x their configured size by default before blocking.
          • compaction threshold and blocking values, the former is when we should kick a compaction and the latter is when we are in a "too many store files" mode.
          • global memstore barriers, the lower one starts force flushing the bigger regions and the upper one blocks inserts.

          I may be missing some others.

          Do we want to keep them or piggy back? In all three cases we don't tell the client anything until it blocks and instead we try to just take action ASAP. One way could be to send resets once we're past the soft limit... but I'm not sure if it's really going to help.

          Show
          Jean-Daniel Cryans added a comment - Yeah to me the most interesting/challenging part is figuring out what's considered a "heavy load" plus all the nuances for the phases. Right now we have a pattern of "soft" and "hard" limits: memstore multiplier, they can get by default up to 2x their configured size by default before blocking. compaction threshold and blocking values, the former is when we should kick a compaction and the latter is when we are in a "too many store files" mode. global memstore barriers, the lower one starts force flushing the bigger regions and the upper one blocks inserts. I may be missing some others. Do we want to keep them or piggy back? In all three cases we don't tell the client anything until it blocks and instead we try to just take action ASAP. One way could be to send resets once we're past the soft limit... but I'm not sure if it's really going to help.
          Hide
          Jesse Yates added a comment -

          Worked up an initial implementation that doesn't actually break the RPC (I think, even if client or the server has monitoring turned on), but avoids doing the exception passing back to the client, which IMHO is the least clean way to handle this as exceptions are for exceptional cases, not the common case.

          Right now the implementation only covers Puts, but could definitely be extended to cover other writes; I wanted to get some feedback on general style, etc. before going for the full blown implementation (and all the general cleanup associated with a 'real' patch).

          As far as how it is put together...
          Client has a backoff policy to take into consideration what the server is saying.
          This policy can take into account the current, max, and growth size of the write buffer for figuring out how long to sleep. The server pressure is unwrapped from the server in the Result as a MonitoredResult and then updated on the client. The next put will then take into account that pressure when attempting a put. The problem here is that the server can't tell all clients that the pressure has gone down, but that trade-off is common given traditional collision/backoff situations.

          The client has also been given permission to grow to a multiplier of its writeBufferSize, similar to the memstoremultiplier, allowing it to buffer more writes. If a write is within the expansion range, we want to allow the client to accept more writes while waiting/backing-off, so we launch a flusher thread that after waiting the backoff time will flush the writes (singleton). This gives us back-off as well as some flexiblilty on the client as to how much we buffer. To disable the backoff behavior, its as simple as setting the multiplier to 1, so the expansion = max.

          Similarly, on the RS, we make the policy for monitoring pluggable and optional to enable the blocking for a given threshold. The policy here can take into account the current number of store files, the number where we will get blocking and the current % full of the memstore (total size and max size). This allows us to ensure that we only slow down based on a given policy (yet to be implemented) but do get protection for the RS from malicious/over-eager clients.

          This impl may be a little over the top, but it does cover both sides of the on-the-wire story. Only things left to do are to extend this to other writes as well as creating at least one (if not two or three) tunable policies for figuring out blocking.

          Thoughts?

          Show
          Jesse Yates added a comment - Worked up an initial implementation that doesn't actually break the RPC (I think, even if client or the server has monitoring turned on), but avoids doing the exception passing back to the client, which IMHO is the least clean way to handle this as exceptions are for exceptional cases, not the common case. Right now the implementation only covers Puts, but could definitely be extended to cover other writes; I wanted to get some feedback on general style, etc. before going for the full blown implementation (and all the general cleanup associated with a 'real' patch). As far as how it is put together... Client has a backoff policy to take into consideration what the server is saying. This policy can take into account the current, max, and growth size of the write buffer for figuring out how long to sleep. The server pressure is unwrapped from the server in the Result as a MonitoredResult and then updated on the client. The next put will then take into account that pressure when attempting a put. The problem here is that the server can't tell all clients that the pressure has gone down, but that trade-off is common given traditional collision/backoff situations. The client has also been given permission to grow to a multiplier of its writeBufferSize, similar to the memstoremultiplier, allowing it to buffer more writes. If a write is within the expansion range, we want to allow the client to accept more writes while waiting/backing-off, so we launch a flusher thread that after waiting the backoff time will flush the writes (singleton). This gives us back-off as well as some flexiblilty on the client as to how much we buffer. To disable the backoff behavior, its as simple as setting the multiplier to 1, so the expansion = max. Similarly, on the RS, we make the policy for monitoring pluggable and optional to enable the blocking for a given threshold. The policy here can take into account the current number of store files, the number where we will get blocking and the current % full of the memstore (total size and max size). This allows us to ensure that we only slow down based on a given policy (yet to be implemented) but do get protection for the RS from malicious/over-eager clients. This impl may be a little over the top, but it does cover both sides of the on-the-wire story. Only things left to do are to extend this to other writes as well as creating at least one (if not two or three) tunable policies for figuring out blocking. Thoughts?
          Jesse Yates made changes -
          Field Original Value New Value
          Attachment java_HBASE-5162.patch [ 12514851 ]
          Hide
          Lars Hofhansl added a comment -

          Might be good to publish on review board, that patch is a bit big to read as diff

          Show
          Lars Hofhansl added a comment - Might be good to publish on review board, that patch is a bit big to read as diff
          Hide
          Jesse Yates added a comment -

          @lars - can do. I didn't want it up there initially as that tends to find a lot of nitpicks, which this patch I'm sure has lots of

          Show
          Jesse Yates added a comment - @lars - can do. I didn't want it up there initially as that tends to find a lot of nitpicks, which this patch I'm sure has lots of
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/3930/
          -----------------------------------------------------------

          Review request for hbase, Michael Stack, Jean-Daniel Cryans, and Lars Hofhansl.

          Summary
          -------

          Under heavy write load, HBase will create a saw-tooth pattern in accepting writes. This is due to the I/O in minor compactions not being able to keep up with the write load. Specifically, the memstore is attempting to flush while we are attempting to do a minor compaction, leading to blocking all writes. Instead, we need to have the option of graceful degradation mechanism.

          This patch supports both a short-term,adjustable server-side write blocking as well as client-side back-off to help alleviate temporary memstore pressure.

          This addresses bug HBASE-5162.
          https://issues.apache.org/jira/browse/HBASE-5162

          Diffs


          src/main/java/org/apache/hadoop/hbase/HConstants.java 763fe89
          src/main/java/org/apache/hadoop/hbase/client/BackoffPolicy.java PRE-CREATION
          src/main/java/org/apache/hadoop/hbase/client/HTable.java 57605e6
          src/main/java/org/apache/hadoop/hbase/client/MonitoredResult.java PRE-CREATION
          src/main/java/org/apache/hadoop/hbase/client/NoServerBackoffPolicy.java PRE-CREATION
          src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 25cb31d
          src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 7d7be3c
          src/main/java/org/apache/hadoop/hbase/regionserver/MemstorePressureMonitor.java PRE-CREATION
          src/main/java/org/apache/hadoop/hbase/regionserver/OperationStatus.java 1b94ab5
          src/main/java/org/apache/hadoop/hbase/regionserver/PressureMonitor.java PRE-CREATION
          src/main/java/org/apache/hadoop/hbase/regionserver/SimpleMemStorePressureMonitor.java PRE-CREATION
          src/main/java/org/apache/hadoop/hbase/regionserver/StoreUtils.java PRE-CREATION
          src/test/java/org/apache/hadoop/hbase/client/TestClientBackOff.java PRE-CREATION
          src/test/java/org/apache/hadoop/hbase/regionserver/TestMemStorePressureMonitor.java PRE-CREATION

          Diff: https://reviews.apache.org/r/3930/diff

          Testing
          -------

          Thanks,

          Jesse

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3930/ ----------------------------------------------------------- Review request for hbase, Michael Stack, Jean-Daniel Cryans, and Lars Hofhansl. Summary ------- Under heavy write load, HBase will create a saw-tooth pattern in accepting writes. This is due to the I/O in minor compactions not being able to keep up with the write load. Specifically, the memstore is attempting to flush while we are attempting to do a minor compaction, leading to blocking all writes. Instead, we need to have the option of graceful degradation mechanism. This patch supports both a short-term,adjustable server-side write blocking as well as client-side back-off to help alleviate temporary memstore pressure. This addresses bug HBASE-5162 . https://issues.apache.org/jira/browse/HBASE-5162 Diffs src/main/java/org/apache/hadoop/hbase/HConstants.java 763fe89 src/main/java/org/apache/hadoop/hbase/client/BackoffPolicy.java PRE-CREATION src/main/java/org/apache/hadoop/hbase/client/HTable.java 57605e6 src/main/java/org/apache/hadoop/hbase/client/MonitoredResult.java PRE-CREATION src/main/java/org/apache/hadoop/hbase/client/NoServerBackoffPolicy.java PRE-CREATION src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 25cb31d src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 7d7be3c src/main/java/org/apache/hadoop/hbase/regionserver/MemstorePressureMonitor.java PRE-CREATION src/main/java/org/apache/hadoop/hbase/regionserver/OperationStatus.java 1b94ab5 src/main/java/org/apache/hadoop/hbase/regionserver/PressureMonitor.java PRE-CREATION src/main/java/org/apache/hadoop/hbase/regionserver/SimpleMemStorePressureMonitor.java PRE-CREATION src/main/java/org/apache/hadoop/hbase/regionserver/StoreUtils.java PRE-CREATION src/test/java/org/apache/hadoop/hbase/client/TestClientBackOff.java PRE-CREATION src/test/java/org/apache/hadoop/hbase/regionserver/TestMemStorePressureMonitor.java PRE-CREATION Diff: https://reviews.apache.org/r/3930/diff Testing ------- Thanks, Jesse
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/3930/#review5209
          -----------------------------------------------------------

          src/main/java/org/apache/hadoop/hbase/client/HTable.java
          <https://reviews.apache.org/r/3930/#comment11397>

          I find this a bit dubious.
          This won't actually slow the client thread down, but just accumulate more data and reduce the number of RPCs. In the end it might lead to more load on the server, because we can deliver more puts as with fewer but larger batches.

          I'd rather just rely on the server sleeping the thread for a bit (as you do later).

          src/main/java/org/apache/hadoop/hbase/client/HTable.java
          <https://reviews.apache.org/r/3930/#comment11399>

          What if the flusher is not null? Should we re-calculate the wait time?

          src/main/java/org/apache/hadoop/hbase/client/HTable.java
          <https://reviews.apache.org/r/3930/#comment11400>

          If sleepTime is 0 (for example from NoServerBackoffPolicy), we should probably not create the thread and flush right here.

          (But as I said in the comment above, I'd probably not bother with this extra thread to begin with )

          src/main/java/org/apache/hadoop/hbase/client/HTable.java
          <https://reviews.apache.org/r/3930/#comment11401>

          Was this a problem before? Or only now becaue of the background thread?

          src/main/java/org/apache/hadoop/hbase/client/HTable.java
          <https://reviews.apache.org/r/3930/#comment11398>

          This will break backwards compatibility, right? (Not saying that's not ok, just calling it out)

          I'd almost rather have the client not know about this, until we reach a bad spot (in which case we can throw back retryable exceptions).

          src/main/java/org/apache/hadoop/hbase/regionserver/MemstorePressureMonitor.java
          <https://reviews.apache.org/r/3930/#comment11402>

          Ah ok, this is where we gracefully delay the server thread a bit.
          Seems this would need to be tweaked carefully to make it effective while not slowing normal operations.

          Should the serverPauseTime be somehow related to the amount of pressure.
          I.e. wait a bit more if the pressure is higher?
          Maybe the pausetime calculation should be part of the pluggable policy?

          Also in the jira there was some discussion about throwing (presumably retryable) exceptions back to the client is the pressure gets too high. That would slow the client, without consuming server resources (beyond multiple requests).

          src/main/java/org/apache/hadoop/hbase/regionserver/StoreUtils.java
          <https://reviews.apache.org/r/3930/#comment11403>

          General comment: Where are we on putting/documenting these things in hbase-defaults.xml?

          • Lars

          On 2012-02-16 20:45:50, Jesse Yates wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/3930/

          -----------------------------------------------------------

          (Updated 2012-02-16 20:45:50)

          Review request for hbase, Michael Stack, Jean-Daniel Cryans, and Lars Hofhansl.

          Summary

          -------

          Under heavy write load, HBase will create a saw-tooth pattern in accepting writes. This is due to the I/O in minor compactions not being able to keep up with the write load. Specifically, the memstore is attempting to flush while we are attempting to do a minor compaction, leading to blocking all writes. Instead, we need to have the option of graceful degradation mechanism.

          This patch supports both a short-term,adjustable server-side write blocking as well as client-side back-off to help alleviate temporary memstore pressure.

          This addresses bug HBASE-5162.

          https://issues.apache.org/jira/browse/HBASE-5162

          Diffs

          -----

          src/main/java/org/apache/hadoop/hbase/HConstants.java 763fe89

          src/main/java/org/apache/hadoop/hbase/client/BackoffPolicy.java PRE-CREATION

          src/main/java/org/apache/hadoop/hbase/client/HTable.java 57605e6

          src/main/java/org/apache/hadoop/hbase/client/MonitoredResult.java PRE-CREATION

          src/main/java/org/apache/hadoop/hbase/client/NoServerBackoffPolicy.java PRE-CREATION

          src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 25cb31d

          src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 7d7be3c

          src/main/java/org/apache/hadoop/hbase/regionserver/MemstorePressureMonitor.java PRE-CREATION

          src/main/java/org/apache/hadoop/hbase/regionserver/OperationStatus.java 1b94ab5

          src/main/java/org/apache/hadoop/hbase/regionserver/PressureMonitor.java PRE-CREATION

          src/main/java/org/apache/hadoop/hbase/regionserver/SimpleMemStorePressureMonitor.java PRE-CREATION

          src/main/java/org/apache/hadoop/hbase/regionserver/StoreUtils.java PRE-CREATION

          src/test/java/org/apache/hadoop/hbase/client/TestClientBackOff.java PRE-CREATION

          src/test/java/org/apache/hadoop/hbase/regionserver/TestMemStorePressureMonitor.java PRE-CREATION

          Diff: https://reviews.apache.org/r/3930/diff

          Testing

          -------

          Thanks,

          Jesse

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3930/#review5209 ----------------------------------------------------------- src/main/java/org/apache/hadoop/hbase/client/HTable.java < https://reviews.apache.org/r/3930/#comment11397 > I find this a bit dubious. This won't actually slow the client thread down, but just accumulate more data and reduce the number of RPCs. In the end it might lead to more load on the server, because we can deliver more puts as with fewer but larger batches. I'd rather just rely on the server sleeping the thread for a bit (as you do later). src/main/java/org/apache/hadoop/hbase/client/HTable.java < https://reviews.apache.org/r/3930/#comment11399 > What if the flusher is not null? Should we re-calculate the wait time? src/main/java/org/apache/hadoop/hbase/client/HTable.java < https://reviews.apache.org/r/3930/#comment11400 > If sleepTime is 0 (for example from NoServerBackoffPolicy), we should probably not create the thread and flush right here. (But as I said in the comment above, I'd probably not bother with this extra thread to begin with ) src/main/java/org/apache/hadoop/hbase/client/HTable.java < https://reviews.apache.org/r/3930/#comment11401 > Was this a problem before? Or only now becaue of the background thread? src/main/java/org/apache/hadoop/hbase/client/HTable.java < https://reviews.apache.org/r/3930/#comment11398 > This will break backwards compatibility, right? (Not saying that's not ok, just calling it out) I'd almost rather have the client not know about this, until we reach a bad spot (in which case we can throw back retryable exceptions). src/main/java/org/apache/hadoop/hbase/regionserver/MemstorePressureMonitor.java < https://reviews.apache.org/r/3930/#comment11402 > Ah ok, this is where we gracefully delay the server thread a bit. Seems this would need to be tweaked carefully to make it effective while not slowing normal operations. Should the serverPauseTime be somehow related to the amount of pressure. I.e. wait a bit more if the pressure is higher? Maybe the pausetime calculation should be part of the pluggable policy? Also in the jira there was some discussion about throwing (presumably retryable) exceptions back to the client is the pressure gets too high. That would slow the client, without consuming server resources (beyond multiple requests). src/main/java/org/apache/hadoop/hbase/regionserver/StoreUtils.java < https://reviews.apache.org/r/3930/#comment11403 > General comment: Where are we on putting/documenting these things in hbase-defaults.xml? Lars On 2012-02-16 20:45:50, Jesse Yates wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3930/ ----------------------------------------------------------- (Updated 2012-02-16 20:45:50) Review request for hbase, Michael Stack, Jean-Daniel Cryans, and Lars Hofhansl. Summary ------- Under heavy write load, HBase will create a saw-tooth pattern in accepting writes. This is due to the I/O in minor compactions not being able to keep up with the write load. Specifically, the memstore is attempting to flush while we are attempting to do a minor compaction, leading to blocking all writes. Instead, we need to have the option of graceful degradation mechanism. This patch supports both a short-term,adjustable server-side write blocking as well as client-side back-off to help alleviate temporary memstore pressure. This addresses bug HBASE-5162 . https://issues.apache.org/jira/browse/HBASE-5162 Diffs ----- src/main/java/org/apache/hadoop/hbase/HConstants.java 763fe89 src/main/java/org/apache/hadoop/hbase/client/BackoffPolicy.java PRE-CREATION src/main/java/org/apache/hadoop/hbase/client/HTable.java 57605e6 src/main/java/org/apache/hadoop/hbase/client/MonitoredResult.java PRE-CREATION src/main/java/org/apache/hadoop/hbase/client/NoServerBackoffPolicy.java PRE-CREATION src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 25cb31d src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 7d7be3c src/main/java/org/apache/hadoop/hbase/regionserver/MemstorePressureMonitor.java PRE-CREATION src/main/java/org/apache/hadoop/hbase/regionserver/OperationStatus.java 1b94ab5 src/main/java/org/apache/hadoop/hbase/regionserver/PressureMonitor.java PRE-CREATION src/main/java/org/apache/hadoop/hbase/regionserver/SimpleMemStorePressureMonitor.java PRE-CREATION src/main/java/org/apache/hadoop/hbase/regionserver/StoreUtils.java PRE-CREATION src/test/java/org/apache/hadoop/hbase/client/TestClientBackOff.java PRE-CREATION src/test/java/org/apache/hadoop/hbase/regionserver/TestMemStorePressureMonitor.java PRE-CREATION Diff: https://reviews.apache.org/r/3930/diff Testing ------- Thanks, Jesse
          Hide
          jiraposter@reviews.apache.org added a comment -

          On 2012-02-18 04:58:21, Lars Hofhansl wrote:

          > src/main/java/org/apache/hadoop/hbase/regionserver/StoreUtils.java, line 7

          > <https://reviews.apache.org/r/3930/diff/1/?file=75496#file75496line7>

          >

          > General comment: Where are we on putting/documenting these things in hbase-defaults.xml?

          That is already in there, but having the constants just reinforces the 'correct' behavior. Though I think there are some situations where the code is different from defaults.xml

          On 2012-02-18 04:58:21, Lars Hofhansl wrote:

          > src/main/java/org/apache/hadoop/hbase/regionserver/MemstorePressureMonitor.java, line 124

          > <https://reviews.apache.org/r/3930/diff/1/?file=75492#file75492line124>

          >

          > Ah ok, this is where we gracefully delay the server thread a bit.

          > Seems this would need to be tweaked carefully to make it effective while not slowing normal operations.

          >

          > Should the serverPauseTime be somehow related to the amount of pressure.

          > I.e. wait a bit more if the pressure is higher?

          > Maybe the pausetime calculation should be part of the pluggable policy?

          >

          > Also in the jira there was some discussion about throwing (presumably retryable) exceptions back to the client is the pressure gets too high. That would slow the client, without consuming server resources (beyond multiple requests).

          Definitely needs some knobs with the policy here and tuning.

          It would be possible to tie the pause time to the amount of pressure (some sort of multiplier effect). Would have to think about the implications of that

          Throwing the exception back the client here means you get a lot of bandwidth overhead as the client passes back a bunch of puts again, which is rough. Otherwise, we are definitely going to be messing with wire-compatibility in a functional (if not strictly RPC) sense.

          On 2012-02-18 04:58:21, Lars Hofhansl wrote:

          > src/main/java/org/apache/hadoop/hbase/client/HTable.java, line 979

          > <https://reviews.apache.org/r/3930/diff/1/?file=75487#file75487line979>

          >

          > This will break backwards compatibility, right? (Not saying that's not ok, just calling it out)

          >

          > I'd almost rather have the client not know about this, until we reach a bad spot (in which case we can throw back retryable exceptions).

          I don't think so. If the server isn't upgraded to the send monitoredResults, then this bit of code won't matter. If the client isn't upgraded, then it won't even consider if the MonitoredResult isn't just a Result.

          On 2012-02-18 04:58:21, Lars Hofhansl wrote:

          > src/main/java/org/apache/hadoop/hbase/client/HTable.java, line 958

          > <https://reviews.apache.org/r/3930/diff/1/?file=75487#file75487line958>

          >

          > Was this a problem before? Or only now becaue of the background thread?

          Just b/c of the background thread.

          On 2012-02-18 04:58:21, Lars Hofhansl wrote:

          > src/main/java/org/apache/hadoop/hbase/client/HTable.java, line 792

          > <https://reviews.apache.org/r/3930/diff/1/?file=75487#file75487line792>

          >

          > If sleepTime is 0 (for example from NoServerBackoffPolicy), we should probably not create the thread and flush right here.

          >

          > (But as I said in the comment above, I'd probably not bother with this extra thread to begin with )

          +1 fixing in next version, assuming the client stuff is kept

          On 2012-02-18 04:58:21, Lars Hofhansl wrote:

          > src/main/java/org/apache/hadoop/hbase/client/HTable.java, line 791

          > <https://reviews.apache.org/r/3930/diff/1/?file=75487#file75487line791>

          >

          > What if the flusher is not null? Should we re-calculate the wait time?

          We are temporarily growing the write buffer, so if we get another write, I was thinking we would just let it accumulate too - it will get flushed soon enough. Only corner case here is if the size grows beyond the allowed, in which case there will be a forced flush.

          On 2012-02-18 04:58:21, Lars Hofhansl wrote:

          > src/main/java/org/apache/hadoop/hbase/client/HTable.java, line 790

          > <https://reviews.apache.org/r/3930/diff/1/?file=75487#file75487line790>

          >

          > I find this a bit dubious.

          > This won't actually slow the client thread down, but just accumulate more data and reduce the number of RPCs. In the end it might lead to more load on the server, because we can deliver more puts as with fewer but larger batches.

          >

          > I'd rather just rely on the server sleeping the thread for a bit (as you do later).

          The question here is what we consider the 'client'. To me, the client was the client-side HTable, not the using application. So yes, this will not slow the using application, but that was the intention...keeping HBase seeming as responsive, but just letting the messaging layer handle the queuing and buffering.

          Technically, this will actually slow the rate of writes to the server, which is what we really are worrying about. Essentially, this implementation is such that we temporarily increase batch size so the server has time to finish its compactions and flushing.

          The server can handle the larger batch sizes (except for extreme cases) since the assumption has to be clientMemory << serverMemory.

          This is just experimental I'll need to do some stress testing to actually see the effects

          • Jesse

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/3930/#review5209
          -----------------------------------------------------------

          On 2012-02-16 20:45:50, Jesse Yates wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/3930/

          -----------------------------------------------------------

          (Updated 2012-02-16 20:45:50)

          Review request for hbase, Michael Stack, Jean-Daniel Cryans, and Lars Hofhansl.

          Summary

          -------

          Under heavy write load, HBase will create a saw-tooth pattern in accepting writes. This is due to the I/O in minor compactions not being able to keep up with the write load. Specifically, the memstore is attempting to flush while we are attempting to do a minor compaction, leading to blocking all writes. Instead, we need to have the option of graceful degradation mechanism.

          This patch supports both a short-term,adjustable server-side write blocking as well as client-side back-off to help alleviate temporary memstore pressure.

          This addresses bug HBASE-5162.

          https://issues.apache.org/jira/browse/HBASE-5162

          Diffs

          -----

          src/main/java/org/apache/hadoop/hbase/HConstants.java 763fe89

          src/main/java/org/apache/hadoop/hbase/client/BackoffPolicy.java PRE-CREATION

          src/main/java/org/apache/hadoop/hbase/client/HTable.java 57605e6

          src/main/java/org/apache/hadoop/hbase/client/MonitoredResult.java PRE-CREATION

          src/main/java/org/apache/hadoop/hbase/client/NoServerBackoffPolicy.java PRE-CREATION

          src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 25cb31d

          src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 7d7be3c

          src/main/java/org/apache/hadoop/hbase/regionserver/MemstorePressureMonitor.java PRE-CREATION

          src/main/java/org/apache/hadoop/hbase/regionserver/OperationStatus.java 1b94ab5

          src/main/java/org/apache/hadoop/hbase/regionserver/PressureMonitor.java PRE-CREATION

          src/main/java/org/apache/hadoop/hbase/regionserver/SimpleMemStorePressureMonitor.java PRE-CREATION

          src/main/java/org/apache/hadoop/hbase/regionserver/StoreUtils.java PRE-CREATION

          src/test/java/org/apache/hadoop/hbase/client/TestClientBackOff.java PRE-CREATION

          src/test/java/org/apache/hadoop/hbase/regionserver/TestMemStorePressureMonitor.java PRE-CREATION

          Diff: https://reviews.apache.org/r/3930/diff

          Testing

          -------

          Thanks,

          Jesse

          Show
          jiraposter@reviews.apache.org added a comment - On 2012-02-18 04:58:21, Lars Hofhansl wrote: > src/main/java/org/apache/hadoop/hbase/regionserver/StoreUtils.java, line 7 > < https://reviews.apache.org/r/3930/diff/1/?file=75496#file75496line7 > > > General comment: Where are we on putting/documenting these things in hbase-defaults.xml? That is already in there, but having the constants just reinforces the 'correct' behavior. Though I think there are some situations where the code is different from defaults.xml On 2012-02-18 04:58:21, Lars Hofhansl wrote: > src/main/java/org/apache/hadoop/hbase/regionserver/MemstorePressureMonitor.java, line 124 > < https://reviews.apache.org/r/3930/diff/1/?file=75492#file75492line124 > > > Ah ok, this is where we gracefully delay the server thread a bit. > Seems this would need to be tweaked carefully to make it effective while not slowing normal operations. > > Should the serverPauseTime be somehow related to the amount of pressure. > I.e. wait a bit more if the pressure is higher? > Maybe the pausetime calculation should be part of the pluggable policy? > > Also in the jira there was some discussion about throwing (presumably retryable) exceptions back to the client is the pressure gets too high. That would slow the client, without consuming server resources (beyond multiple requests). Definitely needs some knobs with the policy here and tuning. It would be possible to tie the pause time to the amount of pressure (some sort of multiplier effect). Would have to think about the implications of that Throwing the exception back the client here means you get a lot of bandwidth overhead as the client passes back a bunch of puts again , which is rough. Otherwise, we are definitely going to be messing with wire-compatibility in a functional (if not strictly RPC) sense. On 2012-02-18 04:58:21, Lars Hofhansl wrote: > src/main/java/org/apache/hadoop/hbase/client/HTable.java, line 979 > < https://reviews.apache.org/r/3930/diff/1/?file=75487#file75487line979 > > > This will break backwards compatibility, right? (Not saying that's not ok, just calling it out) > > I'd almost rather have the client not know about this, until we reach a bad spot (in which case we can throw back retryable exceptions). I don't think so. If the server isn't upgraded to the send monitoredResults, then this bit of code won't matter. If the client isn't upgraded, then it won't even consider if the MonitoredResult isn't just a Result. On 2012-02-18 04:58:21, Lars Hofhansl wrote: > src/main/java/org/apache/hadoop/hbase/client/HTable.java, line 958 > < https://reviews.apache.org/r/3930/diff/1/?file=75487#file75487line958 > > > Was this a problem before? Or only now becaue of the background thread? Just b/c of the background thread. On 2012-02-18 04:58:21, Lars Hofhansl wrote: > src/main/java/org/apache/hadoop/hbase/client/HTable.java, line 792 > < https://reviews.apache.org/r/3930/diff/1/?file=75487#file75487line792 > > > If sleepTime is 0 (for example from NoServerBackoffPolicy), we should probably not create the thread and flush right here. > > (But as I said in the comment above, I'd probably not bother with this extra thread to begin with ) +1 fixing in next version, assuming the client stuff is kept On 2012-02-18 04:58:21, Lars Hofhansl wrote: > src/main/java/org/apache/hadoop/hbase/client/HTable.java, line 791 > < https://reviews.apache.org/r/3930/diff/1/?file=75487#file75487line791 > > > What if the flusher is not null? Should we re-calculate the wait time? We are temporarily growing the write buffer, so if we get another write, I was thinking we would just let it accumulate too - it will get flushed soon enough. Only corner case here is if the size grows beyond the allowed, in which case there will be a forced flush. On 2012-02-18 04:58:21, Lars Hofhansl wrote: > src/main/java/org/apache/hadoop/hbase/client/HTable.java, line 790 > < https://reviews.apache.org/r/3930/diff/1/?file=75487#file75487line790 > > > I find this a bit dubious. > This won't actually slow the client thread down, but just accumulate more data and reduce the number of RPCs. In the end it might lead to more load on the server, because we can deliver more puts as with fewer but larger batches. > > I'd rather just rely on the server sleeping the thread for a bit (as you do later). The question here is what we consider the 'client'. To me, the client was the client-side HTable, not the using application. So yes, this will not slow the using application, but that was the intention...keeping HBase seeming as responsive, but just letting the messaging layer handle the queuing and buffering. Technically, this will actually slow the rate of writes to the server , which is what we really are worrying about. Essentially, this implementation is such that we temporarily increase batch size so the server has time to finish its compactions and flushing. The server can handle the larger batch sizes (except for extreme cases) since the assumption has to be clientMemory << serverMemory. This is just experimental I'll need to do some stress testing to actually see the effects Jesse ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3930/#review5209 ----------------------------------------------------------- On 2012-02-16 20:45:50, Jesse Yates wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3930/ ----------------------------------------------------------- (Updated 2012-02-16 20:45:50) Review request for hbase, Michael Stack, Jean-Daniel Cryans, and Lars Hofhansl. Summary ------- Under heavy write load, HBase will create a saw-tooth pattern in accepting writes. This is due to the I/O in minor compactions not being able to keep up with the write load. Specifically, the memstore is attempting to flush while we are attempting to do a minor compaction, leading to blocking all writes. Instead, we need to have the option of graceful degradation mechanism. This patch supports both a short-term,adjustable server-side write blocking as well as client-side back-off to help alleviate temporary memstore pressure. This addresses bug HBASE-5162 . https://issues.apache.org/jira/browse/HBASE-5162 Diffs ----- src/main/java/org/apache/hadoop/hbase/HConstants.java 763fe89 src/main/java/org/apache/hadoop/hbase/client/BackoffPolicy.java PRE-CREATION src/main/java/org/apache/hadoop/hbase/client/HTable.java 57605e6 src/main/java/org/apache/hadoop/hbase/client/MonitoredResult.java PRE-CREATION src/main/java/org/apache/hadoop/hbase/client/NoServerBackoffPolicy.java PRE-CREATION src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 25cb31d src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 7d7be3c src/main/java/org/apache/hadoop/hbase/regionserver/MemstorePressureMonitor.java PRE-CREATION src/main/java/org/apache/hadoop/hbase/regionserver/OperationStatus.java 1b94ab5 src/main/java/org/apache/hadoop/hbase/regionserver/PressureMonitor.java PRE-CREATION src/main/java/org/apache/hadoop/hbase/regionserver/SimpleMemStorePressureMonitor.java PRE-CREATION src/main/java/org/apache/hadoop/hbase/regionserver/StoreUtils.java PRE-CREATION src/test/java/org/apache/hadoop/hbase/client/TestClientBackOff.java PRE-CREATION src/test/java/org/apache/hadoop/hbase/regionserver/TestMemStorePressureMonitor.java PRE-CREATION Diff: https://reviews.apache.org/r/3930/diff Testing ------- Thanks, Jesse
          Hide
          Lars Hofhansl added a comment -

          Let's aim for 0.94.1 with this.

          Show
          Lars Hofhansl added a comment - Let's aim for 0.94.1 with this.
          Lars Hofhansl made changes -
          Fix Version/s 0.94.1 [ 12320257 ]
          Fix Version/s 0.94.0 [ 12316419 ]
          Hide
          Lars Hofhansl added a comment -

          Is this ready? Moving to 0.96. Feel free to pull back.

          Show
          Lars Hofhansl added a comment - Is this ready? Moving to 0.96. Feel free to pull back.
          Lars Hofhansl made changes -
          Fix Version/s 0.96.0 [ 12320040 ]
          Fix Version/s 0.94.1 [ 12320257 ]
          Hide
          Jesse Yates added a comment -

          @Lars not yet - needs some more testing and validation on a real cluster. I've been a bit busy and haven't got a chance to swing back around.

          Show
          Jesse Yates added a comment - @Lars not yet - needs some more testing and validation on a real cluster. I've been a bit busy and haven't got a chance to swing back around.
          Todd Lipcon made changes -
          Link This issue is related to HBASE-6423 [ HBASE-6423 ]
          Ian Varley made changes -
          Link This issue relates to HBASE-5333 [ HBASE-5333 ]
          Ian Varley made changes -
          Link This issue is duplicated by HBASE-5333 [ HBASE-5333 ]
          Ian Varley made changes -
          Link This issue relates to HBASE-5333 [ HBASE-5333 ]
          Todd Lipcon made changes -
          Link This issue is related to HBASE-2981 [ HBASE-2981 ]
          Hide
          Jimmy Xiang added a comment -

          Isn't the exception way much cleaner and simpler? I think the exception way is greedy, and the hbase client code needs minimal change. Based on the retry count, it can adjust the delay time in the middle.

          For the load monitoring, we assume the load trend remains the same, which may not be that case actually. The client side has to track the regions whose memstore is under pressure. Every client needs to do the same tracking.

          Show
          Jimmy Xiang added a comment - Isn't the exception way much cleaner and simpler? I think the exception way is greedy, and the hbase client code needs minimal change. Based on the retry count, it can adjust the delay time in the middle. For the load monitoring, we assume the load trend remains the same, which may not be that case actually. The client side has to track the regions whose memstore is under pressure. Every client needs to do the same tracking.
          Hide
          Jesse Yates added a comment -

          Jimmy Xiang not really - the exception causes old clients to fail and uses exception type inheritance + instanceof checking to get the information across. The client code does need minimal change (see my attached patch), but it just feels dirty, especially when we have PBs for everythign. What would be far better is just pass that info back as an optional PB parameter and have the client monitor it or not. This both works the the older versions AND optionally turning it off on the client if your workload needs it. the workload doesn't stay the same - the client gets constant information (at least with each mutation across the wire) back from the region and adjusts as it's updated.

          So yeah, every client that has this enabled would have to track the information. But you could make it that you just track the most recent 'n' regions. And an advanced version would also do some load half-life mechanism on the client if it hasn't talked to that region in a while.

          Show
          Jesse Yates added a comment - Jimmy Xiang not really - the exception causes old clients to fail and uses exception type inheritance + instanceof checking to get the information across. The client code does need minimal change (see my attached patch), but it just feels dirty , especially when we have PBs for everythign. What would be far better is just pass that info back as an optional PB parameter and have the client monitor it or not. This both works the the older versions AND optionally turning it off on the client if your workload needs it. the workload doesn't stay the same - the client gets constant information (at least with each mutation across the wire) back from the region and adjusts as it's updated. So yeah, every client that has this enabled would have to track the information. But you could make it that you just track the most recent 'n' regions. And an advanced version would also do some load half-life mechanism on the client if it hasn't talked to that region in a while.
          Hide
          Lars Hofhansl added a comment -

          We could just throw a ServerTooBusyException (or something), which would extend IOException, so the client would just retry. However after a while then the client would fail, when it should just wait longer.
          No sure how much better that would than it is now, though. It would be better to gradually slow clients down, so that they still make progress but only as fast as the system can absorb it.

          Show
          Lars Hofhansl added a comment - We could just throw a ServerTooBusyException (or something), which would extend IOException, so the client would just retry. However after a while then the client would fail, when it should just wait longer. No sure how much better that would than it is now, though. It would be better to gradually slow clients down, so that they still make progress but only as fast as the system can absorb it.
          Hide
          Jesse Yates added a comment -

          The problem with throwing just another IOException with the default client is that the client thinks its writes failed, in which it retries, causing MORE load on the already overloaded server. You'd have to hack the client a bit, which means that still on 0.94 you get the retry behaviour

          Show
          Jesse Yates added a comment - The problem with throwing just another IOException with the default client is that the client thinks its writes failed, in which it retries, causing MORE load on the already overloaded server. You'd have to hack the client a bit, which means that still on 0.94 you get the retry behaviour
          Hide
          Jesse Yates added a comment -

          I tried to tackle this doing the PB way a little while ago (though it may have been in conjunction with some other ticket that I don't recall at the moment) and you basically need to rewrite how the client does batch puts to allow you to actually get at the returned PB object, rather than having it pass the callback the underlying errors/rows. IIRC this wasn't super clean as the code there is very convoluted. However, you can tie it into the other mutation methods really easily as just a hook on the serverCallable.

          Show
          Jesse Yates added a comment - I tried to tackle this doing the PB way a little while ago (though it may have been in conjunction with some other ticket that I don't recall at the moment) and you basically need to rewrite how the client does batch puts to allow you to actually get at the returned PB object, rather than having it pass the callback the underlying errors/rows. IIRC this wasn't super clean as the code there is very convoluted. However, you can tie it into the other mutation methods really easily as just a hook on the serverCallable.
          Hide
          Jimmy Xiang added a comment -

          I was thinking RegionTooBusyException, so close. As long as the server releases the IPC handler in such scenario, accessing other regions should not be blocked. The point is that we don't want a busy region blocks a whole region server.

          As to the old clients, right, the behavior is a little different. But they should not fail, as currently they should expect exceptions and handle them properly, for example, retry, although it may not be as efficient as delaying more when the retry count is bigger.

          As to measure the load, I think it is a good idea. I just have some concern in spending too much efforts on it without trying the simple one at first, which is known to work.

          Show
          Jimmy Xiang added a comment - I was thinking RegionTooBusyException, so close. As long as the server releases the IPC handler in such scenario, accessing other regions should not be blocked. The point is that we don't want a busy region blocks a whole region server. As to the old clients, right, the behavior is a little different. But they should not fail, as currently they should expect exceptions and handle them properly, for example, retry, although it may not be as efficient as delaying more when the retry count is bigger. As to measure the load, I think it is a good idea. I just have some concern in spending too much efforts on it without trying the simple one at first, which is known to work.
          Hide
          Jimmy Xiang added a comment -

          For the extra load due to retry, it is mostly on network, not very much on the server. The retry time is configurable based on the tries:

          ConnectionUtils.getPauseTime(pause, tries)

          As long as the retry is gradually slowing down, is it acceptable?

          Show
          Jimmy Xiang added a comment - For the extra load due to retry, it is mostly on network, not very much on the server. The retry time is configurable based on the tries: ConnectionUtils.getPauseTime(pause, tries) As long as the retry is gradually slowing down, is it acceptable?
          Hide
          Jesse Yates added a comment -

          Jimmy Xiang my patch is up there, if you want to run with it.. I'm a bit busy at the moment

          The client has also been given permission to grow to a multiplier of its writeBufferSize, similar to the memstoremultiplier, allowing it to buffer more writes. If a write is within the expansion range, we want to allow the client to accept more writes while waiting/backing-off, so we launch a flusher thread that after waiting the backoff time will flush the writes (singleton). This gives us back-off as well as some flexiblilty on the client as to how much we buffer. To disable the backoff behavior, its as simple as setting the multiplier to 1, so the expansion = max.

          -Jesse

          I don't this is really the right way to handle this, but instead just plug in the wait-object per region that ties in the most recent information. Also, from the above, using a MonitoredResult rather than throwing an exception ensures the same behavior on old and new clients. Its ugly, but as long as you put in a TODO, I'm okay with it.

          You might need to rewrite a bit of my patch - there are probably some good hints as to the right places to hook in code, but I think just having the clients that 'care' wait will be good enough for now. The addition of the server waiting is a bad idea as it has a much larger effect on the system as a whole.

          Show
          Jesse Yates added a comment - Jimmy Xiang my patch is up there, if you want to run with it.. I'm a bit busy at the moment The client has also been given permission to grow to a multiplier of its writeBufferSize, similar to the memstoremultiplier, allowing it to buffer more writes. If a write is within the expansion range, we want to allow the client to accept more writes while waiting/backing-off, so we launch a flusher thread that after waiting the backoff time will flush the writes (singleton). This gives us back-off as well as some flexiblilty on the client as to how much we buffer. To disable the backoff behavior, its as simple as setting the multiplier to 1, so the expansion = max. -Jesse I don't this is really the right way to handle this, but instead just plug in the wait-object per region that ties in the most recent information. Also, from the above, using a MonitoredResult rather than throwing an exception ensures the same behavior on old and new clients. Its ugly, but as long as you put in a TODO, I'm okay with it. You might need to rewrite a bit of my patch - there are probably some good hints as to the right places to hook in code, but I think just having the clients that 'care' wait will be good enough for now. The addition of the server waiting is a bad idea as it has a much larger effect on the system as a whole.
          Hide
          Jesse Yates added a comment -

          My concern is that the retry is completely a waste - just accept the write and then slow it down later. Otherwise you are resending the data a lot more than necessary, which is going to put more network load (especially with large puts) than you need, possibly multiple times over.

          Show
          Jesse Yates added a comment - My concern is that the retry is completely a waste - just accept the write and then slow it down later. Otherwise you are resending the data a lot more than necessary, which is going to put more network load (especially with large puts) than you need, possibly multiple times over.
          stack made changes -
          Fix Version/s 0.95.0 [ 12324094 ]
          Fix Version/s 0.96.0 [ 12320040 ]
          Lars Hofhansl made changes -
          Fix Version/s 0.94.0 [ 12316419 ]
          Lars Hofhansl made changes -
          Fix Version/s 0.94.1 [ 12320257 ]
          Fix Version/s 0.94.0 [ 12316419 ]
          Lars Hofhansl made changes -
          Fix Version/s 0.94.1 [ 12320257 ]
          stack made changes -
          Fix Version/s 0.95.1 [ 12324288 ]
          Fix Version/s 0.95.0 [ 12324094 ]
          Hide
          stack added a comment -

          Important issue but won't be done for 0.95

          Show
          stack added a comment - Important issue but won't be done for 0.95
          stack made changes -
          Fix Version/s 0.95.1 [ 12324288 ]
          Hide
          Nicolas Liochon added a comment -

          Arriving from HBASE-11208, we could:

          • accept the write as mentioned by jesse
          • return a load status (something like a number between 0 and 100, maybe two figures for the region and the regionserver), the client can then use this to slowdown. The AsyncProcess would ease this.
          Show
          Nicolas Liochon added a comment - Arriving from HBASE-11208 , we could: accept the write as mentioned by jesse return a load status (something like a number between 0 and 100, maybe two figures for the region and the regionserver), the client can then use this to slowdown. The AsyncProcess would ease this.
          Jesse Yates made changes -
          Link This issue relates to HBASE-12217 [ HBASE-12217 ]
          Hide
          Jesse Yates added a comment -

          Attaching patch for basic pushback mechanism (disabled by default) on the client.

          Basically, when the client attempts to make a put, it checks its stats cache to see what the memstore load is for each region it is attempting to talk to. The load is then converted into a wait time (the slowdown part of the patch). If the wait time > 0, we use a special Runnable that sleeps for the specified amount of time before calling the usual runnable.

          When the region responds to the request it also tacks on the currently load for the region to successful results. Right now its just the memstore load, but could easily be expanded to include other statistics as well (I know Andrew Purtell wanted RS CPU for updating CPs). When the client gets that result back it unwraps the result's stats and updates its cache and then hands back the result to go back up the usual call stack.

          Currently it only supports updating calls to #multi but can be expanded to other operations on the HRegion pretty easily (plumbing is there for on the client side, just needs a couple hooks for the server).

          Show
          Jesse Yates added a comment - Attaching patch for basic pushback mechanism (disabled by default) on the client. Basically, when the client attempts to make a put, it checks its stats cache to see what the memstore load is for each region it is attempting to talk to. The load is then converted into a wait time (the slowdown part of the patch). If the wait time > 0, we use a special Runnable that sleeps for the specified amount of time before calling the usual runnable. When the region responds to the request it also tacks on the currently load for the region to successful results. Right now its just the memstore load, but could easily be expanded to include other statistics as well (I know Andrew Purtell wanted RS CPU for updating CPs). When the client gets that result back it unwraps the result's stats and updates its cache and then hands back the result to go back up the usual call stack. Currently it only supports updating calls to #multi but can be expanded to other operations on the HRegion pretty easily (plumbing is there for on the client side, just needs a couple hooks for the server).
          Jesse Yates made changes -
          Attachment hbase-5162-trunk-v0.patch [ 12678516 ]
          Hide
          Jesse Yates added a comment -
          Show
          Jesse Yates added a comment - Review request here: https://reviews.apache.org/r/27436/
          Jesse Yates made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Assignee Jesse Yates [ jesse_yates ]
          Fix Version/s 1.0.0 [ 12325852 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12678516/hbase-5162-trunk-v0.patch
          against trunk revision .
          ATTACHMENT ID: 12678516

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 7 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11572//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12678516/hbase-5162-trunk-v0.patch against trunk revision . ATTACHMENT ID: 12678516 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 7 new or modified tests. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11572//console This message is automatically generated.
          Jesse Yates made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          Jesse Yates added a comment -

          Updated patch on current master.

          Show
          Jesse Yates added a comment - Updated patch on current master.
          Jesse Yates made changes -
          Attachment hbase-5162-trunk-v1.patch [ 12679098 ]
          Jesse Yates made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12679098/hbase-5162-trunk-v1.patch
          against trunk revision .
          ATTACHMENT ID: 12679098

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 7 new or modified tests.

          -1 javac. The applied patch generated 103 javac compiler warnings (more than the trunk's current 102 warnings).

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 javadoc. The javadoc tool appears to have generated 2 warning messages.

          -1 checkstyle. The applied patch generated 3797 checkstyle errors (more than the trunk's current 3781 errors).

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          -1 release audit. The applied patch generated 7 release audit warnings (more than the trunk's current 0 warnings).

          -1 lineLengths. The patch introduces the following lines longer than 100:
          + return RpcRetryingCallerFactory.instantiate(conf, this.interceptor, this.getStatisticsTracker());
          + // even if we get interrupted here, but for now, we still need to run so we decrement the outstanding tasks
          + String className = conf.get(BACKOFF_POLICY_CLASS, ExponentialClientBackoffPolicy.class.getName());
          + new java.lang.String[]

          { "Index", "Result", "Exception", "ServiceResult", "LoadStats", }

          );

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.regionserver.TestRegionServerNoMaster
          org.apache.hadoop.hbase.master.TestSplitLogManager

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11573//testReport/
          Release audit warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11573//artifact/patchprocess/patchReleaseAuditWarnings.txt
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11573//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11573//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11573//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11573//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11573//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11573//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11573//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11573//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11573//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11573//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11573//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/11573//artifact/patchprocess/checkstyle-aggregate.html

          Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11573//artifact/patchprocess/patchJavadocWarnings.txt
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11573//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12679098/hbase-5162-trunk-v1.patch against trunk revision . ATTACHMENT ID: 12679098 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 7 new or modified tests. -1 javac . The applied patch generated 103 javac compiler warnings (more than the trunk's current 102 warnings). +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 2 warning messages. -1 checkstyle . The applied patch generated 3797 checkstyle errors (more than the trunk's current 3781 errors). +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. -1 release audit . The applied patch generated 7 release audit warnings (more than the trunk's current 0 warnings). -1 lineLengths . The patch introduces the following lines longer than 100: + return RpcRetryingCallerFactory.instantiate(conf, this.interceptor, this.getStatisticsTracker()); + // even if we get interrupted here, but for now, we still need to run so we decrement the outstanding tasks + String className = conf.get(BACKOFF_POLICY_CLASS, ExponentialClientBackoffPolicy.class.getName()); + new java.lang.String[] { "Index", "Result", "Exception", "ServiceResult", "LoadStats", } ); +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.TestRegionServerNoMaster org.apache.hadoop.hbase.master.TestSplitLogManager Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11573//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11573//artifact/patchprocess/patchReleaseAuditWarnings.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11573//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11573//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11573//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11573//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11573//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11573//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11573//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11573//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11573//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11573//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11573//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/11573//artifact/patchprocess/checkstyle-aggregate.html Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11573//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11573//console This message is automatically generated.
          Jesse Yates made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          Jesse Yates added a comment -

          Tests passed locally. Fixed the javadoc/findbugs/checkstyle warnings (I think - there's a lot to parse there :-/). Lets give it another spin.

          Show
          Jesse Yates added a comment - Tests passed locally. Fixed the javadoc/findbugs/checkstyle warnings (I think - there's a lot to parse there :-/). Lets give it another spin.
          Jesse Yates made changes -
          Attachment hbase-5162-trunk-v2.patch [ 12679302 ]
          Jesse Yates made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12679302/hbase-5162-trunk-v2.patch
          against trunk revision .
          ATTACHMENT ID: 12679302

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 7 new or modified tests.

          -1 javac. The applied patch generated 103 javac compiler warnings (more than the trunk's current 102 warnings).

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

          -1 checkstyle. The applied patch generated 3791 checkstyle errors (more than the trunk's current 3782 errors).

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 lineLengths. The patch introduces the following lines longer than 100:
          + return RpcRetryingCallerFactory.instantiate(conf, this.interceptor, this.getStatisticsTracker());
          + String className = conf.get(BACKOFF_POLICY_CLASS, ExponentialClientBackoffPolicy.class.getName());
          + new java.lang.String[]

          { "Index", "Result", "Exception", "ServiceResult", "LoadStats", }

          );

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFilesSplitRecovery

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11583//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11583//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11583//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11583//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11583//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11583//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11583//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11583//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11583//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11583//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11583//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11583//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/11583//artifact/patchprocess/checkstyle-aggregate.html

          Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11583//artifact/patchprocess/patchJavadocWarnings.txt
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11583//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12679302/hbase-5162-trunk-v2.patch against trunk revision . ATTACHMENT ID: 12679302 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 7 new or modified tests. -1 javac . The applied patch generated 103 javac compiler warnings (more than the trunk's current 102 warnings). +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 1 warning messages. -1 checkstyle . The applied patch generated 3791 checkstyle errors (more than the trunk's current 3782 errors). +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces the following lines longer than 100: + return RpcRetryingCallerFactory.instantiate(conf, this.interceptor, this.getStatisticsTracker()); + String className = conf.get(BACKOFF_POLICY_CLASS, ExponentialClientBackoffPolicy.class.getName()); + new java.lang.String[] { "Index", "Result", "Exception", "ServiceResult", "LoadStats", } ); +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFilesSplitRecovery Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11583//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11583//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11583//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11583//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11583//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11583//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11583//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11583//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11583//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11583//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11583//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11583//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/11583//artifact/patchprocess/checkstyle-aggregate.html Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11583//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11583//console This message is automatically generated.
          Jesse Yates made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          Jesse Yates added a comment -

          Lets go around again. Pretty pretty sure this should be happy on nits.

          Show
          Jesse Yates added a comment - Lets go around again. Pretty pretty sure this should be happy on nits.
          Jesse Yates made changes -
          Attachment hbase-5162-trunk-v3.patch [ 12679371 ]
          Jesse Yates made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Jesse Yates made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          Jesse Yates added a comment -

          Attaching a slightly cleaned up version (double checked the checkstyle issues - error count matches master, on my box). Hopefully QA picks this up.

          Show
          Jesse Yates added a comment - Attaching a slightly cleaned up version (double checked the checkstyle issues - error count matches master, on my box). Hopefully QA picks this up.
          Jesse Yates made changes -
          Attachment hbase-5162-trunk-v4.patch [ 12679628 ]
          Jesse Yates made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12679628/hbase-5162-trunk-v4.patch
          against trunk revision .
          ATTACHMENT ID: 12679628

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 7 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 checkstyle. The applied patch does not increase the total number of checkstyle errors

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 lineLengths. The patch introduces the following lines longer than 100:
          + return RpcRetryingCallerFactory.instantiate(conf, this.interceptor, this.getStatisticsTracker());
          + new java.lang.String[]

          { "Index", "Result", "Exception", "ServiceResult", "LoadStats", }

          );

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11596//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11596//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11596//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11596//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11596//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11596//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11596//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11596//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11596//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11596//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11596//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11596//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/11596//artifact/patchprocess/checkstyle-aggregate.html

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11596//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12679628/hbase-5162-trunk-v4.patch against trunk revision . ATTACHMENT ID: 12679628 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 7 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 checkstyle . The applied patch does not increase the total number of checkstyle errors +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces the following lines longer than 100: + return RpcRetryingCallerFactory.instantiate(conf, this.interceptor, this.getStatisticsTracker()); + new java.lang.String[] { "Index", "Result", "Exception", "ServiceResult", "LoadStats", } ); +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11596//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11596//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11596//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11596//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11596//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11596//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11596//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11596//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11596//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11596//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11596//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11596//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/11596//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11596//console This message is automatically generated.
          Hide
          Jesse Yates added a comment -

          Ok, thats good enough for a review. Updated diff: https://reviews.apache.org/r/27436/. Maybe if you have some time Andrew Purtell or Lars Hofhansl?

          Show
          Jesse Yates added a comment - Ok, thats good enough for a review. Updated diff: https://reviews.apache.org/r/27436/ . Maybe if you have some time Andrew Purtell or Lars Hofhansl ?
          Hide
          Jesse Yates added a comment -

          Updating diff to address reviewer's excellent comments (thanks Andrew Purtell!).

          Show
          Jesse Yates added a comment - Updating diff to address reviewer's excellent comments (thanks Andrew Purtell !).
          Jesse Yates made changes -
          Attachment hbase-5162-trunk-v5.patch [ 12680022 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12680022/hbase-5162-trunk-v5.patch
          against trunk revision .
          ATTACHMENT ID: 12680022

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 7 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          -1 checkstyle. The applied patch generated 3792 checkstyle errors (more than the trunk's current 3782 errors).

          -1 findbugs. The patch appears to introduce 2 new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 lineLengths. The patch introduces the following lines longer than 100:
          + return RpcRetryingCallerFactory.instantiate(conf, this.interceptor, this.getStatisticsTracker());
          + new java.lang.String[]

          { "Index", "Result", "Exception", "ServiceResult", "LoadStats", }

          );

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.client.TestClientNoCluster
          org.apache.hadoop.hbase.client.TestAsyncProcess

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11610//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11610//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11610//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11610//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11610//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11610//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11610//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11610//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11610//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11610//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11610//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11610//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/11610//artifact/patchprocess/checkstyle-aggregate.html

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11610//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12680022/hbase-5162-trunk-v5.patch against trunk revision . ATTACHMENT ID: 12680022 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 7 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. -1 checkstyle . The applied patch generated 3792 checkstyle errors (more than the trunk's current 3782 errors). -1 findbugs . The patch appears to introduce 2 new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces the following lines longer than 100: + return RpcRetryingCallerFactory.instantiate(conf, this.interceptor, this.getStatisticsTracker()); + new java.lang.String[] { "Index", "Result", "Exception", "ServiceResult", "LoadStats", } ); +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.client.TestClientNoCluster org.apache.hadoop.hbase.client.TestAsyncProcess Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11610//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11610//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11610//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11610//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11610//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11610//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11610//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11610//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11610//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11610//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11610//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11610//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/11610//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11610//console This message is automatically generated.
          Jesse Yates made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          Jesse Yates added a comment -

          Updated patch on latest master (we were getting behind a little bit) and hopefully fixing the checkstyle and findbugs issues.

          Show
          Jesse Yates added a comment - Updated patch on latest master (we were getting behind a little bit) and hopefully fixing the checkstyle and findbugs issues.
          Jesse Yates made changes -
          Attachment hbase-5162-trunk-v6.patch [ 12680247 ]
          Jesse Yates made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12680247/hbase-5162-trunk-v6.patch
          against trunk revision .
          ATTACHMENT ID: 12680247

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 7 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 checkstyle. The applied patch does not increase the total number of checkstyle errors

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:

          -1 core zombie tests. There are 1 zombie test(s): at org.apache.hadoop.hbase.http.TestHttpServerLifecycle.testStartedServerIsAlive(TestHttpServerLifecycle.java:71)

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11615//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11615//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11615//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11615//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11615//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11615//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11615//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11615//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11615//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11615//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11615//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11615//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/11615//artifact/patchprocess/checkstyle-aggregate.html

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11615//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12680247/hbase-5162-trunk-v6.patch against trunk revision . ATTACHMENT ID: 12680247 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 7 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 checkstyle . The applied patch does not increase the total number of checkstyle errors +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: -1 core zombie tests . There are 1 zombie test(s): at org.apache.hadoop.hbase.http.TestHttpServerLifecycle.testStartedServerIsAlive(TestHttpServerLifecycle.java:71) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11615//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11615//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11615//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11615//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11615//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11615//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11615//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11615//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11615//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11615//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11615//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11615//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/11615//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11615//console This message is automatically generated.
          Jesse Yates made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          Jesse Yates added a comment -

          Updated patch with changes from Andrew's review.

          Show
          Jesse Yates added a comment - Updated patch with changes from Andrew's review.
          Jesse Yates made changes -
          Attachment hbase-5162-trunk-v7.patch [ 12681946 ]
          Jesse Yates made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12681946/hbase-5162-trunk-v7.patch
          against trunk revision .
          ATTACHMENT ID: 12681946

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 7 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11711//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12681946/hbase-5162-trunk-v7.patch against trunk revision . ATTACHMENT ID: 12681946 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 7 new or modified tests. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11711//console This message is automatically generated.
          Hide
          Jesse Yates added a comment -

          Latest changes to the RpcRetryingCaller are making me think that it might be cleaner to pull that into an interface and then let the factory decide what to do with it. That makes the StatsTrackingRpcRetryingCaller cleaner in that it just calls delegate methods and doesn't care about the underlying implementation.

          Show
          Jesse Yates added a comment - Latest changes to the RpcRetryingCaller are making me think that it might be cleaner to pull that into an interface and then let the factory decide what to do with it. That makes the StatsTrackingRpcRetryingCaller cleaner in that it just calls delegate methods and doesn't care about the underlying implementation.
          Jesse Yates made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          Jesse Yates added a comment -

          Same basic idea as last patch, but StatsTrackingRpcRetryingCaller just uses a simple delegate pattern and RpcRetryingCaller is now an interface implemented by RpcRetryingCallerImpl (to which the stats just delegates).

          Show
          Jesse Yates added a comment - Same basic idea as last patch, but StatsTrackingRpcRetryingCaller just uses a simple delegate pattern and RpcRetryingCaller is now an interface implemented by RpcRetryingCallerImpl (to which the stats just delegates).
          Jesse Yates made changes -
          Attachment hbase-5162-trunk-v8.patch [ 12681962 ]
          Jesse Yates made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12681962/hbase-5162-trunk-v8.patch
          against trunk revision .
          ATTACHMENT ID: 12681962

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 7 new or modified tests.

          -1 javac. The patch appears to cause mvn compile goal to fail.

          Compilation errors resume:
          [ERROR] COMPILATION ERROR :
          [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java:[211,59] no interface expected here
          [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestFastFailWithoutTestUtil.java:[567,40] anonymous class implements interface; cannot have arguments
          [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestFastFailWithoutTestUtil.java:[567,76] <anonymous org.apache.hadoop.hbase.client.TestFastFailWithoutTestUtil$8> is not abstract and does not override abstract method callWithoutRetries(org.apache.hadoop.hbase.client.RetryingCallable<java.lang.Void>,int) in org.apache.hadoop.hbase.client.RpcRetryingCaller
          [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestFastFailWithoutTestUtil.java:[571,25] cannot find symbol
          [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java:[193,51] anonymous class implements interface; cannot have arguments
          [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java:[193,63] <anonymous org.apache.hadoop.hbase.client.TestAsyncProcess$MyAsyncProcess$3> is not abstract and does not override abstract method callWithRetries(org.apache.hadoop.hbase.client.RetryingCallable<org.apache.hadoop.hbase.client.MultiResponse>,int) in org.apache.hadoop.hbase.client.RpcRetryingCaller
          [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java:[217,5] method does not override or implement a method from a supertype
          [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java:[234,14] incompatible types
          [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java:[297,51] anonymous class implements interface; cannot have arguments
          [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java:[297,63] <anonymous org.apache.hadoop.hbase.client.TestAsyncProcess$MyAsyncProcessWithReplicas$2> is not abstract and does not override abstract method callWithRetries(org.apache.hadoop.hbase.client.RetryingCallable<org.apache.hadoop.hbase.client.MultiResponse>,int) in org.apache.hadoop.hbase.client.RpcRetryingCaller
          [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.2:testCompile (default-testCompile) on project hbase-client: Compilation failure: Compilation failure:
          [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java:[211,59] no interface expected here
          [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestFastFailWithoutTestUtil.java:[567,40] anonymous class implements interface; cannot have arguments
          [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestFastFailWithoutTestUtil.java:[567,76] <anonymous org.apache.hadoop.hbase.client.TestFastFailWithoutTestUtil$8> is not abstract and does not override abstract method callWithoutRetries(org.apache.hadoop.hbase.client.RetryingCallable<java.lang.Void>,int) in org.apache.hadoop.hbase.client.RpcRetryingCaller
          [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestFastFailWithoutTestUtil.java:[571,25] cannot find symbol
          [ERROR] symbol: method callWithRetries(org.apache.hadoop.hbase.client.RetryingCallable<java.lang.Void>,int)
          [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java:[193,51] anonymous class implements interface; cannot have arguments
          [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java:[193,63] <anonymous org.apache.hadoop.hbase.client.TestAsyncProcess$MyAsyncProcess$3> is not abstract and does not override abstract method callWithRetries(org.apache.hadoop.hbase.client.RetryingCallable<org.apache.hadoop.hbase.client.MultiResponse>,int) in org.apache.hadoop.hbase.client.RpcRetryingCaller
          [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java:[217,5] method does not override or implement a method from a supertype
          [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java:[234,14] incompatible types
          [ERROR] required: org.apache.hadoop.hbase.client.RpcRetryingCaller<org.apache.hadoop.hbase.client.MultiResponse>
          [ERROR] found: org.apache.hadoop.hbase.client.TestAsyncProcess.CallerWithFailure
          [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java:[297,51] anonymous class implements interface; cannot have arguments
          [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java:[297,63] <anonymous org.apache.hadoop.hbase.client.TestAsyncProcess$MyAsyncProcessWithReplicas$2> is not abstract and does not override abstract method callWithRetries(org.apache.hadoop.hbase.client.RetryingCallable<org.apache.hadoop.hbase.client.MultiResponse>,int) in org.apache.hadoop.hbase.client.RpcRetryingCaller
          [ERROR] -> [Help 1]
          [ERROR]
          [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
          [ERROR] Re-run Maven using the -X switch to enable full debug logging.
          [ERROR]
          [ERROR] For more information about the errors and possible solutions, please read the following articles:
          [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
          [ERROR]
          [ERROR] After correcting the problems, you can resume the build with the command
          [ERROR] mvn <goals> -rf :hbase-client

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11714//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12681962/hbase-5162-trunk-v8.patch against trunk revision . ATTACHMENT ID: 12681962 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 7 new or modified tests. -1 javac . The patch appears to cause mvn compile goal to fail. Compilation errors resume: [ERROR] COMPILATION ERROR : [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java: [211,59] no interface expected here [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestFastFailWithoutTestUtil.java: [567,40] anonymous class implements interface; cannot have arguments [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestFastFailWithoutTestUtil.java: [567,76] <anonymous org.apache.hadoop.hbase.client.TestFastFailWithoutTestUtil$8> is not abstract and does not override abstract method callWithoutRetries(org.apache.hadoop.hbase.client.RetryingCallable<java.lang.Void>,int) in org.apache.hadoop.hbase.client.RpcRetryingCaller [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestFastFailWithoutTestUtil.java: [571,25] cannot find symbol [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java: [193,51] anonymous class implements interface; cannot have arguments [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java: [193,63] <anonymous org.apache.hadoop.hbase.client.TestAsyncProcess$MyAsyncProcess$3> is not abstract and does not override abstract method callWithRetries(org.apache.hadoop.hbase.client.RetryingCallable<org.apache.hadoop.hbase.client.MultiResponse>,int) in org.apache.hadoop.hbase.client.RpcRetryingCaller [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java: [217,5] method does not override or implement a method from a supertype [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java: [234,14] incompatible types [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java: [297,51] anonymous class implements interface; cannot have arguments [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java: [297,63] <anonymous org.apache.hadoop.hbase.client.TestAsyncProcess$MyAsyncProcessWithReplicas$2> is not abstract and does not override abstract method callWithRetries(org.apache.hadoop.hbase.client.RetryingCallable<org.apache.hadoop.hbase.client.MultiResponse>,int) in org.apache.hadoop.hbase.client.RpcRetryingCaller [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.2:testCompile (default-testCompile) on project hbase-client: Compilation failure: Compilation failure: [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java: [211,59] no interface expected here [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestFastFailWithoutTestUtil.java: [567,40] anonymous class implements interface; cannot have arguments [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestFastFailWithoutTestUtil.java: [567,76] <anonymous org.apache.hadoop.hbase.client.TestFastFailWithoutTestUtil$8> is not abstract and does not override abstract method callWithoutRetries(org.apache.hadoop.hbase.client.RetryingCallable<java.lang.Void>,int) in org.apache.hadoop.hbase.client.RpcRetryingCaller [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestFastFailWithoutTestUtil.java: [571,25] cannot find symbol [ERROR] symbol: method callWithRetries(org.apache.hadoop.hbase.client.RetryingCallable<java.lang.Void>,int) [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java: [193,51] anonymous class implements interface; cannot have arguments [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java: [193,63] <anonymous org.apache.hadoop.hbase.client.TestAsyncProcess$MyAsyncProcess$3> is not abstract and does not override abstract method callWithRetries(org.apache.hadoop.hbase.client.RetryingCallable<org.apache.hadoop.hbase.client.MultiResponse>,int) in org.apache.hadoop.hbase.client.RpcRetryingCaller [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java: [217,5] method does not override or implement a method from a supertype [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java: [234,14] incompatible types [ERROR] required: org.apache.hadoop.hbase.client.RpcRetryingCaller<org.apache.hadoop.hbase.client.MultiResponse> [ERROR] found: org.apache.hadoop.hbase.client.TestAsyncProcess.CallerWithFailure [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java: [297,51] anonymous class implements interface; cannot have arguments [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java: [297,63] <anonymous org.apache.hadoop.hbase.client.TestAsyncProcess$MyAsyncProcessWithReplicas$2> is not abstract and does not override abstract method callWithRetries(org.apache.hadoop.hbase.client.RetryingCallable<org.apache.hadoop.hbase.client.MultiResponse>,int) in org.apache.hadoop.hbase.client.RpcRetryingCaller [ERROR] -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException [ERROR] [ERROR] After correcting the problems, you can resume the build with the command [ERROR] mvn <goals> -rf :hbase-client Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11714//console This message is automatically generated.
          Hide
          Andrew Purtell added a comment -

          Would you like me to clean up this patch Jesse Yates? I don't have more review comments, we should get a good QA run and consider commit.

          Show
          Andrew Purtell added a comment - Would you like me to clean up this patch Jesse Yates ? I don't have more review comments, we should get a good QA run and consider commit.
          Hide
          Jesse Yates added a comment -

          Got a bit distracted. I'll have something up tonight or early tomorrow.

          Show
          Jesse Yates added a comment - Got a bit distracted. I'll have something up tonight or early tomorrow.
          Jesse Yates made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          Jesse Yates added a comment -

          Updating patch as per Andy's comments and rebased on current master

          Show
          Jesse Yates added a comment - Updating patch as per Andy's comments and rebased on current master
          Jesse Yates made changes -
          Attachment hbase-5162-trunk-v10.patch [ 12686931 ]
          Jesse Yates made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12686931/hbase-5162-trunk-v10.patch
          against master branch at commit 3275b964c1c1fbb20ffe646b37317496b265660b.
          ATTACHMENT ID: 12686931

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 19 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 checkstyle. The applied patch does not increase the total number of checkstyle errors

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.TestInterfaceAudienceAnnotations

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12058//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12058//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12058//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12058//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12058//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12058//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12058//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12058//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12058//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12058//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12058//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12058//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12058//artifact/patchprocess/checkstyle-aggregate.html

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12058//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12686931/hbase-5162-trunk-v10.patch against master branch at commit 3275b964c1c1fbb20ffe646b37317496b265660b. ATTACHMENT ID: 12686931 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 19 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 checkstyle . The applied patch does not increase the total number of checkstyle errors +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.TestInterfaceAudienceAnnotations Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12058//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12058//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12058//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12058//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12058//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12058//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12058//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12058//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12058//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12058//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12058//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12058//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12058//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12058//console This message is automatically generated.
          Hide
          Andrew Purtell added a comment -

          TestInterfaceAudienceAnnotations

          Looks like minor issues with annotation and coverage checking needs attention, then I'm +1 for this change.

          Show
          Andrew Purtell added a comment - TestInterfaceAudienceAnnotations Looks like minor issues with annotation and coverage checking needs attention, then I'm +1 for this change.
          Andrew Purtell made changes -
          Fix Version/s 2.0.0 [ 12327188 ]
          Hide
          Jesse Yates added a comment -

          I'm just running it through the test suite locally now to make sure I didn't do any more silly stuff.

          Show
          Jesse Yates added a comment - I'm just running it through the test suite locally now to make sure I didn't do any more silly stuff.
          Jesse Yates made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          Jesse Yates added a comment -

          Updating to fix annotations.

          Show
          Jesse Yates added a comment - Updating to fix annotations.
          Jesse Yates made changes -
          Attachment hbase-5162-trunk-v11.patch [ 12686957 ]
          Jesse Yates made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12686957/hbase-5162-trunk-v11.patch
          against master branch at commit a0e473730e2cd819e7442dbd2b332d7833755ba2.
          ATTACHMENT ID: 12686957

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 19 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          -1 checkstyle. The applied patch generated 2090 checkstyle errors (more than the master's current 2089 errors).

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12059//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12059//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12059//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12059//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12059//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12059//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12059//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12059//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12059//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12059//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12059//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12059//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12059//artifact/patchprocess/checkstyle-aggregate.html

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12059//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12686957/hbase-5162-trunk-v11.patch against master branch at commit a0e473730e2cd819e7442dbd2b332d7833755ba2. ATTACHMENT ID: 12686957 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 19 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. -1 checkstyle . The applied patch generated 2090 checkstyle errors (more than the master's current 2089 errors). +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12059//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12059//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12059//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12059//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12059//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12059//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12059//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12059//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12059//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12059//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12059//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12059//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12059//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12059//console This message is automatically generated.
          Hide
          Jesse Yates added a comment -

          Think I'm just going to commit this then(and fix the the checkstyle on commit), unless there are any objections.

          Show
          Jesse Yates added a comment - Think I'm just going to commit this then(and fix the the checkstyle on commit), unless there are any objections.
          Hide
          Jesse Yates added a comment -

          Attaching patch for actual code committed to trunk.

          Thanks for the copious reviews Andrew Purtell and hanging in there.

          Show
          Jesse Yates added a comment - Attaching patch for actual code committed to trunk. Thanks for the copious reviews Andrew Purtell and hanging in there.
          Jesse Yates made changes -
          Attachment hbase-5162-trunk-v12-committed.patch [ 12687543 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12687543/hbase-5162-trunk-v12-committed.patch
          against master branch at commit a411227b0ebf78b4ee8ae7179e162b54734e77de.
          ATTACHMENT ID: 12687543

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 19 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12100//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12687543/hbase-5162-trunk-v12-committed.patch against master branch at commit a411227b0ebf78b4ee8ae7179e162b54734e77de. ATTACHMENT ID: 12687543 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 19 new or modified tests. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12100//console This message is automatically generated.
          Jesse Yates made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          Jesse Yates added a comment -

          Attaching patch for branch-1, Enis Soztutar - thoughts on getting this in?

          Also, Andrew Purtell, would you like a patch for 0.98 as well? I think it should be pretty close to 1.0/2.0 version.

          Show
          Jesse Yates added a comment - Attaching patch for branch-1, Enis Soztutar - thoughts on getting this in? Also, Andrew Purtell , would you like a patch for 0.98 as well? I think it should be pretty close to 1.0/2.0 version.
          Jesse Yates made changes -
          Attachment hbase-5162-branch-1-v0.patch [ 12687546 ]
          Hide
          Andrew Purtell added a comment -

          I have a feeling Enis Soztutar won't take this at this late time for 1.0. What if we open a branch (soon) for 1.1.

          I think we can look at this for 0.98 if we don't break non-private interfaces and we can get it back into 0.98 from master via any 1.x.

          Show
          Andrew Purtell added a comment - I have a feeling Enis Soztutar won't take this at this late time for 1.0. What if we open a branch (soon) for 1.1. I think we can look at this for 0.98 if we don't break non-private interfaces and we can get it back into 0.98 from master via any 1.x.
          Hide
          Hudson added a comment -

          FAILURE: Integrated in HBase-TRUNK #5930 (See https://builds.apache.org/job/HBase-TRUNK/5930/)
          HBASE-5162 Basic client pushback mechanism (jyates: rev a411227b0ebf78b4ee8ae7179e162b54734e77de)

          • hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientExponentialBackoff.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/DelayingRunner.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALEditsReplaySink.java
          • hbase-protocol/src/main/protobuf/Client.proto
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerFactory.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/MultiAction.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/backoff/ExponentialClientBackoffPolicy.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ResponseConverter.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCaller.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/backoff/ClientBackoffPolicyFactory.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/StatsTrackingRpcRetryingCaller.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/Result.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/backoff/ClientBackoffPolicy.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerImpl.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/ServerStatisticTracker.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClusterConnection.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientPushback.java
          • hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestRegionReplicaReplicationEndpoint.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/ResultStatsUtil.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
          • hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestFastFailWithoutTestUtil.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestReplicasClient.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionAdapter.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/backoff/ServerStatistics.java
          • hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RegionCoprocessorRpcChannel.java
          Show
          Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #5930 (See https://builds.apache.org/job/HBase-TRUNK/5930/ ) HBASE-5162 Basic client pushback mechanism (jyates: rev a411227b0ebf78b4ee8ae7179e162b54734e77de) hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientExponentialBackoff.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/DelayingRunner.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALEditsReplaySink.java hbase-protocol/src/main/protobuf/Client.proto hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerFactory.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/MultiAction.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/backoff/ExponentialClientBackoffPolicy.java hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ResponseConverter.java hbase-server/src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCaller.java hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/backoff/ClientBackoffPolicyFactory.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/StatsTrackingRpcRetryingCaller.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/Result.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/backoff/ClientBackoffPolicy.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerImpl.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/ServerStatisticTracker.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClusterConnection.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientPushback.java hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestRegionReplicaReplicationEndpoint.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/ResultStatsUtil.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestFastFailWithoutTestUtil.java hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestReplicasClient.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionAdapter.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/backoff/ServerStatistics.java hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RegionCoprocessorRpcChannel.java
          Hide
          Jesse Yates added a comment -

          Hmmm, well that's an issue. Looking into the NPE now.

          Show
          Jesse Yates added a comment - Hmmm, well that's an issue. Looking into the NPE now.
          Hide
          Andrew Purtell added a comment -

          Thanks. If it's a minor fix please commit an addendum. If it's more involved, we can revert and commit again later.

          Show
          Andrew Purtell added a comment - Thanks. If it's a minor fix please commit an addendum. If it's more involved, we can revert and commit again later.
          Hide
          Nick Dimiduk added a comment -

          What if we open a branch (soon) for 1.1.

          Why wait for 1.1, any reason this couldn't go into 1.0.1? I mean, if it's okay for 0.98.x, why not 1.0.x?

          Show
          Nick Dimiduk added a comment - What if we open a branch (soon) for 1.1. Why wait for 1.1, any reason this couldn't go into 1.0.1? I mean, if it's okay for 0.98.x, why not 1.0.x?
          Hide
          Andrew Purtell added a comment -

          Either option sounds good IMHO

          Show
          Andrew Purtell added a comment - Either option sounds good IMHO
          Hide
          Jesse Yates added a comment -

          Attaching addedum for trunk.

          A couple lines of actual fix, push a little clean that made it easier to understand while I was debugging (so necessary if anyone else looks at it later).

          Show
          Jesse Yates added a comment - Attaching addedum for trunk. A couple lines of actual fix, push a little clean that made it easier to understand while I was debugging (so necessary if anyone else looks at it later).
          Jesse Yates made changes -
          Attachment hbase-5162-trunk-addendum.patch [ 12687610 ]
          Jesse Yates made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12687610/hbase-5162-trunk-addendum.patch
          against master branch at commit 9e7f7211b95ef4e9c64f5e54411c7c9fa7eeb235.
          ATTACHMENT ID: 12687610

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 checkstyle. The applied patch does not increase the total number of checkstyle errors

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12101//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12101//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12101//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12101//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12101//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12101//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12101//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12101//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12101//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12101//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12101//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12101//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12101//artifact/patchprocess/checkstyle-aggregate.html

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12101//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12687610/hbase-5162-trunk-addendum.patch against master branch at commit 9e7f7211b95ef4e9c64f5e54411c7c9fa7eeb235. ATTACHMENT ID: 12687610 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 checkstyle . The applied patch does not increase the total number of checkstyle errors +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12101//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12101//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12101//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12101//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12101//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12101//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12101//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12101//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12101//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12101//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12101//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12101//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12101//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12101//console This message is automatically generated.
          Hide
          Ted Yu added a comment -

          +1

          Show
          Ted Yu added a comment - +1
          Hide
          stack added a comment -

          The test this patch adds has been failing. You lot on it (i'm sure you are!)

          Show
          stack added a comment - The test this patch adds has been failing. You lot on it (i'm sure you are!)
          Hide
          Andrew Purtell added a comment -

          Let's commit the addendum

          Show
          Andrew Purtell added a comment - Let's commit the addendum
          Hide
          Jesse Yates added a comment -

          Was just waiting on a +1 from someone else. Im away from my computer till late tonight, but can do it tomorrow am, unless someone wants to grab it first

          Show
          Jesse Yates added a comment - Was just waiting on a +1 from someone else. Im away from my computer till late tonight, but can do it tomorrow am, unless someone wants to grab it first
          Hide
          stack added a comment -

          I can do it. No worries Jesse Yates

          Show
          stack added a comment - I can do it. No worries Jesse Yates
          Hide
          stack added a comment -

          Jesse Yates Done sir. BTW, thanks for working on this oldie.

          Show
          stack added a comment - Jesse Yates Done sir. BTW, thanks for working on this oldie.
          Hide
          Lars Hofhansl added a comment -

          Looks like this break the compile now...?

          [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.2:compile (default-compile) on project hbase-client: Compilation failure: Compilation failure:
          [ERROR] /home/lars/dev/hbase-master/hbase-client/src/main/java/org/apache/hadoop/hbase/security/token/TokenUtil.java:[44,32] package org.apache.hadoop.mapred does not exist
          [ERROR] /home/lars/dev/hbase-master/hbase-client/src/main/java/org/apache/hadoop/hbase/security/token/TokenUtil.java:[45,35] package org.apache.hadoop.mapreduce does not exist
          [ERROR] /home/lars/dev/hbase-master/hbase-client/src/main/java/org/apache/hadoop/hbase/security/token/TokenUtil.java:[191,67] cannot find symbol
          [ERROR] symbol:   class Job
          [ERROR] location: class org.apache.hadoop.hbase.security.token.TokenUtil
          [ERROR] /home/lars/dev/hbase-master/hbase-client/src/main/java/org/apache/hadoop/hbase/security/token/TokenUtil.java:[212,18] cannot find symbol
          [ERROR] symbol:   class Job
          [ERROR] location: class org.apache.hadoop.hbase.security.token.TokenUtil
          [ERROR] /home/lars/dev/hbase-master/hbase-client/src/main/java/org/apache/hadoop/hbase/security/token/TokenUtil.java:[248,46] cannot find symbol
          [ERROR] symbol:   class JobConf
          [ERROR] location: class org.apache.hadoop.hbase.security.token.TokenUtil
          [ERROR] /home/lars/dev/hbase-master/hbase-client/src/main/java/org/apache/hadoop/hbase/security/token/TokenUtil.java:[269,69] cannot find symbol
          [ERROR] symbol:   class JobConf
          [ERROR] location: class org.apache.hadoop.hbase.security.token.TokenUtil
          [ERROR] /home/lars/dev/hbase-master/hbase-client/src/main/java/org/apache/hadoop/hbase/security/token/TokenUtil.java:[305,66] cannot find symbol
          [ERROR] symbol:   class JobConf
          [ERROR] location: class org.apache.hadoop.hbase.security.token.TokenUtil
          [ERROR] /home/lars/dev/hbase-master/hbase-client/src/main/java/org/apache/hadoop/hbase/security/token/TokenUtil.java:[325,71] cannot find symbol
          [ERROR] symbol:   class Job
          [ERROR] location: class org.apache.hadoop.hbase.security.token.TokenUtil
          
          Show
          Lars Hofhansl added a comment - Looks like this break the compile now...? [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.2:compile (default-compile) on project hbase-client: Compilation failure: Compilation failure: [ERROR] /home/lars/dev/hbase-master/hbase-client/src/main/java/org/apache/hadoop/hbase/security/token/TokenUtil.java:[44,32] package org.apache.hadoop.mapred does not exist [ERROR] /home/lars/dev/hbase-master/hbase-client/src/main/java/org/apache/hadoop/hbase/security/token/TokenUtil.java:[45,35] package org.apache.hadoop.mapreduce does not exist [ERROR] /home/lars/dev/hbase-master/hbase-client/src/main/java/org/apache/hadoop/hbase/security/token/TokenUtil.java:[191,67] cannot find symbol [ERROR] symbol: class Job [ERROR] location: class org.apache.hadoop.hbase.security.token.TokenUtil [ERROR] /home/lars/dev/hbase-master/hbase-client/src/main/java/org/apache/hadoop/hbase/security/token/TokenUtil.java:[212,18] cannot find symbol [ERROR] symbol: class Job [ERROR] location: class org.apache.hadoop.hbase.security.token.TokenUtil [ERROR] /home/lars/dev/hbase-master/hbase-client/src/main/java/org/apache/hadoop/hbase/security/token/TokenUtil.java:[248,46] cannot find symbol [ERROR] symbol: class JobConf [ERROR] location: class org.apache.hadoop.hbase.security.token.TokenUtil [ERROR] /home/lars/dev/hbase-master/hbase-client/src/main/java/org/apache/hadoop/hbase/security/token/TokenUtil.java:[269,69] cannot find symbol [ERROR] symbol: class JobConf [ERROR] location: class org.apache.hadoop.hbase.security.token.TokenUtil [ERROR] /home/lars/dev/hbase-master/hbase-client/src/main/java/org/apache/hadoop/hbase/security/token/TokenUtil.java:[305,66] cannot find symbol [ERROR] symbol: class JobConf [ERROR] location: class org.apache.hadoop.hbase.security.token.TokenUtil [ERROR] /home/lars/dev/hbase-master/hbase-client/src/main/java/org/apache/hadoop/hbase/security/token/TokenUtil.java:[325,71] cannot find symbol [ERROR] symbol: class Job [ERROR] location: class org.apache.hadoop.hbase.security.token.TokenUtil
          Hide
          Hudson added a comment -

          FAILURE: Integrated in HBase-TRUNK #5936 (See https://builds.apache.org/job/HBase-TRUNK/5936/)
          HBASE-5162 Basic client pushback mechanism (Jesse Yates); ADDENDUM (stack: rev f7154e1ac9e6c0bd2dd3c39078a52d49d3485504)

          • hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientPushback.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/StatsTrackingRpcRetryingCaller.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerFactory.java
          • hbase-client/pom.xml
          Show
          Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #5936 (See https://builds.apache.org/job/HBase-TRUNK/5936/ ) HBASE-5162 Basic client pushback mechanism (Jesse Yates); ADDENDUM (stack: rev f7154e1ac9e6c0bd2dd3c39078a52d49d3485504) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientPushback.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/StatsTrackingRpcRetryingCaller.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerFactory.java hbase-client/pom.xml
          Hide
          Andrew Purtell added a comment -

          The precommit with addendum passed here so what was committed ?

          Show
          Andrew Purtell added a comment - The precommit with addendum passed here so what was committed ?
          Hide
          Andrew Purtell added a comment -

          POM changes were committed that were not part of the addendum patch. I will fix that now.

          Show
          Andrew Purtell added a comment - POM changes were committed that were not part of the addendum patch. I will fix that now.
          Hide
          Andrew Purtell added a comment -

          I reverted the previous addendum as 6a042c3 and reapplied hbase-5162-trunk-addendum.patch as 99a1139. The build is clean here and TestClientPushback is passing (5 out of 5 trials).

          Show
          Andrew Purtell added a comment - I reverted the previous addendum as 6a042c3 and reapplied hbase-5162-trunk-addendum.patch as 99a1139. The build is clean here and TestClientPushback is passing (5 out of 5 trials).
          Hide
          Dima Spivak added a comment -

          Well done, Andy. With your latest push, TestClientPushback passes for me.

          Show
          Dima Spivak added a comment - Well done, Andy. With your latest push, TestClientPushback passes for me.
          Hide
          Hudson added a comment -

          FAILURE: Integrated in HBase-TRUNK #5937 (See https://builds.apache.org/job/HBase-TRUNK/5937/)
          Revert "HBASE-5162 Basic client pushback mechanism (Jesse Yates); ADDENDUM" (apurtell: rev 6a042c381a04ccd4b82bc51720af7a043e144445)

          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerFactory.java
          • hbase-client/pom.xml
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/StatsTrackingRpcRetryingCaller.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientPushback.java
            Amend HBASE-5162 Basic client pushback mechanism (Jesse Yates) (apurtell: rev 99a11390b4758c211af04af2ca0696ac6e3e0aeb)
          • hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientPushback.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/StatsTrackingRpcRetryingCaller.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerFactory.java
          Show
          Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #5937 (See https://builds.apache.org/job/HBase-TRUNK/5937/ ) Revert " HBASE-5162 Basic client pushback mechanism (Jesse Yates); ADDENDUM" (apurtell: rev 6a042c381a04ccd4b82bc51720af7a043e144445) hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerFactory.java hbase-client/pom.xml hbase-client/src/main/java/org/apache/hadoop/hbase/client/StatsTrackingRpcRetryingCaller.java hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientPushback.java Amend HBASE-5162 Basic client pushback mechanism (Jesse Yates) (apurtell: rev 99a11390b4758c211af04af2ca0696ac6e3e0aeb) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientPushback.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/StatsTrackingRpcRetryingCaller.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerFactory.java
          Hide
          Andrew Purtell added a comment -

          We need to determine why the test is failing in the Jenkins environment or revert.

          Show
          Andrew Purtell added a comment - We need to determine why the test is failing in the Jenkins environment or revert.
          Andrew Purtell made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          stack added a comment -

          Arg. Sorry about that Andrew Purtell You seem to be doing a bunch of cleanup after me lately. Let me be better....

          Show
          stack added a comment - Arg. Sorry about that Andrew Purtell You seem to be doing a bunch of cleanup after me lately. Let me be better....
          Hide
          Ted Yu added a comment -

          From https://builds.apache.org/job/HBase-TRUNK/5937/testReport/org.apache.hadoop.hbase.client/TestClientPushback/testClientTracksServerPushback/ :

          java.lang.AssertionError: expected:<15> but was:<11>
          	at org.junit.Assert.fail(Assert.java:88)
          	at org.junit.Assert.failNotEquals(Assert.java:743)
          	at org.junit.Assert.assertEquals(Assert.java:118)
          	at org.junit.Assert.assertEquals(Assert.java:555)
          	at org.junit.Assert.assertEquals(Assert.java:542)
          	at org.apache.hadoop.hbase.client.TestClientPushback.testClientTracksServerPushback(TestClientPushback.java:92)
          

          The attached addendum relaxes the range for memstore load checking.

          Show
          Ted Yu added a comment - From https://builds.apache.org/job/HBase-TRUNK/5937/testReport/org.apache.hadoop.hbase.client/TestClientPushback/testClientTracksServerPushback/ : java.lang.AssertionError: expected:<15> but was:<11> at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:743) at org.junit.Assert.assertEquals(Assert.java:118) at org.junit.Assert.assertEquals(Assert.java:555) at org.junit.Assert.assertEquals(Assert.java:542) at org.apache.hadoop.hbase.client.TestClientPushback.testClientTracksServerPushback(TestClientPushback.java:92) The attached addendum relaxes the range for memstore load checking.
          Ted Yu made changes -
          Attachment 5162-addendum2.txt [ 12687800 ]
          Ted Yu made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Dima Spivak added a comment -

          Can someone explain to me where this magic number of 15% comes from? (And then where your magic number of 11% comes from, Ted Yu? ) I might well just be dense here, but I'm not following what part of the setup of the test dictates a memstore load to be expected.

          Show
          Dima Spivak added a comment - Can someone explain to me where this magic number of 15% comes from? (And then where your magic number of 11% comes from, Ted Yu ? ) I might well just be dense here, but I'm not following what part of the setup of the test dictates a memstore load to be expected.
          Hide
          Ted Yu added a comment -

          The test writes some data to client-pushback table and gets memstore load through StatisticsTracker.
          The load varies: 11 was the reading shown in build #5937.

          Jesse would be able to give us more detail.

          Show
          Ted Yu added a comment - The test writes some data to client-pushback table and gets memstore load through StatisticsTracker. The load varies: 11 was the reading shown in build #5937. Jesse would be able to give us more detail.
          Hide
          Jesse Yates added a comment -

          thanks all for helping out!

          Dima Spivak the number is just what the memstore is currently at, load wise, which is basically the current number of bytes/number of bytes after which it flushes. A put is a certain number of bytes, so it should put a certain amount of load on the memstore.

          I think what is happening in Jenkins is something is hanging, so the memstore is flushing before we expect. I think we can go ahead with Ted's patch, for the meantime. An alternative would be to force-flush the table before doing the write and then get the load - nothing else should be influencing it.

          Show
          Jesse Yates added a comment - thanks all for helping out! Dima Spivak the number is just what the memstore is currently at, load wise, which is basically the current number of bytes/number of bytes after which it flushes. A put is a certain number of bytes, so it should put a certain amount of load on the memstore. I think what is happening in Jenkins is something is hanging, so the memstore is flushing before we expect. I think we can go ahead with Ted's patch, for the meantime. An alternative would be to force-flush the table before doing the write and then get the load - nothing else should be influencing it.
          Hide
          Ted Yu added a comment -

          Planning to commit the addendum soon - this JIRA is in 1.0 whose RC is coming out today.

          Show
          Ted Yu added a comment - Planning to commit the addendum soon - this JIRA is in 1.0 whose RC is coming out today.
          Hide
          Jesse Yates added a comment -

          This jira isn't actually going into 1.0 - couldn't get Enis Soztutar's attention to ok it going in. I'll move it out to 1.1 for now. Feel free to commit to master Ted.

          Show
          Jesse Yates added a comment - This jira isn't actually going into 1.0 - couldn't get Enis Soztutar 's attention to ok it going in. I'll move it out to 1.1 for now. Feel free to commit to master Ted.
          Jesse Yates made changes -
          Fix Version/s 1.1.0 [ 12329043 ]
          Fix Version/s 1.0.0 [ 12325852 ]
          Hide
          Dima Spivak added a comment -

          I really don't think changing one arbitrary to another arbitrary number is the way to go here; the test will start failing in the future if we ever tweak the memstore and that number changes. I think Jesse's alternative solution, setting up the memstore in a known state during/before the test is the most reasonable thing to do.

          Show
          Dima Spivak added a comment - I really don't think changing one arbitrary to another arbitrary number is the way to go here; the test will start failing in the future if we ever tweak the memstore and that number changes. I think Jesse's alternative solution, setting up the memstore in a known state during/before the test is the most reasonable thing to do.
          Hide
          Ted Yu added a comment -

          Integrated to master branch.

          It is not clear when 1.1.0 release comes out. Should this JIRA be resolved and a new JIRA opened for backporting to branch-1 ?

          Show
          Ted Yu added a comment - Integrated to master branch. It is not clear when 1.1.0 release comes out. Should this JIRA be resolved and a new JIRA opened for backporting to branch-1 ?
          Hide
          Jesse Yates added a comment -

          We could. Was hoping to get the 1.0 backport in sooner rather than later, but either way works for me

          Show
          Jesse Yates added a comment - We could. Was hoping to get the 1.0 backport in sooner rather than later, but either way works for me
          Hide
          Sean Busbey added a comment -

          please make a backport ticket. that's what we've done for other things that didn't make the 1.0 cut off.

          Show
          Sean Busbey added a comment - please make a backport ticket. that's what we've done for other things that didn't make the 1.0 cut off.
          Hide
          Jesse Yates added a comment -

          Marking fixed. Thanks for the reviews andrew! And stack and Ted for helping with the addendums. Glad to see this guy finally closed out.

          Backport work to be done over on HBASE-12702

          Show
          Jesse Yates added a comment - Marking fixed. Thanks for the reviews andrew! And stack and Ted for helping with the addendums. Glad to see this guy finally closed out. Backport work to be done over on HBASE-12702
          Jesse Yates made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Jesse Yates made changes -
          Fix Version/s 1.1.0 [ 12329043 ]
          Jesse Yates made changes -
          Link This issue relates to HBASE-12703 [ HBASE-12703 ]
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12687800/5162-addendum2.txt
          against master branch at commit 422df8a3f430e1e41f971a644eec298f23decaf8.
          ATTACHMENT ID: 12687800

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 checkstyle. The applied patch does not increase the total number of checkstyle errors

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12114//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12114//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12114//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12114//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12114//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12114//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12114//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12114//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12114//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12114//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12114//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12114//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12114//artifact/patchprocess/checkstyle-aggregate.html

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12114//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12687800/5162-addendum2.txt against master branch at commit 422df8a3f430e1e41f971a644eec298f23decaf8. ATTACHMENT ID: 12687800 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 checkstyle . The applied patch does not increase the total number of checkstyle errors +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12114//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12114//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12114//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12114//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12114//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12114//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12114//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12114//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12114//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12114//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12114//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12114//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12114//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12114//console This message is automatically generated.
          Hide
          Andrew Purtell added a comment -

          Jesse Yates, what do you think about filing another issue for follow on work for the test... We could force flush as suggested above to set things at a known state. Or we could maybe mock something.

          Show
          Andrew Purtell added a comment - Jesse Yates , what do you think about filing another issue for follow on work for the test... We could force flush as suggested above to set things at a known state. Or we could maybe mock something.
          Hide
          Jesse Yates added a comment -

          Andrew Purtell filed and patch posted: HBASE-12703

          Show
          Jesse Yates added a comment - Andrew Purtell filed and patch posted: HBASE-12703
          Hide
          Andrew Purtell added a comment -

          Ok, oops. Thanks.

          Show
          Andrew Purtell added a comment - Ok, oops. Thanks.
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in HBase-TRUNK #5939 (See https://builds.apache.org/job/HBase-TRUNK/5939/)
          HBASE-5162 Addendum to stabilize TestClientPushback (tedyu: rev 6aa8b3727c75bf8578599ec35afcaad245f13e30)

          • hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientPushback.java
          Show
          Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK #5939 (See https://builds.apache.org/job/HBase-TRUNK/5939/ ) HBASE-5162 Addendum to stabilize TestClientPushback (tedyu: rev 6aa8b3727c75bf8578599ec35afcaad245f13e30) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientPushback.java
          Andrew Purtell made changes -
          Link This issue is related to HBASE-12731 [ HBASE-12731 ]
          Andrew Purtell made changes -
          Link This issue relates to HBASE-12702 [ HBASE-12702 ]
          Hide
          Hudson added a comment -

          FAILURE: Integrated in HBase-TRUNK #6012 (See https://builds.apache.org/job/HBase-TRUNK/6012/)
          HBASE-12838 After HBASE-5162 RSRpcServices accidentally applies mutations twice (apurtell: rev e52d8f85c48adc772dfe99e1f5cebb814e89c16c)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
          Show
          Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #6012 (See https://builds.apache.org/job/HBase-TRUNK/6012/ ) HBASE-12838 After HBASE-5162 RSRpcServices accidentally applies mutations twice (apurtell: rev e52d8f85c48adc772dfe99e1f5cebb814e89c16c) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
          Andrew Purtell made changes -
          Link This issue relates to HBASE-12840 [ HBASE-12840 ]
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in HBase-0.98 #805 (See https://builds.apache.org/job/HBase-0.98/805/)
          HBASE-12729 Backport HBASE-5162 (Basic client pushback mechanism) to 0.98 (apurtell: rev 85e7270b6f8cfb593c1cba137241f2aad986a3e1)

          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTableMultiplexer.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/backoff/ClientBackoffPolicyFactory.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/MultiAction.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
          • hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientExponentialBackoff.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/backoff/ExponentialClientBackoffPolicy.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ResponseConverter.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientPushback.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerFactory.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java
          • hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/DelayingRunner.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCaller.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALEditsReplaySink.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/Result.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/backoff/ClientBackoffPolicy.java
          • hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestDelayingRunner.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/StatisticsHConnection.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/backoff/ServerStatistics.java
          • hbase-protocol/src/main/protobuf/Client.proto
          • hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/StatsTrackingRpcRetryingCaller.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/ResultStatsUtil.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientSmallScanner.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/ServerStatisticTracker.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java
          Show
          Hudson added a comment - SUCCESS: Integrated in HBase-0.98 #805 (See https://builds.apache.org/job/HBase-0.98/805/ ) HBASE-12729 Backport HBASE-5162 (Basic client pushback mechanism) to 0.98 (apurtell: rev 85e7270b6f8cfb593c1cba137241f2aad986a3e1) hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTableMultiplexer.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/backoff/ClientBackoffPolicyFactory.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/MultiAction.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientExponentialBackoff.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/backoff/ExponentialClientBackoffPolicy.java hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ResponseConverter.java hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientPushback.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerFactory.java hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/DelayingRunner.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCaller.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALEditsReplaySink.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/Result.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/backoff/ClientBackoffPolicy.java hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestDelayingRunner.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/StatisticsHConnection.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/backoff/ServerStatistics.java hbase-protocol/src/main/protobuf/Client.proto hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/StatsTrackingRpcRetryingCaller.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/ResultStatsUtil.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientSmallScanner.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/ServerStatisticTracker.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #768 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/768/)
          HBASE-12729 Backport HBASE-5162 (Basic client pushback mechanism) to 0.98 (apurtell: rev 85e7270b6f8cfb593c1cba137241f2aad986a3e1)

          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/backoff/ExponentialClientBackoffPolicy.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/backoff/ServerStatistics.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerFactory.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTableMultiplexer.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java
          • hbase-protocol/src/main/protobuf/Client.proto
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/StatisticsHConnection.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
          • hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/ServerStatisticTracker.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientPushback.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/Result.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/DelayingRunner.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/backoff/ClientBackoffPolicy.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/MultiAction.java
          • hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestDelayingRunner.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientSmallScanner.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALEditsReplaySink.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/backoff/ClientBackoffPolicyFactory.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ResponseConverter.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/ResultStatsUtil.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/StatsTrackingRpcRetryingCaller.java
          • hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientExponentialBackoff.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCaller.java
          Show
          Hudson added a comment - SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #768 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/768/ ) HBASE-12729 Backport HBASE-5162 (Basic client pushback mechanism) to 0.98 (apurtell: rev 85e7270b6f8cfb593c1cba137241f2aad986a3e1) hbase-client/src/main/java/org/apache/hadoop/hbase/client/backoff/ExponentialClientBackoffPolicy.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/backoff/ServerStatistics.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerFactory.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTableMultiplexer.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java hbase-protocol/src/main/protobuf/Client.proto hbase-client/src/main/java/org/apache/hadoop/hbase/client/StatisticsHConnection.java hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/ServerStatisticTracker.java hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientPushback.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/Result.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/DelayingRunner.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/backoff/ClientBackoffPolicy.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/MultiAction.java hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestDelayingRunner.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientSmallScanner.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALEditsReplaySink.java hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/backoff/ClientBackoffPolicyFactory.java hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ResponseConverter.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/ResultStatsUtil.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/StatsTrackingRpcRetryingCaller.java hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientExponentialBackoff.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCaller.java
          Andrew Purtell made changes -
          Link This issue relates to HBASE-12841 [ HBASE-12841 ]
          Andrew Purtell made changes -
          Link This issue relates to HBASE-12906 [ HBASE-12906 ]
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in HBase-1.0 #676 (See https://builds.apache.org/job/HBase-1.0/676/)
          HBASE-12730 Backport HBASE-5162 (Basic client pushback mechanism) to branch-1 (apurtell: rev 06eef6dafb51eaeaea9b0566252bcab15be5729d)

          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClusterConnection.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/ServerStatisticTracker.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/MultiAction.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/Result.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/backoff/ExponentialClientBackoffPolicy.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALEditsReplaySink.java
          • hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientExponentialBackoff.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/backoff/ServerStatistics.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
          • hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestDelayingRunner.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/StatsTrackingRpcRetryingCaller.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/ResultStatsUtil.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java
          • hbase-protocol/src/main/protobuf/Client.proto
          • hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientPushback.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerFactory.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ResponseConverter.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/DelayingRunner.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionAdapter.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/backoff/ClientBackoffPolicy.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/backoff/ClientBackoffPolicyFactory.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RegionCoprocessorRpcChannel.java
          • hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java
          Show
          Hudson added a comment - SUCCESS: Integrated in HBase-1.0 #676 (See https://builds.apache.org/job/HBase-1.0/676/ ) HBASE-12730 Backport HBASE-5162 (Basic client pushback mechanism) to branch-1 (apurtell: rev 06eef6dafb51eaeaea9b0566252bcab15be5729d) hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClusterConnection.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/ServerStatisticTracker.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/MultiAction.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/Result.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/backoff/ExponentialClientBackoffPolicy.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALEditsReplaySink.java hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientExponentialBackoff.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/backoff/ServerStatistics.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java hbase-server/src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestDelayingRunner.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/StatsTrackingRpcRetryingCaller.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/ResultStatsUtil.java hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java hbase-protocol/src/main/protobuf/Client.proto hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientPushback.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerFactory.java hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ResponseConverter.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/DelayingRunner.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionAdapter.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/backoff/ClientBackoffPolicy.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/backoff/ClientBackoffPolicyFactory.java hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RegionCoprocessorRpcChannel.java hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in HBase-1.1 #99 (See https://builds.apache.org/job/HBase-1.1/99/)
          HBASE-12730 Backport HBASE-5162 (Basic client pushback mechanism) to branch-1 (apurtell: rev 04a003d6a2b628bc551a55ae556c1b44485e3022)

          • hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestDelayingRunner.java
          • hbase-protocol/src/main/protobuf/Client.proto
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/DelayingRunner.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/MultiAction.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RegionCoprocessorRpcChannel.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ResponseConverter.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/backoff/ClientBackoffPolicyFactory.java
          • hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientExponentialBackoff.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/StatsTrackingRpcRetryingCaller.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/backoff/ClientBackoffPolicy.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerFactory.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/Result.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/ServerStatisticTracker.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/ResultStatsUtil.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClusterConnection.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/backoff/ExponentialClientBackoffPolicy.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALEditsReplaySink.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/backoff/ServerStatistics.java
          • hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionAdapter.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientPushback.java
          Show
          Hudson added a comment - SUCCESS: Integrated in HBase-1.1 #99 (See https://builds.apache.org/job/HBase-1.1/99/ ) HBASE-12730 Backport HBASE-5162 (Basic client pushback mechanism) to branch-1 (apurtell: rev 04a003d6a2b628bc551a55ae556c1b44485e3022) hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestDelayingRunner.java hbase-protocol/src/main/protobuf/Client.proto hbase-client/src/main/java/org/apache/hadoop/hbase/client/DelayingRunner.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/MultiAction.java hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RegionCoprocessorRpcChannel.java hbase-server/src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ResponseConverter.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/backoff/ClientBackoffPolicyFactory.java hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientExponentialBackoff.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/StatsTrackingRpcRetryingCaller.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/backoff/ClientBackoffPolicy.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerFactory.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/Result.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/ServerStatisticTracker.java hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/ResultStatsUtil.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClusterConnection.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/backoff/ExponentialClientBackoffPolicy.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALEditsReplaySink.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/backoff/ServerStatistics.java hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionAdapter.java hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientPushback.java
          Nick Dimiduk made changes -
          Link This issue is related to HBASE-12911 [ HBASE-12911 ]
          Andrew Purtell made changes -
          Link This issue relates to HBASE-12986 [ HBASE-12986 ]

            People

            • Assignee:
              Jesse Yates
              Reporter:
              Jean-Daniel Cryans
            • Votes:
              0 Vote for this issue
              Watchers:
              27 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development