HBase
  1. HBase
  2. HBASE-5153

Add retry logic in HConnectionImplementation#resetZooKeeperTrackers

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.90.4
    • Fix Version/s: 0.90.6
    • Component/s: Client
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      HBASE-4893 is related to this issue. In that issue, we know, if multi-threads share a same connection, once this connection got abort in one thread, the other threads will got a "HConnectionManager$HConnectionImplementation@18fb1f7 closed" exception.

      It solve the problem of "stale connection can't removed". But the orignal HTable instance cann't be continue to use. The connection in HTable should be recreated.

      Actually, there's two aproach to solve this:
      1. In user code, once catch an IOE, close connection and re-create HTable instance. We can use this as a workaround.
      2. In HBase Client side, catch this exception, and re-create connection.

      1. TestResults-hbase5153.out
        26 kB
        Jieshan Bean
      2. HBASE-5153-V6-90-minorchange.patch
        27 kB
        Jieshan Bean
      3. HBASE-5153-V6-90.txt
        26 kB
        Jieshan Bean
      4. HBASE-5153-V5-90.patch
        26 kB
        Jieshan Bean
      5. HBASE-5153-V4-90.patch
        26 kB
        Jieshan Bean
      6. HBASE-5153-V3.patch
        19 kB
        Jieshan Bean
      7. HBASE-5153-V2.patch
        6 kB
        Jieshan Bean
      8. HBASE-5153-trunk-v2.patch
        12 kB
        Jieshan Bean
      9. HBASE-5153-trunk.patch
        12 kB
        Jieshan Bean
      10. HBase-5153-90-addendum.patch
        11 kB
        Jieshan Bean
      11. HBASE-5153.patch
        4 kB
        Jieshan Bean
      12. HBASE-5153_addendum_0.90_1.patch
        11 kB
        ramkrishna.s.vasudevan
      13. 5153-trunk-v2.txt
        13 kB
        Lars Hofhansl
      14. 5153-trunk-minimal.txt
        6 kB
        Lars Hofhansl
      15. 5153-trunk.txt
        12 kB
        Ted Yu
      16. 5153-trunk.txt
        26 kB
        Ted Yu
      17. 5153-92.txt
        25 kB
        Ted Yu

        Issue Links

          Activity

          ramkrishna.s.vasudevan made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Fix Version/s 0.90.6 [ 12319200 ]
          Fix Version/s 0.90.7 [ 12319481 ]
          Resolution Fixed [ 1 ]
          stack made changes -
          Fix Version/s 0.90.7 [ 12319481 ]
          Fix Version/s 0.90.6 [ 12319200 ]
          ramkrishna.s.vasudevan made changes -
          Attachment HBASE-5153_addendum_0.90_1.patch [ 12512291 ]
          Lars Hofhansl made changes -
          Attachment 5153-trunk-minimal.txt [ 12512248 ]
          Ted Yu made changes -
          Fix Version/s 0.94.0 [ 12316419 ]
          Fix Version/s 0.92.1 [ 12318551 ]
          Ted Yu made changes -
          Comment [ -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12512100/HBase-5153-90-addendum.patch
            against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              +1 tests included. The patch appears to include 6 new or modified tests.

              -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/858//console

          This message is automatically generated. ]
          Jieshan Bean made changes -
          Attachment HBase-5153-90-addendum.patch [ 12512100 ]
          Lars Hofhansl made changes -
          Attachment 5153-trunk-v2.txt [ 12512077 ]
          Krystian Nowak made changes -
          Link This issue relates to HBASE-5289 [ HBASE-5289 ]
          Ted Yu made changes -
          Fix Version/s 0.90.6 [ 12319200 ]
          Fix Version/s 0.90.7 [ 12319481 ]
          Ted Yu made changes -
          Fix Version/s 0.90.7 [ 12319481 ]
          Fix Version/s 0.90.6 [ 12319200 ]
          Ted Yu made changes -
          Comment [ -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12510806/5153-92.txt
            against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              +1 tests included. The patch appears to include 15 new or modified tests.

              -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/787//console

          This message is automatically generated. ]
          Ted Yu made changes -
          Attachment 5153-92.txt [ 12510806 ]
          Ted Yu made changes -
          Fix Version/s 0.94.0 [ 12316419 ]
          Fix Version/s 0.92.1 [ 12318551 ]
          Ted Yu made changes -
          Attachment 5153-trunk.txt [ 12510779 ]
          Ted Yu made changes -
          Comment [ -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12510715/TestResults-hbase5153.out
            against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              +1 tests included. The patch appears to include 1 new or modified tests.

              -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/778//console

          This message is automatically generated. ]
          Jieshan Bean made changes -
          Attachment TestResults-hbase5153.out [ 12510715 ]
          Ted Yu made changes -
          Comment [ -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12510383/HBASE-5153-V4-90.patch
            against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              +1 tests included. The patch appears to include 3 new or modified tests.

              -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/747//console

          This message is automatically generated. ]
          Ted Yu made changes -
          Comment [ -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12510179/HBASE-5153-V3.patch
            against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              +1 tests included. The patch appears to include 3 new or modified tests.

              -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/727//console

          This message is automatically generated. ]
          ramkrishna.s.vasudevan made changes -
          Comment [ -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12510683/HBASE-5153-V6-90-minorchange.patch
            against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              +1 tests included. The patch appears to include 9 new or modified tests.

              -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/775//console

          This message is automatically generated. ]
          Jieshan Bean made changes -
          Attachment HBASE-5153-V6-90-minorchange.patch [ 12510683 ]
          Ted Yu made changes -
          Comment [ -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12510667/HBASE-5153-V6-90.txt
            against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              +1 tests included. The patch appears to include 9 new or modified tests.

              -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/771//console

          This message is automatically generated. ]
          Jieshan Bean made changes -
          Attachment HBASE-5153-V6-90.txt [ 12510667 ]
          Jieshan Bean made changes -
          Summary HConnection re-creation in HTable after HConnection abort Add retry logic in HConnectionImplementation#resetZooKeeperTrackers
          Ted Yu made changes -
          Comment [ -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12510573/HBASE-5153-V5-90.patch
            against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              +1 tests included. The patch appears to include 9 new or modified tests.

              -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/759//console

          This message is automatically generated. ]
          Jieshan Bean made changes -
          Attachment HBASE-5153-V5-90.patch [ 12510573 ]
          Ted Yu made changes -
          Hadoop Flags Reviewed [ 10343 ]
          Jieshan Bean made changes -
          Attachment HBASE-5153-V4-90.patch [ 12510457 ]
          Attachment HBASE-5153-trunk-v2.patch [ 12510458 ]
          Jieshan Bean made changes -
          Attachment HBASE-5153-V4-90.patch [ 12510383 ]
          Ted Yu made changes -
          Attachment 5153-trunk.txt [ 12510397 ]
          Jieshan Bean made changes -
          Attachment HBASE-5153-trunk.patch [ 12510382 ]
          Attachment HBASE-5153-V4-90.patch [ 12510383 ]
          Jieshan Bean made changes -
          Attachment HBASE-5153-V3.patch [ 12510179 ]
          Ted Yu made changes -
          Comment [ -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12509917/HBASE-5153-V2.patch
            against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              +1 tests included. The patch appears to include 3 new or modified tests.

              -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/705//console

          This message is automatically generated. ]
          Ted Yu made changes -
          Comment [ -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12509917/HBASE-5153-V2.patch
            against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              +1 tests included. The patch appears to include 3 new or modified tests.

              -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/706//console

          This message is automatically generated. ]
          Ted Yu made changes -
          Comment [ -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12509890/HBASE-5153.patch
            against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              -1 tests included. The patch doesn't appear to include any new or modified tests.
                                  Please justify why no new tests are needed for this patch.
                                  Also please list what manual steps were performed to verify this patch.

              -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/704//console

          This message is automatically generated. ]
          Jieshan Bean made changes -
          Attachment HBASE-5153-V2.patch [ 12509917 ]
          Jieshan Bean made changes -
          Attachment HBASE-5153-V2.patch [ 12509915 ]
          Jieshan Bean made changes -
          Attachment HBASE-5153-V2.patch [ 12509915 ]
          Ted Yu made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Jieshan Bean made changes -
          Attachment HBASE-5153.patch [ 12509890 ]
          Jieshan Bean made changes -
          Attachment HBASE-5153.patch [ 12509881 ]
          Jieshan Bean made changes -
          Field Original Value New Value
          Attachment HBASE-5153.patch [ 12509881 ]
          Jieshan Bean created issue -

            People

            • Assignee:
              Jieshan Bean
              Reporter:
              Jieshan Bean
            • Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development