HBase
  1. HBase
  2. HBASE-5051

HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.94.0
    • Fix Version/s: 0.94.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      As it's a new instance, it should be closed. As the function name seems to imply that it's an instance managed by HBaseTestingUtility, most of the users don't close it => leak

      1. 5051.v2.patch
        16 kB
        Nicolas Liochon
      2. 5051.v2.patch
        16 kB
        Nicolas Liochon
      3. 5051.v2.patch
        16 kB
        Nicolas Liochon
      4. 5051.v2.patch
        16 kB
        Nicolas Liochon
      5. 5051.patch
        15 kB
        Nicolas Liochon

        Issue Links

          Activity

          Lars Hofhansl made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK-security #38 (See https://builds.apache.org/job/HBase-TRUNK-security/38/)
          HBASE-5051 HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call

          stack :
          Files :

          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/constraint/TestConstraint.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportExport.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestMaster.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestMasterRestartAfterDisablingTable.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRollAbort.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/rest/TestScannersWithFilters.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/rest/TestTableResource.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/hbck/OfflineMetaRebuildTestCore.java
          Show
          Hudson added a comment - Integrated in HBase-TRUNK-security #38 (See https://builds.apache.org/job/HBase-TRUNK-security/38/ ) HBASE-5051 HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call stack : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/constraint/TestConstraint.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportExport.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestMaster.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestMasterRestartAfterDisablingTable.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRollAbort.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/rest/TestScannersWithFilters.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/rest/TestTableResource.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/hbck/OfflineMetaRebuildTestCore.java
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK #2559 (See https://builds.apache.org/job/HBase-TRUNK/2559/)
          HBASE-5051 HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call

          stack :
          Files :

          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/constraint/TestConstraint.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportExport.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestMaster.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestMasterRestartAfterDisablingTable.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRollAbort.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/rest/TestScannersWithFilters.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/rest/TestTableResource.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/hbck/OfflineMetaRebuildTestCore.java
          Show
          Hudson added a comment - Integrated in HBase-TRUNK #2559 (See https://builds.apache.org/job/HBase-TRUNK/2559/ ) HBASE-5051 HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call stack : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/constraint/TestConstraint.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportExport.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestMaster.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestMasterRestartAfterDisablingTable.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRollAbort.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/rest/TestScannersWithFilters.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/rest/TestTableResource.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/hbck/OfflineMetaRebuildTestCore.java
          stack made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags Reviewed [ 10343 ]
          Fix Version/s 0.94.0 [ 12316419 ]
          Resolution Fixed [ 1 ]
          Hide
          stack added a comment -

          Committed to trunk. Thanks for the patch N.

          Show
          stack added a comment - Committed to trunk. Thanks for the patch N.
          Hide
          Nicolas Liochon added a comment -

          TestMasterReplication hang; but it hang on trunk as well (see: https://builds.apache.org/job/HBase-TRUNK/2558/console)
          TestReplication: usually flaky.

          I think the patch is ok.

          Show
          Nicolas Liochon added a comment - TestMasterReplication hang; but it hang on trunk as well (see: https://builds.apache.org/job/HBase-TRUNK/2558/console ) TestReplication: usually flaky. I think the patch is ok.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12507880/5051.v2.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 39 new or modified tests.

          -1 javadoc. The javadoc tool appears to have generated -152 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 76 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.replication.TestReplication

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/543//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/543//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/543//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12507880/5051.v2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 39 new or modified tests. -1 javadoc. The javadoc tool appears to have generated -152 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 76 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.replication.TestReplication Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/543//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/543//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/543//console This message is automatically generated.
          Nicolas Liochon made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Nicolas Liochon made changes -
          Attachment 5051.v2.patch [ 12507880 ]
          Nicolas Liochon made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12507776/5051.v2.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 39 new or modified tests.

          -1 javadoc. The javadoc tool appears to have generated -152 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 76 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.client.TestInstantSchemaChange
          org.apache.hadoop.hbase.mapred.TestTableMapReduce
          org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/531//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/531//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/531//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12507776/5051.v2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 39 new or modified tests. -1 javadoc. The javadoc tool appears to have generated -152 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 76 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.client.TestInstantSchemaChange org.apache.hadoop.hbase.mapred.TestTableMapReduce org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/531//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/531//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/531//console This message is automatically generated.
          Nicolas Liochon made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Nicolas Liochon added a comment -

          mapred.TestTableMapReduce.testMultiRegionTable: NumberFormatException: For input string: "18446743988037478956"
          mapreduce.TestHFileOutputFormat.testMRIncrementalLoad: NumberFormatException: For input string: "18446743988037169444"
          mapreduce.TestHFileOutputFormat.testMRIncrementalLoadWithSplit NumberFormatException: For input string: "18446743988037182259"
          mapreduce.TestHFileOutputFormat.testExcludeMinorCompaction: NumberFormatException: For input string: "18446743988037186552"
          TestReplication.queueFailover: ??
          TestInstantSchemaChange.testInstantSchemaJanitor: Too many open files
          TestMasterReplication: hung

          TestMasterReplication works locally. The patch should not have impacted it. It hungs on trunk as well (see: https://builds.apache.org/job/HBase-TRUNK/2553/testReport/org.apache.hadoop.hbase.replication/ : there is no entry for TestMasterReplication)
          TestReplication works locally. This test is usually flaky.
          mapred.TestTableMapReduce worked in the previous prebuild.
          mapreduce.TestHFileOutputFormat worked in the previous prebuild.

          Let's retry.

          Show
          Nicolas Liochon added a comment - mapred.TestTableMapReduce.testMultiRegionTable: NumberFormatException: For input string: "18446743988037478956" mapreduce.TestHFileOutputFormat.testMRIncrementalLoad: NumberFormatException: For input string: "18446743988037169444" mapreduce.TestHFileOutputFormat.testMRIncrementalLoadWithSplit NumberFormatException: For input string: "18446743988037182259" mapreduce.TestHFileOutputFormat.testExcludeMinorCompaction: NumberFormatException: For input string: "18446743988037186552" TestReplication.queueFailover: ?? TestInstantSchemaChange.testInstantSchemaJanitor: Too many open files TestMasterReplication: hung TestMasterReplication works locally. The patch should not have impacted it. It hungs on trunk as well (see: https://builds.apache.org/job/HBase-TRUNK/2553/testReport/org.apache.hadoop.hbase.replication/ : there is no entry for TestMasterReplication) TestReplication works locally. This test is usually flaky. mapred.TestTableMapReduce worked in the previous prebuild. mapreduce.TestHFileOutputFormat worked in the previous prebuild. Let's retry.
          Nicolas Liochon made changes -
          Attachment 5051.v2.patch [ 12507776 ]
          Nicolas Liochon made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12507771/5051.v2.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 39 new or modified tests.

          -1 javadoc. The javadoc tool appears to have generated -152 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 76 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.client.TestInstantSchemaChange
          org.apache.hadoop.hbase.replication.TestReplication
          org.apache.hadoop.hbase.mapred.TestTableMapReduce
          org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/530//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/530//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/530//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12507771/5051.v2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 39 new or modified tests. -1 javadoc. The javadoc tool appears to have generated -152 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 76 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.client.TestInstantSchemaChange org.apache.hadoop.hbase.replication.TestReplication org.apache.hadoop.hbase.mapred.TestTableMapReduce org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/530//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/530//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/530//console This message is automatically generated.
          Nicolas Liochon made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Nicolas Liochon added a comment -

          retrying with the same patch

          Show
          Nicolas Liochon added a comment - retrying with the same patch
          Nicolas Liochon made changes -
          Attachment 5051.v2.patch [ 12507771 ]
          Nicolas Liochon made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK-security #35 (See https://builds.apache.org/job/HBase-TRUNK-security/35/)
          HBASE-5051 HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call - revert

          tedyu :
          Files :

          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/constraint/TestConstraint.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportExport.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestMaster.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRollAbort.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/rest/TestScannersWithFilters.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/rest/TestTableResource.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/hbck/OfflineMetaRebuildTestCore.java
          Show
          Hudson added a comment - Integrated in HBase-TRUNK-security #35 (See https://builds.apache.org/job/HBase-TRUNK-security/35/ ) HBASE-5051 HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call - revert tedyu : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/constraint/TestConstraint.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportExport.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestMaster.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRollAbort.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/rest/TestScannersWithFilters.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/rest/TestTableResource.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/hbck/OfflineMetaRebuildTestCore.java
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK #2552 (See https://builds.apache.org/job/HBase-TRUNK/2552/)
          HBASE-5051 HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call - revert

          tedyu :
          Files :

          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/constraint/TestConstraint.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportExport.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestMaster.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRollAbort.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/rest/TestScannersWithFilters.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/rest/TestTableResource.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/hbck/OfflineMetaRebuildTestCore.java
          Show
          Hudson added a comment - Integrated in HBase-TRUNK #2552 (See https://builds.apache.org/job/HBase-TRUNK/2552/ ) HBASE-5051 HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call - revert tedyu : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/constraint/TestConstraint.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportExport.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestMaster.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRollAbort.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/rest/TestScannersWithFilters.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/rest/TestTableResource.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/hbck/OfflineMetaRebuildTestCore.java
          Hide
          Ted Yu added a comment -

          TestMasterReplication hung in the above build.

          Show
          Ted Yu added a comment - TestMasterReplication hung in the above build.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12507739/5051.v2.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 39 new or modified tests.

          -1 javadoc. The javadoc tool appears to have generated -152 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 76 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/527//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/527//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/527//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12507739/5051.v2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 39 new or modified tests. -1 javadoc. The javadoc tool appears to have generated -152 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 76 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/527//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/527//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/527//console This message is automatically generated.
          Hide
          Ted Yu added a comment -

          Yeah. TestMasterRestartAfterDisablingTable passes now.

          Show
          Ted Yu added a comment - Yeah. TestMasterRestartAfterDisablingTable passes now.
          Nicolas Liochon made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Nicolas Liochon added a comment -

          This should do it.

          Show
          Nicolas Liochon added a comment - This should do it.
          Nicolas Liochon made changes -
          Attachment 5051.v2.patch [ 12507739 ]
          Nicolas Liochon made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          Nicolas Liochon added a comment -

          my error. sorry. will look after this.

          Show
          Nicolas Liochon added a comment - my error. sorry. will look after this.
          Show
          Ted Yu added a comment - I should have double checked: I don't see 'Too many open files' here: https://builds.apache.org/job/PreCommit-HBASE-Build/521//testReport/org.apache.hadoop.hbase.master/TestMasterRestartAfterDisablingTable/testForCheckingIfEnableAndDisableWorksFineAfterSwitch/
          Hide
          Ted Yu added a comment -

          TestMasterRestartAfterDisablingTable.testForCheckingIfEnableAndDisableWorksFineAfterSwitch failure in TRUNK can be reproduced on MacBook.
          Strangely TestMasterRestartAfterDisablingTable didn't appear in the patch.
          Could be related to the changes in HMaster.java

          Reverting the patch until we determine the root cause.

          Show
          Ted Yu added a comment - TestMasterRestartAfterDisablingTable.testForCheckingIfEnableAndDisableWorksFineAfterSwitch failure in TRUNK can be reproduced on MacBook. Strangely TestMasterRestartAfterDisablingTable didn't appear in the patch. Could be related to the changes in HMaster.java Reverting the patch until we determine the root cause.
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK #2550 (See https://builds.apache.org/job/HBase-TRUNK/2550/)
          HBASE-5051 HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call (N Keywal)

          tedyu :
          Files :

          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/constraint/TestConstraint.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportExport.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestMaster.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRollAbort.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/rest/TestScannersWithFilters.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/rest/TestTableResource.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/hbck/OfflineMetaRebuildTestCore.java
          Show
          Hudson added a comment - Integrated in HBase-TRUNK #2550 (See https://builds.apache.org/job/HBase-TRUNK/2550/ ) HBASE-5051 HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call (N Keywal) tedyu : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/constraint/TestConstraint.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportExport.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestMaster.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRollAbort.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/rest/TestScannersWithFilters.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/rest/TestTableResource.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/hbck/OfflineMetaRebuildTestCore.java
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK-security #34 (See https://builds.apache.org/job/HBase-TRUNK-security/34/)
          HBASE-5051 HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call (N Keywal)

          tedyu :
          Files :

          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/constraint/TestConstraint.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportExport.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestMaster.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRollAbort.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/rest/TestScannersWithFilters.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/rest/TestTableResource.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/hbck/OfflineMetaRebuildTestCore.java
          Show
          Hudson added a comment - Integrated in HBase-TRUNK-security #34 (See https://builds.apache.org/job/HBase-TRUNK-security/34/ ) HBASE-5051 HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call (N Keywal) tedyu : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/constraint/TestConstraint.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportExport.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestMaster.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRollAbort.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/rest/TestScannersWithFilters.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/rest/TestTableResource.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/hbck/OfflineMetaRebuildTestCore.java
          Hide
          Ted Yu added a comment -

          Integrated to TRUNK.

          Thanks for the patch, N.

          Show
          Ted Yu added a comment - Integrated to TRUNK. Thanks for the patch, N.
          Hide
          Nicolas Liochon added a comment -

          TestMasterRestartAfterDisablingTable.testForCheckingIfEnableAndDisableWorksFineAfterSwitch = "Too many open files"
          TestReplication.queueFailover = usual flaky test, works locally (just rechecked)
          TestInstantSchemaChange.testInstantSchemaJanitor = "Too many open files"
          TestInstantSchemaChange.testInstantSchemaChangeBlocksDuringLoadBalancerRun = "Too many open files"

          patch ok imho.

          Show
          Nicolas Liochon added a comment - TestMasterRestartAfterDisablingTable.testForCheckingIfEnableAndDisableWorksFineAfterSwitch = "Too many open files" TestReplication.queueFailover = usual flaky test, works locally (just rechecked) TestInstantSchemaChange.testInstantSchemaJanitor = "Too many open files" TestInstantSchemaChange.testInstantSchemaChangeBlocksDuringLoadBalancerRun = "Too many open files" patch ok imho.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12507670/5051.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 36 new or modified tests.

          -1 javadoc. The javadoc tool appears to have generated -152 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 76 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.master.TestMasterRestartAfterDisablingTable
          org.apache.hadoop.hbase.replication.TestReplication
          org.apache.hadoop.hbase.client.TestInstantSchemaChange

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/521//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/521//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/521//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12507670/5051.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 36 new or modified tests. -1 javadoc. The javadoc tool appears to have generated -152 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 76 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.master.TestMasterRestartAfterDisablingTable org.apache.hadoop.hbase.replication.TestReplication org.apache.hadoop.hbase.client.TestInstantSchemaChange Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/521//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/521//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/521//console This message is automatically generated.
          Nicolas Liochon made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Nicolas Liochon made changes -
          Link This issue relates to HBASE-4602 [ HBASE-4602 ]
          Nicolas Liochon made changes -
          Field Original Value New Value
          Attachment 5051.patch [ 12507670 ]
          Nicolas Liochon created issue -

            People

            • Assignee:
              Nicolas Liochon
              Reporter:
              Nicolas Liochon
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development