HBase
  1. HBase
  2. HBASE-4957

Clean up some log messages, code in RecoverableZooKeeper

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.92.0
    • Fix Version/s: 0.94.0, 0.95.0
    • Component/s: Zookeeper
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In RecoverableZooKeeper, there are a number of log messages and comments which don't really read correctly, and some other pieces of code that can be cleaned up. Simple cleanup - shouldn't be any actual behavioral changes.

      1. hbase-4957.txt
        15 kB
        stack
      2. hbase-4957.txt
        15 kB
        stack
      3. hbase-4957.txt
        15 kB
        Todd Lipcon
      4. hbase-4957.txt
        9 kB
        Todd Lipcon

        Activity

        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12506152/hbase-4957.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/445//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12506152/hbase-4957.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/445//console This message is automatically generated.
        Hide
        Todd Lipcon added a comment -

        oops, uploaded only half the patch so it didn't apply. take 2!

        Show
        Todd Lipcon added a comment - oops, uploaded only half the patch so it didn't apply. take 2!
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12506156/hbase-4957.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 javadoc. The javadoc tool appears to have generated -160 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 71 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.mapreduce.TestTimeRangeMapRed
        org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFilesSplitRecovery
        org.apache.hadoop.hbase.TestDrainingServer
        org.apache.hadoop.hbase.TestFullLogReconstruction
        org.apache.hadoop.hbase.mapreduce.TestImportTsv
        org.apache.hadoop.hbase.mapreduce.TestTableMapReduce

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/446//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/446//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/446//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12506156/hbase-4957.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javadoc. The javadoc tool appears to have generated -160 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 71 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.mapreduce.TestTimeRangeMapRed org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFilesSplitRecovery org.apache.hadoop.hbase.TestDrainingServer org.apache.hadoop.hbase.TestFullLogReconstruction org.apache.hadoop.hbase.mapreduce.TestImportTsv org.apache.hadoop.hbase.mapreduce.TestTableMapReduce Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/446//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/446//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/446//console This message is automatically generated.
        Hide
        stack added a comment -

        +1 on patch. Small change.

        Show
        stack added a comment - +1 on patch. Small change.
        Hide
        ramkrishna.s.vasudevan added a comment -

        +1 on patch

        Show
        ramkrishna.s.vasudevan added a comment - +1 on patch
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12506156/hbase-4957.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 javadoc. The javadoc tool appears to have generated -152 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 75 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.client.TestInstantSchemaChange
        org.apache.hadoop.hbase.client.TestAdmin
        org.apache.hadoop.hbase.master.TestDistributedLogSplitting

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/510//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/510//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/510//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12506156/hbase-4957.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javadoc. The javadoc tool appears to have generated -152 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 75 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.client.TestInstantSchemaChange org.apache.hadoop.hbase.client.TestAdmin org.apache.hadoop.hbase.master.TestDistributedLogSplitting Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/510//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/510//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/510//console This message is automatically generated.
        Hide
        Lars Hofhansl added a comment -

        +1 on latest version.
        Some of the test failures are strange, though.

        Show
        Lars Hofhansl added a comment - +1 on latest version. Some of the test failures are strange, though.
        Hide
        Ted Yu added a comment -

        Would the change in RecoverableZooKeeper be in conflict with what N Keywal is doing ?

        Show
        Ted Yu added a comment - Would the change in RecoverableZooKeeper be in conflict with what N Keywal is doing ?
        Hide
        stack added a comment -

        +1 on patch (again). Its good cleanup. N can rebase.

        Show
        stack added a comment - +1 on patch (again). Its good cleanup. N can rebase.
        Hide
        stack added a comment -

        Resubmit to hadoopqa

        Show
        stack added a comment - Resubmit to hadoopqa
        Hide
        Lars Hofhansl added a comment -

        Let's commit if hadoopqa is (mostly) cool with it

        Show
        Lars Hofhansl added a comment - Let's commit if hadoopqa is (mostly) cool with it
        Hide
        Lars Hofhansl added a comment -

        hadoopqa is taking a nap

        Show
        Lars Hofhansl added a comment - hadoopqa is taking a nap
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12519303/hbase-4957.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1262//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1262//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1262//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12519303/hbase-4957.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1262//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1262//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1262//console This message is automatically generated.
        Hide
        Lars Hofhansl added a comment -

        Looks good. I'm going to commit later unless somebody else wants and has objections.

        Show
        Lars Hofhansl added a comment - Looks good. I'm going to commit later unless somebody else wants and has objections.
        Hide
        Ted Yu added a comment -

        It was not clear which test timed out.
        Running through Hadoop QA again would be wise.

        Show
        Ted Yu added a comment - It was not clear which test timed out. Running through Hadoop QA again would be wise.
        Hide
        stack added a comment -

        Retry

        Show
        stack added a comment - Retry
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12519579/hbase-4957.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.mapreduce.TestImportTsv
        org.apache.hadoop.hbase.mapred.TestTableMapReduce
        org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
        org.apache.hadoop.hbase.master.TestSplitLogManager

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1299//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1299//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1299//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12519579/hbase-4957.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.mapreduce.TestImportTsv org.apache.hadoop.hbase.mapred.TestTableMapReduce org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat org.apache.hadoop.hbase.master.TestSplitLogManager Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1299//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1299//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1299//console This message is automatically generated.
        Hide
        Lars Hofhansl added a comment -

        TestSplitLogManager passed locally. Going to commit.

        Show
        Lars Hofhansl added a comment - TestSplitLogManager passed locally. Going to commit.
        Hide
        Lars Hofhansl added a comment -

        Committed to 0.94 and 0.96.

        Show
        Lars Hofhansl added a comment - Committed to 0.94 and 0.96.
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94 #54 (See https://builds.apache.org/job/HBase-0.94/54/)
        HBASE-4957 Clean up some log messages, code in RecoverableZooKeeper (Todd) (Revision 1304941)

        Result = SUCCESS
        larsh :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/RetryCounter.java
        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java
        Show
        Hudson added a comment - Integrated in HBase-0.94 #54 (See https://builds.apache.org/job/HBase-0.94/54/ ) HBASE-4957 Clean up some log messages, code in RecoverableZooKeeper (Todd) (Revision 1304941) Result = SUCCESS larsh : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/RetryCounter.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #2695 (See https://builds.apache.org/job/HBase-TRUNK/2695/)
        HBASE-4957 Clean up some log messages, code in RecoverableZooKeeper (Todd) (Revision 1304940)

        Result = FAILURE
        larsh :
        Files :

        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/RetryCounter.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #2695 (See https://builds.apache.org/job/HBase-TRUNK/2695/ ) HBASE-4957 Clean up some log messages, code in RecoverableZooKeeper (Todd) (Revision 1304940) Result = FAILURE larsh : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/RetryCounter.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java

          People

          • Assignee:
            Todd Lipcon
            Reporter:
            Todd Lipcon
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development