HBase
  1. HBase
  2. HBASE-4955

Use the official versions of surefire & junit

    Details

    • Type: Improvement Improvement
    • Status: Patch Available
    • Priority: Critical Critical
    • Resolution: Unresolved
    • Affects Version/s: 0.94.0, 0.98.0, 0.96.0, 0.99.0
    • Fix Version/s: None
    • Component/s: test
    • Labels:
      None
    • Environment:

      all

      Description

      We currently use private versions for Surefire & JUnit since HBASE-4763.

      This JIRA traks what we need to move to official versions.

      Surefire 2.11 is just out, but, after some tests, it does not contain all what we need.

      JUnit. Could be for JUnit 4.11. Issue to monitor:
      https://github.com/KentBeck/junit/issues/359: fixed in our version, no feedback for an integration on trunk

      Surefire: Could be for Surefire 2.12. Issues to monitor are:
      329 (category support): fixed, we use the official implementation from the trunk
      786 (@Category with forkMode=always): fixed, we use the official implementation from the trunk
      791 (incorrect elapsed time on test failure): fixed, we use the official implementation from the trunk
      793 (incorrect time in the XML report): Not fixed (reopen) on trunk, fixed on our version.
      760 (does not take into account the test method): fixed in trunk, not fixed in our version
      798 (print immediately the test class name): not fixed in trunk, not fixed in our version
      799 (Allow test parallelization when forkMode=always): not fixed in trunk, not fixed in our version
      800 (redirectTestOutputToFile not taken into account): not yet fix on trunk, fixed on our version

      800 & 793 are the more important to monitor, it's the only ones that are fixed in our version but not on trunk.

      1. 8204.v4.patch
        11 kB
        Nicolas Liochon
      2. 4955.v9.patch
        2 kB
        Nicolas Liochon
      3. 4955.v8.patch
        17 kB
        Nicolas Liochon
      4. 4955.v7.patch
        17 kB
        Nicolas Liochon
      5. 4955.v7.patch
        17 kB
        Nicolas Liochon
      6. 4955.v6.patch
        16 kB
        Nicolas Liochon
      7. 4955.v5.patch
        24 kB
        Nicolas Liochon
      8. 4955.v4.patch
        24 kB
        Nicolas Liochon
      9. 4955.v4.patch
        24 kB
        Nicolas Liochon
      10. 4955.v4.patch
        24 kB
        Nicolas Liochon
      11. 4955.v4.patch
        24 kB
        Nicolas Liochon
      12. 4955.v4.patch
        24 kB
        Nicolas Liochon
      13. 4955.v4.patch
        24 kB
        Nicolas Liochon
      14. 4955.v3.patch
        17 kB
        Nicolas Liochon
      15. 4955.v3.patch
        17 kB
        Nicolas Liochon
      16. 4955.v3.patch
        17 kB
        Nicolas Liochon
      17. 4955.v2.patch
        0.8 kB
        Nicolas Liochon
      18. 4955.v2.patch
        0.8 kB
        Nicolas Liochon
      19. 4955.v2.patch
        17 kB
        Nicolas Liochon
      20. 4955.v2.patch
        17 kB
        Nicolas Liochon
      21. 4955.v1.patch
        0.5 kB
        Nicolas Liochon

        Issue Links

          Activity

          Hide
          Nicolas Liochon added a comment -

          We're now using 2.12-TRUNK-HBASE-2.

          It's a private version, built on the 2.12 trunk (i.e.: it does not contain eveyrthing that will be in 2.12 final).

          Surefire: Could be for Surefire 2.12. Issues to monitor are:
          329 (category support): fixed, we use the official implementation from the trunk
          773 (forked processes not killed after timeout): not fixed in trunk, not fixed in our version
          786 (@Category with forkMode=always): fixed, we use the official implementation from the trunk
          791 (incorrect elapsed time on test failure): fixed, we use the official implementation from the trunk
          793 (incorrect time in the XML report): Not fixed (reopen) in trunk, partial fixed in our version.
          760 (does not take into account the test method): fixed, we use the official implementation from the trunk
          798 (print immediately the test class name): not fixed in trunk, not fixed in our version
          799 (Allow test parallelization when forkMode=always): fixed in trunk, fixed in our version with some minimal differences.
          800 (redirectTestOutputToFile not taken into account): not yet fix on trunk, fixed in our version
          806 (Ignore selection criteria when -Dtest= is specified): not fixed in trunk, not fixed in our version
          813 (Randomly wrong tests count and empty summary files): fixed in trunk, fixed in our version

          800 & 793 are the more important to monitor, it's the only ones that are fixed in our version but not on trunk.

          Show
          Nicolas Liochon added a comment - We're now using 2.12-TRUNK- HBASE-2 . It's a private version, built on the 2.12 trunk (i.e.: it does not contain eveyrthing that will be in 2.12 final). Surefire: Could be for Surefire 2.12. Issues to monitor are: 329 (category support): fixed, we use the official implementation from the trunk 773 (forked processes not killed after timeout): not fixed in trunk, not fixed in our version 786 (@Category with forkMode=always): fixed, we use the official implementation from the trunk 791 (incorrect elapsed time on test failure): fixed, we use the official implementation from the trunk 793 (incorrect time in the XML report): Not fixed (reopen) in trunk, partial fixed in our version. 760 (does not take into account the test method): fixed, we use the official implementation from the trunk 798 (print immediately the test class name): not fixed in trunk, not fixed in our version 799 (Allow test parallelization when forkMode=always): fixed in trunk, fixed in our version with some minimal differences. 800 (redirectTestOutputToFile not taken into account): not yet fix on trunk, fixed in our version 806 (Ignore selection criteria when -Dtest= is specified): not fixed in trunk, not fixed in our version 813 (Randomly wrong tests count and empty summary files): fixed in trunk, fixed in our version 800 & 793 are the more important to monitor, it's the only ones that are fixed in our version but not on trunk.
          Hide
          Nicolas Liochon added a comment -

          Small update:

          • No news from JUnit team. Issues was raised in november and they classified it as a bug, but my one line fix is not yet integrated. The main committers don't have a lot of time to spend on the project...
          • Surefire 2.12 is available, but there is a regression (SUREFIRE-827) that they are currently fixing, so it seems better to wait for the 2.13.
          Show
          Nicolas Liochon added a comment - Small update: No news from JUnit team. Issues was raised in november and they classified it as a bug, but my one line fix is not yet integrated. The main committers don't have a lot of time to spend on the project... Surefire 2.12 is available, but there is a regression (SUREFIRE-827) that they are currently fixing, so it seems better to wait for the 2.13.
          Hide
          Nicolas Liochon added a comment -

          Monthly update:

          • The JUnit team merged my fix on the JUnit trunk, so the next JUnit version (should be 4.11) will be ok for us. I don't have the release date however.
          • The surefire regression (SUREFIRE-827) is not yet fixed, still planned for 2.13. No release date.
          Show
          Nicolas Liochon added a comment - Monthly update: The JUnit team merged my fix on the JUnit trunk, so the next JUnit version (should be 4.11) will be ok for us. I don't have the release date however. The surefire regression (SUREFIRE-827) is not yet fixed, still planned for 2.13. No release date.
          Hide
          Nicolas Liochon added a comment -

          Update: Still waiting for JUnit 4.11 & Surefire 2.13, still no release date.

          Show
          Nicolas Liochon added a comment - Update: Still waiting for JUnit 4.11 & Surefire 2.13, still no release date.
          Hide
          Nicolas Liochon added a comment -

          Update: Still waiting. There is some life on Surefire, for JUnit there won't be anything before Q4 I guess.

          Show
          Nicolas Liochon added a comment - Update: Still waiting. There is some life on Surefire, for JUnit there won't be anything before Q4 I guess.
          Hide
          Nicolas Liochon added a comment -

          There is a new surefire 2.12.1 version. It fixes the regression #827, #800 is reopened. Our fix is different, but I suppose that if I didn't propose my fix it was for a good reason. I will need to have a look at this. Will wait a little however to see if someone fixes it. And anyway this new version could contain new regressions, so there is no reasons to be the first users.

          They're adding stuff into JUnit, so hopefully their will deliver something soon and it won't contain regressions...

          Show
          Nicolas Liochon added a comment - There is a new surefire 2.12.1 version. It fixes the regression #827, #800 is reopened. Our fix is different, but I suppose that if I didn't propose my fix it was for a good reason. I will need to have a look at this. Will wait a little however to see if someone fixes it. And anyway this new version could contain new regressions, so there is no reasons to be the first users. They're adding stuff into JUnit, so hopefully their will deliver something soon and it won't contain regressions...
          Hide
          Nicolas Liochon added a comment -

          2.12.2 is now available, and there are some activity on surefire, so we could have a 2.13 "soon". I tested the snapshot version on HBase trunk, the only issue I found is #800.

          I proposed a reasonable (imho) fix for it in surefire. It covers the case for forkMode=perthread (i.e. medium & large tests). I don't have a non hacky fix for small tests (they are on a different code path in surefire), so we will have either to accept output on the console for small tests either to change the verbose small tests to medium.

          The former option would likely put us with very simple tests that we should be able to parallelize within a single jvm, so it's reasonable.

          Show
          Nicolas Liochon added a comment - 2.12.2 is now available, and there are some activity on surefire, so we could have a 2.13 "soon". I tested the snapshot version on HBase trunk, the only issue I found is #800. I proposed a reasonable (imho) fix for it in surefire. It covers the case for forkMode=perthread (i.e. medium & large tests). I don't have a non hacky fix for small tests (they are on a different code path in surefire), so we will have either to accept output on the console for small tests either to change the verbose small tests to medium. The former option would likely put us with very simple tests that we should be able to parallelize within a single jvm, so it's reasonable.
          Hide
          stack added a comment -

          Thanks for update. I'd say if 2.13 works even though we have to move a good few tests to medium, lets use it so we can undo our dependency on custom surefire. Good on you N.

          Show
          stack added a comment - Thanks for update. I'd say if 2.13 works even though we have to move a good few tests to medium, lets use it so we can undo our dependency on custom surefire. Good on you N.
          Hide
          Nicolas Liochon added a comment -

          No feedback from surefire author yet, but usually (but not always...) he replies quite fast on patch proposal; so I hope to know where I stand with #800 next week.

          Actions are forecast to close this are:
          1) Change some tests from small to medium.
          2) Check if we can parallelize small within a single JVM
          3) Make the profile localTests activated if we define a test (hence users won't have to know about -P localTests)
          3.1) As a side effect we would use only in JUnit provider & JUnit version instead of 2 as of today.
          4) Push the number of parallel process to 5 instead of 4.
          5) Simplify the .pom by removing some profile not used imho: singleJVMTests, parallelTests, nonParallelTests, runSmallTests, runMediumTests
          6) See what to do with long running tests, tests should not last more than 2 or 3 minutes, more makes the tests cumbersome to run...

          Except one, they're all nice to have. Will do that slowly.

          I've done more tests on 2.13-SNAPSHOT + #800 fix and saw:

          • wrong test elapsed time when a test fails. Confusion within milliseconds & seconds in Surefire. No need to fix.
          • TestReplication does not finish. It seems surefire waits for it (so may be 900s), then stops without killing the process. This last point is not new, but we didn't get an error in surefire before. Now we have "The forked VM terminated without saying properly goodbye.". May be it"s an improvement. Will see.
          Show
          Nicolas Liochon added a comment - No feedback from surefire author yet, but usually (but not always...) he replies quite fast on patch proposal; so I hope to know where I stand with #800 next week. Actions are forecast to close this are: 1) Change some tests from small to medium. 2) Check if we can parallelize small within a single JVM 3) Make the profile localTests activated if we define a test (hence users won't have to know about -P localTests) 3.1) As a side effect we would use only in JUnit provider & JUnit version instead of 2 as of today. 4) Push the number of parallel process to 5 instead of 4. 5) Simplify the .pom by removing some profile not used imho: singleJVMTests, parallelTests, nonParallelTests, runSmallTests, runMediumTests 6) See what to do with long running tests, tests should not last more than 2 or 3 minutes, more makes the tests cumbersome to run... Except one, they're all nice to have. Will do that slowly. I've done more tests on 2.13-SNAPSHOT + #800 fix and saw: wrong test elapsed time when a test fails. Confusion within milliseconds & seconds in Surefire. No need to fix. TestReplication does not finish. It seems surefire waits for it (so may be 900s), then stops without killing the process. This last point is not new, but we didn't get an error in surefire before. Now we have "The forked VM terminated without saying properly goodbye.". May be it"s an improvement. Will see.
          Hide
          Ryan Hennig added a comment -

          With surefire 2.12, we are getting a build error on our Jenkins server with message "Error occurred in starting fork".
          This appears to be due to SUREFIRE-870, which is fixed in 2.12.1 and above. We are currently experimenting with surefire 2.12.3 to get build working.

          Show
          Ryan Hennig added a comment - With surefire 2.12, we are getting a build error on our Jenkins server with message "Error occurred in starting fork". This appears to be due to SUREFIRE-870, which is fixed in 2.12.1 and above. We are currently experimenting with surefire 2.12.3 to get build working.
          Hide
          Nicolas Liochon added a comment -

          Yeah, I've never tried 2.12, it was too smelly. I'm targeting the next release (likely numbered 2.13); i.e. trunk as of today + #800. I'm still awaiting feedback for this last one.
          I've done some tests on hadoop-qa, there are in HBASE-6674. Don't hesitate to add your findings.

          Show
          Nicolas Liochon added a comment - Yeah, I've never tried 2.12, it was too smelly. I'm targeting the next release (likely numbered 2.13); i.e. trunk as of today + #800. I'm still awaiting feedback for this last one. I've done some tests on hadoop-qa, there are in HBASE-6674 . Don't hesitate to add your findings.
          Hide
          Nicolas Liochon added a comment -

          Monthly update...
          Surefire: the regression on elapsed time is fixed on 2.12.4 (not tested). Still waiting for #800. May be it will make it to the 2.13. No date.
          JUnit: no life there. Still a release this quarter is likely...

          Show
          Nicolas Liochon added a comment - Monthly update... Surefire: the regression on elapsed time is fixed on 2.12.4 (not tested). Still waiting for #800. May be it will make it to the 2.13. No date. JUnit: no life there. Still a release this quarter is likely...
          Hide
          Nicolas Liochon added a comment -

          From JUnit mailing list (15th oct) I am happy to announce the release of JUnit 4.11-beta-1. There have been a lot of contributions by a full cast of contributors. So we will have the release this quarter with some luck.
          Surefire: Still waiting for #800. May be it will make it to the 2.13. No date.

          Show
          Nicolas Liochon added a comment - From JUnit mailing list (15th oct) I am happy to announce the release of JUnit 4.11-beta-1. There have been a lot of contributions by a full cast of contributors. So we will have the release this quarter with some luck. Surefire: Still waiting for #800. May be it will make it to the 2.13. No date.
          Hide
          Nicolas Liochon added a comment -

          Monthly update: same status as a month ago....

          Show
          Nicolas Liochon added a comment - Monthly update: same status as a month ago....
          Hide
          Nicolas Liochon added a comment -

          Junit 4.11 is now available (wow!). Let's test it on trunk (locally it's ok), I will backport to 0.94 if it's ok.

          Show
          Nicolas Liochon added a comment - Junit 4.11 is now available (wow!). Let's test it on trunk (locally it's ok), I will backport to 0.94 if it's ok.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12553691/4955.v1.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          -1 javadoc. The javadoc tool appears to have generated 93 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 16 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.TestZooKeeper
          org.apache.hadoop.hbase.client.TestAdmin
          org.apache.hadoop.hbase.client.TestMultiParallel

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3348//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3348//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3348//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3348//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3348//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3348//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3348//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3348//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12553691/4955.v1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 93 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 findbugs . The patch appears to introduce 16 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.TestZooKeeper org.apache.hadoop.hbase.client.TestAdmin org.apache.hadoop.hbase.client.TestMultiParallel Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3348//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3348//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3348//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3348//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3348//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3348//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3348//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3348//console This message is automatically generated.
          Hide
          stack added a comment -

          @nkeywal That'd be sweet undoing one of our custom dependencies

          Show
          stack added a comment - @nkeywal That'd be sweet undoing one of our custom dependencies
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12553768/4955.v2.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          -1 javadoc. The javadoc tool appears to have generated 99 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 24 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.client.TestMultiParallel
          org.apache.hadoop.hbase.client.TestAdmin
          org.apache.hadoop.hbase.util.TestMiniClusterLoadParallel
          org.apache.hadoop.hbase.TestZooKeeper

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3351//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3351//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3351//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3351//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3351//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3351//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3351//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3351//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12553768/4955.v2.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 99 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 findbugs . The patch appears to introduce 24 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.client.TestMultiParallel org.apache.hadoop.hbase.client.TestAdmin org.apache.hadoop.hbase.util.TestMiniClusterLoadParallel org.apache.hadoop.hbase.TestZooKeeper Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3351//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3351//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3351//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3351//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3351//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3351//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3351//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3351//console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12553786/4955.v2.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          -1 javadoc. The javadoc tool appears to have generated 99 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 24 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.client.TestMultiParallel
          org.apache.hadoop.hbase.client.TestAdmin
          org.apache.hadoop.hbase.master.TestSplitLogManager
          org.apache.hadoop.hbase.TestZooKeeper

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3354//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3354//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3354//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3354//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3354//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3354//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3354//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3354//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12553786/4955.v2.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 99 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 findbugs . The patch appears to introduce 24 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.client.TestMultiParallel org.apache.hadoop.hbase.client.TestAdmin org.apache.hadoop.hbase.master.TestSplitLogManager org.apache.hadoop.hbase.TestZooKeeper Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3354//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3354//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3354//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3354//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3354//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3354//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3354//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3354//console This message is automatically generated.
          Hide
          Nicolas Liochon added a comment -

          This is annoying: 3 times the same errors. I'm gonna wait a little. Will retry in a week or so.

          Show
          Nicolas Liochon added a comment - This is annoying: 3 times the same errors. I'm gonna wait a little. Will retry in a week or so.
          Hide
          Nicolas Liochon added a comment -

          Local test on trunk: errors on TestAdmin / TestZooKeeper / TestMultiParallel as previously in precommit. I will wait another week.

          Failed tests:testFlushCommitsWithAbort(org.apache.hadoop.hbase.client.TestMultiParallel): Server count=2, abort=true expected:<1> but was:<2>
          testVerifyRepJob(org.apache.hadoop.hbase.replication.TestReplication): Waited too much time for truncate
          testSmallBatch(org.apache.hadoop.hbase.replication.TestReplication): Waited too much time for truncate
          testDisableEnable(org.apache.hadoop.hbase.replication.TestReplication): Waited too much time for truncate
          testSimplePutDelete(org.apache.hadoop.hbase.replication.TestReplication): Waited too much time for truncate
          testDeleteEditUnknownColumnFamilyAndOrTable(org.apache.hadoop.hbase.client.TestAdmin)

          Tests in error:
          testReadModifyWrite(org.apache.hadoop.hbase.coprocessor.TestRowProcessorEndpoint): Failed after attempts=1, exceptions..)
          testZNodeDeletes(org.apache.hadoop.hbase.TestZooKeeper): KeeperErrorCode = NoAuth for /l1

          Show
          Nicolas Liochon added a comment - Local test on trunk: errors on TestAdmin / TestZooKeeper / TestMultiParallel as previously in precommit. I will wait another week. Failed tests:testFlushCommitsWithAbort(org.apache.hadoop.hbase.client.TestMultiParallel): Server count=2, abort=true expected:<1> but was:<2> testVerifyRepJob(org.apache.hadoop.hbase.replication.TestReplication): Waited too much time for truncate testSmallBatch(org.apache.hadoop.hbase.replication.TestReplication): Waited too much time for truncate testDisableEnable(org.apache.hadoop.hbase.replication.TestReplication): Waited too much time for truncate testSimplePutDelete(org.apache.hadoop.hbase.replication.TestReplication): Waited too much time for truncate testDeleteEditUnknownColumnFamilyAndOrTable(org.apache.hadoop.hbase.client.TestAdmin) Tests in error: testReadModifyWrite(org.apache.hadoop.hbase.coprocessor.TestRowProcessorEndpoint): Failed after attempts=1, exceptions ..) testZNodeDeletes(org.apache.hadoop.hbase.TestZooKeeper): KeeperErrorCode = NoAuth for /l1
          Hide
          Nicolas Liochon added a comment -

          Retested 3 times again on trunk, these errors are always there. I don't always have then when I test with the current JUnit:
          testZNodeDeletes(org.apache.hadoop.hbase.TestZooKeeper): KeeperErrorCode = NoAuth for /l1
          testFlushCommitsWithAbort(org.apache.hadoop.hbase.client.TestMultiParallel): Server count=2, abort=true expected:<1> but was:<2>

          JUnit 4.11 is out for a month, no one raised an issue about it. So may be we have flaky tests that are now just failed tests on 4.11 (i.e. a bug on out side that always appears with 4.11?). We can either wait a little bit more, for example waiting for more validation work on 0.96, either push it now, expecting someone will be motivated about finding the root issue, either try to fix the issue before pushing .

          Show
          Nicolas Liochon added a comment - Retested 3 times again on trunk, these errors are always there. I don't always have then when I test with the current JUnit: testZNodeDeletes(org.apache.hadoop.hbase.TestZooKeeper): KeeperErrorCode = NoAuth for /l1 testFlushCommitsWithAbort(org.apache.hadoop.hbase.client.TestMultiParallel): Server count=2, abort=true expected:<1> but was:<2> JUnit 4.11 is out for a month, no one raised an issue about it. So may be we have flaky tests that are now just failed tests on 4.11 (i.e. a bug on out side that always appears with 4.11?). We can either wait a little bit more, for example waiting for more validation work on 0.96, either push it now, expecting someone will be motivated about finding the root issue, either try to fix the issue before pushing .
          Hide
          stack added a comment -

          If just two test failures, I'm inclined to think it flakey tests rather than junit version and that we should move to junit 4.11 and fix the tests

          Show
          stack added a comment - If just two test failures, I'm inclined to think it flakey tests rather than junit version and that we should move to junit 4.11 and fix the tests
          Hide
          Nicolas Liochon added a comment -

          I've got 2 to 5 failures, but these two are always in the failed, while the others vary. So do I push the 'commit' button? It's likely to fail all builds until we fix the issue

          Show
          Nicolas Liochon added a comment - I've got 2 to 5 failures, but these two are always in the failed, while the others vary. So do I push the 'commit' button? It's likely to fail all builds until we fix the issue
          Hide
          stack added a comment -

          Normally I would say commit but since you are so regular checking in on this issue, lets put off the commit till the next time you make your cycle through this issue. Hopefully trunk will be more stable then and we'll be able to take on these new failures and fix them quickly. Thanks Nicolas Liochon

          Show
          stack added a comment - Normally I would say commit but since you are so regular checking in on this issue, lets put off the commit till the next time you make your cycle through this issue. Hopefully trunk will be more stable then and we'll be able to take on these new failures and fix them quickly. Thanks Nicolas Liochon
          Hide
          Nicolas Liochon added a comment -

          Surefire 2.13 is nearly out. I tried it, it seems to work for us, with the restriction mentioned above: we will have to accept some partial output on screen or to recategorize the tests. It's anyway better to wait for the official release and see what the other users find: we don't need to be the first users. But 2.13 is likely the winner.

          I tried again with JUnit, and here the news are not so good: we still have errors:

            TestServerCustomProtocol.testSingleProxy:219 null
            TestMultiParallel.testFlushCommitsWithAbort:226->doTestFlushCommits:267 Server count=2, abort=true expected:<1> but was:<2>
            TestAdmin.testDeleteEditUnknownColumnFamilyAndOrTable:203 null
            TestReplication.setUp:180 Waited too much time for truncate
          
          Tests in error:
            TestZooKeeper.testZNodeDeletes:291 » NoAuth KeeperErrorCode = NoAuth for /l1
          

          I checked the JUnit mailing lists and bug tracking, there is nothing. So it's likely us and we will have to investigate I guess.

          Show
          Nicolas Liochon added a comment - Surefire 2.13 is nearly out. I tried it, it seems to work for us, with the restriction mentioned above: we will have to accept some partial output on screen or to recategorize the tests. It's anyway better to wait for the official release and see what the other users find: we don't need to be the first users. But 2.13 is likely the winner. I tried again with JUnit, and here the news are not so good: we still have errors: TestServerCustomProtocol.testSingleProxy:219 null TestMultiParallel.testFlushCommitsWithAbort:226->doTestFlushCommits:267 Server count=2, abort=true expected:<1> but was:<2> TestAdmin.testDeleteEditUnknownColumnFamilyAndOrTable:203 null TestReplication.setUp:180 Waited too much time for truncate Tests in error: TestZooKeeper.testZNodeDeletes:291 » NoAuth KeeperErrorCode = NoAuth for /l1 I checked the JUnit mailing lists and bug tracking, there is nothing. So it's likely us and we will have to investigate I guess.
          Hide
          Nicolas Liochon added a comment -

          Waiting for 2.14 or more info on SUREFIRE-943 before going further in Surefire. For JUnit 4.11, the work is on our side.

          Show
          Nicolas Liochon added a comment - Waiting for 2.14 or more info on SUREFIRE-943 before going further in Surefire. For JUnit 4.11, the work is on our side.
          Hide
          stack added a comment -

          Its a while since we got an update Mr Nicolas Liochon

          Show
          stack added a comment - Its a while since we got an update Mr Nicolas Liochon
          Hide
          Nicolas Liochon added a comment -

          For JUnit, it's now done and we have 4.11 now. As guessed above, the work was on our side (order dependant tests, fixed in various jiras).
          For Surefire, the safer is to wait for 2.14 and SUREFIRE-943. It was supposed to be released beginning of February, but I had no news since. Hopefully in will be for March.

          Technically, we will use the 'reusable fork' for small tests. This allows to have isolated logs (we have this in our patch today but the official release messes them), good performances (forks would be too expensive for small tests) and even parallelization for small tests. Tested ok on 2.13.

          Show
          Nicolas Liochon added a comment - For JUnit, it's now done and we have 4.11 now. As guessed above, the work was on our side (order dependant tests, fixed in various jiras). For Surefire, the safer is to wait for 2.14 and SUREFIRE-943. It was supposed to be released beginning of February, but I had no news since. Hopefully in will be for March. Technically, we will use the 'reusable fork' for small tests. This allows to have isolated logs (we have this in our patch today but the official release messes them), good performances (forks would be too expensive for small tests) and even parallelization for small tests. Tested ok on 2.13.
          Hide
          Nicolas Liochon added a comment -

          The regression in SUREFIRE-970 makes the move to 2.14 problematic. It would be nice to have SUREFIRE-969 as well bu it's more mandatory. A bigger issue is that in my tests it seems that having multiple execution with different parameters does not work anymore. I will need to have a look at that to get it fixed in a release...

          Show
          Nicolas Liochon added a comment - The regression in SUREFIRE-970 makes the move to 2.14 problematic. It would be nice to have SUREFIRE-969 as well bu it's more mandatory. A bigger issue is that in my tests it seems that having multiple execution with different parameters does not work anymore. I will need to have a look at that to get it fixed in a release...
          Hide
          stack added a comment -

          Thanks Nicolas Liochon for the update

          Show
          stack added a comment - Thanks Nicolas Liochon for the update
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12574003/4955.v2.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 lineLengths. The patch introduces lines longer than 100

          -1 site. The patch appears to cause mvn site goal to fail.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.client.TestHTableMultiplexer

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4848//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4848//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4848//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4848//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4848//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4848//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4848//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4848//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4848//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4848//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12574003/4955.v2.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.client.TestHTableMultiplexer Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4848//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4848//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4848//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4848//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4848//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4848//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4848//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4848//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4848//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4848//console This message is automatically generated.
          Hide
          Nicolas Liochon added a comment -

          Tests run: 35, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 281.479 sec

          Useless log lines. That's SUREFIRE-969

          Took 2 mo. 7 d.

          That's SUREFIRE-970.

          2,158 tests (-274)

          It should be the flakiness of TestHTableMultiplexer.testHTableMultiplexer

          I'm going to retry because of the point 3.
          For the first 2 ones, I tend to think it should not prevent us from committing. We don't have any issue today because I built a version that included all we need. If we want to come back to an official version, we need to compromise. We can expect these points are likely to be solved in a later version, but these later version can also include regressions.. We need to jump in at a moment, and we've been waiting for more than a year now.

          Show
          Nicolas Liochon added a comment - Tests run: 35, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 281.479 sec Useless log lines. That's SUREFIRE-969 Took 2 mo. 7 d. That's SUREFIRE-970. 2,158 tests (-274) It should be the flakiness of TestHTableMultiplexer.testHTableMultiplexer I'm going to retry because of the point 3. For the first 2 ones, I tend to think it should not prevent us from committing. We don't have any issue today because I built a version that included all we need. If we want to come back to an official version, we need to compromise. We can expect these points are likely to be solved in a later version, but these later version can also include regressions.. We need to jump in at a moment, and we've been waiting for more than a year now.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12574127/4955.v2.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 lineLengths. The patch introduces lines longer than 100

          -1 site. The patch appears to cause mvn site goal to fail.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4861//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4861//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4861//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4861//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4861//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4861//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4861//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4861//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4861//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4861//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12574127/4955.v2.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4861//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4861//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4861//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4861//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4861//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4861//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4861//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4861//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4861//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4861//console This message is automatically generated.
          Hide
          Nicolas Liochon added a comment -

          Likely a bad news... Among the missing tests, we have this:

          @RunWith(Parameterized.class)
          @Category(SmallTests.class)
          public class TestFixedFileTrailer {

          i.e. there could be issues with parametized tests (and that could not be enough to explain the 200 missing tests).

          Looking...

          Show
          Nicolas Liochon added a comment - Likely a bad news... Among the missing tests, we have this: @RunWith(Parameterized.class) @Category(SmallTests.class) public class TestFixedFileTrailer { i.e. there could be issues with parametized tests (and that could not be enough to explain the 200 missing tests). Looking...
          Hide
          Nicolas Liochon added a comment -

          It's fun, because if I do:
          mvn clean test -Dsurefire.part2.skip=true -q -PrunAllTests -Dsurefire.part1.forkCount=10
          the number of executed tests is a random number above 600

          while with
          mvn clean test -Dsurefire.part2.skip=true -q -PrunAllTests -Dsurefire.part1.forkCount=1
          It's always 543

          more parallism == less randomness (logic) but less tests executed (not logic)

          I don't reproduce it on a surefire unit tests. I'm going to try a little bit more then we will have the option to wait for 2.15, hoping it will be identified and fixed.

          Show
          Nicolas Liochon added a comment - It's fun, because if I do: mvn clean test -Dsurefire.part2.skip=true -q -PrunAllTests -Dsurefire.part1.forkCount=10 the number of executed tests is a random number above 600 while with mvn clean test -Dsurefire.part2.skip=true -q -PrunAllTests -Dsurefire.part1.forkCount=1 It's always 543 more parallism == less randomness (logic) but less tests executed (not logic) I don't reproduce it on a surefire unit tests. I'm going to try a little bit more then we will have the option to wait for 2.15, hoping it will be identified and fixed.
          Hide
          stack added a comment -

          Nicolas Liochon Thanks for staying on top of this one. So, we only host surefire now? It is in Gary's repo or in yours?

          Show
          stack added a comment - Nicolas Liochon Thanks for staying on top of this one. So, we only host surefire now? It is in Gary's repo or in yours?
          Hide
          Nicolas Liochon added a comment -

          Yes, JUnit 4.11 contains what we need. Surefire contains what we need as well, we just need to get a version that comes up with an acceptable set of regressions.

          Our Surefire is in Gary's repo. He will be the one getting the blame if Apache complains .
          BTW, I haven't done the update to JUnit in HBase 0.94, as it implies backporting a few jiras as well (in the required section). So we still need to have it in Gary's repo as well.

          Show
          Nicolas Liochon added a comment - Yes, JUnit 4.11 contains what we need. Surefire contains what we need as well, we just need to get a version that comes up with an acceptable set of regressions. Our Surefire is in Gary's repo. He will be the one getting the blame if Apache complains . BTW, I haven't done the update to JUnit in HBase 0.94, as it implies backporting a few jiras as well (in the required section). So we still need to have it in Gary's repo as well.
          Hide
          Nicolas Liochon added a comment -

          Rebased patch, new invisible stack:

          Running org.apache.hadoop.hbase.mapreduce.TestMultithreadedTableMapper
          Exception in thread "ThreadedStreamConsumer" java.lang.OutOfMemoryError: Java heap space
          	at java.util.Arrays.copyOf(Arrays.java:2882)
          	at java.lang.AbstractStringBuilder.expandCapacity(AbstractStringBuilder.java:100)
          	at java.lang.AbstractStringBuilder.append(AbstractStringBuilder.java:390)
          	at java.lang.StringBuilder.append(StringBuilder.java:119)
          	at org.apache.maven.plugin.surefire.report.TestSetRunListener.getAsString(TestSetRunListener.java:221)
          	at org.apache.maven.plugin.surefire.report.TestSetRunListener.wrap(TestSetRunListener.java:228)
          	at org.apache.maven.plugin.surefire.report.TestSetRunListener.testSucceeded(TestSetRunListener.java:159)
          	at org.apache.maven.plugin.surefire.booterclient.output.ForkClient.consumeLine(ForkClient.java:111)
          	at org.apache.maven.plugin.surefire.booterclient.output.ThreadedStreamConsumer$Pumper.run(ThreadedStreamConsumer.java:67)
          	at java.lang.Thread.run(Thread.java:662)
          Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 111.181 sec
          parallel='none', perCoreThreadCount=true, threadCount=2, useUnlimitedThreads=false
          
          Show
          Nicolas Liochon added a comment - Rebased patch, new invisible stack: Running org.apache.hadoop.hbase.mapreduce.TestMultithreadedTableMapper Exception in thread "ThreadedStreamConsumer" java.lang.OutOfMemoryError: Java heap space at java.util.Arrays.copyOf(Arrays.java:2882) at java.lang.AbstractStringBuilder.expandCapacity(AbstractStringBuilder.java:100) at java.lang.AbstractStringBuilder.append(AbstractStringBuilder.java:390) at java.lang.StringBuilder.append(StringBuilder.java:119) at org.apache.maven.plugin.surefire.report.TestSetRunListener.getAsString(TestSetRunListener.java:221) at org.apache.maven.plugin.surefire.report.TestSetRunListener.wrap(TestSetRunListener.java:228) at org.apache.maven.plugin.surefire.report.TestSetRunListener.testSucceeded(TestSetRunListener.java:159) at org.apache.maven.plugin.surefire.booterclient.output.ForkClient.consumeLine(ForkClient.java:111) at org.apache.maven.plugin.surefire.booterclient.output.ThreadedStreamConsumer$Pumper.run(ThreadedStreamConsumer.java:67) at java.lang.Thread.run(Thread.java:662) Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 111.181 sec parallel='none', perCoreThreadCount=true, threadCount=2, useUnlimitedThreads=false
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12577504/4955.v3.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 lineLengths. The patch introduces lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5180//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5180//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5180//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5180//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5180//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5180//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5180//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5180//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5180//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5180//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12577504/4955.v3.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5180//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5180//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5180//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5180//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5180//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5180//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5180//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5180//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5180//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5180//console This message is automatically generated.
          Hide
          Nicolas Liochon added a comment -

          tests: 2,116 tests (-370)
          => still missing some

          Show
          Nicolas Liochon added a comment - tests: 2,116 tests (-370) => still missing some
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12577507/4955.v3.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 lineLengths. The patch introduces lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5181//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5181//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5181//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5181//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5181//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5181//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5181//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5181//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5181//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5181//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12577507/4955.v3.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5181//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5181//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5181//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5181//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5181//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5181//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5181//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5181//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5181//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5181//console This message is automatically generated.
          Hide
          Nicolas Liochon added a comment -

          Here is the gap between the two runs;
          > Running org.apache.hadoop.hbase.io.hfile.TestFixedFileTrailer
          95a97
          > Running org.apache.hadoop.hbase.io.hfile.TestHFileBlockCompatibility
          103a106
          > Running org.apache.hadoop.hbase.io.hfile.TestScannerSelectionUsingKeyRange
          244d246
          < Running org.apache.hadoop.hbase.regionserver.TestScanWithBloomError

          All these tests have something in common: they are parameterized. That's unlikely to be an accident.

          Show
          Nicolas Liochon added a comment - Here is the gap between the two runs; > Running org.apache.hadoop.hbase.io.hfile.TestFixedFileTrailer 95a97 > Running org.apache.hadoop.hbase.io.hfile.TestHFileBlockCompatibility 103a106 > Running org.apache.hadoop.hbase.io.hfile.TestScannerSelectionUsingKeyRange 244d246 < Running org.apache.hadoop.hbase.regionserver.TestScanWithBloomError All these tests have something in common: they are parameterized. That's unlikely to be an accident.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12577511/4955.v3.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 lineLengths. The patch introduces lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.security.access.TestAccessController
          org.apache.hadoop.hbase.master.TestMasterFailover

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5182//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5182//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5182//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5182//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5182//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5182//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5182//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5182//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5182//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5182//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12577511/4955.v3.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.security.access.TestAccessController org.apache.hadoop.hbase.master.TestMasterFailover Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5182//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5182//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5182//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5182//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5182//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5182//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5182//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5182//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5182//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5182//console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12577543/4955.v4.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 24 new or modified tests.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 lineLengths. The patch introduces lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.procedure.TestProcedureCoordinator

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5185//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5185//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5185//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5185//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5185//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5185//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5185//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5185//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5185//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5185//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12577543/4955.v4.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 24 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.procedure.TestProcedureCoordinator Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5185//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5185//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5185//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5185//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5185//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5185//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5185//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5185//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5185//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5185//console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12577547/4955.v4.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 24 new or modified tests.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 lineLengths. The patch introduces lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5186//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5186//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5186//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5186//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5186//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5186//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5186//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5186//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5186//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5186//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12577547/4955.v4.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 24 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5186//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5186//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5186//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5186//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5186//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5186//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5186//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5186//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5186//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5186//console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12577560/4955.v4.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 24 new or modified tests.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 lineLengths. The patch introduces lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5187//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5187//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5187//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5187//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5187//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5187//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5187//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5187//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5187//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5187//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12577560/4955.v4.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 24 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5187//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5187//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5187//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5187//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5187//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5187//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5187//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5187//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5187//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5187//console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12577582/4955.v4.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 24 new or modified tests.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 lineLengths. The patch introduces lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5189//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5189//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5189//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5189//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5189//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5189//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5189//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5189//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5189//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5189//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12577582/4955.v4.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 24 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5189//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5189//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5189//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5189//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5189//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5189//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5189//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5189//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5189//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5189//console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12577768/4955.v5.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 24 new or modified tests.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 lineLengths. The patch introduces lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5213//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5213//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5213//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5213//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5213//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5213//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5213//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5213//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5213//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5213//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12577768/4955.v5.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 24 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5213//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5213//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5213//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5213//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5213//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5213//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5213//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5213//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5213//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5213//console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12577768/4955.v5.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 24 new or modified tests.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 lineLengths. The patch introduces lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5216//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5216//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12577768/4955.v5.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 24 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 findbugs . The patch appears to cause Findbugs (version 1.3.9) to fail. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5216//testReport/ Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5216//console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12577768/4955.v5.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 24 new or modified tests.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 lineLengths. The patch introduces lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.regionserver.wal.TestHLog

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5218//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5218//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5218//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5218//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5218//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5218//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5218//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5218//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5218//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5218//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12577768/4955.v5.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 24 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.wal.TestHLog Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5218//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5218//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5218//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5218//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5218//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5218//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5218//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5218//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5218//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5218//console This message is automatically generated.
          Hide
          Nicolas Liochon added a comment -

          And the winner is: SUREFIRE-985

          Show
          Nicolas Liochon added a comment - And the winner is: SUREFIRE-985
          Hide
          Nicolas Liochon added a comment -

          SUREFIRE-985 is fixed (it took less than 1 day between the jira creation & the fix). There is as well an acceptable workaround. SUREFIRE-969 is now fixed as well. So absolutely all our (known) issues are fixed now.

          We now have 3 options:
          1) go with 2.14.1 + the workaround. We will have the log line all over the place.
          2) wait for 2.15
          3) Do a private build. Without modifications, just the trunk as of today.

          Imho, the only reasonable option is 2. I wanted to go for the first one but everybody will complain about the log line. I will build locally a version to validate that we're fine (usual stuff: an issue can hide another...). I don't have a target date for 2.15, but I hope it won't take too long (less than 2 months).

          Show
          Nicolas Liochon added a comment - SUREFIRE-985 is fixed (it took less than 1 day between the jira creation & the fix). There is as well an acceptable workaround. SUREFIRE-969 is now fixed as well. So absolutely all our (known) issues are fixed now. We now have 3 options: 1) go with 2.14.1 + the workaround. We will have the log line all over the place. 2) wait for 2.15 3) Do a private build. Without modifications, just the trunk as of today. Imho, the only reasonable option is 2. I wanted to go for the first one but everybody will complain about the log line. I will build locally a version to validate that we're fine (usual stuff: an issue can hide another...). I don't have a target date for 2.15, but I hope it won't take too long (less than 2 months).
          Hide
          Jimmy Xiang added a comment -

          With 1), is it possible to suppress the log line? Is 3) relatively stable? How big is the difference between the trunk and the latest release?

          Show
          Jimmy Xiang added a comment - With 1), is it possible to suppress the log line? Is 3) relatively stable? How big is the difference between the trunk and the latest release?
          Hide
          Nicolas Liochon added a comment -

          With 1), is it possible to suppress the log line?

          It means 3) or a trivial private change. Best option is 3).

          Is 3) relatively stable?

          I think so. On the other hand, not everybody uses parallel tests and categories. For example, SUREFIRE-985 was there for a year in Surefire (you have to use parameterized tests + categories + parallel to get it). But it won't be different with an official release.

          How big is the difference between the trunk and the latest release?

          2.14.1 is just out, it could be that the only differences are the fixes for SUREFIRE-985 and SUREFIRE-969.

          Show
          Nicolas Liochon added a comment - With 1), is it possible to suppress the log line? It means 3) or a trivial private change. Best option is 3). Is 3) relatively stable? I think so. On the other hand, not everybody uses parallel tests and categories. For example, SUREFIRE-985 was there for a year in Surefire (you have to use parameterized tests + categories + parallel to get it). But it won't be different with an official release. How big is the difference between the trunk and the latest release? 2.14.1 is just out, it could be that the only differences are the fixes for SUREFIRE-985 and SUREFIRE-969.
          Hide
          Jimmy Xiang added a comment -

          +1 for 3). We can move to official surefire after 2.14.2/2.15 is released.

          Show
          Jimmy Xiang added a comment - +1 for 3). We can move to official surefire after 2.14.2/2.15 is released.
          Hide
          stack added a comment -

          Undoing this from 0.95.1 This issue moves at a rate independent of our releases. Upped the priority though.

          Show
          stack added a comment - Undoing this from 0.95.1 This issue moves at a rate independent of our releases. Upped the priority though.
          Hide
          Nicolas Liochon added a comment -

          Surefire 2.15 is available. I will give it a try 'soon'.

          Show
          Nicolas Liochon added a comment - Surefire 2.15 is available. I will give it a try 'soon'.
          Hide
          Nicolas Liochon added a comment -

          hopes hopes hopes... Partly tested locally, worked. stack may be it will improve some test reports when things go wrong. And at least we will be back to the official release.

          Show
          Nicolas Liochon added a comment - hopes hopes hopes... Partly tested locally, worked. stack may be it will improve some test reports when things go wrong. And at least we will be back to the official release.
          Hide
          stack added a comment -

          Go for it Nicolas Liochon! I can back it out if it makes things worse. My full time job is watching build box tests these times.

          Show
          stack added a comment - Go for it Nicolas Liochon ! I can back it out if it makes things worse. My full time job is watching build box tests these times.
          Hide
          Nicolas Liochon added a comment -

          Looking at https://builds.apache.org/job/PreCommit-HBASE-Build/6377/console it seems stuck. This was working two months ago...
          Trying locally as well.

          Show
          Nicolas Liochon added a comment - Looking at https://builds.apache.org/job/PreCommit-HBASE-Build/6377/console it seems stuck. This was working two months ago... Trying locally as well.
          Hide
          Nicolas Liochon added a comment -

          Totally stuck. Interrupted after 4 hours. Stuck locally as well: even the timeout does not work.

          Show
          Nicolas Liochon added a comment - Totally stuck. Interrupted after 4 hours. Stuck locally as well: even the timeout does not work.
          Hide
          stack added a comment -

          dang

          Show
          stack added a comment - dang
          Hide
          Nicolas Liochon added a comment -

          It was working with the snapshot a 2 months ago. I may have to try all the surefire commits to find the problematic one. I had a look at jiras on surefire. I don't see anything releated but the 2.16 seems to be released soon. I will try with this one first.

          Show
          Nicolas Liochon added a comment - It was working with the snapshot a 2 months ago. I may have to try all the surefire commits to find the problematic one. I had a look at jiras on surefire. I don't see anything releated but the 2.16 seems to be released soon. I will try with this one first.
          Hide
          stack added a comment -

          Related, I am into a new domain of failures. The zombie script found a few but it maybe that zombies are inevitable up on apache as sometimes the load is VERY high – up in the hundreds – and I see that we can also be up against the file limits (4k on some machines). Besides zombies, there are fails where the zombie trap has nothing in it and "all" tests fail (it looks like some tests just don't show in the list... these are the ones I am looking at). Maybe a new surefire would at least list these problematic tests? E.g. http://54.241.6.143/job/HBase-0.95/661/testReport/ (Clues for how to debug these failing tests appreciated).

          Show
          stack added a comment - Related, I am into a new domain of failures. The zombie script found a few but it maybe that zombies are inevitable up on apache as sometimes the load is VERY high – up in the hundreds – and I see that we can also be up against the file limits (4k on some machines). Besides zombies, there are fails where the zombie trap has nothing in it and "all" tests fail (it looks like some tests just don't show in the list... these are the ones I am looking at). Maybe a new surefire would at least list these problematic tests? E.g. http://54.241.6.143/job/HBase-0.95/661/testReport/ (Clues for how to debug these failing tests appreciated).
          Hide
          Nicolas Liochon added a comment -

          On the precommit env, there is only one application tested at a time. So the load should be limited. Or more exactly, this load is suspicious. IIRC there are some improvements in the last surefire versions, but I can't say if they will work for us.

          Show
          Nicolas Liochon added a comment - On the precommit env, there is only one application tested at a time. So the load should be limited. Or more exactly, this load is suspicious. IIRC there are some improvements in the last surefire versions, but I can't say if they will work for us.
          Hide
          Nicolas Liochon added a comment -

          v7 is about trying surefire 2.16 with the latest trunk. 3 tries:
          1) local: tests seems to run well, but get stuck at a moment in the middle of the tests.
          2) apache attempt 1: stuck. Some tests had errors.
          3) apache attempt 2: as attempt 1.

          So it means that I will have to go after each surefire commit to find the guilty one. Will do, but later.

          Show
          Nicolas Liochon added a comment - v7 is about trying surefire 2.16 with the latest trunk. 3 tries: 1) local: tests seems to run well, but get stuck at a moment in the middle of the tests. 2) apache attempt 1: stuck. Some tests had errors. 3) apache attempt 2: as attempt 1. So it means that I will have to go after each surefire commit to find the guilty one. Will do, but later.
          Hide
          Hadoop QA added a comment - - edited

          v8 results:

          1. There is insufficient memory for the Java Runtime Environment to continue.
          2. Native memory allocation (malloc) failed to allocate 1021944 bytes for Arena::Amalloc
          3. An error report file with more information is saved as:
          4. /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hs_err_pid12566.log

          likely an env problem.

          Show
          Hadoop QA added a comment - - edited v8 results: There is insufficient memory for the Java Runtime Environment to continue. Native memory allocation (malloc) failed to allocate 1021944 bytes for Arena::Amalloc An error report file with more information is saved as: /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hs_err_pid12566.log likely an env problem.
          Hide
          Nicolas Liochon added a comment -

          2.17-SNAPSHOT 867b33c8e3c8bbd656ed01bed2b6acf122c62d25 nok
          2.16 nok
          2.15 nok
          2.15-SNAPSHOT 8315562ededdbf80f059f843fa34e793b6b25ac7 nok
          2.15-SNAPSHOT 199c6162596b19d5b6e25cc0c3706bd657d92b1e nok
          2.14.1 nok
          2.14 nok

          It means that we changed something in HBase that broke surefire. In the past (see above 09/Apr/13 14:04), it was missing some tests but it was not hanging...

          Show
          Nicolas Liochon added a comment - 2.17-SNAPSHOT 867b33c8e3c8bbd656ed01bed2b6acf122c62d25 nok 2.16 nok 2.15 nok 2.15-SNAPSHOT 8315562ededdbf80f059f843fa34e793b6b25ac7 nok 2.15-SNAPSHOT 199c6162596b19d5b6e25cc0c3706bd657d92b1e nok 2.14.1 nok 2.14 nok It means that we changed something in HBase that broke surefire. In the past (see above 09/Apr/13 14:04), it was missing some tests but it was not hanging...
          Hide
          stack added a comment -

          How could we break surefire? How would we find what broke it? A bisect would take for ever.

          Show
          stack added a comment - How could we break surefire? How would we find what broke it? A bisect would take for ever.
          Hide
          Nicolas Liochon added a comment -

          I know... May be we log more than before, may be we have a conflict of some sort. I don't know. I looked at the stack trace, nothing obvious. I will need to spend more time on this.

          Show
          Nicolas Liochon added a comment - I know... May be we log more than before, may be we have a conflict of some sort. I don't know. I looked at the stack trace, nothing obvious. I will need to spend more time on this.
          Hide
          stack added a comment -

          I am not sure I understand where you are at the mo Nicolas. You are trying new surefire but it runs out of memory? Whereas current hacked surefire is fine?

          Show
          stack added a comment - I am not sure I understand where you are at the mo Nicolas. You are trying new surefire but it runs out of memory? Whereas current hacked surefire is fine?
          Hide
          Nicolas Liochon added a comment -

          The memory issue is a pure transient apache build issue. When we use the official release of surefire, the tests do not finish. It seems to be a hbase related issue as in the past this part was working (not the others, but it's another story).

          Show
          Nicolas Liochon added a comment - The memory issue is a pure transient apache build issue. When we use the official release of surefire, the tests do not finish. It seems to be a hbase related issue as in the past this part was working (not the others, but it's another story).
          Hide
          Nicolas Liochon added a comment -

          I've tried again a couple of month ago, same result. I'm waiting for surefire 2.17 to try again.

          Show
          Nicolas Liochon added a comment - I've tried again a couple of month ago, same result. I'm waiting for surefire 2.17 to try again.
          Hide
          Nicolas Liochon added a comment -

          Still waiting for 2.17.

          Show
          Nicolas Liochon added a comment - Still waiting for 2.17.
          Hide
          Nicolas Liochon added a comment -

          2.17 is out. Let's try it.

          Show
          Nicolas Liochon added a comment - 2.17 is out. Let's try it.

            People

            • Assignee:
              Nicolas Liochon
              Reporter:
              Nicolas Liochon
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:

                Development