HBase
  1. HBase
  2. HBASE-4853

HBASE-4789 does overzealous pruning of seqids

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.92.0, 0.94.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Working w/ J-D on failing replication test turned up hole in seqids made by the patch over in hbase-4789. With this patch in place we see lots of instances of the suspicious: 'Last sequenceid written is empty. Deleting all old hlogs'

      At a minimum, these lines need removing:

      diff --git a/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java b/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java
      index 623edbe..a0bbe01 100644
      --- a/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java
      +++ b/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java
      @@ -1359,11 +1359,6 @@ public class HLog implements Syncable {
             // Cleaning up of lastSeqWritten is in the finally clause because we
             // don't want to confuse getOldestOutstandingSeqNum()
             this.lastSeqWritten.remove(getSnapshotName(encodedRegionName));
      -      Long l = this.lastSeqWritten.remove(encodedRegionName);
      -      if (l != null) {
      -        LOG.warn("Why is there a raw encodedRegionName in lastSeqWritten? name=" +
      -          Bytes.toString(encodedRegionName) + ", seqid=" + l);
      -       }
             this.cacheFlushLock.unlock();
           }
         }
      

      ... but above is no good w/o figuring why WALs are not being rotated off.

      1. 4853.txt
        2 kB
        stack
      2. 4853--no-prefix.txt
        2 kB
        stack
      3. 4853-trunk.txt
        2 kB
        stack
      4. 4853-v4.txt
        9 kB
        stack
      5. 4853-v5.txt
        3 kB
        stack
      6. 4853-v6.txt
        4 kB
        stack
      7. 4853-v7.txt
        7 kB
        stack
      8. 4853-v8.txt
        8 kB
        stack
      9. 4853-v9.txt
        8 kB
        stack
      10. 4853-v9.txt
        8 kB
        stack
      11. 4853-v10.txt
        7 kB
        stack

        Activity

        No work has yet been logged on this issue.

          People

          • Assignee:
            stack
            Reporter:
            stack
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development