[HBASE-4798] Sleeps and synchronisation improvements for tests

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.94.0
• Fix Version/s: 0.94.0
• Component/s: master, regionserver, test

Environment

all

• Release Note: last try on the same patch, but I think it's ok to commit it.
• Assignee: Nicolas Liochon
• Reporter: Nicolas Liochon
• Created: 16/Nov/11 08:49
• Updated: 12/Oct/12 05:34
• Resolved: 22/Nov/11 01:05

Description

Multiple small changes:

@commiters: Removing some sleeps made visible a bug on JVMClusterUtil#HMaster#waitForServerOnline, so I had to add a synchro point. You may want to review this.

JVMClusterUtil#HMaster#waitForServerOnline: removed, the condition was never met (test on "!c && !!c"). Added a new synchronization point.

AssignementManager#waitForAssignment: add a timeout on the wait => not stuck if the notification is received before the wait.

HMaster#loop: use a notification instead of a 1s sleep

HRegionServer#waitForServerOnline: new method used by JVMClusterUtil#waitForServerOnline() to replace a 1s sleep by a notification

HRegionServer#getMaster() 1s sleeps replaced by one 0,1s sleep and one 0,2s sleep

HRegionServer#stop: use a notification on sleeper to lower shutdown by 0,5s

ZooKeeperNodeTracker#start: replace a recursive call by a loop

ZooKeeperNodeTracker#blockUntilAvailable: add a timeout on the wait => not stuck if the notification is received before the wait.

HBaseTestingUtility#expireSession: use a timeout of 1s instead of 5s

TestZooKeeper#testClientSessionExpired: use a timeout of 1s instead of 5s, with the change on HBaseTestingUtility we are 60s faster

TestRegionRebalancing#waitForAllRegionsAssigned: use a sleep of 0,2s instead of 1s

TestRestartCluster#testClusterRestart: send all the table creation together, then check creation, should be faster

TestHLog: shutdown the whole cluster instead of DFS only (more standard)

JVMClusterUtil#startup: lower the sleep from 1s to 0,1s

HConnectionManager#close: Zookeeper name in debug message from HConnectionManager after connection close was always null because it was set to null in the delete.

Issue Links

• is related to: HBASE-4832 TestRegionServerCoprocessorExceptionWithAbort fails if the region server stops too fast
• is required by: HBASE-4602 Make the suite run in at least half the time
• relates to: HBASE-4690 Intermittent TestRegionServerCoprocessorExceptionWithAbort#testExceptionFromCoprocessorDuringPut failure